Skip to content

fix(e2e): mount the disk where any image can host it when labeling - #1138

Merged
Danathar merged 1 commit into
mainfrom
fix/selinux-label-mounts
Nov 11, 2026
Merged

Danathar merged 1 commit into
mainfrom
fix/selinux-label-mounts

Conversation

@Danathar

Copy link
Copy Markdown
Contributor

Summary: #1119 (SELinux enforcing by default) added a labeling step to e2e.yml that runs the image under test with -v /mnt/root:/mnt/root and -v $SELINUX_DIR:$SELINUX_DIR. In ostree-style images /mnt and /home are symlinks into an unpopulated /var, so podman can't create those mount points, and the run stops before any test starts. utah:testing fails this way (manual run 42919494173: "crun: creating /mnt/root: openat2 mnt: No such file or directory"). dakota:testing doesn't, which is why the v1 gate passed. v1 now includes #1119, so utah's e2e will most likely hit this when its v1 pin is bumped.

Fix

Mount the disk at /harness/root and the file list at /harness/list inside the container, and rewrite /mnt/root to /harness/root in setfiles' root, the file_contexts path and every list entry. setfiles labels exactly the same files as before.

How to test (e2e.yml only runs when called, so this needs manual runs from this branch)

  1. gh workflow run manual.yml -R projectbluefin/testsuite --ref fix/selinux-label-mounts -f image=ghcr.io/projectbluefin/utah:testing -f suites=common: should get past "Install OCI image and configure disk" and boot.
  2. gh workflow run manual.yml -R projectbluefin/testsuite --ref fix/selinux-label-mounts -f image=ghcr.io/projectbluefin/dakota:testing -f suites=common: should behave as on main (no regression on the gate image).

Checked locally: the path rewrite gives the expected setfiles arguments for both the deployment and stateroot calls, and actionlint shows the same findings as main.

e2e.yml is a human-merge path, so a maintainer merges this after both runs.

🤖 Generated with Claude Code

https://claude.ai/code/session_01WcWm7qQa538Zjcuvv8jBtn

#1119's labeling step runs the candidate image with
-v /mnt/root:/mnt/root and -v SELINUX_DIR:SELINUX_DIR. In ostree-style
images /mnt and /home are symlinks into /var that the image does not
populate, so podman cannot create the mount point and the step fails
before any test runs: utah:testing stopped with "crun: creating
`/mnt/root`: openat2 `mnt`: No such file or directory" (manual run
42919494173). dakota:testing is not affected, so the v1 gate passed.

Mount the disk at /harness/root and the list at /harness/list, and
rewrite /mnt/root to /harness/root in setfiles' root, the file_contexts
path and every list entry, so the same files are labeled.

Assisted-by: Claude Opus 5.5 via Claude Code
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WcWm7qQa538Zjcuvv8jBtn
Signed-off-by: Danathar <Danathar@users.noreply.github.com>
@hivecommons-hive hivecommons-hive Bot added author/clanker A contributor's own hive authored this PR under their login dco All commits are DCO signed-off role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/050-review-pending Review swarm requested; awaiting a verdict for the current head stage/072-returned-to-contributor Contributor PR: CI red, changes requested or conflicting; diagnosis posted, author must act and removed stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Nov 10, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor

@Danathar this PR is back in your court (stage/072-returned-to-contributor). The hive will not merge it until the head changes.

Failing checks:

  • test / GNOME 50 — common-a
  • test / GNOME 50 — common-b

Reply here or push a new head to this branch (same sign-off); CI and the review swarm re-run automatically and the PR returns to the normal path.

Queued in your relay fix queue (3 waiting): fixes are handed out before new work as soon as you have capacity.

@hivecommons-hive

Copy link
Copy Markdown
Contributor
203415c

ℹ️ Sentinel notice — informational; author is trusted (owner), merge is not blocked

Hive flagged this PR (author @Danathar, head 203415c181aa) because it matches behaviors that can override security controls, escalate privileges or damage the codebase. This is a heuristic, not an accusation — a maintainer should confirm the change is intended before it merges.

  • sensitive_path — changes 1 sensitive path(s) (Touches a sensitive path (OWNERS, workflows, policies, hive config, security docs, …))
    • .github/workflows/e2e.yml

Hive did not add the sentinel-alert label because this author is trusted. The finding remains recorded for audit and the dashboard Security tab; set sentinel.trusted_authors_block: true to require the blocking label for trusted authors too.

@Danathar
Danathar merged commit ef2024c into main Nov 11, 2026
12 of 14 checks passed
hivecommons-hive Bot pushed a commit that referenced this pull request Nov 12, 2026
* ci: boot the suites a pull request affects before it merges

e2e.yml only runs when something calls it, and contributor agents may
not dispatch workflows, so a VM-related change got its first VM run
after merge (as a v1 hold) or when a maintainer started a manual run.
On 2026-11-10 every VM question (#827, #838, #908, #1138, #1139) waited
on a person starting a run.

Add "PR VM check": on every pull request, plan the PR's own changes with
the v1 gate's planner (vm_validation_plan.py + v1_gate.py) and, when a
VM is needed, boot those suites through e2e.yml on dakota:testing pinned
by digest, testing the merge commit. Docs-only and tooling PRs boot
nothing; a change the gate cannot boot (the gnome-e2e composite action)
gets a notice. Advisory, not required. This PR changes the workflow
itself, so it boots common and smoke as its own proof.

Assisted-by: Claude Opus 5.5 via Claude Code
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WcWm7qQa538Zjcuvv8jBtn
Signed-off-by: Danathar <Danathar@users.noreply.github.com>

* docs: say how to validate what the PR VM check cannot boot

The manual run calls e2e.yml, so it cannot cover a hold. Point
composite_action changes (the gnome-e2e action and the extension
validation gate it runs) at gnomeos-canary.yml on a branch at the PR's
head, and no_hosted_lane suites at their own hardware or a hand check.
Also drop "advisory": the hive merges no PR while any check is red.

Addresses the hive reviewer's docs-currency finding on #1142.

Assisted-by: Claude Opus 5.5 via Claude Code
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WcWm7qQa538Zjcuvv8jBtn
Signed-off-by: Danathar <Danathar@users.noreply.github.com>

---------

Signed-off-by: Danathar <Danathar@users.noreply.github.com>
Co-authored-by: Danathar <Danathar@users.noreply.github.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author/clanker A contributor's own hive authored this PR under their login dco All commits are DCO signed-off role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/072-returned-to-contributor Contributor PR: CI red, changes requested or conflicting; diagnosis posted, author must act

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant