Repository navigation
fix(e2e): mount the disk where any image can host it when labeling - #1138
Conversation
#1119's labeling step runs the candidate image with -v /mnt/root:/mnt/root and -v SELINUX_DIR:SELINUX_DIR. In ostree-style images /mnt and /home are symlinks into /var that the image does not populate, so podman cannot create the mount point and the step fails before any test runs: utah:testing stopped with "crun: creating `/mnt/root`: openat2 `mnt`: No such file or directory" (manual run 42919494173). dakota:testing is not affected, so the v1 gate passed. Mount the disk at /harness/root and the list at /harness/list, and rewrite /mnt/root to /harness/root in setfiles' root, the file_contexts path and every list entry, so the same files are labeled. Assisted-by: Claude Opus 5.5 via Claude Code Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WcWm7qQa538Zjcuvv8jBtn Signed-off-by: Danathar <Danathar@users.noreply.github.com>
|
@Danathar this PR is back in your court ( Failing checks:
Reply here or push a new head to this branch (same sign-off); CI and the review swarm re-run automatically and the PR returns to the normal path. Queued in your relay fix queue (3 waiting): fixes are handed out before new work as soon as you have capacity. |
203415c
ℹ️ Sentinel notice — informational; author is trusted (owner), merge is not blockedHive flagged this PR (author @Danathar, head
Hive did not add the |
* ci: boot the suites a pull request affects before it merges e2e.yml only runs when something calls it, and contributor agents may not dispatch workflows, so a VM-related change got its first VM run after merge (as a v1 hold) or when a maintainer started a manual run. On 2026-11-10 every VM question (#827, #838, #908, #1138, #1139) waited on a person starting a run. Add "PR VM check": on every pull request, plan the PR's own changes with the v1 gate's planner (vm_validation_plan.py + v1_gate.py) and, when a VM is needed, boot those suites through e2e.yml on dakota:testing pinned by digest, testing the merge commit. Docs-only and tooling PRs boot nothing; a change the gate cannot boot (the gnome-e2e composite action) gets a notice. Advisory, not required. This PR changes the workflow itself, so it boots common and smoke as its own proof. Assisted-by: Claude Opus 5.5 via Claude Code Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WcWm7qQa538Zjcuvv8jBtn Signed-off-by: Danathar <Danathar@users.noreply.github.com> * docs: say how to validate what the PR VM check cannot boot The manual run calls e2e.yml, so it cannot cover a hold. Point composite_action changes (the gnome-e2e action and the extension validation gate it runs) at gnomeos-canary.yml on a branch at the PR's head, and no_hosted_lane suites at their own hardware or a hand check. Also drop "advisory": the hive merges no PR while any check is red. Addresses the hive reviewer's docs-currency finding on #1142. Assisted-by: Claude Opus 5.5 via Claude Code Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WcWm7qQa538Zjcuvv8jBtn Signed-off-by: Danathar <Danathar@users.noreply.github.com> --------- Signed-off-by: Danathar <Danathar@users.noreply.github.com> Co-authored-by: Danathar <Danathar@users.noreply.github.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Summary: #1119 (SELinux enforcing by default) added a labeling step to
e2e.ymlthat runs the image under test with-v /mnt/root:/mnt/rootand-v $SELINUX_DIR:$SELINUX_DIR. In ostree-style images/mntand/homeare symlinks into an unpopulated/var, so podman can't create those mount points, and the run stops before any test starts.utah:testingfails this way (manual run 42919494173: "crun: creating/mnt/root: openat2mnt: No such file or directory").dakota:testingdoesn't, which is why thev1gate passed.v1now includes #1119, so utah's e2e will most likely hit this when itsv1pin is bumped.Fix
Mount the disk at
/harness/rootand the file list at/harness/listinside the container, and rewrite/mnt/rootto/harness/rootinsetfiles' root, thefile_contextspath and every list entry.setfileslabels exactly the same files as before.How to test (
e2e.ymlonly runs when called, so this needs manual runs from this branch)gh workflow run manual.yml -R projectbluefin/testsuite --ref fix/selinux-label-mounts -f image=ghcr.io/projectbluefin/utah:testing -f suites=common: should get past "Install OCI image and configure disk" and boot.gh workflow run manual.yml -R projectbluefin/testsuite --ref fix/selinux-label-mounts -f image=ghcr.io/projectbluefin/dakota:testing -f suites=common: should behave as onmain(no regression on the gate image).Checked locally: the path rewrite gives the expected
setfilesarguments for both the deployment and stateroot calls, and actionlint shows the same findings asmain.e2e.ymlis a human-merge path, so a maintainer merges this after both runs.🤖 Generated with Claude Code
https://claude.ai/code/session_01WcWm7qQa538Zjcuvv8jBtn