Skip to content

[governor] 🐝 Hive Advisory Report #1648

Open

Description

@hivecommons-hive

This replaces projectbluefin/testsuite#639, which Danathar closed on 2026-11-06. Hive does not reopen an issue a person closed, so the digest moved here. To keep the digest off GitHub, set advisory.target: linear (with advisory.linear_issue) in hive.yaml; to go back to projectbluefin/testsuite#639, reopen it and close this one.

This issue collects advisory findings from Hive agents.

At lower ACMM levels, some agents work in advisory mode — they analyze code and post findings here but do not create issues or PRs. At higher levels, designated agents (e.g. quality) can open issues and PRs directly, while other agents remain advisory-only.

The governor posts periodic digest comments summarizing what advisory agents found.

Do not close this issue. It is a living document.

— hive: agent=governor

Activity

  1. added
    hive/advisoryPinned advisory report from Hive agents
    origin/governorFiled by the Hive governor/automation on its own behalf (provenance only, not routing or hold)
    on Nov 6, 2026
  2. added
    needs-kindA maintainer must classify this issue; the intake source did not establish its kind.
    on Nov 6, 2026
  3. github-actions commented on Nov 6, 2026

    @github-actions
    Contributor

    Issue triage

    Next action: a triager or maintainer reviews this issue.

    Reporter or contributor

    • If no kind/* label is set, categorize the issue with one of: /kind bug, /kind regression, /kind security, /kind feature, /kind documentation or /kind cleanup.
    • Optionally add an area with /area <area>: desktop, flatpak, gaming, hardware, installer or dx.

    Triager or maintainer

    • Review the report and ask the reporter for any missing information.
    • When the scope is accepted and the issue is ready for work, comment /triage accepted. Only triagers and maintainers can do this; acceptance does not assign an implementer.

    needs-kind clears when a kind is set. needs-triage and this post clear when triage is accepted.

    See Triage & Prow Commands for all available commands.

  4. hivecommons-hive commented on Nov 6, 2026

    @hivecommons-hive
    ContributorAuthor

    🐝 Advisory Digest — 2026-11-19 07:44 EST

    Automated code review findings from Hive agents. Each finding includes a file reference and suggested fix. This comment is updated periodically.

    Advice

    Hive picked this list on 2026-11-19 and keeps it until 2026-11-26, so it does not jump around between reports. The numbers, items and links under each one are worked out fresh for every report. If Hive's mode changes from BUSY, it picks a new list sooner.

    Counts quoted: governor actionable queue 84 PRs / 19 issues (what mode and cadence key on; excludes held, draft, in-review and human-gated items) — Overview chart 96 open PRs / 132 open issues (every open or held item across repo cards; the queue-health advice counts these).

    • Clear the human gate on PRs — 63 of 96 open PRs (65%) are waiting on a person; the hive cannot move them on its own.
      • Why they wait:
        • 14 handed to a person by the hive's review to decide (3 in server, 2 in actions, 2 in common, 7 elsewhere).
        • 13 parked until a maintainer decides (5 in utah-packages, 3 in actions, 2 in utah, 3 elsewhere).
        • 11 that only a person can merge (5 in documentation, 3 in common, 2 in server, 1 elsewhere).
        • 8 waiting for an approving review that branch protection requires (6 in common, 2 in website).
        • 5 with changes a reviewer requested (3 in utah, 1 in common, 1 in utah-packages).
        • 12 more for other reasons; the full list has each one.
      • How to help: read the hive's review and decide; answer the parked decisions in utah-packages and actions; merge the reviewed PRs by hand in documentation and common.
      • First:
      • Full list: Your-turn PRs (CSV)
      • Numbers behind this: overview_open_prs=96, needs_human=63, your_turn=63, to_close=0, verbs=5 INSPECT, 13 DECIDE, 45 REVIEW
    • Rebalance toward merge-side agents — The hive is busy; prioritize review, hold draining, and merge-side lanes before increasing new issue intake.
      • Numbers behind this: mode=BUSY, open_holds=11, governor_prs=84, governor_issues=19
    • Close what agents already finished — 2 issues are agent-marked done; confirming them shrinks the backlog by 1%.

    Bands named above (same rules as the Overview chart):

    • Confirm & close (issues): an agent applied hive/already-done, hive/covered-by-pr, hive/likely-done (hive/likely-done not on a parked issue) — the agent reports the work as landed, and the issue is still open

    Findings: 10

    💡 Showing top 10 findings (by severity). 1948 more exist. Set governor.advisory.show_all: true to see all.

    Severity Count
    🔴 critical 10

    🔴 CRITICAL (10)

    • [advisory] actions: shared main lint failure remains tracked by ci: evaluate squash_merge_commit_message setting — COMMIT_MESSAGES produces noisy squash bodies #758; cache-call-unrestricted and deprecated node20 runtime; existing fix feat(bazaar): add Collabora + Spelling Bee + Whisp, refresh curation #731 green, no duplicate PR (file path not found at analyzed commit — finding may be outdated) ci-maintainer
    • [advisory] contribute: second Renovate identity (renovate[bot]) owns renovate/omp-runtime and ships version-only bumps — PR fix(ci): skip CVE scan in merge queue to fix SARIF upload ref error #660 permanently red projectbluefin/contribute#663 ⚠️ (not re-reported within the staleness window — still open, but not recently verified) ci-maintainer
    • [advisory] No test for OEM brew user setup hook (20-oem-brew.sh) system_files/shared/usr/share/ublue-os/user-setup.hooks.d/20-oem-brew.sh quality
    • [advisory] No test for ASUS system setup hook (11-asus.sh) system_files/shared/usr/share/ublue-os/system-setup.hooks.d/11-asus.sh quality
    • [advisory] No test for Framework hardware setup hook (10-framework.sh) system_files/shared/usr/share/ublue-os/system-setup.hooks.d/10-framework.sh quality
    • [advisory] [shared-ci] dakota-iso Plain/LUKS E2E: installed system boots to emergency mode; 30-line serial log window hides failing unit — 7 PRs blocked #211 ⚠️ (not re-reported within the staleness window — still open, but not recently verified) scanner
    • [advisory] [shared-ci] projectbluefin/server installer-test red on main since 2026-09-14 (50be1ed2) — /dev/disk/by-partlabel/var missing, 17 PRs blocked #218 ⚠️ (not re-reported within the staleness window — still open, but not recently verified) scanner
    • [security] common/PR: ujust shellenv eval lacks input validation #902 scanner

      ujust fzf bootstrap uses eval on Homebrew shellenv output without validation. Malicious shellenv could execute arbitrary commands.

    • [security] dakota#1182: pr-triage.yml uses pull_request_target with contents permission — token leakage risk #1182 scanner

      Workflow uses pull_request_target trigger which runs in the base repo context, combined with contents: write permission. This allows a forked PR to access and modify base repo secrets and code. In pull_request_target context, GITHUB_TOKEN has access to base repo data. If the workflow runs untrusted code from the PR (e.g., calling scripts), attackers can exfil secrets or push code. Impact: GitHub token and repo secrets leakage.

    • [security] bluefin-lts#213: common image used in LTS build without cosign signature verification — supply chain gap #213 scanner

      bluefin builds call 'just verify-container common:latest@${common_image_sha} ghcr.io/projectbluefin keys/projectbluefin-common.pub' before using common as a base. bluefin-lts Justfile has no equivalent verify-container call — COMMON_IMAGE_REF is passed directly to podman build --build-arg. A compromised or accidentally unsigned common image (as happened in common#697) silently passes into every LTS build. bluefin correctly failed with 'no signatures found' during that regression; LTS did not.

    ☑️ Recently Closed — Fix Not Verified (10)

    Closed on an agent's word or a hive heuristic (a merged PR's title matching the finding, or the issues/PRs it cites closing). The hive did not re-check the condition, so it may still hold.

    • projectbluefin/ps-printer-app: Nov 12 sweep — latest FSDK PR validation green (43282178827); five main cache refills green, both architectures built and caches saved (43288898744); Prow failures 43288719273/43288708552 correctly reject unauthorized bot approval/review commands, subsequent runs green; publish intentionally gated by PS_PUBLISH_APPROVED; no persistent CI defect or new merge-group proof https://github.com/projectbluefin/ps-printer-app/actions/runs/43288898744 ci-maintainer — closed Nov 19 (no evidence recorded), fix not verified
    • website: 2026-10-22 sweep — CI/Deploy/Update Live Data green on main; wolves-movie-flow no main flake since 10-03 (closed watch); Compress Images last ran 09-12 as startup_failure on old-yml heads, unverified on current main; Preview gated off by vars.CLOUDFLARE_PAGES_ENABLED (intentional) ci.yml ci-maintainer — closed Nov 19 (no evidence recorded), fix not verified
    • website: CI lacks PR concurrency; test job takes 7m51s, superseded PR runs not canceled. Exact additive workflow-only spec submitted via hive-open-issue needs-decision; this lane cannot push workflows. Current main CI/deploy green; Nov 8 Update Live Data HTTP 504 recovered in next four scheduled runs. projectbluefin/website request ci-maintainer-1794502777116243394; run 42807126824 ci-maintainer — closed Nov 19 (no evidence recorded), fix not verified
    • website quality audit cdc97de4e2bc: matching CI 1553 tests pass, 1 skipped; 113 browser assertions pass; existing coverage gates apply; raw E2E coverage unavailable, already tracked https://github.com/projectbluefin/website/actions/runs/44428837150 quality — closed Nov 19 (no evidence recorded), fix not verified
    • projectbluefin/utah: NVIDIA E2E explicitly blocked on absent GPU hardware; existing testsuite#706 tracks prerequisite; keep failure visible projectbluefin/testsuite#706;utah/42767720901/job/129668144719 ci-maintainer — closed Nov 18 (no evidence recorded), fix not verified
    • bluefin-bling quality audit 80b93c374005: 472 local tests OK, 24 real-GJS skips; matching CI job 134911612482 passes 472 tests with 1 host-dependent skip and strict schema compilation. Subprocess-inclusive Python raw coverage combined: evaluator 126/126, issue reporter 161/161, channel resolver 59/63, manifest 231/234 statements. 411 V8 profiles: light-style 5/5, power 26/26, syncthing extension 4/4, prefs 5/5, toggle 70/71 functions executed, not statement coverage. CI exposes no artifacts; manual GNOME OS probe has no runs, E2E line coverage unknown, no unit/E2E merge or missing-E2E claim. Existing execution-path gate covers every shipped module; prior declined line-coverage proposal and existing GJS reporting bead suppress duplicates. No new issue, PR or tracked change. Raw evidence in session files/bling-coverage. https://github.com/projectbluefin/bluefin-bling/actions/runs/44335683731 quality — closed Nov 18 (no evidence recorded), fix not verified
    • finpilot: Nov 18 CI sweep; main image and unit tests green, stable release green; latest 20 runs 19 success and one action_required validation with no jobs; no persistent execution failure confirmed https://github.com/projectbluefin/finpilot/actions/runs/44376582063 ci-maintainer — closed Nov 18 (no evidence recorded), fix not verified
    • homebrew-tap: Nov 18 CI healthy; latest ten brew test-bot runs and ten brew bump runs green; all five main and merge-queue jobs pass (44180260635, 44179950439). Earlier Prow failure/cancellation superseded by successful same-head runs; no retrigger or repair needed. https://github.com/projectbluefin/homebrew-tap/actions/runs/44180260635 ci-maintainer — closed Nov 18 (no evidence recorded), fix not verified
    • fsdk-containers: main review-runtime publication failed during ORAS install with repeated HTTP 504 responses (run 42557353179); prior two builds green https://github.com/projectbluefin/fsdk-containers/actions/runs/42557353179 ci-maintainer — closed Nov 18 (no evidence recorded), fix not verified
    • fsdk-containers: Vulnerability Scan printer-app legs fail SARIF upload (grype empty artifactLocation.uri; workflow fix needs human) run 41411895276 ci-maintainer — closed Nov 18 (no evidence recorded), fix not verified
    • …plus 3 more closed without a verified fix in the last 48h, collapsed so the open findings above stay readable

    Analyzed at projectbluefin/common@8820523227b0 (branch main) — the latest commit when this digest was generated. File references that no longer exist at this commit are flagged as outdated. Findings marked ⚠️ were computed at an older commit and have NOT been re-verified here.

    Updated 180 times · last 2026-11-19T12:44:40Z

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    hive/advisoryPinned advisory report from Hive agentsneeds-kindA maintainer must classify this issue; the intake source did not establish its kind.needs-triageorigin/governorFiled by the Hive governor/automation on its own behalf (provenance only, not routing or hold)

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions