Repository navigation
feat(e2e): keep Linux security protections on during desktop tests and fail on blocked actions - #1109
Merged
Merged
Conversation
Drop selinux=0 from the guest kernel arguments so the candidate runs with its own policy, and make the run prove it: - Label only the files the harness writes on the non-SELinux runner, using the candidate's own setfiles and file_contexts. Files already unlabeled before injection are candidate-owned and left alone so labeling defects stay product failures. - Fail early when a guest with a policy store is not Enforcing, and again after the suite (covers lifecycle reboots). Images without a policy store are reported as unsupported. - Fail on enforced AVC denials not named in selinux_allowlist.yaml (narrow type/permission/comm/tclass matching, reason required). - Trigger a deliberate httpd_t denial after judging the scenario log and fail if it does not reach the gate. Evidence goes to results/selinux/ in the results artifact. Refs #1024 Hive-Run: #1024 Hive-Plan: issue-1024-selinux-enforcing Hive-Spec: testsuite-e2e-selinux#1024 Assisted-by: Claude Opus 5.5 via Claude Code Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: codebymarshall <codebymarshall@users.noreply.github.com>
The e2e guest no longer boots with selinux=0; point the skill at the SELinux enforcing reference instead. Refs #1024 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: codebymarshall <codebymarshall@users.noreply.github.com>
…cope claim Add the Verify SELinux enforcing and SELinux denial gate steps to the SKILL.md step list and link references/selinux-enforcing.md from the references index. State that only each deployment's etc and var are relabeled: the fallback boot.N symlinks under /ostree/boot.* stay unlabeled and are read only by unconfined ostree/bootc. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: codebymarshall <codebymarshall@users.noreply.github.com>
e2e.yml no longer passes selinux=0; point authors at the enforcing reference instead of steering them to re-add the bypass. Hive-Fix-Attempt: 2/6 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Signed-off-by: Danathar <berths-purger-0g@icloud.com> # Conflicts: # docs/skills/ci-ops/e2e-workflow/SKILL.md
The enforcing boot, harness labeling, enforcing check and AVC denial gate have not run on a hosted VM yet, and e2e.yml is called by every image repo. Gate them behind a selinux_enforcing input (default false, also exposed by manual.yml): without it the guest keeps selinux=0 and the SELinux steps are skipped, so existing runs are unchanged. A manual dispatch from main with selinux_enforcing=true qualifies the lane; the rollout plan in #1021 then flips the default. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SnzFs53Qcer1xDySyxv1Vj Signed-off-by: Danathar <berths-purger-0g@icloud.com>
Contributor
|
1 of 5 commits on |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: This carries @codebymarshall's change from #1037 into a branch in this repository, unchanged: an opt-in lane for the desktop tests that keeps SELinux protections switched on and fails the run when the system blocks something unexpected. The original came from a fork and its author's agent has been offline since 10-28. The hive won't move fork PRs that edit workflow files, and it couldn't push fixes to the fork, so a maintainer has to bring it in.
What I need from you: A maintainer merges it by hand once checks pass, because it edits
e2e.yml.Supersedes #1037. Refs #1024.
7d9d3b0. Authorship and sign-offs are unchanged, so credit stays with @codebymarshall. That head includes Danathar's rebase onto main.selinux_enforcingdefaults to false, so existing runs don't change.e2e.ymladditions only talk to the local test VM over SSH and run an in-VM SELinux canary.scripts/selinux_qualify.pyonly reads files and parses JSON/YAML.scripts/selinux_collect_avc.shonly reads the guest's audit log.pull_request_target.🤖 Generated with Claude Code
https://claude.ai/code/session_01SnzFs53Qcer1xDySyxv1Vj