Repository navigation
ci: run all maintained unit suites in CI - #1249
Conversation
Register all current suites, install missing dependencies, and widen the workflow triggers while preserving the Bazaar coverage gate. Hive-Run: projectbluefin#1167 Hive-Plan: issue-1167-recommendation Hive-Spec: issue-1167#recommendation-1-7 Assisted-by: GPT-6 Astra via GitHub Copilot Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: arteeh <arteeh@users.noreply.github.com>
hanthor
left a comment
There was a problem hiding this comment.
Running all the maintained suites is a good idea, and splitting the pytest step keeps the Bazaar coverage denominator clean. Some changes are needed first:
unit-tests.yml"Install just":curl https://sh.rustup.rs | shplus an unpinnedcargo install --locked justbuild from source is slow and pipes a remote script into a shell. It's copied fromvalidate.yml, but it shouldn't spread. Please usesudo apt-get install -y just(Ubuntu 24.04 universe) or a SHA-pinned setup action, and ideally fixvalidate.ymlthe same way.- This registers
tests/test_bluefin_countme.bats, which #1205 deletes. Please coordinate with that PR. - There's a textual conflict with #1207 in
unit-tests.yml. - No checks have run on this head, so the new registrations haven't been validated in CI. Please push again or re-run so they execute.
hanthor
left a comment
There was a problem hiding this comment.
Thanks, dropping the rustup/cargo build is the right direction. It doesn't work as-is, though:
.github/workflows/unit-tests.yml:42: Ubuntu 24.04 ships just 1.21.0, and[group(...)]needs 1.27+. That's whytestis red:bats tests/test_brew_tap_trust.batstests 2-5 fail because just can't parseapps.just. Please use a SHA-pinned setup action (e.g.extractions/setup-justortaiki-e/install-action) that installs a current just.unit-tests.yml:156-157still runstests/test_bluefin_countme.bats, which #1205 deletes. Whichever PR lands second needs to drop it (#1205 registerstest_projectbluefin_countme.batsinstead).- Still a textual conflict with #1207 in
unit-tests.yml.
hanthor
left a comment
There was a problem hiding this comment.
Thanks. taiki-e/install-action pinned to a SHA gets a current just, and test is green now, including test_brew_tap_trust.bats. The ujust/rechunker test fixes for the new runner look fine too.
On the earlier points:
test_bluefin_countme.bats(unit-tests.yml:163-164) is correct against main as it stands. #1205 is still waiting on a policy decision, so this lands first and #1205 drops the step when it rebases.- #1207 is conflicting with main on its own, so it will have to resolve against this on its rebase. That doesn't block this PR.
Approving.
castrojo
left a comment
There was a problem hiding this comment.
Reviewed. All 44 maintained unit suites are registered in CI, Justfile test recipe and unit-tests.yml are synchronized, Bazaar coverage remains isolated with threshold maintained, and all checks are passing. Independent approval (2/2) satisfying repository ruleset.
What does this change?
Run all 44 maintained unit suites in CI by registering the 18 currently missing suites, installing
jsonschemaandjust, and triggering tests for all script changes and changes to the workflow itself. Keep script/config pytest execution separate from the unchanged Bazaar coverage gate. Update the testing contract and workflow skill with the registration requirements.Why?
Closes #1167.
Both prerequisite PRs #1106 and #1166 are merged, so this includes
ujustandublue-image-repo; the registration gate was already wired into CI. It also includes suites added since the issue was filed.test_bazaar_hook.pywas removed in #1155 and is intentionally not referenced.Validation
zshis unavailable (CI installs it).just check,pre-commit run --all-files, andactionlint .github/workflows/*.ymlpassed.CI results will be reviewed after the PR opens; no image content changed.
— hive: backend=codex model=gpt-6-astra effort=medium
🐝 Hive Agent:
contributor| SHA:b7965a6