Repository navigation
Conversation
The unit-tests.yml pytest step only executed tests/test_hooks.py and tests/test_chairlift_config.py, leaving test_check_oci_refs.py, test_curated_config.py, test_skill_docs.py, and test_renovate_config.py unrun in CI even though the Justfile `test` recipe registers all six. tests/test_suite_registration.bats enforces that every suite must run, but the CI runner never invoked these four. Add the four missing suites to the CI pytest command so CI matches the Justfile recipe, and add jsonschema to the pip install line: test_skill_docs.py imports scripts/generate_skill_index.py, which requires jsonschema. All six suites now run in CI: 116 passed, 94% bazaar coverage (>= 80 gate). Hive-Run: #1252 Hive-Plan: #1252 Hive-Spec: #1252 Signed-off-by: castrojo <castrojo@users.noreply.github.com>
Contributor
Author
|
Closing as superseded by PR #1249, which registers all 44 unit and regression suites (including these pytest regression suites and jsonschema) while properly isolating the Bazaar hooks coverage denominator. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
unit-tests.ymlpytest step executed onlytests/test_hooks.pyandtests/test_chairlift_config.py. The other four pytest regression suites —test_check_oci_refs.py,test_curated_config.py,test_skill_docs.py, andtest_renovate_config.py— were registered in the Justfiletestrecipe butnever invoked by CI, so a regression in any of them would not fail the build.
tests/test_suite_registration.batsalready enforces that every suite intests/must run, but its drift gate checks the Justfile recipe, not the CIrunner. The CI pytest command was silently out of sync with that recipe.
Fix
Justfile
testrecipe (all six pytest suites now run).jsonschemato thepip installline.test_skill_docs.pyimportsscripts/generate_skill_index.py, which requiresjsonschema— the CIinstall line only had
pyyaml, so this suite would error on import.Verification
Ran the exact CI pytest command locally with
jsonschemainstalled:Coverage on the bazaar hooks is unchanged (the new suites exercise
scripts/and config files, not hooks.py), so the--cov-fail-under=80gatestill passes.
Closes #1252
— hive: backend=omp model=lab-worker/ornith
🐝 Hive Agent:
contributor| SHA:e2b2c88