IBX-11907: Added php-version input to composer-install action and Rector workflow - #115
Merged
Merged
Conversation
The action passed matrix.php straight to setup-php. Callers without a PHP matrix ended up with an empty version and setup-php silently installed the latest stable PHP. The input is optional and falls back to matrix.php when empty, so existing matrix-based callers are not affected. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
The Rector job has no matrix, so composer-install resolved an empty PHP version and setup-php picked its default (PHP 8.5.10 observed in https://github.com/ibexa/cloud/actions/runs/33925477235). The input is passed through to composer-install with no default on purpose: current behavior stays unless a caller opts in with e.g. php-version: '8.3'. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
alongosz
force-pushed
the
ibx-11907-composer-install-php-version-input
branch
from
September 5, 2026 00:00
1b5cc39 to
7a6d0eb
Compare
|
alongosz
requested review from
Steveb-p,
ViniTou,
barw4,
bnowak,
ciastektk,
konradoboza,
mikadamczyk,
tbialcz and
wiewiurdp
September 5, 2026 15:09
Member
Author
|
Merged to unblock IBX-11778 pending wave of PRs. Can address remarks, if any, as a follow-up. |
This was referenced Sep 5, 2026
This was referenced Sep 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Caution
rector.ymlpointscomposer-installat this branch for testing)Description:
actions/composer-installpasses${{ matrix.php }}straight to setup-php instead of exposing an input. Any caller without a PHP matrix ends up with an emptyphp-version, and setup-php silently installs the latest stable PHP.The reusable
rector.ymlworkflow is exactly such a caller: Rector run 33925477235 via ibexa/cloud#14 installed PHP 8.5.10. A fleet scan (2026-09-05) found 23rector.yamlcallers across 14 packages (core, migrations, test-fixtures, dam-user, fieldtype-richtext-rte, connector-anthropic, connector-ai-assistant, connector-raptor, connector-seenthis, admin-ui-extras, async-content-publishing, mercure, translations, fastly-forwarded-host), plus the new ones from the IBX-11778 rollout. All of them run on whatever setup-php considers latest ATM.php-versioninput toactions/composer-install. When empty, it falls back tomatrix.php, so existing callers behave exactly as before (BC).php-versioninput in the reusablerector.ymlworkflow and passed it tocomposer-install. No default on purpose: an empty value keeps the current behavior (setup-php default, ATM PHP 8.5.x).Note
No caller changes required. Rector callers that want a stable PHP version can now opt in with
with: php-version: '8.3'.For QA:
No manual QA required. Tested via a throwaway harness on ibexa/gha-testing@ibx-11907-rector-harness, run 33928247591:
php-version: '8.3'installed PHP 8.3.33php-versionkept current behavior (installed PHP 8.5.10)actions/composer-installwithoutphp-versionin a matrix job (8.3,8.4) still usedmatrix.php(installed PHP 8.3.33 and 8.4.25)Documentation:
No documentation required.
🤖 Generated with Claude Code