Skip to content

🐛 Close partially-addressed issues the scanner verified complete #19299

Closed

Description

@clubanderson

Problem

Multi-phase PRs say Refs #N. On merge the claim sync (prclaims.go) and close-on-merge (markPartiallyAddressed) label the issue hive/partially-addressed and the stage engine moves it back to stage/010-actionable. The scanner's verify-once kick then verifies it and writes free text such as "This can be closed" (#17157, #19177), but nothing acts on that, so finished issues sit at 010 until a person closes them. Partly done ones also lose their scanner claim when the agent is relaunched.

Fix

  • A machine-readable verdict the scanner ends its verification note with: <!-- hive:verification verdict=complete prs=N[,M] --> or verdict=partial. The verify-once kick wording asks for it.
  • The issue stage sweep reads the marker on hive/partially-addressed issues, from hive-authored comments only, and with two reads one settle interval apart (the tracker auto-close's settle code, ✨ Close tracker and umbrella issues whose referenced work is done (opt-in) #19151):
    • closes the issue as completed with an evidence comment citing the merged PRs when every cited PR is merged and no linked PR is open;
    • otherwise parks it in a verify-close lane (045 park label hive/verify-close) that the dashboard shows with a one-click Close;
    • verdict=partial adds hive/verified-open.
  • Never touched: hold, hive/tracking, umbrella or tracker issues, parents with an open child, issues a person reopened or took out of the lane.
  • Relaunch claims: explained why they are still released, and how the marker carries the verdict across the relaunch.

Activity

  1. self-assigned this
    on Nov 19, 2026
  2. clubanderson commented on Nov 19, 2026

    @clubanderson
    MemberAuthor

    Claiming: fix in progress on branch fix-scanner-verified-close; PR to follow.

  3. clubanderson commented on Nov 19, 2026

    @clubanderson
    MemberAuthor

    PR: #19301

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions