Repository navigation
π Keep agents from pushing their own commits to a person's PR - #19298
Merged
Merged
Conversation
The trusted-author rebase kick, the FIX-BEFORE-NEW work list and the merge-request re-engagement kick sent the scanner lane to people's PRs with "commit -s, push" and nothing more. It pushed its own follow-up commits and once re-signed a person's commit (#19110, #19102, #19063). The squash lands those under the PR author with the agent's sign-off, which fails "Sign-off survives the squash". Rows for a person's PR now carry person_authored and a shared rule: no own commits, no re-signing, anything beyond the rebase goes in a PR comment. The review-fix prompt signs off only the agent's own commits instead of git rebase --signoff, and the sign-off attribution note no longer says the commits are signed off as the hive App when an agent wrote them. Fixes #19296 Signed-off-by: Andy Anderson <andy@clubanderson.com>
Contributor
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of
|
This was referenced Nov 19, 2026
Contributor
Mutation testing5 mutant(s) in changed files are not reached by any test (NOT COVERED). A maintainer may apply the
Verdict: |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #19267 / #19268. #19268 fixed the no-dco repair kick. The audit in #19296 found the other flows behind the bad commits on #19110, #19102 and #19063: the trusted-author rebase kick, the FIX-BEFORE-NEW work list, and the merge-request re-engagement kick. Each sent the scanner lane to a person's PR with "commit -s, push". It pushed its own follow-ups (rebase citation refreshes, test and coverage fixes) and once re-signed a person's commit. A squash lands those under the PR author with the agent's sign-off, which fails "Sign-off survives the squash". That check counts no
Co-authored-by, so the compliant behavior is: no agent commits on a person's PR unless it carriesmerge-method/merge.Changes
stagelabels.PersonPRAgentCommitRuleandstagelabels.OwnSignoffRebaseExec(moved fromcmd/hive) are the single source for the rule.ci-failing.jsonrows carryperson_authored(not hive-authored, not adopted, not a bot). The FIX-BEFORE-NEW block prints the rule on those rows. The trusted-author rebase text now says to add no commit or Signed-off-by of the agent's own.redPRFixKickstates the rule for any author, because the merge-watcher hook that reaches it knows no author (π Filter em-dashes on every outbound path, agent proxy writes includedΒ #19110).review.BuildFixPromptnames the own-commits-only--execinstead ofgit rebase --signoff.stage-labels.mdand a changelog fragment.The check is unchanged. The deterministic in-pod guard (agents that push outside the broker) is tracked in #19297.
Fixes #19296
π€ Generated with Claude Code