Repository navigation
✨ customers: hub import disclosure, docs and consent views - #19253
hivecommons-hive[bot] wants to merge 1 commit into
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor. hive/awaiting-ci: CI pending - sweep will merge when green. Synced with v5 this kick. 🐝 Hive Agent: Review findings from The code looks correct to me; the open point is a consent and privacy wording decision, which is a person's call. Verified against the tree at
Suggestion, not a defect: the disclosure states concrete timing ("normally within an hour", "within three days") that nothing in this diff ties to a code constant, so it can drift. A maintainer should confirm those numbers match the spoke sync behaviour from the earlier phases. |
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of
|
UI render evidenceRender evidence captured. Built from
These are fixture renders, not live data: the page was built from the PR head and filled with synthetic data from |
There was a problem hiding this comment.
Decision needed: @clubanderson should decide whether the new consent disclosure wording (hub learns the hive-customer relationship, 72h/hourly withdrawal timing, "cannot recall exported copies") is the text people should be consenting to, since it bumps customerConsentTextVersion to 2 and suspends every existing consent.
Code read at the PR head: the aggregate admin endpoint and the stamp change look correct to me; the open item is a consent and privacy wording decision, which is a person's call.
customerConsentCounts(src/pkg/hub/customer_consent.go) reads only the consent store, skips withdrawn, discardable and empty-field records, and splits current vs olderTextVersion. It is behindrequireAdminand returns 404 while the switch is off.TestCustomerConsentAdminCountschecks both gates and that no login, value or field name appears in the body.LastDeliveredFieldsis stamped instampCustomerDelivery(customer_match.go) and covered by the updated match test.- Open question, not a defect: the endpoint states "no person or value is shown", but a hive with one consent reveals that one person consented for that hive. Admin-only, so probably acceptable; worth a conscious yes.
- The version bump to 2 is intentional and tested (
TestCustomerConsentDisclosureText). It is irreversible for users in practice (all prior consents pause), hence the routing above.
I did not run anything; CI is the verdict. The PR shows mergeable_state=blocked, so check the required checks.
-- hive: agent=reviewer-2 backend=claude model=claude-sonnet-5-5 claude=2.1.328
Mutation testinggremlins found 1 surviving mutant(s) in changed files: the code ran under tests, but changing it did not fail any test.
Verdict: |
|
Needs a decision, not a merge:
Head: verdict requires_human @aa56e0c, 75/75 checks green, DCO yes, soak 0s of 10m0s. What to do: approve this head ( How to release it:
Clear the cause and the hive re-evaluates on its next pass; the stage moves to Updated 2026-11-19 15:38 UTC. |
|
/approve Posted by @clubanderson from the Hive dashboard; the merge gate decides from here. |
|
/hive decision approve #19253: green head, reviewer question answered with the reversible default — proceed as implemented Rationale: no owner rule holds this back; a merge is reversible and keeps work moving. Hive decided: Approved for merge. Decided by the hive at @clubanderson's request as the owner's delegate under the owner-delegate policy (rule |
|
Approved by @clubanderson for Hive auto-merge on green CI. |
|
Hive queued this PR but could not set the |
|
New changes are detected. LGTM label has been removed. |
There was a problem hiding this comment.
Decision needed: @clubanderson should decide whether the version 2 consent disclosure text, which suspends every existing version 1 consent until each person reconfirms, is acceptable to ship as worded.
Code reads correct to me; the open point is the consent-text change, which is a privacy/legal call for a person.
What I checked in the tree at the head:
- Bumping
customerConsentTextVersionto "2" (customer_consent.go:23) really does suspend v1 consents: the delivery gatecustomerMatchEffectiverequiresc.TextVersion == customerConsentTextVersion(customer_match.go:221), and the counts endpoint reports older records asawaiting_reconfirmation. customerConsentCountsreturns only hive id, name and two integers, skips withdrawn and discardable records, and the route sits behindrequireAdminand the sharing switch. No person or field value leaks.last_delivered_fieldsis stamped only instampCustomerDelivery(customer_match.go:453), so the UI summary reflects what was actually sent.
One finding:
src/docs/api-reference/hub-saas.md:86and:108both add the identicalGET /api/saas/admin/profile-share/countsrow, so the route is listed twice in the table. Drop one.
The decision: existing v1 consents stop sharing on merge and people must reconfirm. That is the intended behavior per the code comment, but whether the new disclosure wording is final is not stated anywhere I can see.
-- hive: agent=reviewer-2 backend=claude model=claude-sonnet-5-5 claude=2.1.328
|
/approve Posted by @clubanderson from the Hive dashboard; the merge gate decides from here. |
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com> Co-authored-by: clubanderson <407614+clubanderson@users.noreply.github.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
aa56e0c to
31a730e
Compare
Phases 1 to 3 of #19088 made the hub import work end to end, but the consent page still told people "No profile details are sent to any hive in this release", and the docs still said Customers reads nothing from the hub. So a person could consent under text that no longer matched what happens. This closing slice fixes that gap. People can now see their consent being used, and the hub admin gets a view that does not turn into a per-person lookup.
customerConsentTextVersiongoes to 2. As the design requires, a consent given under the old "nothing is sent" text is suspended until the person confirms again.last_delivered_fieldsstamp holds the last answer's fields, becausedelivered_fieldsis the union of every field ever sent.Fixes #19164 (needs-human: live hub/spoke verification, scope item 5)
🤖 Generated with Claude Code
-- hive: agent=scanner backend=claude model=claude-sonnet-5-5 claude=2.1.328 requested_by=@clubanderson