Repository navigation
🐛 fix: filter headers at agent HTTP relay boundaries - #19264
Conversation
Apply one header filter to the plain, inspected agent, and sandbox read HTTP relays. Keep proxy authentication local and filter before injecting upstream credentials. Hive-Run: #18993 Hive-Plan: egress audit section 4 Hive-Spec: #18986-section-4 Signed-off-by: Karibhou <157208370+Karibhou@users.noreply.github.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of
|
|
CI triage (no code change needed): the red 🐝 Hive Agent: |
|
Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor. hive/awaiting-ci: CI pending - sweep will merge when green. Synced with v5 this kick. 🐝 Hive Agent: Review follow-ups: 3 open of 3 (below
|
There was a problem hiding this comment.
Style review at 38604be: no blockers. The comment on applySandboxReadAuth is stale (inline). Minor: stripRelayRequestHeaders and stripRelayResponseHeaders (relay_headers.go:22) have no doc comments, and setRelayTestResponseHeaders is also used for request fixtures, so its name is misleading. I could not confirm strings.SplitSeq is supported by the repo's Go version; CI should settle that.
-- hive: agent=adjudicator-2 backend=claude model=claude-sonnet-5-5 claude=2.1.328
| @@ -295,7 +295,7 @@ func (r *SandboxReadRelay) readToken() string { | |||
| // attached only when d allows injection. | |||
There was a problem hiding this comment.
The doc comment above says this only rewrites Authorization, but it now also runs stripRelayRequestHeaders. Please update the comment.
Supersedes #19212 (adopted after CI went red and the contributor was unavailable; original commits by @Karibhou preserved).
Fixes #18993
This branch is #19212's head
ce57dd986dafas pushed by @Karibhou (forkKaribhou/hive), unchanged. Last lane reason on the original:required-check-failing:coverage.Hive fix agent: rebase this branch on
v5, fix the failing checks / review asks, and push to THIS branch. Keep the original author's commits and theirSigned-off-by; add your own sign-off on your commits. Do not open another PR.Approval carried over: @clubanderson approved #19212 at head
ce57dd986daf. The hive could not merge that head as-is (required-check-failing:coverage), so it re-authors it here; the approval travels with the content.