You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Sentinel alert label and status stay attached to an old PR head after new pushes #19262
The sentinel result is sticky across pushes. Once a PR gets the sentinel-alert label for a finding on one head, later heads are never judged on their own:
PR 📖 docs: prepare Ask AI dashboard help coverage #19192 kept sentinel-alert and the dashboard kept showing "Needs human · sentinel" because of a sensitive_path finding (Makefile) raised on an earlier head (0bee4e4). The current head (f718e15) is docs-only and touches no sensitive path.
trySentinelPR in src/pkg/github/sentinel_sweep.go returns early for any PR that already carries the alert label on the blocking path ("already alerted on; a maintainer has not cleared it yet"), so a labelled PR's new head is never evaluated. A clean evaluation also writes nothing, so neither the label nor the quiet-mode sentinel status section is ever updated for a newer head.
Expected
Evaluate every new head (opened / synchronize / reopened and the reconcile sweep), including PRs that already carry the label.
Record the head SHA with each finding (already true for events and the /api/sentinel ring) and keep the earlier findings for audit.
When the current head matches no rule, remove sentinel-alert only if the hive itself added it for an earlier head's finding (the hive's own alert comment names an earlier head and the hive's account applied the label). A label a person added, directly or later, is left alone.
Update the hive's sentinel comment and the status section to say the current head is clean.
The dashboard shows the sentinel state for the current head only.
A finding on the new head keeps the label and rewrites the explanation for that head.
Claiming: working on a fix that makes the sentinel head-scoped (evaluate every new head, clear the hive-added label when the current head is clean). PR to follow.
Activity
clubanderson commentedon Nov 19, 2026
Claiming: working on a fix that makes the sentinel head-scoped (evaluate every new head, clear the hive-added label when the current head is clean). PR to follow.
fix(sentinel): drop unused marker read, cover head-scoped branches