Skip to content

πŸ› Fix SHA hold exemptions and dashboard controls - #18879

Closed
hivecommons-hive[bot] wants to merge 2 commits into
v5from
hive/adopt-18870
Closed

hivecommons-hive[bot] wants to merge 2 commits into
v5from
hive/adopt-18870

Conversation

@hivecommons-hive

Copy link
Copy Markdown
Contributor

Supersedes #18870 (adopted after CI went red and the contributor was unavailable; original commits by @Karibhou preserved).

Fixes #18866

This branch is #18870's head 5a97f973ba15 as pushed by @Karibhou (fork Karibhou/hive), unchanged. Last lane reason on the original: reviewer-verdict:changes_requested.

Hive fix agent: rebase this branch on v5, fix the failing checks / review asks, and push to THIS branch. Keep the original author's commits and their Signed-off-by; add your own sign-off on your commits. Do not open another PR.

Karibhou and others added 2 commits November 18, 2026 04:32
Honor reporter and path exemptions and persist authorized SHA overrides.

Hive-Run: #18866
Hive-Plan: needs-sha hold exemptions and dashboard signal
Hive-Spec: issue-18866#acceptance
Signed-off-by: Karibhou <Karibhou@users.noreply.github.com>
Signed-off-by: Karibhou <157208370+Karibhou@users.noreply.github.com>
@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Nov 18, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign nicholasjackson for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 18, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

PR Title Relation Files
#18873 πŸ› needs-sha: exempt owner/detailed issues, overrideable waiver, visible hold on the row CONFLICT src/docs/labels-and-control-signals/glossary-and-operations.md (conflict)
src/docs/labels-and-control-signals/reference.md (conflict)
src/docs/operator-reference/README.md (conflict)
src/docs/scale-envelope.md (conflict)
src/pkg/dashboard/stage_tracker.go
src/pkg/dashboard/stage_tracker_build.go (conflict)
src/pkg/dashboard/static-src/js/tracker-actions.js (conflict)
src/pkg/dashboard/static-src/js/tracker-row-strip.js
src/pkg/dashboard/static/index.html (conflict)
src/pkg/github/client.go (conflict)
src/pkg/github/sha_hold_soft_test.go (conflict)

@github-actions github-actions Bot added the conflicts-with-open-pr Open PR has a merge conflict with another open PR label Nov 18, 2026
@hivecommons-hive hivecommons-hive Bot added author/hive This repository's own hive (the App or one of its agent lanes) authored this PR dco All commits are DCO signed-off role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/070-fixing Hive-authored PR: CI red, changes requested or needs rebase; a hive agent is fixing it labels Nov 18, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor Author

Superseded by #18873 (earlier fix for #18866). Closing as duplicate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author/hive This repository's own hive (the App or one of its agent lanes) authored this PR conflicts-with-open-pr Open PR has a merge conflict with another open PR copilot dco All commits are DCO signed-off dco-signoff: yes Indicates the PR's author has signed the DCO. hive/superseded Closed by Hive: a different merged PR already landed this change role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) size/L Denotes a PR that changes 100-499 lines, ignoring generated files. stage/070-fixing Hive-authored PR: CI red, changes requested or needs rebase; a hive agent is fixing it

Projects

None yet

Development

Successfully merging this pull request may close these issues.

πŸ› needs-sha hold blocks owner-filed bugs and gives no dashboard signal

1 participant