Skip to content

πŸ› Never adopt a contributor PR when another open PR covers the issue - #18933

Merged
kubestellar-prow[bot] merged 1 commit into
v5from
fix/no-adopt-covered-pr-18900
Nov 18, 2026
Merged

kubestellar-prow[bot] merged 1 commit into
v5from
fix/no-adopt-covered-pr-18900

Conversation

@clubanderson

Copy link
Copy Markdown
Member

Fixes #18900 (child of #18890, Wanted 3).

What

  • Engine (the executor that created πŸ› Fix SHA hold exemptions and dashboard controlsΒ #18879): adoptContributorPR now looks, before adopting, for another open PR on the same base branch that closes an issue the contributor PR closes and is a person's (owner, author/human, or an owner/member/collaborator not driving a clanker) or the hive's. If there is one, the contributor PR is closed as a duplicate of it with one thank-you/credit note (<!-- hive:adoption-covered -->), the head records covered-by-open-pr (tracker row explains), and adoption is never opened. The close goes through the write-back gate; a gate refusal or failed close leaves the PR open with adoption still off; the note is not repeated. The hive's own copy of the PR (Supersedes #N), another contributor's PR, a PR on another release line and a merge-queue-held duplicate do not count (equal trust is a tie). An unreadable PR list reads as not-covered and is logged (fail open, so it cannot stall adoption). Placed ahead of the human-claim check from [scanner] πŸ› Human claim or assignee releases a contributor lease and blocks contributor PRsΒ #18899 so a covering PR is still closed.
  • Ladder ("Let hive decide"): new rung 5a covered-by-other-pr just before adopt-supersede: close as duplicate of the competing PR with credit (recommend-only on a paused repo). A live person/hive-agent claim with no PR yet gives a recommend-only decision naming the holder. CompetingPR.PersonAuthored and Input.IssueClaimHolder are populated in gatherDelegatedPRContext; glossary entry added (Go glossary, JS mirror in static-src and static/index.html, docs table).
  • πŸ› Withhold the contributor nudge for a head the hive adopts anywayΒ #18874 not undone: AdoptsImmediately is false for a covered PR (the ladder returns close, not adopt), and adoptionBound is untouched, so the withheld-nudge behaviour is unchanged; a covered PR's one notification is the close note.
  • Ledger hive-agent claims are also read by IssueHumanClaimReason (as hive claim: <agent>, which never triggers the contributor yank), so adoption does not open a copy beside work the hive already holds.

Not done (called out)

The merge train's own winner rule (mergeTrainDuplicateBetter, green then earlier-opened) is unchanged; trust-ranking it would touch merge planning and I could not run its tests here.

Tests

engine (owner PR open -> closed as duplicate with note, not adopted, no repeat; contributor/maintainer-clanker/own-copy/unrelated/other-branch PRs do not block), ladder (owner, hive, conflicting head, paused, claim-only, ties, AdoptsImmediately false), github ledger claims. Adoption test harness serves an empty open-PR listing by default. No new unannotated write sites (writes use // writeback:gated behind writebackAllowed).

Docs: stage-labels, glossary table; changelog fragment added.

πŸ€– Generated with Claude Code

Fixes #18900

Signed-off-by: Andrew Anderson <andy@clubanderson.com>
@kubestellar-prow kubestellar-prow Bot added dco-signoff: yes Indicates the PR's author has signed the DCO. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Nov 18, 2026
@github-actions

github-actions Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

PR Title Relation Files
#18912 πŸ› Model/method switch for stopped or paused agents; keep page in place after a switch same files src/pkg/dashboard/static/index.html
#18908 πŸ› fix: preserve agent position when switching methods same files src/pkg/dashboard/static/index.html
#18873 πŸ› needs-sha: exempt owner/detailed issues, overrideable waiver, visible hold on the row same files src/docs/labels-and-control-signals/glossary-and-operations.md
src/pkg/dashboard/static/index.html

@github-actions

Copy link
Copy Markdown
Contributor

UI render evidence

Render evidence captured.

Built from c1d4fc02cda1.
Screenshots: download the artifact (sign-in to GitHub required).
Run: https://github.com/hivecommons/hive/actions/runs/44253751811

Page Section Viewport Theme File Size
hive overview desktop light hive-overview-desktop-light.png 326 KB
hive overview desktop dark hive-overview-desktop-dark.png 307 KB
hive overview phone light hive-overview-phone-light.png 467 KB
hive overview phone dark hive-overview-phone-dark.png 464 KB
hub-fleet overview desktop light hub-fleet-overview-desktop-light.png 113 KB
hub-fleet overview desktop dark hub-fleet-overview-desktop-dark.png 115 KB
hub-fleet overview phone light hub-fleet-overview-phone-light.png 265 KB
hub-fleet overview phone dark hub-fleet-overview-phone-dark.png 270 KB
hub-dashboard overview desktop light hub-dashboard-overview-desktop-light.png 338 KB
hub-dashboard overview desktop dark hub-dashboard-overview-desktop-dark.png 344 KB
hub-dashboard overview phone light hub-dashboard-overview-phone-light.png 624 KB
hub-dashboard overview phone dark hub-dashboard-overview-phone-dark.png 656 KB

These are fixture renders, not live data: the page was built from the PR head and filled with synthetic data from src/scripts/fixtures/render-evidence/. They show layout and theming, not how real hives behave. How to read them: src/docs/ui-render-evidence.md.

@github-actions

Copy link
Copy Markdown
Contributor

Mutation testing

gremlins found 7 surviving mutant(s) in changed files: the code ran under tests, but changing it did not fail any test.

File Line Mutation
src/pkg/github/automerge/automerge_adoption_covered.go 79 CONDITIONALS_BOUNDARY
src/pkg/github/automerge/automerge_adoption_covered.go 79 CONDITIONALS_NEGATION
src/pkg/github/automerge/automerge_adoption_covered.go 93 CONDITIONALS_BOUNDARY
src/pkg/github/automerge/automerge_adoption_covered.go 93 CONDITIONALS_NEGATION
src/pkg/github/automerge/automerge_adoption_covered.go 118 CONDITIONALS_BOUNDARY
src/pkg/github/automerge/automerge_adoption_covered.go 118 CONDITIONALS_NEGATION
src/pkg/github/automerge/automerge_adoption_covered.go 157 CONDITIONALS_NEGATION

12 mutant(s) in changed files are not reached by any test (NOT COVERED). A maintainer may apply the mutation/acknowledged label to accept this.

File Line Mutation
src/pkg/dashboard/delegated_pr_context.go 173 ARITHMETIC_BASE
src/pkg/dashboard/delegated_pr_context.go 173 ARITHMETIC_BASE
src/pkg/dashboard/delegated_pr_context.go 174 CONDITIONALS_BOUNDARY
src/pkg/dashboard/delegated_pr_context.go 174 CONDITIONALS_NEGATION
src/pkg/dashboard/delegated_pr_context.go 174 CONDITIONALS_NEGATION
src/pkg/dashboard/stage_tracker_adoption.go 216 CONDITIONALS_NEGATION
src/pkg/github/automerge/automerge_adoption_covered.go 54 CONDITIONALS_NEGATION
src/pkg/github/automerge/automerge_adoption_covered.go 54 CONDITIONALS_NEGATION
src/pkg/github/automerge/automerge_adoption_covered.go 55 CONDITIONALS_NEGATION
src/pkg/github/automerge/automerge_adoption_covered.go 55 CONDITIONALS_NEGATION
src/pkg/github/automerge/automerge_adoption_covered.go 58 CONDITIONALS_NEGATION
src/pkg/github/automerge/automerge_adoption_covered.go 58 CONDITIONALS_NEGATION

ℹ️ 2 mutant(s) on added lines were SKIPPED because gremlins v0.6.0 only honours the first lines added lines of each default-context hunk, so non-contiguous edits in one hunk are partly missed. This does not affect the verdict.

File Line Mutation
src/pkg/dashboard/delegated_pr_context.go 177 CONDITIONALS_NEGATION
src/pkg/dashboard/delegated_pr_context.go 177 CONDITIONALS_NEGATION

Verdict: lived (#17349).

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the engine half of this PR (automerge_adoption_covered.go and its call site in adoptContributorPR). I did not read the ladder, dashboard or test files in depth, so this comment covers the engine path only.

The covering-PR selection looks sound. It skips self, other base lines, closed PRs and Supersedes copies, and it requires a shared closed issue and a person's or the hive's trust before picking the lowest PR number. The fail-open path on an unreadable PR list is consistent with the description.

One low-severity point is inline on closeCoveredContributorPR: the block is recorded before the write, so a transient failure is never retried on that head.

β€” hive: agent=reviewer backend=claude model=claude-sonnet-5-5 claude=2.1.326

return 0, nil
}
logArgs := []any{"repo", obs.Display, "pr", obs.Number, "author", obs.Author, "head", obs.HeadSHA, "covered_by", cover.Number, "issue", cover.Issue}
store.NoteAdoptionBlocked(key, obs.HeadSHA, stagelabels.AdoptBlockedCoveredByOpenPR, now)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Low: NoteAdoptionBlocked runs before the write-back gate, CreateComment and the close, and the early return at the top (AdoptionBlocked(head) == covered-by-open-pr β†’ return 0, nil) then skips every later pass on this head. A transient CreateComment or Edit error, or a gate refusal that later lifts (for example a paused repo being resumed), leaves the contributor PR open with adoption off and nothing retrying the close until the head changes. The PR body describes this as intended, so this is a note rather than a defect. If you want a retry, record the block only after a successful close, or keep a separate 'close attempted' marker.

@hivecommons-hive

Copy link
Copy Markdown
Contributor

Hive status β€” updated in place; edits do not notify. Full history is in the Activity Monitor.

Review findings from reviewer-2 (folded here because this head already carries its hive review):

Read automerge_adoption_covered.go and the adopt hook in automerge_contributor_adopt.go. One verified gap; the rest of the engine path (same-base filter, Supersedes exclusion, lowest-number tie-break, fail-open on an unreadable list, gate-refusal leaves the PR open) reads correctly to me.

Medium β€” a draft covering PR can close a contributor's PR. adoptionCoveringPR skips only nil, self, non-open and other-base PRs before trusting other. It never checks other.GetDraft(). The diff already treats drafts as not current elsewhere (!other.GetDraft() in delegated_pr_context.go), so a person's WIP draft that mentions Closes #N is enough for closeCoveredContributorPR to comment and close the contributor's ready PR. The closing note says the covering PR "already covers" the issue, which a draft does not. Suggest skipping drafts when picking a cover (and a test beside automerge_adoption_covered_test.go).

Open question (not a defect): the single recorded block means a failed PullRequests.Edit after the note posts is never retried on that head. That matches the stated "adoption stays off" design, so I'm only flagging it.

Findings not on a changed line

  • src/pkg/github/automerge/automerge_adoption_covered.go:94: No draft check here: a person's draft PR that closes the same issue counts as a cover and gets the contributor's ready PR closed as a duplicate. Skip other.GetDraft() (the dashboard side already treats drafts as not current) and add a test.

@clubanderson clubanderson added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 18, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow
kubestellar-prow Bot merged commit a23dcca into v5 Nov 18, 2026
111 checks passed
@kubestellar-prow
kubestellar-prow Bot deleted the fix/no-adopt-covered-pr-18900 branch November 18, 2026 07:05
kubestellar-prow Bot pushed a commit that referenced this pull request Nov 18, 2026
* πŸ› Contributor lane: grace window before claiming owner/hive-filed issues (#18913)

* πŸ› Contributor lane: grace window before claiming owner/hive-filed issues

Fixes #18898

Signed-off-by: Andrew Anderson <andy@clubanderson.com>

* πŸ› Fix CI: register SetContributorGrace as a resync setter, drop the settings allowlist entry the UI already covers

Refs #18898

Signed-off-by: Andrew Anderson <andy@clubanderson.com>

---------

Signed-off-by: Andrew Anderson <andy@clubanderson.com>

* πŸ› Label the age, session and staleness of a replayed hand-off decline (#18917)

* πŸ› Label the age, session and staleness of a replayed hand-off decline (#18916)

Signed-off-by: Andy Anderson <andy@clubanderson.com>

* πŸ› Fix the hand-off UI harness for the stale-reason label (#18916)

Signed-off-by: Andy Anderson <andy@clubanderson.com>

---------

Signed-off-by: Andy Anderson <andy@clubanderson.com>

* ✨ Betty: meeting-budget meter, 80/90 percent steps, and no silently dropped questions (#18920)

* ✨ Betty: meeting-budget meter, 80/90 percent steps, and no silently dropped questions (#18914)

Meter per meeting and per hive on the meetings read API and in the
dashboard; one 80 percent warn line per meeting; shorter answers and no
new research at 90 percent; an exhaustion notice that says what to do;
questions dropped for budget are counted, shown and listed in the inbox
record.

Signed-off-by: Andrew Anderson <andy@clubanderson.com>

* πŸ› Meetings dashboard test: stub the budget meter helpers the role-race slice now needs (#18914)

Signed-off-by: Andrew Anderson <andy@clubanderson.com>

---------

Signed-off-by: Andrew Anderson <andy@clubanderson.com>

* ✨ Does this build contain PR #N: ancestry lookup API on the hub and each hive (#18918)

* ✨ Does this build contain PR #N: ancestry lookup API on the hub and each hive

Adds pkg/buildcontains (yes/no/unknown from git ancestry; an unresolvable
commit is unknown, a PR outside the build's history is no), the hub read
route GET /api/saas/build-contains and the hive route GET
/api/version/contains, with openapi, API-reference and telemetry docs.

Part of #18915.

Signed-off-by: Andy Anderson <andy@clubanderson.com>

* βœ… Allow pkg/dashboard to import the leaf pkg/buildcontains resolver

Part of #18915.

Signed-off-by: Andy Anderson <andy@clubanderson.com>

---------

Signed-off-by: Andy Anderson <andy@clubanderson.com>

* 🌱 images: bump goose 1.59.0 -> 1.60.1 (#18924)

Automated pin bump (#8419). Digests recomputed from the downloaded
release artifacts by src/scripts/cli-pin-bump.sh:

  VERSION=1.60.1
  SHA256_AMD64=0327b1857f8030343f59b77503e0455629bbf472c2901cb94b88389d6278635a
  SHA256_ARM64=6a962a0ba55829e00f6f297dff736d53b9bdc8da84f0f49c4768e2557ac39cbe

Signed-off-by: hive-release[bot] <hive-release@hive.kubestellar.io>
Signed-off-by: clubanderson <407614+clubanderson@users.noreply.github.com>
Signed-off-by: clubanderson <andy@clubanderson.com>

* 🌱 images: bump gh 2.104.0 -> 2.105.0 (#18927)

Automated pin bump (#8419). Digests recomputed from the downloaded
release artifacts by src/scripts/cli-pin-bump.sh:

  VERSION=2.105.0
  SHA256_AMD64=79e7ab5db738c48777b696e374f8b428f0647debfb424f44d2f426370407fe2f
  SHA256_ARM64=b1278c75107423d818f1937fd92cafc9e5e9b606631568f68d7fb816f5885a02

Signed-off-by: hive-release[bot] <hive-release@hive.kubestellar.io>
Signed-off-by: clubanderson <407614+clubanderson@users.noreply.github.com>
Signed-off-by: clubanderson <andy@clubanderson.com>

* πŸ”– release: v5.319.0

Automated release commit. Compiles changelog.d/ fragments and moves
the CHANGELOG.md Unreleased section into a dated v5.319.0 entry.
See src/docs/releases.md.

Signed-off-by: hive-release-bot <actions@github.com>

* ✨ Build visibility UI: contains lookup on the hub hive list and the hive version menu (#18925)

* ✨ Build visibility UI: contains lookup on the hub hive list and the hive version menu

Adds a PR number or commit SHA lookup (yes, no or unknown, with the reason)
to the hub dashboard hive list and to the hive's own version menu, and shows
the newest image commit and the newest merged commit separately. Regenerates
static/index.html with make dashboard-gen.

Part of #18915.

Signed-off-by: Andy Anderson <andy@clubanderson.com>

* 🌱 Keep the hub styling ratchet green: tokens and hidden attribute for the contains lookup

Part of #18915.

Signed-off-by: Andy Anderson <andy@clubanderson.com>

---------

Signed-off-by: Andy Anderson <andy@clubanderson.com>

* 🌱 images: bump codex 0.169.0 -> 0.170.0 (#18926)

Automated pin bump (#8419). Digests recomputed from the downloaded
release artifacts by src/scripts/cli-pin-bump.sh:

  VERSION=0.170.0

Signed-off-by: hive-release[bot] <hive-release@hive.kubestellar.io>
Signed-off-by: clubanderson <407614+clubanderson@users.noreply.github.com>
Signed-off-by: clubanderson <andy@clubanderson.com>

* ✨ UI render evidence: fixture screenshots and one sticky PR comment for dashboard changes (#18921)

* ✨ UI render evidence: fixture screenshots and one sticky PR comment for dashboard changes

Adds a non-blocking pull_request job that renders the affected dashboard
pages with synthetic fixture data at desktop and phone width in light and
dark themes (no network, no credentials), a workflow_run sibling that posts
or updates one sticky comment and records a neutral-or-success check, a doc on
reading the evidence, and tests for the pure helpers.

Part of #18915.

Signed-off-by: Andy Anderson <andy@clubanderson.com>

* 🌱 Re-pin TRUSTED_SCRIPTS_TREE for the render-evidence scripts

Part of #18915.

Signed-off-by: Andy Anderson <andy@clubanderson.com>

---------

Signed-off-by: Andy Anderson <andy@clubanderson.com>

* 🌱 images: bump claude 2.1.326 -> 2.1.327 (#18922)

Automated pin bump (#8419). Digests recomputed from the downloaded
release artifacts by src/scripts/cli-pin-bump.sh:

  VERSION=2.1.327

Signed-off-by: hive-release[bot] <hive-release@hive.kubestellar.io>
Signed-off-by: clubanderson <407614+clubanderson@users.noreply.github.com>
Signed-off-by: clubanderson <andy@clubanderson.com>

* πŸ› A person's claim outside the ledger releases a contributor lease and blocks adoption (#18930)

* πŸ› Human claim or assignee releases a contributor lease and blocks contributor adoption

Fixes #18899

Signed-off-by: Andrew Anderson <andy@clubanderson.com>

* πŸ“ Re-anchor the scale-envelope citation after the client.go insertions

Refs #18899

Signed-off-by: Andrew Anderson <andy@clubanderson.com>

* πŸ› Fix test fixtures: no claim comment before the owner acts, no time.Sleep

Refs #18899

Signed-off-by: Andrew Anderson <andy@clubanderson.com>

* πŸ› Keep the engine's optional transport hooks in the human-claim adoption test

Refs #18899

Signed-off-by: Andrew Anderson <andy@clubanderson.com>

* πŸ› Serve an empty comment list in the verdict-cache test

Refs #18899

Signed-off-by: Andrew Anderson <andy@clubanderson.com>

---------

Signed-off-by: Andrew Anderson <andy@clubanderson.com>

* πŸ› Hold decisions on a PR whose CI or review is still running on its current head (#18893)

* πŸ› Hold decisions on a PR whose CI or review is still running on its current head

Fixes #18889

Signed-off-by: Andrew Anderson <andy@clubanderson.com>

* πŸ› mid-flight: read the nested PR's park reason from its listed row

Signed-off-by: Andrew Anderson <andy@clubanderson.com>

* πŸ› mid-flight: mirror new rules in the JS glossary, fix pending-CI test, document skips

Signed-off-by: Andrew Anderson <andy@clubanderson.com>

* πŸ› mid-flight: tidy the skipped-PR word, regenerate the bundle

Signed-off-by: Andrew Anderson <andy@clubanderson.com>

* πŸ› mid-flight: fail closed when the review state cannot be read

Signed-off-by: Andrew Anderson <andy@clubanderson.com>

* πŸ”– release: v5.320.0

Automated release commit. Compiles changelog.d/ fragments and moves
the CHANGELOG.md Unreleased section into a dated v5.320.0 entry.
See src/docs/releases.md.

Signed-off-by: hive-release-bot <actions@github.com>

* πŸ› Never adopt a contributor PR when another open PR covers the issue (#18933)

Fixes #18900

Signed-off-by: Andrew Anderson <andy@clubanderson.com>

* πŸ› fix: stop serving an established read-relay tunnel after its key is released (#18928)

* fix: refuse relay requests once the per-kick key is released

Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Co-authored-by: clubanderson <407614+clubanderson@users.noreply.github.com>

* πŸ› test: drain response body in relay test roundTrip

The released-key tunnel test reuses one TLS connection for two requests.
roundTrip built a fresh bufio.Reader and never read the body, so the
leftover 'ok' body was parsed as part of the next status line
(malformed HTTP version "okHTTP/1.1").

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>

* πŸ”– release: v5.320.1

Automated release commit. Compiles changelog.d/ fragments and moves
the CHANGELOG.md Unreleased section into a dated v5.320.1 entry.
See src/docs/releases.md.

Signed-off-by: hive-release-bot <actions@github.com>

* πŸ”– release: v5.320.2

Automated release commit. Compiles changelog.d/ fragments and moves
the CHANGELOG.md Unreleased section into a dated v5.320.2 entry.
See src/docs/releases.md.

Signed-off-by: hive-release-bot <actions@github.com>

* πŸ› Model/method switch for stopped or paused agents; keep page in place after a switch (#18912)

* πŸ› fix: model/method switch for a stopped or paused agent, and keep the page in place after a switch

Fixes the not-found failure for configured agents the runtime does not hold and holds scroll, focus and card order across the re-render.

Signed-off-by: Andrew Anderson <andy@clubanderson.com>

* πŸ› fix: import sort in the agent control handlers

Signed-off-by: Andrew Anderson <andy@clubanderson.com>

* πŸ› fix: keep a second body tag out of the generated dashboard document

Signed-off-by: Andrew Anderson <andy@clubanderson.com>

* πŸ› fix: test a registered agent's model switch without assuming it is launched

Signed-off-by: Andrew Anderson <andy@clubanderson.com>

* fix: treat already-running agent at startup launch as benign (#18938)

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>

* πŸ”– release: v5.320.3

Automated release commit. Compiles changelog.d/ fragments and moves
the CHANGELOG.md Unreleased section into a dated v5.320.3 entry.
See src/docs/releases.md.

Signed-off-by: hive-release-bot <actions@github.com>

* fix: de-flake TestMirrorHeartbeat_SendsReducedCopyWithMirrorKey (#18942)

Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>

* πŸ”– release: v5.320.4

Automated release commit. Compiles changelog.d/ fragments and moves
the CHANGELOG.md Unreleased section into a dated v5.320.4 entry.
See src/docs/releases.md.

Signed-off-by: hive-release-bot <actions@github.com>

* fix: de-flake TestSyncIssueStageLabels_ClosesParentWhenAllChildrenClosed (#18943)

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>

* πŸ”§ v6-topup: keep v5 ancestry on v6, heal it when a top-up was squashed (#18931) (#18954)

Record the v5 head each top-up PR carries in its body, check on every run
that it is still an ancestor of origin/v6, and when a squash or rebase lost
it start the branch with a signed-off ours-merge of that head before merging
origin/v5. Forward-merge PRs in a native-queue group that does not contain
their own head are refused by name as a merge-method violation. The failure
messages now point at the ancestry check first. The DCO gate is unchanged.

Signed-off-by: Andrew Anderson <andy@clubanderson.com>

* ✨ Record what each kick came to: per-kick outcome record and read API (#18923)

* ✨ Record what each kick came to: durable per-kick outcome and GET /api/kick-outcomes (#18916)

Signed-off-by: Andy Anderson <andy@clubanderson.com>

* πŸ› Reach the kick observer registry through a checked type assertion (#18916)

Signed-off-by: Andy Anderson <andy@clubanderson.com>

* πŸ› Keep pkg/dashboard free of a new package import; lower the comment-marker baseline (#18916)

Signed-off-by: Andy Anderson <andy@clubanderson.com>

* βœ… Cover the kick outcome store; fix the API-reference citation (#18916)

Signed-off-by: Andy Anderson <andy@clubanderson.com>

* πŸ› Restore the comment-marker baseline to the v5 value (#18916)

The kick outcome record adds no comment emitter, so the baseline stays at 45;
the earlier lowering to 44 made TestCommentMarkerRatchet fail.

Signed-off-by: Andrew Anderson <andy@clubanderson.com>

* ✨ Hub: confirmation reply decision, ledger and templates for mail sent to a hive (off by default) (#18955)

* ✨ Hub: confirmation reply decision, ledger and templates for mail sent to a hive (off by default)

Adds wire.Delivery.Facts (header facts from hive-mx), the hub's reply decision
(authenticated senders only, never automatic/bulk/list/bounce mail, one reply
per Message-ID, per-sender/domain/hive limits), a content-free durable ledger,
the received/held plain-text templates, and a sender interface with no real
sender. Off unless the DKIM key file is present.

Refs #18746

Signed-off-by: Andrew Anderson <andy@clubanderson.com>

* πŸ“– Resync api-reference citations after the HubServer field

Refs #18746

Signed-off-by: Andrew Anderson <andy@clubanderson.com>

---------

Signed-off-by: Andrew Anderson <andy@clubanderson.com>

* πŸ› worksource/jira: surface rejected Jira Cloud credentials instead of an empty backlog (#18951)

Signed-off-by: Ondra Pelech <ondra@chilipiper.com>

* ✨ config: accept PROJECT_NAME in config.env (#18952)

Signed-off-by: Ondra Pelech <ondra@chilipiper.com>

* πŸ› fix(betty): live weather by city+state, sourced figures, attention questions, links in chat (#18960)

* 🐝 fix(betty): live weather by city+state with NWS readings, no unsourced figures, attention questions from hive state, links in chat

Weather: split a trailing US state from the place and pick the geocoder match in that state; read the nearest NWS station for US places and label model values as estimates; never answer weather from cached search pages. Research follow-ups with an unsourced figure say she is not sure; failed deep dives are one short sentence. Attention questions route to hive-status. Spoken answers are followed by a chat line with the links of the sources used.
Signed-off-by: Andy Anderson <andy@clubanderson.com>

* test(betty): update weather text expectations for the labelled model value

Signed-off-by: Andy Anderson <andy@clubanderson.com>

* chore: re-trigger PR Type check

Signed-off-by: Andy Anderson <andy@clubanderson.com>

---------

Signed-off-by: Andy Anderson <andy@clubanderson.com>

* πŸ› fix(betty): say last known figures when no repo is confirmed (#18961)

* 🐝 fix(betty): say last known figures when no repo is confirmed, never 'counted in 0 of N'

After a restart every repo is flagged stale until re-read, so the brief reported 'counted in 0 of 14 repos so far' beside real restored figures. Word that as last known figures not yet confirmed in any repo; the K of N wording returns, filling in, as repos are re-read.

Signed-off-by: Andy Anderson <andy@clubanderson.com>

* chore: re-trigger PR Type check

Signed-off-by: Andy Anderson <andy@clubanderson.com>

* fix(betty): keep the guide line free of the retired 'counted in 0 of N' wording

Signed-off-by: Andy Anderson <andy@clubanderson.com>

---------

Signed-off-by: Andy Anderson <andy@clubanderson.com>

* ✨ Betty plays a soft listening chime when addressed and about to answer (#18964)

* ✨ Betty plays a soft listening chime when addressed and about to answer

When a spoken request addresses her and she will answer, the engine asks the session for a tone (TriggerTone, no text). The session plays it through Quorum say.tone in the background only when voice is on, nothing is queued or playing and nobody else is mid-sentence; failures are dropped silently. One setting, meetings.listening_tone (HIVE_MEETINGS_LISTENING_TONE), default on.

Signed-off-by: Andy Anderson <andy@clubanderson.com>

* βœ… Tone tests: no fixed sleeps (sleep ratchet)

Signed-off-by: Andy Anderson <andy@clubanderson.com>

---------

Signed-off-by: Andy Anderson <andy@clubanderson.com>

* ✨ Meetings: auto-approve a trusted Discord requester by user id (#18965)

* ✨ Meetings: always approve a trusted Discord requester by user id

Adds a one-click 'Always approve this person' on a pending Discord join request. The requester's Discord user id (from the interaction Discord verifies, never the display name) is stored as trusted; later requests from that id are approved automatically and audited. Owner-only add and remove, listed in the Meetings panel.

Signed-off-by: Andy Anderson <andy@clubanderson.com>

* πŸ› Meetings trust: fix audit assertion and dashboard JS test harness

Signed-off-by: Andy Anderson <andy@clubanderson.com>

---------

Signed-off-by: Andy Anderson <andy@clubanderson.com>

* πŸ”– release: v5.321.0

Automated release commit. Compiles changelog.d/ fragments and moves
the CHANGELOG.md Unreleased section into a dated v5.321.0 entry.
See src/docs/releases.md.

Signed-off-by: hive-release-bot <actions@github.com>

* ✨ Stop hive from writing em-dashes: shared outbound filter, ASCII trailer, base-prompt rule, ratchet test (#18970)

* 🧹 Stop hive from writing em-dashes: shared outbound filter, ASCII trailer, base-prompt rule, ratchet test

Signed-off-by: Andy Anderson <andy@clubanderson.com>

* πŸ› Keep em-dash filter off hive-rendered comments and issue dedupe keys

Signed-off-by: Andy Anderson <andy@clubanderson.com>

---------

Signed-off-by: Andy Anderson <andy@clubanderson.com>

* ✨ Meetings: details open in place under the row, shared row chevron, calmer layout (#18969)

* Customers: inline profile under the row, shared tag pill, base type size so content is not larger than headings

Signed-off-by: Andy Anderson <andy@clubanderson.com>

* ✨ Meetings: details open in place under the row, shared row chevron, calmer layout

Signed-off-by: Andy Anderson <andy@clubanderson.com>

* βœ… Meetings node test: stub the shared row chevron and focus state

Signed-off-by: Andy Anderson <andy@clubanderson.com>

---------

Signed-off-by: Andy Anderson <andy@clubanderson.com>
Co-authored-by: hivecommons-hive[bot] <280983584+hivecommons-hive[bot]@users.noreply.github.com>

* πŸ› Inbox: no player or error toasts for live meetings (audio is never kept) (#18966)

* πŸ› Inbox: no player or error toasts for live meetings, which keep no audio

Meetings hive attends (source meeting) store only the transcript and notes (docs/meetings.md: No audio is stored). The Inbox offered a play button anyway, which ended in an Error player and an 'Audio unavailable' toast. Hide the player and show a quiet note instead.

Signed-off-by: Andy Anderson <andy@clubanderson.com>

* changelog: fragment for #18966

Generated by changelog-fragment-guard from the PR title (#5675).
Edit the wording freely, or replace this file with the no-changelog
label if the change is not user-visible.

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Signed-off-by: clubanderson <407614+clubanderson@users.noreply.github.com>

* πŸ› sentinel: stop flagging local bash -c runners, sha256sum -c and plain chmod (#18959)

* fix: narrow sentinel remote_code_execution subprocess and chmod patterns

Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Co-authored-by: Danathar <6772335+Danathar@users.noreply.github.com>

* fix: keep narrowed subprocess shell -c fetch/decode pattern in sentinel RCE rule

Restore a narrowed subprocess alternative (literal shell, then -c, then a
curl/wget/base64/b64decode marker on the same line) and add trip tests.

Hive-Fix-Attempt: 1/6

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>

* πŸ”– release: v5.322.0

Automated release commit. Compiles changelog.d/ fragments and moves
the CHANGELOG.md Unreleased section into a dated v5.322.0 entry.
See src/docs/releases.md.

Signed-off-by: hive-release-bot <actions@github.com>

* πŸ“– docs: state plainly what Hive is and is not (#18981)

Fixes #18978

Signed-off-by: Andrew Anderson <andy@clubanderson.com>

* πŸ“– docs: explain the RFC and proposal process to outsiders (#18982)

Fixes #18980

Signed-off-by: Andrew Anderson <andy@clubanderson.com>

* 🌱 Publish a generated quality report that feeds dynamic README badges (#18984)

Adds a Quality report workflow and generator that write a shields.io endpoint file per badge, plus report.json, to the quality-badges branch. Sources: v2-tests and go-security-analysis run conclusions, the coverage-hourly profile artifact, the published scorecard, the newest outcomes JSON and an optional ACMM evaluation URL. Unknown or stale sources render as such. Adds the doc, README badges and a changelog fragment.

Signed-off-by: Andrew Anderson <andy@clubanderson.com>

* πŸ› fix: claim ledger persist races on a shared temp file (#18977)

* fix: serialize claim ledger persist so concurrent saves cannot lose the temp file

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>

* fix: take claim ledger snapshot under saveMu so stale saves cannot overwrite newer ones

Hive-Fix-Attempt: 1/6

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>

* ✨ feat(dashboard): one Needs human state for rows blocked on a person (#18972)

* ✨ feat(dashboard): one Needs human state for rows blocked on a person

An issue an agent filed for outside help read as a stalled Open row.
The tracker now derives needs_human_why server side (filed-for-help,
pending decision, level-gate hold, hive hold, approval waits), shows
Needs human in the Open column with the later stages not applicable,
and feeds the existing filter, count and waiting-on-you list.

Signed-off-by: Andy Anderson <andy@clubanderson.com>

* 🧹 chore(dashboard): drop em-dashes from Needs human tooltip

Signed-off-by: Andy Anderson <andy@clubanderson.com>

* πŸ› fix(dashboard): drop duplicate STAGE_TRACKER_NEEDS_HUMAN_WORD const

Signed-off-by: Andy Anderson <andy@clubanderson.com>

* 🧹 chore(dashboard): regenerate index.html after merging v5

Signed-off-by: Andy Anderson <andy@clubanderson.com>

* ✨ hivectl benchmarks export: offline schema records from local evidence (#18990) (#18995)

Adds the offline variant of GET /api/benchmarks/export: reads the local
evidence tree, converts with the shared pkg/evidence/benchmarks converter,
and writes the same anonymized records as a JSON array or as
data/fleet/<hash>/<YYYY-MM>.json month files. The hive is named by hash
only; repositories are named only when passed with --public-repo.

Tracks hivecommons/benchmarks#1.

Signed-off-by: Andy Anderson <andy@clubanderson.com>

* πŸ“– docs(design): session taint design for RFC #18987 (#18999)

Refs #18987

Signed-off-by: Andrew Anderson <andy@clubanderson.com>

* ✨ Customers: inline profile under the row, shared tag pill, base type size (#18958)

* Customers: inline profile under the row, shared tag pill, base type size so content is not larger than headings

Signed-off-by: Andy Anderson <andy@clubanderson.com>

* ✨ Customers: real name, organization and location on a profile, filled from the public GitHub profile or set by hand (#18973)

Signed-off-by: Andy Anderson <andy@clubanderson.com>

* Customers: resync api-reference citations and give the view-gate harness the profile-field helpers

Signed-off-by: Andy Anderson <andy@clubanderson.com>

---------

Signed-off-by: Andy Anderson <andy@clubanderson.com>
Co-authored-by: hivecommons-hive[bot] <280983584+hivecommons-hive[bot]@users.noreply.github.com>

* πŸ“– docs: evaluate a generic AI gateway in front of the model backend (recipe and spike plan) (#19002)

Refs #18989

Signed-off-by: Andrew Anderson <andy@clubanderson.com>

* πŸ”– release: v5.322.1

Automated release commit. Compiles changelog.d/ fragments and moves
the CHANGELOG.md Unreleased section into a dated v5.322.1 entry.
See src/docs/releases.md.

Signed-off-by: hive-release-bot <actions@github.com>

* πŸ› fix(meetings): say a long answer in brief, full text in chat (#18962)

* fix(meetings): say a long answer in brief, full text in chat

Live Meet test: a 200 character spoken answer took 14 s to first audio and
25 s to say, and a longer one outran the 30 s say deadline and fell back to
chat. The CPU voice runs at about real time, so a spoken answer over 120
characters is now its first sentence plus 'The details are in chat.', and
the whole answer is posted once in chat.

Signed-off-by: Andy Anderson <andy@clubanderson.com>

* docs(meetings): spoken answers over 120 characters are said in brief

Signed-off-by: Andy Anderson <andy@clubanderson.com>

* changelog: fragment for #18962

Generated by changelog-fragment-guard from the PR title (#5675).
Edit the wording freely, or replace this file with the no-changelog
label if the change is not user-visible.

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Signed-off-by: clubanderson <407614+clubanderson@users.noreply.github.com>

* fix(meetings): pre-render the consent notice with the fixed spoken lines

Live Teams test: chat had no composer, the spoken consent notice was
synthesized cold (0 cached, 10.7 s to first audio, 21 s in all) and came
32 s after the session started. It is now first in the say.prewarm list.

Signed-off-by: Andy Anderson <andy@clubanderson.com>

* chore: re-run PR Type check

Signed-off-by: Andy Anderson <andy@clubanderson.com>

* fix(meetings): speak the consent notice at once and keep retrying chat on no_composer

A Teams chat with no composer (reported as platform_unavailable) was not
transient, so the chat copy was never retried, and the spoken notice waited
for the 10 s composer wait. A bot that can speak now says the notice when
chat fails with no_composer or has not answered in 2 s, and the chat post
is retried afterwards.

Signed-off-by: Andy Anderson <andy@clubanderson.com>

* πŸ› fix: one address classifier for isPrivateURL sites (#19001)

* fix: one address classifier for isPrivateURL sites

Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>

* fix: refresh api-reference citations after base merge

Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>

* fix: raise dashboard import ratchet for pkg/netguard

isPrivateURL now delegates to pkg/netguard, which is the 67th internal
package pkg/dashboard imports; the allowlist already lists it.

Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>

* πŸ“– Design record: one authorization point for push broker, proxy writes and tool grants (#18997)

* πŸ“– docs: design record for one authorization point (decision seam, events, scoped credentials)

Refs #18988

Signed-off-by: Andrew Anderson <andy@clubanderson.com>

* πŸ“– docs: neutralize two proxy and credential notes in the authorization design record

Refs #18988

Signed-off-by: Andrew Anderson <andy@clubanderson.com>

* πŸ“– docs: generalize credential open question

Refs #18988

Signed-off-by: Andrew Anderson <andy@clubanderson.com>

* πŸ”– release: v5.323.0

Automated release commit. Compiles changelog.d/ fragments and moves
the CHANGELOG.md Unreleased section into a dated v5.323.0 entry.
See src/docs/releases.md.

Signed-off-by: hive-release-bot <actions@github.com>

* πŸ› fix: keep a relay's owner-action blocked label and show it as Needs human (#18998)

* πŸ› fix: keep a relay's owner-action blocked label and show it as Needs human

Fixes #18996

The relay applies blocked through the hive bot, so the sweep's actor check could not tell its deliberate marker-less block from a defect. The relay now posts a hive:blocked-on kind=owner-action marker with a reason before labelling; the sweep keeps such a block; the row reads Needs human with the reason. A hive-applied marker-less block is still lifted.

Signed-off-by: Andy Anderson <andy@clubanderson.com>

* πŸ“ docs: re-point scale-envelope citation after client.go shift

Signed-off-by: Andy Anderson <andy@clubanderson.com>

* πŸ› fix: JSON-escape the owner-action marker in the sweep test fixture

Signed-off-by: Andy Anderson <andy@clubanderson.com>

* πŸ”– release: v5.323.1

Automated release commit. Compiles changelog.d/ fragments and moves
the CHANGELOG.md Unreleased section into a dated v5.323.1 entry.
See src/docs/releases.md.

Signed-off-by: hive-release-bot <actions@github.com>

* πŸ› fix(dashboard): a hub restart is not a feedback refresh failure (#19019)

The feedback issue refresh hit the hub while it restarted and got
503 "hive unavailable". The existing backoff already retries, but the
failure was logged at WARN, which feeds the slog fleet self-report and
filed #19008. Mark 502/503/504 answers as errFeedbackUpstreamUnavailable
and log those at INFO; every other refresh failure stays a WARN.

Hive-Run: #19008
Hive-Plan: selfreport triage
Hive-Spec: feedback_issue_refresh_failed#transient-upstream

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Danathar <Danathar@users.noreply.github.com>

* ✨ feat(dashboard): owner-action blocked rows carry needs_human_why (#19026)

Fixes #19025

Signed-off-by: Andy Anderson <andy@clubanderson.com>

* πŸ”’ security(netguard): refuse every special-purpose address range (#19022)

Add the documentation, benchmarking, protocol-assignment, 6to4 relay, Teredo, discard-only and site-local ranges to the shared classifier, refuse malformed all-numeric dotted hosts before DNS, and point the Inbox link fetcher at the shared classifier. Test stand-ins that used documentation addresses as public hosts now use a real public address.

Signed-off-by: Andrew Anderson <andy@clubanderson.com>

* πŸ”– release: v5.323.2

Automated release commit. Compiles changelog.d/ fragments and moves
the CHANGELOG.md Unreleased section into a dated v5.323.2 entry.
See src/docs/releases.md.

Signed-off-by: hive-release-bot <actions@github.com>

* πŸ› fix(ci): native-queue gate accepts a hive-posted PR-contents status and the plain pull_request event (#19045)

Refs #19039

Signed-off-by: Andrew Anderson <andy@clubanderson.com>

* πŸ› fix(inbox): validate link hosts with the shared netguard host check (#19041)

ValidateLinkURL only parsed strict IP literals, so a malformed all-numeric host reached DNS and loose IPv4 spellings were caught only after resolution. It now calls netguard.HostDenyReason, which the security docs already describe.

Signed-off-by: Andrew Anderson <andy@clubanderson.com>

* πŸ”– release: v5.323.3

Automated release commit. Compiles changelog.d/ fragments and moves
the CHANGELOG.md Unreleased section into a dated v5.323.3 entry.
See src/docs/releases.md.

Signed-off-by: hive-release-bot <actions@github.com>

* ✨ PR gate: post the PR-contents check from the hive in shadow mode (default off) (#19047)

* ✨ PR gate: post the PR-contents check from the hive in shadow mode

GitHub blocks pull_request_target workflows by default in public
repositories from 2026-12-02, and the required "verify PR contents" check
comes from one. This is the first slice of posting that gate from the hive
itself as a commit status, shipped default off and shadow-only.

- src/pkg/prgate: Go port of the PR Type / PR Issue verdicts, replayed
  against the same golden corpus as the JS verifier so they cannot drift;
  a closed four-context allowlist enforced before every write; a gate that
  pins the event head, re-reads the PR, skips drafts and closed PRs, is
  idempotent, and records a comparison with the workflow result.
- The status write now goes through one shared writer (also used by the
  prow/lgtm binding, behaviour unchanged).
- auto_merge.pr_gate.mode (off, shadow, enforce) with an explicit repos
  scope, yaml-only. enforce runs as shadow until the grant check lands.
- The authenticated pull_request and check_run webhook deliveries feed the
  gate; with the mode off nothing is read or posted.

Refs #19038

Signed-off-by: Andrew Anderson <andy@clubanderson.com>

* πŸ› PR gate: route the dashboard through the github package and update the config golden

pkg/dashboard keeps its internal import count by reaching the gate through a
facade in pkg/github, and the agent runtime config golden carries the new
empty auto_merge.pr_gate block.

Refs #19038

Signed-off-by: Andrew Anderson <andy@clubanderson.com>

* πŸ“– docs: refresh api-reference citations after the server.go change

Refs #19038

Signed-off-by: Andrew Anderson <andy@clubanderson.com>

* πŸ› PR gate: bound the memory of posted statuses

The posted-status memory was the one unbounded map in the gate; it now
restarts empty at a fixed size like the verdict memory does.

Refs #19038

Signed-off-by: Andrew Anderson <andy@clubanderson.com>

* docs: say how gemini and goose model lists are kept (part of #19028) (#19034)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Co-authored-by: Danathar <6772335+Danathar@users.noreply.github.com>

* πŸ› merge gate: a blocked pull_request_target startup failure does not turn a green head red (#19054)

* πŸ› merge gate: a blocked pull_request_target startup failure does not turn a green head red

When the required context set is known and every required context is green,
a zero-job startup_failure run of event pull_request_target is logged instead
of failing the merge-request CI verdict. Every other zero-job failure, and
any head whose required contexts are unknown, missing or red, stays red.

Refs #19038

Signed-off-by: Andrew Anderson <andy@clubanderson.com>

* πŸ› merge gate: fix the duplicated struct field in the target startup change

Refs #19038

Signed-off-by: Andrew Anderson <andy@clubanderson.com>

* πŸ› merge gate: make the missing-required-context test use branch protection

Refs #19038

Signed-off-by: Andrew Anderson <andy@clubanderson.com>

---------

Signed-off-by: Andrew Anderson <andy@clubanderson.com>

* fix: pin resolved address and enforce redirect policy for server-side fetchers (#19030)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>

* ✨ contribute: state the hive's display name on auth_ok so the relay stops parsing the hostname (#19062)

Fixes #19059

Signed-off-by: Andy Anderson <andy@clubanderson.com>

* πŸ› Answer human review feedback on the hive's own agent PRs (draft, held, remote) (#19029)

* πŸ› fix: answer human review feedback on the hive's own agent PRs (draft, held, remote)

Fixes #19027

Signed-off-by: Andy Anderson <andy@clubanderson.com>

* πŸ› fix: mark the needs-human note as solicited for the write-back ratchet

Fixes #19027

Signed-off-by: Andy Anderson <andy@clubanderson.com>

* πŸ› fix: tag the needs-human note as a notification site and fix the feedback test fixture

Fixes #19027

Signed-off-by: Andy Anderson <andy@clubanderson.com>

* πŸ› fix: coalesce review feedback bursts, queue mid-run comments, rolling cap, whole-thread briefs

Fixes #19027

Signed-off-by: Andy Anderson <andy@clubanderson.com>

* πŸ› test: raise reviewfeedback coverage over the package floor

Fixes #19027

Signed-off-by: Andy Anderson <andy@clubanderson.com>

---------

Signed-off-by: Andy Anderson <andy@clubanderson.com>

* πŸ”– release: v5.324.0

Automated release commit. Compiles changelog.d/ fragments and moves
the CHANGELOG.md Unreleased section into a dated v5.324.0 entry.
See src/docs/releases.md.

Signed-off-by: hive-release-bot <actions@github.com>

* πŸ› fix(contribute): skip opencode --auto when unsupported and show the failure reason (#19061)

* πŸ› fix(contribute): skip opencode --auto when unsupported and show the failure reason

Fixes #19060

Signed-off-by: Andy Anderson <andy@clubanderson.com>

* πŸ§ͺ test(contribute): run the failure-tail test on the interactive path

Signed-off-by: Andy Anderson <andy@clubanderson.com>

---------

Signed-off-by: Andy Anderson <andy@clubanderson.com>

* fix: record governor backoff-withheld kick as a refusal (#19067)

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>

* πŸ› contributor container: rootless Docker works, permission failure falls back to podman (#19077)

* πŸ› contributor container: support rootless Docker, fall back to podman on permission failure

Fixes #19076

Signed-off-by: Andrew Anderson <andy@clubanderson.com>

* ci: regenerate integration candidate workflows for runtime-selection test (#19076)

Signed-off-by: Andrew Anderson <andy@clubanderson.com>

* test: handle runtime-fallback interpolations in container-exit block harness (#19076)

Signed-off-by: Andrew Anderson <andy@clubanderson.com>

---------

Signed-off-by: Andrew Anderson <andy@clubanderson.com>

* πŸ› fix(contribute): pre-accept Claude's bypass consent and say plainly when the queue is empty (#19053)

* πŸ› fix(contribute): pre-accept Claude's bypass consent, never Enter on "No, exit", and say plainly when the queue is empty

Fixes #19049

Signed-off-by: Andy Anderson <andy@clubanderson.com>

* πŸ› fix(contribute): reset pane capture counter in consent test

Refs #19049

Signed-off-by: Andy Anderson <andy@clubanderson.com>

* πŸ› fix(contribute): multi-hive aware empty-queue messaging, retry bookkeeping behind HIVE_RELAY_DEBUG

Refs #19049

Signed-off-by: Andy Anderson <andy@clubanderson.com>

* πŸ› fix(contribute): no_matching_work never claims an empty queue; use the hive's actionable_items count

Refs #19049

Signed-off-by: Andy Anderson <andy@clubanderson.com>

* πŸ› fix(contribute): correct short-name test expectation

Refs #19049

Signed-off-by: Andy Anderson <andy@clubanderson.com>

* πŸ› fix(contribute): cover the hive-stated name in hiveShortName

Refs #19049

Signed-off-by: Andy Anderson <andy@clubanderson.com>

---------

Signed-off-by: Andy Anderson <andy@clubanderson.com>

* ✨ Independent fact-check review pass for analysis and report PRs (#19080)

* πŸ”Ž Add independent fact-check review pass for analysis and report PRs

Opt-in review.analysis_factcheck: a reviewer agent that is not the author
re-verifies claims, scores and attributions, checks skew both ways and
inspection coverage, checks people against maintainers files, and posts one
review with line-anchored Verify comments. The PR stays a draft; rounds are
bounded and findings reach the author through a marked path of their own.

Fixes #19074

Signed-off-by: Andy Anderson <andy@clubanderson.com>

* πŸ› Fix promoted-field literal in fact-check wire test

Signed-off-by: Andy Anderson <andy@clubanderson.com>

* πŸ› Add analysis_factcheck to the agent runtime config golden

Signed-off-by: Andy Anderson <andy@clubanderson.com>

---------

Signed-off-by: Andy Anderson <andy@clubanderson.com>

* 🌱 fix: v5 top-up follow-ups (duplicate backend read, model-rejected trigger on crux, marker baseline)

- api_agent_control.go: v5 resolves the agent's backend before the shape
  check; drop v6's second resolution of it, which redeclared backend from
  an out-of-scope proc.
- The model-rejected pause trigger moves to the crux package (crux/agent
  aliases it), so the dashboard reads it without a new crux/agent symbol
  (crux boundary ratchet).
- comment_marker_ratchet_test.go: v6's baseline grows by v5's
  closeCoveredContributorPR, a marker-carrying once-per-head note.

Signed-off-by: Andy Anderson <andy@clubanderson.com>

* 🌱 fix: carry v5's dash rule into the v6 resident kick goldens

v5's #18970 adds plainDashRule under every kick header; the v6-only
resident kick goldens (TestResidentKickGoldensUnchanged) now carry it at
the same spot, right after the governor work-source rule.

Signed-off-by: Andy Anderson <andy@clubanderson.com>

* 🌱 fix: v5 top-up test and waiting-on-you follow-ups

- stage_tracker_waiting.go: v5's needs-human fallback wait kind skips
  standing meta issues, keeping v6's rule that a bot Dependency Dashboard
  or the advisory report never waits on anyone (#17548).
- attribution_test.go: the standby trailer test expects v5's ASCII
  '-- hive:' prefix.
- contribute_opencode_auto_flag_test.go: v6 carries opencode's deny-list
  in opencode_local_perm_env_shell, so the v5 test checks the flag and
  env halves separately.

Signed-off-by: Andy Anderson <andy@clubanderson.com>

---------

Signed-off-by: Andrew Anderson <andy@clubanderson.com>
Signed-off-by: Andy Anderson <andy@clubanderson.com>
Signed-off-by: hive-release[bot] <hive-release@hive.kubestellar.io>
Signed-off-by: clubanderson <407614+clubanderson@users.noreply.github.com>
Signed-off-by: clubanderson <andy@clubanderson.com>
Signed-off-by: hive-release-bot <actions@github.com>
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Signed-off-by: Ondra Pelech <ondra@chilipiper.com>
Signed-off-by: Danathar <Danathar@users.noreply.github.com>
Co-authored-by: hive-release-bot <actions@github.com>
Co-authored-by: hivecommons-hive[bot] <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Co-authored-by: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-authored-by: Ondra Pelech <ondra@chilipiper.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Danathar <6772335+Danathar@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has signed the DCO. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[scanner] πŸ› Never adopt a contributor PR when another open PR covers the issue

1 participant