Skip to content

[scanner] 🐛 Never adopt a contributor PR when another open PR covers the issue #18900

Closed

Description

@hivecommons-hive

Child of #18890 (Wanted 3).

Problem

On #18866 the hive adopted contributor PR #18870 as #18879 (CI red, contributor unavailable) while owner PR #18873 for the same issue was already open. Rung 5 of the ladder (src/pkg/delegatedecision/ladder.go, adopt-supersede) does not look at other open PRs covering the issue, and decideTrainDuplicate only applies when the merge queue split the pair.

Wanted

  • Before adopt-supersede, if in.Competing has an open PR for the same issue that is person-authored, owner-authored or hive-authored (or the issue carries a human/hive claim), close the contributor PR as a duplicate of that PR (with credit) instead of adopting it.
  • "Green first, then earlier-opened" must not let a contributor copy win over a human- or hive-claimed PR.
  • The adoption engine (the executor that created 🐛 Fix SHA hold exemptions and dashboard controls #18879) re-checks for a covering open PR before opening the copy.

Acceptance

  • Test: with an owner PR open for the issue, a contributor PR that is the adoption candidate is closed as a duplicate, not adopted.
  • Changelog fragment.

— hive: agent=scanner backend=claude model=claude-sonnet-5-5 claude=2.1.326

Activity

  1. added
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    agent/scannerCreated or modified by the scanner agent
    on Nov 18, 2026
  2. hivecommons-hive commented on Nov 18, 2026

    @hivecommons-hive
    ContributorAuthor

    🔓 Claim by @Karibhou released (lease revoked).

    Claim history
    • 2026-11-18 04:53 UTC — claimed by Karibhou (contributor on hive hosted-available-oke-11-placeholder-r05x)
    • 2026-11-18 05:01 UTC — released by Karibhou (contributor; lease revoked)
  3. self-assigned this
    on Nov 18, 2026
  4. clubanderson commented on Nov 18, 2026

    @clubanderson
    Member

    Claimed by the operator's dispatcher; fix in progress.

  5. added
    stage/020-claimedClaimed by the scanner or a relay contributor
    and removed
    stage/010-actionableTriaged; eligible for the hive to pick up
    stage/020-claimedClaimed by the scanner or a relay contributor
    on Nov 18, 2026
  6. clubanderson commented on Nov 18, 2026

    @clubanderson
    Member

    Fixed by #18933 (merged to v5): the adoption executor and the "Let hive decide" ladder (rung 5a covered-by-other-pr) close a contributor PR as a duplicate of a person's or the hive's open PR for the same issue, with credit, instead of adopting it.

  7. added
    hive/likely-doneHive verified that a merged PR references or claims this issue; pending confirmation
    and removed on Nov 18, 2026
  8. added a commit that references this issue on Nov 18, 2026
    f4f3849
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

agent/scannerCreated or modified by the scanner agenthelp wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.hive/likely-doneHive verified that a merged PR references or claims this issue; pending confirmation

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions