Skip to content

πŸ› Dashboard asks for a decision (Decide, Approve as-is, Let hive decide) before CI and review finish on the current headΒ #18889

Closed

Description

@clubanderson

Problem

The dashboard asks the operator to decide ("Decide…", "Approve as-is", "Let hive decide", "Let hive decide β€” all N PRs") on PRs whose CI and review have not finished on the current head. Seen on:

Findings (read of v5; to be verified)

  • Single-PR button: stageTrackerDecideOptions (static-src/js/tracker-actions.js ~L281-286) via stageTrackerDecisionTarget (L245-259) and stageTrackerPRParked (L227). Server mirror: stageTrackerHumanGatePRParked / stageTrackerHumanGateAccepts (stage_tracker_gate.go ~L127, L165). None checks review quorum, CI state, or whether the park belongs to the current head (stageTrackerHumanGateOnHead is used for the gate reasons, not the delegate precondition). A park recorded on an earlier head survives a new push.
  • "all N PRs": tracker-actions.js ~L453-457, offered for any row with 2+ open nested PRs; only gate is write permission; server DelegateAllMin = 2.
  • The action POSTs /api/repos/{repo}/items/{n}/decide-delegated; runDelegatedDecisionPerPR -> decideDelegatedOne -> delegatedecision.Run; it can record /lgtm and /approve on an unreviewed head, close a PR as superseded while CI runs (decideTrainDuplicate), and default-release (policy.go ~L758) has no CI guard because CIRed() is false while CI is merely pending.

Wanted

  1. While review is incomplete or CI is pending on the CURRENT head, do not offer Decide / Approve as-is / Let hive decide. Show disabled with the reason ("review in progress on ", "CI running 2/5"). A park from an earlier head must not count.
  2. "Let hive decide β€” all N PRs" skips or disables for any PR that is mid-review or mid-CI.
  3. Server side: decideDelegatedOne returns a no-effect result when CI is pending or review is incomplete; default-release requires CI green on the current head.
  4. Explain why quorum-companion#7 is "Needs human Β· decision" at all (no linked issue? repo not on the Prow label path? mode?) and show that reason on the row rather than a bare decision prompt.

Acceptance

Tests for each guard (pending CI, queued review, stale park after a push, delegate-all with mid-flight PRs, pending-CI fall-through) in stage_tracker_row_actions_test.go, stage_tracker_gate_truth.test.js, api_repo_item_decide_delegated_test.go; docs; changelog fragment.

Activity

  1. self-assigned this
    on Nov 18, 2026
  2. clubanderson commented on Nov 18, 2026

    @clubanderson
    MemberAuthor

    Claimed; fix in progress.

  3. hivecommons-hive commented on Nov 18, 2026

    @hivecommons-hive
    Contributor

    πŸ”“ Claim by @Karibhou released (lease revoked).

    Claim history
    • 2026-11-18 04:19 UTC β€” claimed by Karibhou (contributor on hive hosted-available-oke-11-placeholder-r05x)
    • 2026-11-18 04:28 UTC β€” released by Karibhou (contributor; lease revoked)
  4. clubanderson commented on Nov 18, 2026

    @clubanderson
    MemberAuthor

    /claim

  5. added
    stage/020-claimedClaimed by the scanner or a relay contributor
    and removed
    stage/010-actionableTriaged; eligible for the hive to pick up
    stage/020-claimedClaimed by the scanner or a relay contributor
    on Nov 18, 2026
  6. added 2 commits that reference this issue on Nov 18, 2026
    bb04979
    ef47e0e
  7. clubanderson commented on Nov 18, 2026

    @clubanderson
    MemberAuthor

    Delivered by #18893 (merged to v5, 1606ec7): decision buttons (Decide, Approve as-is, Let hive decide, Give direction) are disabled with a reason while CI or review is still running on the current head, delegate-all skips mid-flight PRs, the server returns a no-effect result for a mid-flight PR and fails closed when the review state cannot be read, default-release and small-low-risk no longer fire while CI is pending, and the row now says why a PR with no linked issue is parked.

  8. added a commit that references this issue on Nov 18, 2026
    f4f3849
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions