You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
π Dashboard asks for a decision (Decide, Approve as-is, Let hive decide) before CI and review finish on the current headΒ #18889
The dashboard asks the operator to decide ("Decideβ¦", "Approve as-is", "Let hive decide", "Let hive decide β all N PRs") on PRs whose CI and review have not finished on the current head. Seen on:
Single-PR button: stageTrackerDecideOptions (static-src/js/tracker-actions.js ~L281-286) via stageTrackerDecisionTarget (L245-259) and stageTrackerPRParked (L227). Server mirror: stageTrackerHumanGatePRParked / stageTrackerHumanGateAccepts (stage_tracker_gate.go ~L127, L165). None checks review quorum, CI state, or whether the park belongs to the current head (stageTrackerHumanGateOnHead is used for the gate reasons, not the delegate precondition). A park recorded on an earlier head survives a new push.
"all N PRs": tracker-actions.js ~L453-457, offered for any row with 2+ open nested PRs; only gate is write permission; server DelegateAllMin = 2.
The action POSTs /api/repos/{repo}/items/{n}/decide-delegated; runDelegatedDecisionPerPR -> decideDelegatedOne -> delegatedecision.Run; it can record /lgtm and /approve on an unreviewed head, close a PR as superseded while CI runs (decideTrainDuplicate), and default-release (policy.go ~L758) has no CI guard because CIRed() is false while CI is merely pending.
Wanted
While review is incomplete or CI is pending on the CURRENT head, do not offer Decide / Approve as-is / Let hive decide. Show disabled with the reason ("review in progress on ", "CI running 2/5"). A park from an earlier head must not count.
"Let hive decide β all N PRs" skips or disables for any PR that is mid-review or mid-CI.
Server side: decideDelegatedOne returns a no-effect result when CI is pending or review is incomplete; default-release requires CI green on the current head.
Explain why quorum-companion#7 is "Needs human Β· decision" at all (no linked issue? repo not on the Prow label path? mode?) and show that reason on the row rather than a bare decision prompt.
Acceptance
Tests for each guard (pending CI, queued review, stale park after a push, delegate-all with mid-flight PRs, pending-CI fall-through) in stage_tracker_row_actions_test.go, stage_tracker_gate_truth.test.js, api_repo_item_decide_delegated_test.go; docs; changelog fragment.
Delivered by #18893 (merged to v5, 1606ec7): decision buttons (Decide, Approve as-is, Let hive decide, Give direction) are disabled with a reason while CI or review is still running on the current head, delegate-all skips mid-flight PRs, the server returns a no-effect result for a mid-flight PR and fails closed when the review state cannot be read, default-release and small-low-risk no longer fire while CI is pending, and the row now says why a PR with no linked issue is parked.
Activity
clubanderson commentedon Nov 18, 2026
Claimed; fix in progress.
hivecommons-hive commentedon Nov 18, 2026
π Claim by @Karibhou released (lease revoked).
Claim history
Karibhou(contributor on hive hosted-available-oke-11-placeholder-r05x)Karibhou(contributor; lease revoked)clubanderson commentedon Nov 18, 2026
/claim
π Hold decisions on a PR whose CI or review is still running on its cβ¦
π Hold decisions on a PR whose CI or review is still running on its cβ¦
clubanderson commentedon Nov 18, 2026
Delivered by #18893 (merged to v5, 1606ec7): decision buttons (Decide, Approve as-is, Let hive decide, Give direction) are disabled with a reason while CI or review is still running on the current head, delegate-all skips mid-flight PRs, the server returns a no-effect result for a mid-flight PR and fails closed when the review state cannot be read, default-release and small-low-risk no longer fire while CI is pending, and the row now says why a PR with no linked issue is parked.
π± chore: top up v6 from v5 (2026-11-18) (#19100)