Skip to content

✨ Dashboard/API: set review.perspectives_source and agent sandbox image/block without editing config files - #18800

Merged
kubestellar-prow[bot] merged 3 commits into
v5from
feat/18797-perspectives-source-sandbox-ui
Nov 17, 2026
Merged

kubestellar-prow[bot] merged 3 commits into
v5from
feat/18797-perspectives-source-sandbox-ui

Conversation

@clubanderson

Copy link
Copy Markdown
Member

Fixes #18797

What

  • Review Gate: owner/repo/path/ref fields, resolver status, Unlink button. PUT /api/config/review accepts perspectives_source (set; null or an incomplete object clears), validated like definition_source and gated by GitHubPromptAllowed. An unapproved repo gets a 400 pointing to Settings, Security, Prompt sources. A save re-resolves through the existing ReviewConfigApplied hook, so no restart. The 409 now names Unlink; sending null with the inline edit unlinks and edits in one request.
  • Agent sandbox: editable image, runtime and Job fields on the General tab (sandboxImage, sandboxRuntime, sandboxJob), a standalone "Copy sandbox settings from..." (sandboxCopyFrom, Secret names only, deep copy), saving an enabled sandbox with no image is refused naming sandbox.image, and the "no sandbox image" warning links to the agent and Settings, Security controls.
  • Settings, Security: agent_sandbox.job.env_from_secrets (names validated), default image section opens when the gate is on with no image.
  • Saves go through the existing Config.Save, which writes the same marshalled config to both hive.yaml.runtime and hive.yaml.dashboard; no new writer. A test pins both files for the new fields.
  • Tests (Go and node), docs (review-swarm, sandbox-isolation, agent-configuration), changelog.d fragment, regenerated index.html.

Not run locally (CI is the gate).

🤖 Generated with Claude Code

…ge/block without editing config files

Fixes #18797

Signed-off-by: Andy Anderson <andy@clubanderson.com>
@kubestellar-prow kubestellar-prow Bot added dco-signoff: yes Indicates the PR's author has signed the DCO. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 17, 2026
@github-actions

github-actions Bot commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

PR Title Relation Files
#18778 ✨ Governor PRs by model: rework per backend and a per-effort breakdown same files src/pkg/dashboard/static/index.html
#18805 🐛 config: adopt review and agent_sandbox from the dashboard overlay on reload same files src/docs/agent-configuration.md
#18781 ✨ Spend and contributor run stats by model: add the canonical model name same files src/pkg/dashboard/static/index.html
#18782 ✨ Governor PRs by model: split closed-unmerged PRs into superseded, duplicate and other same files src/pkg/dashboard/static/index.html
#18779 ✨ Governor PRs by model: per-repository breakdown and weekly trend same files src/pkg/dashboard/static/index.html
#18785 ✨ PRs by model: list one model's pull requests same files src/pkg/dashboard/static/index.html
#18780 ✨ Governor PRs by model: what each model's PRs cost the hive to review same files src/pkg/dashboard/static/index.html
#18786 🐛 Claude model dropdown and price table: add Fable 5.2, Fable 5.1, Haiku 5.5 and the fable alias same files src/pkg/dashboard/static/index.html
#18783 ✨ Evidence summary: change failures (reverts, reopened issues) per model same files src/pkg/dashboard/static/index.html
#18803 🐛 modelfamily: read the vendor family from the provider-stripped model id same files src/docs/agent-configuration.md

Signed-off-by: Andy Anderson <andy@clubanderson.com>
@hivecommons-hive

Copy link
Copy Markdown
Contributor

Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor.

@clubanderson this PR is held at stage/071-needs-author and the hive will not merge it yet.

Failing checks:

  • coverage

Next: the hive does not push to your branch. Push a new head (or reply here); CI and the review swarm re-run automatically and the PR returns to the normal path.

Signed-off-by: Andy Anderson <andy@clubanderson.com>
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow
kubestellar-prow Bot merged commit 3ea317f into v5 Nov 17, 2026
98 checks passed
@kubestellar-prow
kubestellar-prow Bot deleted the feat/18797-perspectives-source-sandbox-ui branch November 17, 2026 19:14

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correctness review at 4c6d4e6: no in-scope blocker. Set/clear of perspectives_source, the approval gate, hook re-resolve and sandbox field validation match #18797. Two low advisory edge cases are inline (mutate-before-validate order; link plus inline edit in one request). I did not run the tests.

— hive: agent=adjudicator backend=claude model=claude-sonnet-5-5 claude=2.1.326

cfg.Review.PerspectivePrompts = cleaned
}
}
if sourceChange {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Advisory: this mutates the live config before later validations (e.g. revise_verdicts_before 400 below) can reject the request, leaving the link changed in memory but unsaved/unresolved. Move this block after the last validation return.

if src := s.deps.Config.Review.PerspectivesSource; src.IsSet() && (body.Perspectives != nil || body.PerspectivePrompts != nil) {
// editable (hivecommons/hive#17989). Unlinking in the same request lifts
// the refusal.
if src := s.deps.Config.Review.PerspectivesSource; linkedAfter && src.IsSet() && (body.Perspectives != nil || body.PerspectivePrompts != nil) {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Advisory: the guard also requires the current source to be set, so linking plus inline perspectives in one request passes and the inline values are then overwritten by the resolver. Consider refusing whenever linkedAfter and inline edits are present.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has signed the DCO. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

✨ Dashboard/API: set review.perspectives_source and agent sandbox image/block without editing config files

1 participant