Repository navigation
π config: adopt review and agent_sandbox from the dashboard overlay on reload - #18805
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Open PR overlap checkβ
Resolved: no conflicting open PRs or same-file overlaps remain against |
|
Second commit covers the live OpenShell case: π€ Generated with Claude Code |
|
Hive status β updated in place; edits do not notify. Full history is in the Activity Monitor. @clubanderson this PR is held at Failing checks:
Next: the hive does not push to your branch. Push a new head (or reply here); CI and the review swarm re-run automatically and the PR returns to the normal path. Evidence bundle `#1880508c193d` sha256:6257d64e9ad2ef412ebf3cfa3c67489bcb4ad14deff3fa4dfa8aa907b2318309 β download from the dashboard or `hivectl review evidence #18805`.merged by Hive trusted-author auto-merge: author |
|
Failing π Hive Agent: β hive: agent=scanner backend=claude model=claude-sonnet-5-5 claude=2.1.326 |
There was a problem hiding this comment.
Verified a defect, read from the tree at head 6201ddd and from the failing CI log (test (rest 2/4)).
The second hunk (agent files re-applied after the overlay) breaks an existing, intentionally pinned contract β see the inline thread. TestLoadWithDashboardOverlay_ExplicitFalseStillRevokesConverse (src/pkg/config/dashboard_overlay_converse_test.go:100-111) fails with explicit converse: false in the dashboard overlay must win. The comment at config.go:6288-6303 (#7503) says the per-agent file must not be unconditionally authoritative; an explicit value in the overlay is a real decision (the dashboard writes both). The new block restores the file wholesale, so converse: true in the file beats an explicit false in the overlay.
The first hunk (adopting review / agent_sandbox from the overlay) reads correctly to me and its tests are on point. Suggest splitting the agent-file change out, or making it field-wise (only fill what the overlay leaves nil/unset, as the #7503 loop does) so both tests hold.
I haven't posted anything on the issue and have not tried to run the suite.
β hive: agent=reviewer backend=claude model=claude-sonnet-5-5 claude=2.1.326
| // or `sandbox:` block in the agent file never took effect while the | ||
| // overlay and runtime config still said otherwise (#18804). Re-apply the | ||
| // files last. The dashboard writes the same file on every per-agent save | ||
| // and pack apply, so a current file already agrees with the overlay. |
There was a problem hiding this comment.
Re-applying LoadAgentOverrides files here replaces the whole entry again, so a file's converse: true overrides an explicit converse: false in the overlay. That regresses #7503's contract (loop at ~6301) and is what fails TestLoadWithDashboardOverlay_ExplicitFalseStillRevokesConverse in CI. Merge field-wise (fill only fields the overlay leaves unset) rather than wholesale.
|
Scanner triage (cannot push to this author's branch): the red Suggested: keep the review/agent_sandbox adoption (that part is independent), and either drop the agent-file re-apply or make it not overwrite fields the overlay sets explicitly (e.g. skip hive/awaiting-ci: author to push; sweep merges when green. π Hive Agent: β hive: agent=scanner backend=claude model=claude-sonnet-5-5 claude=2.1.326 |
|
scanner: baseline triage says MERGE_BASE (17 commits behind v5, not a shared incident). Human-authored branch, so not pushing; please merge v5 in (signed off) and re-check. Changes were requested at 6201ddd. π Hive Agent: β hive: agent=scanner backend=claude model=claude-sonnet-5-5 claude=2.1.326 |
|
Scanner triage: the only red check is π Hive Agent: β hive: agent=scanner backend=claude model=claude-sonnet-5-5 claude=2.1.326 |
|
scanner: not pushing (human-authored branch). Failing checks on 6201ddd: π Hive Agent: β hive: agent=scanner backend=claude model=claude-sonnet-5-5 claude=2.1.326 |
β¦n reload Refs the reload path loadWithDashboardOverlay only adopted a fixed list of blocks, so a seed-started reload dropped dashboard-saved review and agent_sandbox settings. Adopt both whole before the fullness guard; keep variables seed-only. Fixes #18804 Signed-off-by: Andy Anderson <andy@clubanderson.com>
Re-apply /data/agent-configs/<name>.yaml after the overlay's whole-entry agent replacement so paused and sandbox edits take effect. Fixes #18804 Signed-off-by: Andy Anderson <andy@clubanderson.com>
β¦verse winning Fixes #18804 Signed-off-by: Andy Anderson <andy@clubanderson.com>
6201ddd to
08c193d
Compare
Fixes #18804
Verified by code read:
loadWithDashboardOverlayadopted OTel, work source, operator cadences, tombstones and agents from/data/hive.yaml.dashboard, but notrevieworagent_sandbox. The entrypoint boot merge (overlay wins wholesale) and a boot fromhive.yaml.runtimealready protect a normal restart, but any Go load that starts from the seed (read-only ConfigMap mount on first boot or reprovision,config-check, a watcher reload of the seed path) lostreview.combined_perspectives,require_labels,perspectives_sourceandagent_sandbox.image/job.*.Fix: adopt both blocks whole when the overlay carries them, before the fullness guard; a silent overlay leaves the seed block alone;
variables.securitystays seed-only. Tests insrc/pkg/config/overlay_review_sandbox_test.gocover both loaders, the silent overlay and the variables invariant. Docs and changelog fragment included. Not built or tested locally; CI is the gate.π€ Generated with Claude Code