Skip to content

πŸ› config: adopt review and agent_sandbox from the dashboard overlay on reload - #18805

Merged
hivecommons-hive[bot] merged 3 commits into
v5from
fix/18804-overlay-review-sandbox
Nov 17, 2026
Merged

hivecommons-hive[bot] merged 3 commits into
v5from
fix/18804-overlay-review-sandbox

Conversation

@clubanderson

Copy link
Copy Markdown
Member

Fixes #18804

Verified by code read: loadWithDashboardOverlay adopted OTel, work source, operator cadences, tombstones and agents from /data/hive.yaml.dashboard, but not review or agent_sandbox. The entrypoint boot merge (overlay wins wholesale) and a boot from hive.yaml.runtime already protect a normal restart, but any Go load that starts from the seed (read-only ConfigMap mount on first boot or reprovision, config-check, a watcher reload of the seed path) lost review.combined_perspectives, require_labels, perspectives_source and agent_sandbox.image/job.*.

Fix: adopt both blocks whole when the overlay carries them, before the fullness guard; a silent overlay leaves the seed block alone; variables.security stays seed-only. Tests in src/pkg/config/overlay_review_sandbox_test.go cover both loaders, the silent overlay and the variables invariant. Docs and changelog fragment included. Not built or tested locally; CI is the gate.

πŸ€– Generated with Claude Code

@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Nov 17, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign clubanderson for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 17, 2026
@github-actions

github-actions Bot commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

Open PR overlap check

βœ… Resolved: no conflicting open PRs or same-file overlaps remain against v5.

@clubanderson

Copy link
Copy Markdown
Member Author

Second commit covers the live OpenShell case: loadWithDashboardOverlay replaced per-agent files (/data/agent-configs/.yaml, documented higher layer) with the overlay's older whole agent entry, so paused and sandbox edits never took effect. Files are now re-applied last; test TestLoadWithDashboardOverlay_AgentFileOutranksDashboardOverlay. Fixes #18804 still applies.

πŸ€– Generated with Claude Code

@hivecommons-hive

hivecommons-hive Bot commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

Hive status β€” updated in place; edits do not notify. Full history is in the Activity Monitor.

@clubanderson this PR is held at stage/071-needs-author and the hive will not merge it yet.

Failing checks:

  • coverage

Next: the hive does not push to your branch. Push a new head (or reply here); CI and the review swarm re-run automatically and the PR returns to the normal path.

Evidence bundle `#1880508c193d` sha256:6257d64e9ad2ef412ebf3cfa3c67489bcb4ad14deff3fa4dfa8aa907b2318309 β€” download from the dashboard or `hivectl review evidence #18805`.

merged by Hive trusted-author auto-merge: author clubanderson holds role owner and GitHub permission admin on repo; CI green at 08c193d.

@hivecommons-hive

Copy link
Copy Markdown
Contributor

Failing test (rest 2/4) / coverage here is not shared baseline breakage: the branch is 15 commits behind v5. This is a human-authored branch so I have not pushed; merging v5 in (signed off) and re-running should clear it.


🐝 Hive Agent: scanner | Instance: hosted-available-oke-11-placeholder-r05x | SHA: unknown

β€” hive: agent=scanner backend=claude model=claude-sonnet-5-5 claude=2.1.326

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified a defect, read from the tree at head 6201ddd and from the failing CI log (test (rest 2/4)).

The second hunk (agent files re-applied after the overlay) breaks an existing, intentionally pinned contract β€” see the inline thread. TestLoadWithDashboardOverlay_ExplicitFalseStillRevokesConverse (src/pkg/config/dashboard_overlay_converse_test.go:100-111) fails with explicit converse: false in the dashboard overlay must win. The comment at config.go:6288-6303 (#7503) says the per-agent file must not be unconditionally authoritative; an explicit value in the overlay is a real decision (the dashboard writes both). The new block restores the file wholesale, so converse: true in the file beats an explicit false in the overlay.

The first hunk (adopting review / agent_sandbox from the overlay) reads correctly to me and its tests are on point. Suggest splitting the agent-file change out, or making it field-wise (only fill what the overlay leaves nil/unset, as the #7503 loop does) so both tests hold.

I haven't posted anything on the issue and have not tried to run the suite.

β€” hive: agent=reviewer backend=claude model=claude-sonnet-5-5 claude=2.1.326

Comment thread src/pkg/config/config.go Outdated
// or `sandbox:` block in the agent file never took effect while the
// overlay and runtime config still said otherwise (#18804). Re-apply the
// files last. The dashboard writes the same file on every per-agent save
// and pack apply, so a current file already agrees with the overlay.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-applying LoadAgentOverrides files here replaces the whole entry again, so a file's converse: true overrides an explicit converse: false in the overlay. That regresses #7503's contract (loop at ~6301) and is what fails TestLoadWithDashboardOverlay_ExplicitFalseStillRevokesConverse in CI. Merge field-wise (fill only fields the overlay leaves unset) rather than wholesale.

@hivecommons-hive

Copy link
Copy Markdown
Contributor

Scanner triage (cannot push to this author's branch): the red test (rest 2/4) is real, not infra. TestLoadWithDashboardOverlay_ExplicitFalseStillRevokesConverse (dashboard_overlay_converse_test.go:110) fails: the fixture has a per-agent file with converse: true and the overlay has an explicit converse: false, which must win (#7503). The new block in loadWithDashboardOverlay that re-applies LoadAgentOverrides after the overlay's agents now lets the per-agent file beat that explicit revocation.

Suggested: keep the review/agent_sandbox adoption (that part is independent), and either drop the agent-file re-apply or make it not overwrite fields the overlay sets explicitly (e.g. skip Converse when the overlay's agent entry has it non-nil). Also sleep_ratchet_test.go:87 reports 194 time.Sleep( calls, below baseline 195: lower sleepBaseline in internal/testutil/sleep_ratchet_test.go to 194. Branch is 17 commits behind v5; merge base in signed off.

hive/awaiting-ci: author to push; sweep merges when green.


🐝 Hive Agent: scanner | Instance: hosted-available-oke-11-placeholder-r05x | SHA: unknown

β€” hive: agent=scanner backend=claude model=claude-sonnet-5-5 claude=2.1.326

@hivecommons-hive

Copy link
Copy Markdown
Contributor

scanner: baseline triage says MERGE_BASE (17 commits behind v5, not a shared incident). Human-authored branch, so not pushing; please merge v5 in (signed off) and re-check. Changes were requested at 6201ddd.


🐝 Hive Agent: scanner | Instance: hosted-available-oke-11-placeholder-r05x | SHA: unknown

β€” hive: agent=scanner backend=claude model=claude-sonnet-5-5 claude=2.1.326

@hivecommons-hive

Copy link
Copy Markdown
Contributor

Scanner triage: the only red check is test (rest 2/4) (so test and coverage follow). The baseline check says PR-local and 27 commits behind v5, which is green. Suggested fix: merge v5 into this branch (signed off) and re-run. I have not pushed to this branch because it is not hive-authored.


🐝 Hive Agent: scanner | Instance: hosted-available-oke-11-placeholder-r05x | SHA: unknown

β€” hive: agent=scanner backend=claude model=claude-sonnet-5-5 claude=2.1.326

@hivecommons-hive

Copy link
Copy Markdown
Contributor

scanner: not pushing (human-authored branch). Failing checks on 6201ddd: test (rest 2/4), hence coverage/test; the other shards are green. Please read the test (rest 2/4) job log; this is separate from the server-tests incident #18830. Changes were also requested in review.


🐝 Hive Agent: scanner | Instance: hosted-available-oke-11-placeholder-r05x | SHA: unknown

β€” hive: agent=scanner backend=claude model=claude-sonnet-5-5 claude=2.1.326

…n reload

Refs the reload path loadWithDashboardOverlay only adopted a fixed list of
blocks, so a seed-started reload dropped dashboard-saved review and
agent_sandbox settings. Adopt both whole before the fullness guard; keep
variables seed-only. Fixes #18804

Signed-off-by: Andy Anderson <andy@clubanderson.com>
Re-apply /data/agent-configs/<name>.yaml after the overlay's whole-entry agent
replacement so paused and sandbox edits take effect. Fixes #18804

Signed-off-by: Andy Anderson <andy@clubanderson.com>
…verse winning

Fixes #18804

Signed-off-by: Andy Anderson <andy@clubanderson.com>
@clubanderson
clubanderson force-pushed the fix/18804-overlay-review-sandbox branch from 6201ddd to 08c193d Compare November 17, 2026 23:48
@hivecommons-hive
hivecommons-hive Bot merged commit 13819f0 into v5 Nov 17, 2026
88 of 89 checks passed
@kubestellar-prow
kubestellar-prow Bot deleted the fix/18804-overlay-review-sandbox branch November 17, 2026 23:55
@clubanderson clubanderson added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has signed the DCO. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

πŸ› Kubernetes reload may drop dashboard-saved review and agent_sandbox settings (loadWithDashboardOverlay does not adopt them)

1 participant