Skip to content

🐛 Kubernetes reload may drop dashboard-saved review and agent_sandbox settings (loadWithDashboardOverlay does not adopt them) #18804

Closed

Description

@clubanderson

Observation (needs verification)

Found while building #18800: on Kubernetes, the config reload path loadWithDashboardOverlay (src/pkg/config/config.go:6201) adopts a fixed list of blocks from /data/hive.yaml.dashboard over the ConfigMap seed (OTel, the governor work source, operator-owned cadences, tombstones, and so on, each with a comment naming the bug that added it). It does not appear to adopt review or agent_sandbox from the overlay.

If that is right, a setting the dashboard saves into those blocks (review.combined_perspectives, review.require_labels, review.perspectives_source, agent_sandbox.image and the Job defaults) can be lost on a reload that rebuilds from the seed, and the same shape of bug as #5632 (cadences) and the work-source fix would apply. It also explains why a customer's hand edit to review had to go into both /data/hive.yaml.runtime and /data/hive.yaml.dashboard (2026-11-17, standalone hive on OpenShift): it was not obvious which file wins.

What I have NOT verified: whether the boot path (which boots from /data/hive.yaml.runtime and does not re-merge the seed, per src/docs/agent-configuration.md) already protects these blocks, which reload paths call loadWithDashboardOverlay, and whether standalone hives (not hosted spokes) take this path at all. Reproduce first.

Expected

  • A dashboard-saved review block (and agent_sandbox) survives restart and every reload path on Kubernetes, standalone or hosted, with the seed as the fallback only when the overlay has nothing.
  • A test per block: seed with one value, overlay with another, load through every reload entry point, assert the overlay value wins and the rest of the seed is intact.
  • If a block is intentionally seed-owned (for example a security gate), say so in a comment and in src/docs/agent-configuration.md, and make the dashboard refuse to save it instead of silently losing it.

Acceptance

Related: #18797, #18800, #5632.

Activity

  1. added
    kind/bugCategorizes issue or PR as related to a bug.
    triage/acceptedIndicates an issue or PR is ready to be actively worked on.
    on Nov 17, 2026
  2. self-assigned this
    on Nov 17, 2026
  3. clubanderson commented on Nov 17, 2026

    @clubanderson
    MemberAuthor

    Claimed: an operator-dispatched agent is working on this now. Hive agents, please do not pick it up.

  4. added
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    on Nov 17, 2026
  5. added a commit that references this issue on Nov 17, 2026
    6201ddd
  6. hivecommons-hive commented on Nov 17, 2026

    @hivecommons-hive
    Contributor

    Thanks for filing this issue! To help us reproduce and investigate, could you please include the commit SHA of the build you're running?

    You can find it by running:

    git rev-parse --short HEAD
    

    Or check the bottom of the console UI for the version string.

    This issue will be on hold until a SHA is provided. Simply add a comment with the SHA and the label will be automatically removed.

  7. added 3 commits that reference this issue on Nov 17, 2026
    2ef6b21
    60516bd
    08c193d
  8. added a commit that references this issue on Nov 17, 2026
    13819f0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.kind/bugCategorizes issue or PR as related to a bug.needs-shatriage/acceptedIndicates an issue or PR is ready to be actively worked on.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions