Repository navigation
✨ Customers: graph view, merge and split, and export - #18802
Conversation
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of
|
PR 8 of RFC #18742. - A profile Graph: the person, their artefacts and the other people on them, an SVG drawn from one GraphQL query. - Merge, unmerge and split with exact edge moves by the identity that produced them; two dashboard users never merge; a hive user identity never splits off. Full view only, audited. - Export for the owner: profile, merge history, hints and up to 10,000 edge references. Audited. - Four routes in openapi and the API reference. Refs #18742 Signed-off-by: Andy Anderson <andy@clubanderson.com>
TestNoForcedBrowserDownloadsRatchet forbids createObjectURL and a.download. Refs #18742 Signed-off-by: Andy Anderson <andy@clubanderson.com>
Refs #18742 Signed-off-by: Andy Anderson <andy@clubanderson.com>
6503971 to
4d709b4
Compare
Refs #18742 Signed-off-by: Andy Anderson <andy@clubanderson.com>
Mutation testinggremlins found 1 surviving mutant(s) in changed files: the code ran under tests, but changing it did not fail any test.
2 mutant(s) in changed files are not reached by any test (NOT COVERED). A maintainer may apply the
Verdict: |
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
PR 8 of the Customers series (RFC #18742). Independent of PR 7 (#18794).
What is here
viaidentity belonged to the restored person; activity the target produced on its own stays.hive_useridentity cannot be split off, a split must leave an identity behind, and two dashboard users cannot be merged.POST /api/customers/{id}/merge,/unmerge,/split, andGET /api/customers/{id}/export, in openapi and the API reference. Audited ascustomer_merge,customer_unmerge,customer_split,customer_export; ids copied into the audit line are cleaned and bounded.Access (tests walk every role)
A read-only user can use none of these routes, on anyone, themselves included (
TestMergeSplitExportRoles,TestCustomersRoleMatrix). Read-write cannot export. The page hides what a role cannot use, and the server refuses it anyway.Departure from the plan
The plan said to share the canvas layout from
js/knowledge.js. I did not: that canvas is animated, drawn with inline styles that the style ratchet only tolerates because they are baselined, and is built for a thousand-node force layout. The customers view is a small static radial drawing in a new file (js/graphcanvas.js) that follows the page's design tokens, adds no inline styles and no raw colours, and stays readable on a phone. The layout and the SVG are tested under node (bounded, deduplicated, escaped, no NaN).Tests
Edge moves through merge, undo and split (
TestMergeUnmergeSplitMoveEdgesExactly); export (TestExport); handler bodies and audit (TestCustomersMergeSplitExportBodiesAndAudit); the render helpers as owner, read-write and read-only, and the graph layout (TestCustomersViewGates).Refs #18742
🤖 Generated with Claude Code