Skip to content

πŸ› fix(stage): bot Dependency Dashboards and the advisory report get no stage label - #16833

Merged
hivecommons-hive[bot] merged 1 commit into
hivecommons:v6from
Danathar:fix/standing-meta-no-stage
Nov 5, 2026
Merged

hivecommons-hive[bot] merged 1 commit into
hivecommons:v6from
Danathar:fix/standing-meta-no-stage

Conversation

@Danathar

@Danathar Danathar commented Nov 5, 2026

Copy link
Copy Markdown
Contributor

Executive summary

Bot Dependency Dashboards were parked at stage/045-needs-decision. Examples: projectbluefin/gutenprint-printer-app#45, projectbluefin/ps-printer-app#50 and projectbluefin/hplip-printer-app#42, all mergeraptor's. A triage bot added needs-human, and the stage engine turned that into a park.

A standing meta issue is a control panel or a report, not work. The stage engine now derives no stage for one, in the sweep and out of cycle, so the 045 comes off. #16786 already keeps these issues off the activity monitor's rows. This is the stage label itself.

What

Issue Before After
Dependency Dashboard + needs-human stage/045-needs-decision No stage label; the 045 is removed
Hive Advisory Report + a decision label stage/045-needs-decision No stage label
Out-of-cycle fact (webhook) on either Re-parked at 045 between sweeps No stage label
The bot's own labels (needs-human, …) Kept Kept (not the hive's to remove)

Why

Enumeration already files these issues in their own work-detail buckets: dependency_dashboard and hive_advisory (standingMetaIssueKindFor). deriveIssue carried those buckets through as unknown, but checked Park.NeedsHuman first, so a park label won.

How

  • stageengine: BucketDependencyDashboard and BucketHiveAdvisory. issueStage returns None for them before any park check, with the reason standing meta issue, not work: <bucket>.
  • github/stage_facts_sink.go: the enrichment classifies the fresh read with standingMetaIssueKindFor and sets the bucket. An out-of-cycle fact then derives the same thing as the sweep.

Tests

Check Result
TestDeriveIssueTable (two new rows) pass
TestStandingMetaIssueDerivesNoStage (sweep row, sink fact, enrichment) pass: 045 removed, nothing added, needs-human kept
go test ./pkg/stageengine/... ./pkg/stagelabels/... ./pkg/github/... ./pkg/writeback/ pass
check-docs-citations.py src/docs 2006 verified
Mutants (derive check, advisory branch Γ—2, sink classification) 4/4 caught

Notes

  • Test fixture: stageFactsServer gained optional title / login fields, so the fixture can serve a bot-authored dashboard.
  • Scope: part of a checklist on stale hive labels. The other items are in separate PRs or left out.

πŸ€– Generated with Claude Code

https://claude.ai/code/session_01BQYnPGFJx81c8JXR3o1sg1

mergeraptor's Dependency Dashboards (projectbluefin/gutenprint-printer-app#45,
ps-printer-app#50, hplip-printer-app#42) wore stage/045-needs-decision because
a triage bot added needs-human. A standing meta issue (bot Dependency
Dashboard, Hive Advisory Report) is not work: the engine derives no stage
for its bucket, and the out-of-cycle sink classifies it from the fresh read,
so the 045 comes off and a webhook cannot re-park it between sweeps.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BQYnPGFJx81c8JXR3o1sg1
Signed-off-by: Danathar <Danathar@users.noreply.github.com>
@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Nov 5, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign clubanderson for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 5, 2026
@github-actions

github-actions Bot commented Nov 5, 2026 •

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v6

Conflicts are checked with every PR merged onto the current tip of v6, so a PR that only needs a rebase is not reported as conflicting with its siblings.

PR Title Relation Files
#16831 πŸ› fix(ownership): issues the issue filter refuses reach the inbox as ADMIT same files src/docs/dashboard.md
#16829 πŸ› fix(dashboard): issue bands agree with hold, parked likely-done and stage/040 same files src/docs/dashboard.md

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read the diff against the v6 tree at 91ba1dde5 and the callers. This looks correct to me.

What I verified:

  • Sweep path agrees with the new constants. client.go:2018-2026 files these issues with the string buckets "hive_advisory" / "dependency_dashboard"; issue_stage_labels.go:339 passes row.Bucket through, and issueBucketFrom (issue_stage_facts.go:72-77) is a plain IssueBucket(bucket) cast β€” so the sweep row lands on BucketDependencyDashboard / BucketHiveAdvisory with no further wiring. Before this PR those strings were carried as an unknown bucket and fell through to the Park.NeedsHuman branch, which is exactly the 045 described.
  • Ordering. The new check in issueStage (derive_issue.go:146) sits ahead of LikelyDone, hold, blocked and park, matching the sweep, which continues on standing meta before isHeld (client.go:2029-2035). No disagreement between the two.
  • Out-of-cycle path. stage_facts_sink.go:166 reuses standingMetaIssueKindFor with the same title/author/labels the sweep uses, so a webhook fact classifies identically.
  • go build ./pkg/stageengine/ ./pkg/github/ is clean at head 40d6e3b.

One non-blocking note: TestStandingMetaIssueDerivesNoStage asserts the bot's needs-human survives the write β€” good, since that label is not the hive's β€” but nothing asserts the behaviour for an issue that is both a dependency dashboard and wears a hold label. Reading the code it derives None either way, so I don't think a test is required; mentioning it only because standing_issues.go calls out hold-on-advisory explicitly.

β€” hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive
hivecommons-hive Bot merged commit 7f7d59f into hivecommons:v6 Nov 5, 2026
71 of 74 checks passed
@hivecommons-hive

Copy link
Copy Markdown
Contributor

Hive status β€” updated in place; edits do not notify. Full history is in the Activity Monitor.

Evidence bundle `#1683340d6e3b` sha256:008676774a78b275da06bf0843c307347c5dfd14582bf47e1dffc9967ee831f7 β€” download from the dashboard or `hivectl review evidence #16833`.

hivecommons-hive Bot pushed a commit that referenced this pull request Nov 10, 2026
The four Renovate Dependency Dashboards on projectbluefin
(common#245, gutenprint-printer-app#45, hplip-printer-app#42,
ps-printer-app#50) wear needs-human from a triage bot, so the stage
tracker's waiting_on_human block listed them as approve-needed. The
monitor never draws a standing meta issue and the stage engine gives it
no stage (#16833), but stageTrackerWaitKind did not look at the bucket,
so the badge, the topbar pill and the MCP's waiting_on_you counted rows
nobody can see or act on.

stageTrackerWaitKind now returns no wait for an issue in the
dependency_dashboard or hive_advisory bucket, the same structural
classification (bot author plus dashboard title, or the advisory
title/label) the enumeration and the SPA already use.


Claude-Session: https://claude.ai/code/session_01BQYnPGFJx81c8JXR3o1sg1

Signed-off-by: Danathar <Danathar@users.noreply.github.com>
Co-authored-by: Danathar <Danathar@users.noreply.github.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-signoff: yes Indicates the PR's author has signed the DCO. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant