Repository navigation
🐛 fix(dashboard): issue bands agree with hold, parked likely-done and stage/040 - #16829
Conversation
…and 040 labels - A held issue is Parked (chip `hold`), not Unclaimed (projectbluefin/utah#551). - A parked issue whose only done label is hive/likely-done stays Parked (projectbluefin/common#1328, an RFC parked on needs-decision). - stage/040 with no done label signals "covered by an open PR", not "already done" (projectbluefin/utah#12, hivecommons#1075). The legacy Overview parity oracle mirrors the band changes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BQYnPGFJx81c8JXR3o1sg1 Signed-off-by: Danathar <Danathar@users.noreply.github.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of
|
|
Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor. Hive filed review findings that do not block this PR as backlog items:
Cap: 10 backlog item(s) per PR per day. Review findings from Correctness review (head Hive-filed proposals under the ACMM gate drop out of "Needs triage" into "Parked" — Suggested fix — let a gate-held proposal keep its triage band while a human-placed park still wins: - waiting := hasAnyLabel(labels, norm.WaitingLabels) || held
+ selfAuthorizationHeld := true
+ if len(selfAuthorizationHoldActive) > 0 && selfAuthorizationHoldActive[0] != nil {
+ selfAuthorizationHeld = selfAuthorizationHoldActive[0](issue.Repo)
+ }
+ agentFiled := role != "" && !acknowledged && selfAuthorizationHeld
+ // A generic hold on an unacknowledged agent proposal is the ACMM gate
+ // (see heldReason); that stays "Needs triage". Any other hold parks.
+ waiting := hasAnyLabel(labels, norm.WaitingLabels) || (held && !agentFiled)(and drop the later duplicate Note: the PR's linked issue projectbluefin/common#1328 is an RFC about the Bluefin contract that this PR cites only as an example row; it is not the work this PR implements, so I judged against the PR's own stated rules. Review findings from Read the diff against the What I verified:
One observation, not a defect: the oracle's likely-done guard omits the Go |
There was a problem hiding this comment.
Style/maintainability pass at head 0c4bc1e. Nothing blocking; two small things the author may want to fold in.
1. Oracle CSV fallback drops the new held argument — src/pkg/dashboard/testdata/overview_legacy_9102.js:482. issueBandInfo now takes held (line 90) and groupedRepoIssues passes it (line 159), but overviewIssueCsvRow still calls issueBandInfo(issue) on its fallback path while computing held from the item two lines later (line 484). The parity test is unaffected because item.info is always populated via groupedRepoIssues, but the fallback now silently disagrees with Go for a held issue.
const info = (item && item.info) || issueBandInfo(issue, !!(item && item.held));
2. onlyLikelyDone duplicates the loop in issueDoneLabel — src/pkg/dashboard/bands.go:280-290 vs :269-274. Both iterate doneLabels for "any done label other than hive/likely-done". A shared helper keeps the two rules (verified-open cancels likely-done; park cancels likely-done) from drifting:
+// hasOtherDoneLabel reports whether a configured done label other than
+// hive/likely-done is set.
+func hasOtherDoneLabel(labels map[string]bool, doneLabels []string) bool {
+ for _, label := range doneLabels {
+ lower := strings.ToLower(label)
+ if lower != github.LikelyDoneLabel && labels[lower] {
+ return true
+ }
+ }
+ return false
+}
+
func issueDoneLabel(labels map[string]bool, doneLabels []string) bool {
if !labels[github.VerifiedOpenLabel] {
return hasAnyLabel(labels, doneLabels)
}
- for _, label := range doneLabels {
- lower := strings.ToLower(label)
- if lower != github.LikelyDoneLabel && labels[lower] {
- return true
- }
- }
- return false
+ return hasOtherDoneLabel(labels, doneLabels)
}
func onlyLikelyDone(labels map[string]bool, doneLabels []string) bool {
- if !labels[github.LikelyDoneLabel] {
- return false
- }
- for _, label := range doneLabels {
- lower := strings.ToLower(label)
- if lower != github.LikelyDoneLabel && labels[lower] {
- return false
- }
- }
- return true
+ return labels[github.LikelyDoneLabel] && !hasOtherDoneLabel(labels, doneLabels)
}Advisory: the ✓ text at bands.go:218 names stage/040 literally, while issueStageCovered → stagelabels.IssueCoveredByPR (stagelabels.go:990) also matches later mirrored PR stages, as src/docs/dashboard.md notes. Enforce clamps those back to 040, so this is transient; fine to leave.
— hive: agent=ci-maintainer backend=copilot model=claude-fable-5.1 copilot=1.0.88
…andInfo Reviewer finding on hivecommons#16829: overviewIssueCsvRow's fallback called issueBandInfo(issue) without the new held argument, so the oracle disagreed with Go for a held issue on that path. It now passes held, and the parity test asserts the fallback's band for a held issue. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BQYnPGFJx81c8JXR3o1sg1 Signed-off-by: Danathar <Danathar@users.noreply.github.com>
|
Fixed in c03edd2: |
|
Style item 2: |
…l and onlyLikelyDone Reviewer item on hivecommons#16829: onlyLikelyDone duplicated issueDoneLabel's loop. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BQYnPGFJx81c8JXR3o1sg1 Signed-off-by: Danathar <Danathar@users.noreply.github.com>
Conflict in src/docs/dashboard.md: kept hivecommons#16829's band text and this PR's sentence on the verdict pair. Signed-off-by: Danathar <Danathar@users.noreply.github.com>
Executive summary
The Overview issue bands trusted labels whose meaning they got wrong in three cases:
hold).hive/likely-done(RFC: centralize the Bluefin contract in common so every Bluefin is held to it projectbluefin/common#1328).stage/040-covered-by-prsaid "already done" while their PR was still open (parity: install and assert the factory multimedia transaction projectbluefin/utah#12, fix: local mode uses tmux + relay, goose idle detection #1075).This PR fixes the three band rules. It writes no labels.
What
hold(serverheld)hold(a parking label's chip wins)needs-decision, 045, …) and onlyhive/likely-donehive/already-done/hive/covered-by-prstage/040-covered-by-pr, no done labelWhy
IssueBandignored its ownheldargument.hive/likely-doneis a heuristic: a merged PR referenced the issue. On common#1328 it came from PR test(agent): unit tests for non-tmux functions — 51.7% → 58.1% #1329 on 10-01. A maintainer parked the RFC onneeds-decisionafterwards, and done outranked parked.hive/verified-openalready cancels likely-done (🐛 [v6] dashboard issue band: hive/verified-open must keep an issue out of Confirm & close #11722); a park on a person now does too. Stronger done labels are not affected.issueStageCoveredcounts 040 as done, which is by design (Confirm & close checks the PR). But the signal text claimed the work had landed.How
src/pkg/dashboard/bands.go:waitingincludesheld.onlyLikelyDonedropsdonefor a parked issue whose only done label is likely-done, when no merged or covering link is present.waitinganddoneband rules name the change.testdata/overview_legacy_9102.js(the parity oracle) mirrors the held and likely-done rules.Files
src/pkg/dashboard/bands.gosrc/pkg/dashboard/bands_label_state_test.gosrc/pkg/dashboard/bands_inprogress_test.gosrc/pkg/dashboard/overview_ownership_11567_test.go?band=waitingnow includes the two held fixture issuessrc/pkg/dashboard/testdata/overview_legacy_9102.jssrc/docs/dashboard.md,changelog.d/…Tests
TestIssueBandAgreesWithLabelsgo test ./pkg/dashboard/... ./pkg/adminmcp/... ./pkg/hiveadvisor/...node --test src/pkg/dashboard/*.test.jscheck-docs-citations.py src/docsNotes
hive/likely-donestays on GitHub. The claim-label sync only re-evaluates issues with a live PR claim, so this PR does not remove it.bands.go(hold reason text and drafts). The hunks are different.🤖 Generated with Claude Code
https://claude.ai/code/session_01BQYnPGFJx81c8JXR3o1sg1