Repository navigation
π fix(advisory): never reopen an advisory issue a person closed - #16838
Merged
hivecommons-hive[bot] merged 1 commit intoNov 5, 2026
Merged
hivecommons-hive[bot] merged 1 commit into
hivecommons-hive[bot] merged 1 commit into
Conversation
projectbluefin/common#639: a maintainer closed the advisory digest ("no longer used") on 2026-10-27; the hive's hivecommons#4167 reuse reopened it the next day with no comment. A person's close now stands, on both the list and the ForgeState-cache path: the hive files a new advisory issue that says which one it replaces and why, and names `advisory.target`. A close by the hive or a bot, or one GitHub does not attribute, is reused as before. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BQYnPGFJx81c8JXR3o1sg1 Signed-off-by: Danathar <Danathar@users.noreply.github.com>
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Contributor
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Executive summary
projectbluefin/common#639 is the June advisory digest. A maintainer closed it on 2026-10-27 at 20:51Z, with the comment "no longer used". The hive reopened it the next day at 17:14Z, re-added
hive/advisory, and the issue was parked at 045. No comment was posted. The reopen is #4167's deliberate reuse of a closed advisory issue, which keeps subscribers on one URL. That reuse doesn't distinguish an accidental close from a person's decision.With this PR, a person's close stands. The hive leaves that issue closed and files a new advisory issue. The new issue says which one it replaces and why, and names
advisory.targetas the setting that moves the digest off GitHub. A close by the hive or a bot, or one GitHub doesn't attribute, is reused exactly as before.What
closed_byis a user, not this hive)The new issue's opening paragraph covers three things:
advisory.target: linear(withadvisory.linear_issue) keeps the digest off GitHub.The closer's login appears without
@, so the closer isn't notified.How
advisory_person_close.go(new):advisoryClosedByPersonreadsclosed_by. It counts as a person unless the login is empty, has theBottype or a[bot]suffix, or is this hive's account.advisoryReusablefetches the issue when the caller has no copy and records a note for the next create.advisory.go: fallback 3 (closed reuse) reopens only whenadvisoryReusableagrees.EnsureAdvisoryIssueprefixes the replacement note to the new issue's body.advisory_forgestate.go: the cache path (confirmAdvisoryIssue) applies the same check. On a person's close it forgets the memo and falls through to the list path, which then creates the new issue.docs/advisory.md: the "Someone closed the pinned issue" entry now covers both cases.Tests
TestEnsureAdvisoryIssue_HonoursPersonCloseTestFindAdvisoryIssue_CachedPersonCloseNotReopenedgo testgithub, writeback; docs citationsNotes
needs-humansince 10-03. Stopping the reopen removes that path. Separately, π fix(stage): bot Dependency Dashboards and the advisory report get no stage labelΒ #16833 stops stage labels on the advisory report.π€ Generated with Claude Code
https://claude.ai/code/session_01BQYnPGFJx81c8JXR3o1sg1