Skip to content

πŸ› fix(ownership): issues the issue filter refuses reach the inbox as ADMIT - #16831

Merged
hivecommons-hive[bot] merged 2 commits into
hivecommons:v6from
Danathar:fix/admit-verb-unadmitted
Nov 5, 2026
Merged

hivecommons-hive[bot] merged 2 commits into
hivecommons:v6from
Danathar:fix/admit-verb-unadmitted

Conversation

@Danathar

@Danathar Danathar commented Nov 5, 2026 •

Copy link
Copy Markdown
Contributor

Executive summary

Some issues that the issue filter (project.issue_filter.require_labels) keeps off every agent queue showed up in no inbox, even though only a maintainer could move them. There were two kinds:

This PR gives both kinds the existing ADMIT verb, with a reason that names the label that admits them. An undecided issue a person filed gets it too: the filter only ever lets it in through a maintainer's label.

What

Issue (refused by the issue filter) Before After
Carries approved-direction (/hive decision, /hive approve) outside, no verb ADMIT decided_not_admitted: "Decided, but the issue filter keeps it off the agent queue β€” add triage/accepted to admit it"
Agent-filed, agents self-authorize (L6 by default) outside, no verb ADMIT agent_finding_not_admitted: "… add triage/accepted to admit it, or close it if it no longer applies"
Agent-filed, self-authorization hold on (L5 and below) TRIAGE TRIAGE (unchanged)
Person-filed, undecided outside, no verb ADMIT person_issue_not_admitted: "A person filed this; … add triage/accepted to admit it so the hive works it, or close it"
Bot-filed (not a standing dashboard), undecided outside outside (unchanged)
Parked (045 etc.), or filtered for another reason park verb / not yours unchanged

Why

decideIssueOwnership had no rule for an issue whose enumeration bucket is filtered with reason "Project issue filter". Only the reporter-trust gate (untrusted_reporter) and the agent TRIAGE row produced an admission ask. A /hive decision un-parks the issue and applies approved-direction, but not the filter's label. The issue then dropped out of every list while the reply told the maintainer it was waiting on them.

How

  • pkg/dashboard/ownership.go: new rule (9b), placed after TRIAGE and before the safety net. It applies to a row in bucket filtered with reason github.IssueFilterReason:

    • with approved-direction, it gives decided_not_admitted;
    • with an agent/<role> label, it gives agent_finding_not_admitted;
    • with a human author (RepoWorkIssue.AuthorIsHuman, now passed to ownership), it gives person_issue_not_admitted.

    Only the filter's own refusal (bucket filtered, reason "Project issue filter") counts. The enumeration records holds, exempt, tracking, blocked, parks (needs-spec included), reporter confirmation, reporter triage and standing dashboards before it reaches the filter, with other buckets or reasons, so those rows keep what they had.

    Both use the verb ADMIT. The reason names project.issue_filter.require_labels (ownershipEnv.admitLabels, read from configuration with no GitHub call).

  • pkg/github/issue_admitter.go: exports IssueFilterReason, so the dashboard matches the enumeration's own reason string.

  • pkg/hiveadvisor/human_gate.go: plain-language wording for both codes; TestHiveAdviceWordsEveryOwnershipReason keeps the two lists in step.

  • static-src/js/label-filter.js: the ADMIT menu note naming reporter trust's admission labels is now shown only on untrusted_reporter rows. The filter rows' reason already names the filter's own labels, and those can differ.

Files

File Change
src/pkg/dashboard/ownership.go Rule (9b), two reason codes, admitLabels
src/pkg/github/issue_admitter.go IssueFilterReason
src/pkg/hiveadvisor/human_gate.go Wording for the two codes
src/pkg/dashboard/static-src/js/label-filter.js, static/index.html ADMIT note skipped for these rows; regenerated
src/docs/dashboard.md, changelog.d/… Reason-code table, level table, precedence
Tests See below

Tests

Test Covers
TestIssueFilterRefusedDecidedAndAgentFindingsAreAdmit 18 shapes: testsuite#1091, server#622, utah-packages#882 (lapsed claim label), agent findings at L6/L5, person-filed (L5/L6, decided), bot-filed, person's needs-spec park, exempt, reporter triage, other filter reasons, admitted; label naming
TestRepoOwnershipAdmitsFilterRefusedRows End to end from enumeration rows (decided, agent, person, bot), with require_labels read from configuration
your_turn_ui_11566_test.go The menu adds no reporter-trust note on these rows
Mutants (14) 14/14 caught
go test dashboard, hiveadvisor, adminmcp, writeback, github pass
node --test src/pkg/dashboard/*.test.js 332 pass
make dashboard-gen-check, check-docs-citations.py pass; 2006 references verified

Notes

πŸ€– Generated with Claude Code

https://claude.ai/code/session_01BQYnPGFJx81c8JXR3o1sg1

…ADMIT

A decided issue (approved-direction from /hive decision or /hive approve)
and an agent finding where agents self-authorize sat in band "outside"
with no verb when project.issue_filter.require_labels refused them:
projectbluefin/testsuite#1091, server#622, dakota-iso#294 (decided) and
testsuite#1085, documentation#1630 (L6 findings). Rule (9b) gives them
ADMIT (decided_not_admitted, agent_finding_not_admitted) with a reason
naming the labels that admit them.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BQYnPGFJx81c8JXR3o1sg1
Signed-off-by: Danathar <Danathar@users.noreply.github.com>
@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Nov 5, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign danathar for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 5, 2026
@github-actions

github-actions Bot commented Nov 5, 2026 •

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v6

Conflicts are checked with every PR merged onto the current tip of v6, so a PR that only needs a rebase is not reported as conflicting with its siblings.

PR Title Relation Files
#16807 πŸ› fix: route workflow blockers to capable lanes same files src/pkg/dashboard/static/index.html
#16688 🌱 Forward-merge v5 into v6 (2 commits) same files src/pkg/dashboard/static/index.html
#16829 πŸ› fix(dashboard): issue bands agree with hold, parked likely-done and stage/040 same files src/docs/dashboard.md
#16843 ✨ feat(ownership): CLOSE an agent finding whose cited lines are gone from main CONFLICT src/pkg/dashboard/ownership.go
src/pkg/dashboard/ownership_11565_test.go
src/pkg/hiveadvisor/human_gate.go

…MIT too

Doug's call on hivecommons#16831: an issue a person filed that only the missing
project.issue_filter.require_labels keeps out gets ADMIT
(person_issue_not_admitted) with "admit it so the hive works it, or close
it". Holds, exempt, tracking, blocked, parks, reporter confirmation,
reporter triage and standing dashboards are decided before the filter and
keep their rows; a bot's issue stays outside. The ADMIT menu's
reporter-trust note now shows only on untrusted_reporter.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BQYnPGFJx81c8JXR3o1sg1
Signed-off-by: Danathar <Danathar@users.noreply.github.com>

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The two rules the body describes are correct and well-grounded; the diff also ships a third rule the body says it does not, and that one changes inbox volume materially. I'd ask that the body and the code be made to agree before this lands.

Body/diff mismatch β€” person_issue_not_admitted. The What table's row "Person-filed, undecided" says outside β†’ outside (unchanged), and the How section lists exactly two reason codes. But ownership.go adds OwnershipReasonPersonIssueNotAdmitted and the branch

if in.authorIsHuman {
    return yourTurn(OwnershipReasonPersonIssueNotAdmitted, "A person filed this; the issue filter keeps it off the agent queue β€” ...")
}

inside rule (9b), plus the authorIsHuman plumbing from RepoWorkIssue.AuthorIsHuman in decideRepoOwnership, the human_gate.go wording, the docs rows and the changelog fragment. The new test rows "a person's undecided issue" / "a person's undecided issue at L5" assert ADMIT. So on any repo with project.issue_filter.require_labels set, every open human-filed issue that does not yet carry the admission label becomes a your_turn=true ADMIT row β€” i.e. the whole untriaged backlog, not just the decided issues and agent findings the summary is about. That may be the intended product behaviour (it is symmetric with untrusted_reporter), but it is a different and much larger change than the one the body argues for, and the body currently tells a maintainer it does not happen. Either drop the third branch to match the stated scope, or update the summary/What table to own it and say why the backlog should surface as inbox rows.

What I verified and agree with:

  • The match is exactly the filter's own refusal. client.go:2040-2145 decides exempt, tracking, blocked, reporter-confirmation, hard-suppress parks and reporter-triage before issueFilter.Admits, and only the last writes "Project issue filter"; issue_admitter.go now exports that string as IssueFilterReason, so bucketReason == github.IssueFilterReason cannot pick up a park or exempt row. Matches the test rows that keep DECIDE/SPEC/not-yours.
  • Placement. Rule (9b) sits after the TRIAGE row and before the safety net, so the L5 agent-finding case still yields TRIAGE as the table says.
  • admitLabels is read from cfg.Project.IssueFilter.RequireLabelsForNotice() (config/issue_filter.go:173), no GitHub call; admitPhrase degrades to "add an admission label" when empty.
  • Frontend. label-filter.js now keys the reporter-trust note on own.reason_code === 'untrusted_reporter'; reason_code is the JSON tag of Ownership.ReasonCode (ownership.go:177), so the new rows correctly skip that note.
  • TestOwnershipFixedSets11565 is bumped 32β†’35, consistent with three new codes (which is itself the tell that there are three, not two).

β€” hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive

hivecommons-hive Bot commented Nov 5, 2026 •

Copy link
Copy Markdown
Contributor

Hive status β€” updated in place; edits do not notify. Full history is in the Activity Monitor.

Review findings from reviewer-2 (folded here because this head already carries its hive review):

Read the diff against the v6 tree and traced the row it keys on; this looks correct to me.

  • Rule (9b) at src/pkg/dashboard/ownership.go:650 keys on bucket == "filtered" && reason == github.IssueFilterReason. In src/pkg/github/client.go (fetchIssues, ~2085–2145) that pair is emitted only by the final !issueFilter.Admits(labels) branch, after reporter-confirmation, hard-suppress and reporter-triage rows have already continued with other reasons β€” so the "only the filter's own refusal counts" claim holds in the tree, not just in the comment.
  • Placement after rule (9) means an agent finding under a self-authorization hold still gets TRIAGE, as the body's table says; with the hold off it falls through to agent_finding_not_admitted. approved-direction is checked first, so a decided agent finding reads as decided_not_admitted.
  • RequireLabelsForNotice() (src/pkg/config/issue_filter.go:173) and RepoWorkIssue.AuthorIsHuman (client.go:5091) already exist; the diff only threads them through. admitPhrase() degrades to "add an admission label" when the list is empty.
  • label-filter.js:103 now limits the reporter-trust note to untrusted_reporter, which is right: the new rows carry the filter's labels in their reason text and the trust labels would be the wrong hint.

CI was still in progress when I read this; the fixed-set count in TestOwnershipFixedSets11565 was bumped 32β†’35 to match the three new codes.

Evidence bundle `#16831d606164` sha256:2adafcaa4bdbb32a361b74dd51a804737b01490f8094594989a7d3c9a64d7dbc β€” download from the dashboard or `hivectl review evidence #16831`.

@github-actions github-actions Bot added the conflicts-with-open-pr Open PR has a merge conflict with another open PR label Nov 5, 2026
@hivecommons-hive
hivecommons-hive Bot merged commit 681b6e4 into hivecommons:v6 Nov 5, 2026
72 of 75 checks passed
hivecommons-hive Bot added a commit that referenced this pull request Nov 6, 2026
…from main (#16843)

* ✨ feat(ownership): CLOSE an agent finding whose cited lines are gone from main

Follow-up to #16831. Review-backlog findings cite permalinks pinned to a
commit (projectbluefin/testsuite#1085: SKILL.md:163). For a filter-refused
agent finding the enumeration reads the cited lines at that SHA and the
file on the default branch; when every citation's lines (>=16 chars, as in
#16693) are gone, the row records RepoWorkIssue.CitedLinesGone and the
dashboard offers CLOSE (cited_lines_gone). Bounded: 3 refreshes per repo
per pass, 6h TTL, pinned-SHA content cached; read failures are unknown.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BQYnPGFJx81c8JXR3o1sg1
Signed-off-by: Danathar <Danathar@users.noreply.github.com>

* πŸ› fix(ownership): stale-finding check settles unknowns and never CLOSEs a rename

Hive review on #16843:
- quality: a file gone from main is unknown, not gone (a rename keeps the
  lines); test pinned-present/main-404.
- correctness: a pinned-SHA 404 or evidence too short is settled once and
  costs no further read or budget; `?query` is stripped from permalink
  paths (`SKILL.md?plain=1#L163`).
- style: reuse hasAgentLaneLabel.
- security: cache only the evidence lines (16-400 chars) at a pinned SHA,
  bounded at 1024 citations, never whole files.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BQYnPGFJx81c8JXR3o1sg1
Signed-off-by: Danathar <Danathar@users.noreply.github.com>

---------

Signed-off-by: Danathar <Danathar@users.noreply.github.com>
Co-authored-by: Danathar <Danathar@users.noreply.github.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: hivecommons-hive[bot] <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

conflicts-with-open-pr Open PR has a merge conflict with another open PR dco-signoff: yes Indicates the PR's author has signed the DCO. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant