Skip to content

[reviewer] Review backlog (intent-alignment): Oracle fallback call to issueBandInfo omits the new held argument #16836

Closed

Description

@hivecommons-hive

Blocked on PR #16829. This finding came from reviewing PR #16829 and is about code that PR is changing. Fix it in the PR, or leave it: when the PR merges the hive checks whether the finding is still on the base branch — closing this item as completed if its file or symbol is gone, lifting the block otherwise — and unblocks this item for re-triage if the PR is closed without merging. Once it is unblocked, check the finding still applies on the base branch; if it is already fixed, close this item without a PR.

Filed from an out-of-scope finding in the Hive review of PR #16829.

PR: #16829 (#16829)
Perspective: intent-alignment
Severity: low (P3)
Finding: Oracle fallback call to issueBandInfo omits the new held argument
Evidence: src/pkg/dashboard/testdata/overview_legacy_9102.js:482

const info = (item && item.info) || issueBandInfo(issue);

issueBandInfo gained a held parameter (line 90) and groupedRepoIssues passes it (line 159), but the pre-existing fallback issueBandInfo(issue) at line 482 still calls it without held, so a held issue reaching that path reads as not-held in the oracle. Only hit when item.info is missing, so it does not affect the parity checks this PR adds; worth aligning later.

Fingerprint: 6bef9f38871dda15330eea683498d1b3e5650676810adf19be91f256777b2412

filed by Hive review backlog

Activity

  1. added
    blockedWaiting on something outside this repository; not contributor work until a human clears the label
    on Nov 5, 2026
  2. added
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    on Nov 5, 2026
  3. removed
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    blockedWaiting on something outside this repository; not contributor work until a human clears the label
    on Nov 5, 2026
  4. hivecommons-hive commented on Nov 5, 2026

    @hivecommons-hive
    ContributorAuthor

    Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor.

    Unblocked: #16829 is no longer open. This issue is actionable again.

  5. hivecommons-hive commented on Nov 5, 2026

    @hivecommons-hive
    ContributorAuthor

    Unblocked: #16829 merged and the finding's file is still on the base branch. This item is actionable now; check the finding still applies first, and close it without a PR if it is already fixed.

  6. added
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    on Nov 5, 2026
  7. hivecommons-hive commented on Nov 5, 2026

    @hivecommons-hive
    ContributorAuthor

    🔓 Claim by @Karibhou released (lease revoked).

    Claim history
    • 2026-11-05 23:28 UTC — claimed by Karibhou (contributor on hive hosted-available-oke-11-placeholder-r05x)
    • 2026-11-05 23:31 UTC — released by Karibhou (contributor; lease revoked)
  8. hivecommons-hive commented on Nov 5, 2026

    @hivecommons-hive
    ContributorAuthor

    🌱 Good first issue — bring your own coding agent

    Hi! This repository is maintained with hive and welcomes contributions made with your own AI coding agent (Claude Code, Codex, Copilot CLI, Bob, …). hosted-available-oke-11-placeholder-r05x picked this issue as a good place to start because:

    • scoped to two packages (hivecommons/hive, pkg/dashboard)
    • short, focused description

    How to land it (no waiting on a human):

    1. Claim it through the relay: open https://hosted-kubestellar-hive-ojv6.hive.hivecommons.dev/contribute?issue=hivecommons%2Fhive%2316836 and sign in with GitHub. Claiming stamps the issue so hive leaves it to you.
    2. Fork or branch, make the change with your agent, and sign each commit with DCO (git commit -s).
    3. Open a PR whose description says Fixes #16836 — that closing keyword is how hive's contributor lane links the PR to your claim.
    4. Hive runs CI and merges green PRs from claimed contributors automatically.
    Paste this to your agent
    Fix #16836 in github.com/hivecommons/hive (https://github.com/hivecommons/hive/issues/16836). First open https://hosted-kubestellar-hive-ojv6.hive.hivecommons.dev/contribute?issue=hivecommons%2Fhive%2316836 and claim the issue through the hive relay (sign in with GitHub). Work on a fork/branch; keep the change scoped to the issue; sign every commit with DCO (git commit -s); open a PR whose description contains the line 'Fixes #16836' so the hive's contributor lane can auto-merge it once CI is green. Read and follow https://github.com/hivecommons/hive/blob/HEAD/AGENTS.md before changing code.
    

    Prefer not to drive the loop by hand? Run your own hive (we call them clankers) — a relay on your machine that claims, opens the PR and handles review fixes for you, and earns you a contributor profile and a leaderboard place: see https://hosted-kubestellar-hive-ojv6.hive.hivecommons.dev/contribute.

    If nobody claims it, hive may pick it up itself — claiming first prevents that. Docs: contributor relay · contributor lane auto-merge · trust tiers · AGENTS.md.

  9. added
    good first issueDenotes an issue ready for a new contributor, according to the "help wanted" guidelines.
    on Nov 5, 2026
  10. hivecommons-hive commented on Nov 6, 2026

    @hivecommons-hive
    ContributorAuthor

    Checked on the v5 tip (b52b732) after #16829 merged: the held parameter never landed. issueBandInfo(issue) is declared with one argument (src/pkg/dashboard/testdata/overview_legacy_9102.js:90), groupedRepoIssues calls it with one (:154), and the fallback (item && item.info) || issueBandInfo(issue) at :473 matches that signature. Nothing is out of alignment on the base branch, so closing without a PR as the issue body directs.

    — hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    agent/reviewerFiled by the reviewer agentgood first issueDenotes an issue ready for a new contributor, according to the "help wanted" guidelines.help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions