Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.d/fixed-16625.md
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
- Keep a not-yet-run current-phase CI/Review chevron visibly filled (#16625)
5 changes: 5 additions & 0 deletions src/pkg/dashboard/static-src/css/tracker.css
Original file line number Diff line number Diff line change
Expand Up @@ -388,6 +388,11 @@
.ham-seg.ham-activity-track.done { background: var(--panel-strong); color: var(--green); box-shadow: none; opacity: 1; }
.ham-seg.ham-activity-track.failing { background: var(--panel-strong); color: var(--status-error); box-shadow: none; opacity: 1; }
.ham-seg.ham-activity-track.failing .ham-ico { stroke-width: 2; }
/* A not-yet-run track in the current phase (CI unknown on a 050 row,
Review queued beside running CI) keeps the same muted field as its
done / failing neighbours — the glyph alone, neutral — so the current
phase stays a visibly filled location (hivecommons/hive#16599). */
.ham-seg.ham-activity-track.todo.ham-current { background: var(--panel-strong); color: var(--muted); box-shadow: none; opacity: 1; }
/* Words without motion (checks not reported, unknown evidence, a row
parked on a person): current-phase text on a muted field, never amber. */
.ham-seg.ham-activity-track.pending { background: var(--panel-strong); color: var(--muted); box-shadow: none; opacity: 1; animation: none; }
Expand Down
5 changes: 5 additions & 0 deletions src/pkg/dashboard/static/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -1728,6 +1728,11 @@
.ham-seg.ham-activity-track.done { background: var(--panel-strong); color: var(--green); box-shadow: none; opacity: 1; }
.ham-seg.ham-activity-track.failing { background: var(--panel-strong); color: var(--status-error); box-shadow: none; opacity: 1; }
.ham-seg.ham-activity-track.failing .ham-ico { stroke-width: 2; }
/* A not-yet-run track in the current phase (CI unknown on a 050 row,
Review queued beside running CI) keeps the same muted field as its
done / failing neighbours — the glyph alone, neutral — so the current
phase stays a visibly filled location (hivecommons/hive#16599). */
.ham-seg.ham-activity-track.todo.ham-current { background: var(--panel-strong); color: var(--muted); box-shadow: none; opacity: 1; }
/* Words without motion (checks not reported, unknown evidence, a row
parked on a person): current-phase text on a muted field, never amber. */
.ham-seg.ham-activity-track.pending { background: var(--panel-strong); color: var(--muted); box-shadow: none; opacity: 1; animation: none; }
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -211,7 +211,7 @@
if (cell.dataset.routeState?.split(' ').includes('active')) {
assert(cell.classList.contains('ham-current'), name + 'current phase remains highlighted independently of work');
const style = getComputedStyle(cell);
assert(Number(style.opacity) >= 0.9 && style.backgroundColor !== 'rgba(0, 0, 0, 0)' && style.backgroundColor !== 'transparent', name + 'queued/unknown/assigned/completed current tracks retain a visible steady fill');
assert(Number(style.opacity) >= 0.9 && style.backgroundColor !== 'rgba(0, 0, 0, 0)' && style.backgroundColor !== 'transparent', name + 'queued/unknown/assigned/completed current tracks retain a visible steady fill: ' + JSON.stringify({ cls: cell.className, track: cell.dataset.track, state: cell.dataset.activityState, bg: style.backgroundColor, opacity: style.opacity, label: cell.getAttribute('aria-label')?.slice(0, 80) }));
}
if (cell.dataset.track) {
// CI / Review lanes are chevrons like their neighbours: same notch
Expand Down
Loading