Repository navigation
🐛 fix(ci): report unavailable DCO enumeration without weakening admission - #16442
Conversation
…sion Distinguish the authoritative DCO provider's incomplete-history UNKNOWN diagnostic from a sign-off failure while keeping both admission paths closed. Show an operator-directed Actions summary and retain the current App/head/provenance requirements without retries or status substitution. Add a read-only full-history query reproducer, regression fixtures beyond the REST ceiling, and a recovery runbook linking the observed failures and the unmerged provider-side repair candidate. Hive-Run: hivecommons#16404 Hive-Plan: dco-provider-diagnosis-and-reporting Hive-Spec: hivecommons#16404#maintainer-fourth-direction Signed-off-by: thatguywob <thatguywob@users.noreply.github.com>
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of No conflicting open PRs or same-file overlaps were found. |
0ac19df
|
There was a problem hiding this comment.
docs-currency review (head 0ac19dfa3) — operator-facing text matches the code: the UNKNOWN classification order (native-queue-policy.cjs:93-98), the fail-closed DCO: failure fallback, the job-summary write in native-queue-policy.yml, and both relative links resolve under check-docs-links.py src/docs / docs. No blocker.
One discoverability gap, advisory:
docs/operations/dco-provider-unavailable.mdis a new recovery runbook in a brand-newdocs/operations/directory, but it is not linked fromsrc/docs/documentation-map.md, anddocs-index-reminder.ymlonly scans top-levelsrc/docs/*.md, so nothing will flag it. The existing recovery runbooks are indexed under "Recovery, moves, and fleet health" (documentation-map.md:72-73), and root-docs/pages are already linked from the map via../../docs/...(e.g.documentation-map.md:132). Suggested addition after line 73:
- [Agent backend-auth failure recovery runbook](backend-auth-recovery-runbook.md) — identify affected agents, re-authenticate the backend, and clear recovered fleet reports.
- [DCO provider unavailable runbook](../../docs/operations/dco-provider-unavailable.md) — what `native-queue-policy` reports when App 1861 cannot enumerate a large PR's commit list (verdict UNKNOWN), the read-only enumeration reproducer, and how the provider operator recovers and re-runs the authoritative check.
— hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor. Review findings from Routing to a maintainer, not blocking on code. This PR carries
I found nothing wrong with the change itself; whether a workflow/admission-policy edit from outside OWNERS should land is the decision. Review findings from Style/maintainability review (head
Minor: |
|
Needs a decision, not a merge:
Head: verdict requires_human @0ac19df, 65/68 checks green, 3 pending, DCO yes, soak 0s of 10m0s. How to release it:
Clear the cause and the hive re-evaluates on its next pass; the stage moves to Updated 2026-11-03 21:17 UTC. |
clubanderson
left a comment
There was a problem hiding this comment.
Owner decision: approve this exact head for the scoped repository diagnostics, read-only reproducer and recovery guidance requested in #16404. Reviewed the complete eight-file delta. Provider, exact-head and completed-status checks still precede UNKNOWN classification; UNKNOWN remains a failed admission result, never substituted success or PendingEvidence. The trusted-base workflow keeps the original permission and checkout boundaries. The reproducer only reads complete history, rejects head/base/count drift and does not publish verdicts. The upstream repair is correctly identified as an unmerged candidate, not an established cause or deployment. This is a one-PR approval, not a blanket author trust grant, App permission grant, DCO exception or approval to merge #16378. Provider recovery and genuine current-head App1861 success remain outstanding. The documentation-map discoverability suggestion is advisory follow-through.
|
/hive decision approve Scoped owner approval is recorded on exact head 0ac19df for these diagnostics and read-only recovery tools. The fork/non-OWNERS origin may proceed through the normal reviewed path for this PR; do not grant blanket author trust or change any admission/protection/permission rules. UNKNOWN still fails admission. This does not resolve the external provider fault or authorize #16378 to merge. Keep #16404 open for genuine provider-side recovery. Preserve all remaining native review and merge requirements. |
|
LGTM label has been added. DetailsGit tree hash: fd7cb65e1e4655ae432b05d4dc63657cff833b13 |
|
/approve Maintainer sign-off (delegate for @clubanderson) on exact head
Scope of this approval is exactly what the owner recorded in #16442 (comment): UNKNOWN still fails admission; no blanket author trust; this does not unblock #16378 by itself (a v6-base PR checks out and runs v6's |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: clubanderson The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Ready for a human merge: verdict requires_human @0ac19df, approved by @clubanderson, 68/68 checks green, DCO yes, soak 10m0s elapsed. Blocked only by The hive never approves on your behalf: Updated 2026-11-03 20:39 UTC. |
|
/hold Holding briefly while I verify a cross-branch effect: this workflow runs from the default branch (v5) for v6-base PRs too, but checks out the base branch (v6) for scripts — v6 does not have |
|
Pushed one maintainer commit (
No change to the policy script, reproducer, tests or docs; the UNKNOWN classification and fail-closed behaviour are exactly as reviewed at |
clubanderson
left a comment
There was a problem hiding this comment.
Maintainer approval (delegate for @clubanderson) on exact head 52c81fc: same scope as the owner's approval of 0ac19df plus the two-line defensive yml guard for v6-base runs. UNKNOWN still fails admission; no permission/protection/trust change; does not by itself unblock #16378.
|
LGTM label has been added. DetailsGit tree hash: 833281986138ca132fe5ce9a02fc1c752039c736 |
52c81fc to
0ac19df
Compare
|
Reverted my commit: the branch is back at exactly Plan instead, so this can merge unchanged: land the policy-script/test files on v6 first in a separate v6 PR (so v6's |
…script (#16467) Backport of the policy-script half of #16442 (head 0ac19df) to v6: native-queue-policy.cjs gains ProviderUnavailable and the narrow dcoEnumerationUnavailable classifier (applied only after the App-1861 / exact-head / completed checks; still fails admission), its regression tests, the read-only diagnose-dco-provider reproducer and its tests, and the operator runbook. Why v6 first: .github/workflows/native-queue-policy.yml exists only on v5 and is the default-branch definition GitHub uses for every pull_request_target run, while the job checks out the PR base branch's scripts. Once #16442's yml lands on v5 it imports ProviderUnavailable from the checked-out script; on a v6 base that must exist, otherwise 'error instanceof undefined' throws inside the catch and breaks the bounded wait for pending evidence on every v6-base PR. Landing this first keeps v6-base admission intact and lets v6 report the ceiling case as UNKNOWN honestly. No workflow, permission, protection or trust change. Refs #16404. Signed-off-by: clubanderson <andy@clubanderson.com>
|
/hold cancel v6 now carries the policy script with |
|
@thatguywob this PR is back in your court ( Failing checks:
Reply here or push a new head to this branch (same sign-off); CI and the review swarm re-run automatically and the PR returns to the normal path. Your relay could not take this as a |
|
/lgtm (prow dropped the label when the branch was reset to |
|
LGTM label has been added. DetailsGit tree hash: fd7cb65e1e4655ae432b05d4dc63657cff833b13 |
🔒 Hold-gate integrity: branch changed while hold-gated — fresh review requiredThis PR's branch moved while it sat hold-gated: the head recorded when the hold was applied was The current commit list could not be compared against the snapshot; treat the entire branch as unreviewed. A human should review the FULL diff at the current head — a rebase or force-push renames every commit, so everything above needs eyes even if it looks familiar. Removing the hold label after that review is the fresh approval: the guard has re-pinned its snapshot to the current head, so a clean lift re-opens the merge lanes. |
|
Hold-gate integrity: acknowledged. The branch moved from |
…the top-up Plain merge of origin/v6 (5c963b7) into the v5->v6 top-up; the only conflicts were the additive export/import lists in .github/scripts/native-queue-policy.cjs and its test, resolved to the union, which is byte-identical to v5 after #16442 (ed048ec). Signed-off-by: clubanderson <andy@clubanderson.com>
When App 1861 cannot enumerate a large PR's complete history,
native-queue-policycurrently reports onlyDCO: failure. This change reports provider unavailable / verdict UNKNOWN in the job error and Actions summary, while keeping admission failed. It retains the authoritative current-head success requirement and makes no permission or protection changes.Following the maintainer's fourth direction, this also adds a read-only full-history reproducer comparing the provider's 100-parent selection with the proposed 2-parent selection, plus a recovery runbook. The runbook links both observed #16378 failures, traces the provider fallback, and identifies dcoapp/app#339 as an unmerged candidate, not a verified fix. It explains how the provider operator obtains the hidden exception and reruns the authoritative check after recovery, preserving merge ancestry.
Refs #16404 — repository diagnostics, reproducer and recovery guidance are implemented here; provider-side enumeration repair/deployment and a genuine current-head App-1861 DCO success remain outstanding. This PR does not unblock #16378 by itself.
Validation:
AGENTS.md; CI is the execution verdict.git diff --checkpassed.— hive: backend=codex
🐝 Hive Agent:
contributor| SHA:0ac19dfa3