Skip to content

🌱 chore(ci): port DCO provider runbook relocation and policy constants to v6 - #16478

Merged
hivecommons-hive[bot] merged 1 commit into
v6from
scanner/fix-16404-v6-parity
Nov 4, 2026
Merged

hivecommons-hive[bot] merged 1 commit into
v6from
scanner/fix-16404-v6-parity

Conversation

@hivecommons-hive

Copy link
Copy Markdown
Contributor

Ports the script/test and docs half of #16468 (merged on v5) to v6, the same way #16467 ported #16442.

  • .github/scripts/native-queue-policy.cjs: hoists the DCO provider diagnostic literals into named constants (DCO_ENUMERATION_SUMMARY_PREFIX, DCO_ENUMERATION_SUMMARY_FALLBACK, DCO_PROVIDER_UNAVAILABLE_TEXT, DCO_PROVIDER_RUNBOOK) and exports them. Classification is unchanged: UNKNOWN still fails admission.
  • .github/scripts/native-queue-policy.test.cjs: the test uses those constants and asserts the message prefix and runbook path.
  • Moves the runbook from docs/operations/dco-provider-unavailable.md to src/docs/operator-reference/dco-provider-unavailable.md, links it from src/docs/operator-reference.md and src/docs/native-merge-queue.md, and adds the matching changelog fragment (the same file as on v5).

v5 and v6 now match for these files, so the v5 pull_request_target workflow sees the same exports from either base branch.

Refs #16404 (remaining: external DCO App enumeration ceiling dcoapp/app#339; workflow yml decoupling needs an operator push — diff posted on the issue)

— hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

…o v6

Ports the v5 change from #16468 so v6's native-queue-policy script exports
the same named DCO provider constants and links the relocated runbook.

Refs #16404

Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Nov 3, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign hanthor for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 3, 2026
@hivecommons-hive

hivecommons-hive Bot commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor Author

Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor.

hive/awaiting-ci: CI pending — sweep will merge when green.


🐝 Hive Agent: scanner | Instance: hosted-available-oke-11-placeholder-r05x | SHA: unknown

— hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

Review findings from reviewer (folded here because this head already carries its hive review):

Looks correct to me as a v6 port of #16468.

Verified at fd56d16: git diff origin/v5 fd56d16 -- .github/scripts/native-queue-policy.cjs .github/scripts/native-queue-policy.test.cjs src/docs/operator-reference/dco-provider-unavailable.md changelog.d/changed-dco-provider-runbook-location.md is empty — all four are byte-identical to v5, so the pull_request_target workflow sees the same exports from either base. docs/operations/dco-provider-unavailable.md is gone from the tree, native-queue-policy.cjs has no remaining docs/operations reference, and the two link lines added to src/docs/native-merge-queue.md:374-378 and src/docs/operator-reference.md:138-139 match v5's :376 and :126-127. Classification in dcoEnumerationUnavailable (native-queue-policy.cjs:50-55) is unchanged — same prefix/fallback strings, now named.

Evidence bundle `#16478fd56d16` sha256:7efea859115500b644a53813d6301d06edcfa33343c3f8ad25073bd175fdc337 — download from the dashboard or `hivectl review evidence #16478`.

@github-actions

github-actions Bot commented Nov 4, 2026

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v6

Conflicts are checked with every PR merged onto the current tip of v6, so a PR that only needs a rebase is not reported as conflicting with its siblings.

No conflicting open PRs or same-file overlaps were found.

@hivecommons-hive hivecommons-hive Bot added author/hive This repository's own hive (the App or one of its agent lanes) authored this PR dco All commits are DCO signed-off role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Nov 4, 2026

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read this against the merged v5 source (#16468) and the v6 tree at fd56d16; looks correct to me as a port.

What I verified

  • .github/scripts/native-queue-policy.cjs and .test.cjs hunks are byte-identical to #16468 — same four constants, same export list, dcoEnumerationUnavailable() (native-queue-policy.cjs:50-55) still matches the same prefix/fallback strings, so classification is unchanged.
  • The one intentional divergence from v5 is src/docs/native-merge-queue.md:374-378: v5 already had the "DCO provider unavailable" bullet and only re-pointed its link; v6 lacked the bullet, so this PR adds it with the new path. That is the right adaptation, not drift.
  • No remaining references to docs/operations/dco-provider-unavailable.md anywhere in the v6 tree after the rename; both new links (operator-reference.md:139, native-merge-queue.md:376) resolve to the moved file.
  • node --test .github/scripts/native-queue-policy.test.cjs on the PR head: 24/24 pass — the same command .github/workflows/native-queue-policy.yml:36 runs.

Refs #16404 is appropriate here: the remainder (DCO App enumeration ceiling, workflow decoupling) is outside this port, as the body states.

— hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive
hivecommons-hive Bot merged commit bc48887 into v6 Nov 4, 2026
87 of 91 checks passed
@kubestellar-prow
kubestellar-prow Bot deleted the scanner/fix-16404-v6-parity branch November 4, 2026 00:15
@github-actions

github-actions Bot commented Nov 4, 2026

Copy link
Copy Markdown
Contributor

Thank you for your contribution! Your PR has been merged.

We'd love to hear how your experience was: share feedback

@hivecommons-hive hivecommons-hive Bot removed role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Nov 4, 2026
clubanderson added a commit that referenced this pull request Nov 4, 2026
Integrates #16478, #16498 and #16505, which landed on v6 after the merge
was prepared. tracker.css: kept v5's title-line grid (#16454..#16494,
which supersedes #16498's flex-only title line and already keeps cap
pills off the PR title); static/index.html regenerated from static-src.

Signed-off-by: Andrew Anderson <andy@clubanderson.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author/hive This repository's own hive (the App or one of its agent lanes) authored this PR copilot dco All commits are DCO signed-off dco-signoff: yes Indicates the PR's author has signed the DCO. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants