Repository navigation
🌱 chore(ci): port DCO provider runbook relocation and policy constants to v6 - #16478
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor. hive/awaiting-ci: CI pending — sweep will merge when green. 🐝 Hive Agent: — hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88 Review findings from Looks correct to me as a v6 port of #16468. Verified at |
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of No conflicting open PRs or same-file overlaps were found. |
There was a problem hiding this comment.
Read this against the merged v5 source (#16468) and the v6 tree at fd56d16; looks correct to me as a port.
What I verified
.github/scripts/native-queue-policy.cjsand.test.cjshunks are byte-identical to #16468 — same four constants, same export list,dcoEnumerationUnavailable()(native-queue-policy.cjs:50-55) still matches the same prefix/fallback strings, so classification is unchanged.- The one intentional divergence from v5 is
src/docs/native-merge-queue.md:374-378: v5 already had the "DCO provider unavailable" bullet and only re-pointed its link; v6 lacked the bullet, so this PR adds it with the new path. That is the right adaptation, not drift. - No remaining references to
docs/operations/dco-provider-unavailable.mdanywhere in the v6 tree after the rename; both new links (operator-reference.md:139,native-merge-queue.md:376) resolve to the moved file. node --test .github/scripts/native-queue-policy.test.cjson the PR head: 24/24 pass — the same command.github/workflows/native-queue-policy.yml:36runs.
Refs #16404 is appropriate here: the remainder (DCO App enumeration ceiling, workflow decoupling) is outside this port, as the body states.
— hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
Thank you for your contribution! Your PR has been merged. We'd love to hear how your experience was: share feedback |
Integrates #16478, #16498 and #16505, which landed on v6 after the merge was prepared. tracker.css: kept v5's title-line grid (#16454..#16494, which supersedes #16498's flex-only title line and already keeps cap pills off the PR title); static/index.html regenerated from static-src. Signed-off-by: Andrew Anderson <andy@clubanderson.com>
Ports the script/test and docs half of #16468 (merged on v5) to v6, the same way #16467 ported #16442.
.github/scripts/native-queue-policy.cjs: hoists the DCO provider diagnostic literals into named constants (DCO_ENUMERATION_SUMMARY_PREFIX,DCO_ENUMERATION_SUMMARY_FALLBACK,DCO_PROVIDER_UNAVAILABLE_TEXT,DCO_PROVIDER_RUNBOOK) and exports them. Classification is unchanged: UNKNOWN still fails admission..github/scripts/native-queue-policy.test.cjs: the test uses those constants and asserts the message prefix and runbook path.docs/operations/dco-provider-unavailable.mdtosrc/docs/operator-reference/dco-provider-unavailable.md, links it fromsrc/docs/operator-reference.mdandsrc/docs/native-merge-queue.md, and adds the matching changelog fragment (the same file as on v5).v5 and v6 now match for these files, so the v5
pull_request_targetworkflow sees the same exports from either base branch.Refs #16404 (remaining: external DCO App enumeration ceiling dcoapp/app#339; workflow yml decoupling needs an operator push — diff posted on the issue)
— hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88