Skip to content

[scanner] native-queue-policy cannot pass when the DCO app hits its 250-commit ceiling (forward-merge PRs) #16404

Closed

Description

@hivecommons-hive

Problem

native-queue-policy (.github/scripts/native-queue-policy.cjs, evidenceForHead) requires the probot DCO check-run to conclude success. On PRs with more than 250 commits the DCO app cannot evaluate at all: its check-run reports

"GitHub returned 250 commits from the REST API, so the app attempted to retrieve the full list through GraphQL … That fallback did not complete, so the DCO verdict is unknown."

and concludes failure. native-queue-policy then fails with Error: DCO: failure even though every commit carries Signed-off-by: and the prow dco commit status on the same head is success.

Observed on #16378 (v5→v6 forward-merge, 250 commits) on two consecutive heads (96ba258f, 1989d20a): job 125732142573 fails at native-queue-policy.cjs:78 solely on the DCO verdict. Forward-merge PRs of this size will hit this every time, and the only remedy today is an owner retry of the DCO app or a manual merge past the gate.

Decision needed

The script deliberately refuses to impersonate or substitute the probot DCO proof ("Policy proofs, especially external DCO, must have actually succeeded"). Relaxing that is a trust-posture change, so this is parked for a maintainer ruling rather than changed by the hive.

Options:

  • A. In native-queue-policy.cjs, when the DCO check-run's output.summary says the verdict could not be evaluated (commit-list ceiling), accept the prow dco commit status (success, from the kubestellar-prow context) on the same head as the DCO proof. Narrow: only the "could not be evaluated" case, never a real DCO failure.
  • B. Keep the gate as is; document that forward-merge PRs over 250 commits must be split (or batched more often) so the DCO app can evaluate them.
  • C. Keep the gate as is and have the hive re-request the DCO check-run on such PRs (requires granting the hive App checks:write, which it does not have today).

Risk: governance

Refs #16378

— hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

Activity

  1. added
    agent/scannerCreated or modified by the scanner agent
    ciApproved by a Hive merger/owner for auto-merge on green CI
    stage/045-needs-decisionIssue parked on a person: needs-human or a maintainer decision is owed before the hive picks it up
    on Nov 3, 2026
  2. added
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    on Nov 3, 2026
  3. hivecommons-hive commented on Nov 3, 2026

    @hivecommons-hive
    ContributorAuthor

    What to reply

    • /hive approve: go with the recommendation
    • /hive decision <your instructions>: go ahead, following your instructions
    • /hive help: show these again

    If what this issue waited on has been done (a merged fix, or an action taken outside this repository), a maintainer can reply /fixed to close it as completed; Hive clears its park labels.

    Only a maintainer with write access can un-park; everything else is ignored. Full command reference: https://github.com/hivecommons/hive/blob/v5/src/docs/maintainer-commands.md.

  4. clubanderson commented on Nov 3, 2026

    @clubanderson
    Member

    /hive decision Choose a fourth direction: preserve authoritative, complete-history DCO verification and repair the actual provider enumeration path. Do not adopt A: a lowercase status name is not proven equivalent to App1861 policy/producer, and parsing an error message must not manufacture a passing DCO proof. Do not adopt B as a forced ancestry rewrite or pretend 250 is a fundamental Git limit; the failure is the unsuccessful GraphQL fallback. Do not adopt C or request checks:write; current App permissions remain unchanged. Produce a minimal full-history reproducer and diagnose the genuine DCO provider fallback, retain failure/UNKNOWN distinctly, and give the operator a supported provider-side recovery path. Repository UI/CI reporting should identify provider-unavailable admission rather than instructing an author to change otherwise-green code. Actual current-head DCO success remains required; no copied statuses, empty commits, blind retry loops or gate/protection weakening. Preserve true merge ancestry in #16378. This direction authorizes investigation and accurate reporting, not a bypass or a source-change instruction to the PR author.

  5. added
    stage/010-actionableTriaged; eligible for the hive to pick up
    and removed
    stage/045-needs-decisionIssue parked on a person: needs-human or a maintainer decision is owed before the hive picks it up
    on Nov 3, 2026
  6. hivecommons-hive commented on Nov 3, 2026

    @hivecommons-hive
    ContributorAuthor

    Un-parked by @clubanderson. Decision: Choose a fourth direction: preserve authoritative, complete-history DCO verification and repair the actual provider enumeration path. Do not adopt A: a lowercase status name is not proven equivalent to App1861 policy/producer, and parsing an error message must not manufacture a passing DCO proof. Do not adopt B as a forced ancestry rewrite or pretend 250 is a fundamental Git limit; the failure is the unsuccessful GraphQL fallback. Do not adopt C or request checks:write; current App permissions remain unchanged. Produce a minimal full-history reproducer and diagnose the genuine DCO provider fallback, retain failure/UNKNOWN distinctly, and give the operator a supported provider-side recovery path. Repository UI/CI reporting should identify provider-unavailable admission rather than instructing an author to change otherwise-green code. Actual current-head DCO success remains required; no copied statuses, empty commits, blind retry loops or gate/protection weakening. Preserve true merge ancestry in #16378. This direction authorizes investigation and accurate reporting, not a bypass or a source-change instruction to the PR author.

    stage/045-needs-decision is cleared when present and approved-direction is applied; any hold label is left exactly as it was.

  7. hivecommons-hive commented on Nov 3, 2026

    @hivecommons-hive
    ContributorAuthor

    Good first issue — superseded: hosted-available-oke-11-placeholder-r05x started working on this issue itself (claimed-by-hive, 2026-11-03T22:07:52Z), so the good first issue label has been removed. Thanks for looking! Other issues open to new contributors are listed on the relay page: https://hosted-kubestellar-hive-ojv6.hive.hivecommons.dev/contribute

  8. added
    good first issueDenotes an issue ready for a new contributor, according to the "help wanted" guidelines.
    on Nov 3, 2026
  9. hivecommons-hive commented on Nov 3, 2026

    @hivecommons-hive
    ContributorAuthor

    🔒 Claimed by @thatguywob (contributor on hive hosted-available-oke-11-placeholder-r05x). The claim lasts 30m0s without activity and renews while the work continues. Reply /unclaim to release, or /claim to take it over if you outrank the holder.

  10. added
    stage/020-claimedClaimed by the scanner or a relay contributor
    and removed
    stage/010-actionableTriaged; eligible for the hive to pick up
    on Nov 3, 2026
  11. 33 remaining items

  12. hivecommons-hive commented on Nov 3, 2026

    @hivecommons-hive
    ContributorAuthor

    Un-parked by @clubanderson. Decision: Approved — continue under the fourth direction above. Finish every in-repo remainder you can push (#16468 follow-ups). For the admission-job test-step decoupling in .github/workflows/native-queue-policy.yml, which the App cannot push, prepare the exact diff on a branch or in a comment here with a one-line rationale so an operator can push it; do not re-park for that alone. The external DCO App enumeration ceiling (dcoapp/app#339) stays tracked here as an external dependency.

    stage/045-needs-decision is cleared when present and approved-direction is applied; any hold label is left exactly as it was. needs-human cleared: your command is the human input it waited for, so the issue returns to the agent queue; add hold to keep agents off it.

    Recorded from the hive dashboard.

  13. hivecommons-hive commented on Nov 4, 2026

    @hivecommons-hive
    ContributorAuthor

    Operator patch: decouple the admission job from the DCO reproducer tests (.github/workflows/native-queue-policy.yml, base v5)

    Rationale: the required native-queue-policy admission job should test only the policy script it executes, so it moves the read-only reproducer self-tests to a separate, non-required dco-provider-reproducer job; admission semantics are unchanged (UNKNOWN still fails).

    The App cannot push workflow files. Apply on a v5 checkout with git apply (save the block below as yml.diff, then run git apply yml.diff):

    diff --git a/.github/workflows/native-queue-policy.yml b/.github/workflows/native-queue-policy.yml
    index 08420d8e4..829fd3cb8 100644
    --- a/.github/workflows/native-queue-policy.yml
    +++ b/.github/workflows/native-queue-policy.yml
    @@ -33,7 +33,7 @@ jobs:
               ref: ${{ github.event.merge_group.base_sha || format('refs/heads/{0}', github.event.pull_request.base.ref) }}
               persist-credentials: false
           - name: Test policy behavior
    -        run: node --test .github/scripts/native-queue-policy.test.cjs .github/scripts/diagnose-dco-provider.test.cjs
    +        run: node --test .github/scripts/native-queue-policy.test.cjs
           - name: Validate exact-head evidence (bounded wait for PR providers)
             uses: actions/github-script@3a2844b7e9c422d3c10d287c895573f7108da1b3 # v9.0.0
             with:
    @@ -59,3 +59,17 @@ jobs:
                     await new Promise(resolve => setTimeout(resolve, intervalMs));
                   }
                 }
    +
    +  dco-provider-reproducer:
    +    name: dco-provider-reproducer
    +    # Self-tests for the read-only operator reproducer. Kept out of the
    +    # admission job so they can neither pass nor block admission.
    +    runs-on: ubuntu-latest
    +    timeout-minutes: 5
    +    steps:
    +      - uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
    +        with:
    +          ref: ${{ github.event.merge_group.base_sha || format('refs/heads/{0}', github.event.pull_request.base.ref) }}
    +          persist-credentials: false
    +      - name: Test DCO provider reproducer
    +        run: node --test .github/scripts/diagnose-dco-provider.test.cjs

    🐝 Hive Agent: scanner | Instance: hosted-available-oke-11-placeholder-r05x | SHA: unknown

    — hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

  14. hivecommons-hive commented on Nov 4, 2026

    @hivecommons-hive
    ContributorAuthor

    PR #16478 covers this issue: #16478

    GitHub only shows its linked-PR icon for closing-keyword PRs that target the repository default branch; this PR targets v6, so Hive cannot make GitHub display that icon for this issue.

  15. hivecommons-hive commented on Nov 4, 2026

    @hivecommons-hive
    ContributorAuthor

    Fixed by #16467 (merged 5c963b7). Closing. Reply /reopen if the problem persists.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    agent/scannerCreated or modified by the scanner agentapproved-directionciApproved by a Hive merger/owner for auto-merge on green CIhelp wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.hive/partially-addressedA merged PR addressed only part of this issue; remainder still actionablehive/verified-openHive verified that a likely/already-done claim did not finish this issue; keep open for more work

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions