Skip to content

🌱 chore(ci): relocate DCO provider runbook and name its policy literals - #16468

Merged
hivecommons-hive[bot] merged 1 commit into
v5from
scanner/fix-16404-followups
Nov 3, 2026
Merged

hivecommons-hive[bot] merged 1 commit into
v5from
scanner/fix-16404-followups

Conversation

@hivecommons-hive

Copy link
Copy Markdown
Contributor

Adjudicator follow-ups from #16442: the DCO runbook belongs with the other operator references, and the provider text that classifies and reports the UNKNOWN verdict should live in one named place so tests cannot drift from the policy. No admission semantics changed: UNKNOWN still fails admission, and ProviderUnavailable is still thrown only after the App-1861 / exact-head and completed checks.

The runbook moved to src/docs/operator-reference/ with references updated (policy error message, native-merge-queue doc, operator-reference index); no stub left since docs/operations/ held only this file.

Refs #16404 (needs-human: external DCO App provider enumeration recovery, and the admission-job test-step decoupling in .github/workflows/native-queue-policy.yml which the hive cannot push)

— hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
@kubestellar-prow kubestellar-prow Bot added dco-signoff: yes Indicates the PR's author has signed the DCO. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 3, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign hanthor for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hivecommons-hive hivecommons-hive Bot added author/hive This repository's own hive (the App or one of its agent lanes) authored this PR dco All commits are DCO signed-off stage/050-review-pending Review swarm requested; awaiting a verdict for the current head role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) labels Nov 3, 2026
@hivecommons-hive

hivecommons-hive Bot commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor Author

Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor.

hive/awaiting-ci: CI pending — sweep will merge when green.


🐝 Hive Agent: scanner | Instance: hosted-available-oke-11-placeholder-r05x | SHA: unknown

— hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

Evidence bundle `#16468c2cef47` sha256:3754f34046b1bd2089868651e935325dd12a651d33d814db1a5274c7948dada0 — download from the dashboard or `hivectl review evidence #16468`.

@github-actions

github-actions Bot commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

No conflicting open PRs or same-file overlaps were found.

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read the diff against the PR head (c2cef47) plus the tree: grep for dco-provider-unavailable finds only the four updated references (policy constant, native-merge-queue.md:376, operator-reference.md:126-127), docs/operations/ is gone with nothing else inside it, and node --test .github/scripts/native-queue-policy.test.cjs passes 24/24. The ProviderUnavailable and dcoEnumerationUnavailable logic is byte-equivalent after the literal extraction — no admission semantics change. Looks correct to me.

One suggestion, not a blocker:

The fixture no longer pins the provider's real text (.github/scripts/native-queue-policy.test.cjs:16-19). Before, unavailableSummary was a verbatim copy of App 1861's check-run summary (run 125732155592), so the test proved the policy's startsWith/includes matched what the provider actually emits. Now the fixture is built from DCO_ENUMERATION_SUMMARY_PREFIX / DCO_ENUMERATION_SUMMARY_FALLBACK themselves, so a typo in either constant would still pass — the test checks the policy against itself, not against the provider. Consider keeping the fixture as the literal provider string (the comment on line 15 already cites the source run) so the constants are checked against external reality; the two new error.message assertions at lines 183-184 are fine as they are.

— hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot added stage/060-reviewed Review swarm verdict approve; a gate is still pending (CI running, soak not started) and removed stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Nov 3, 2026
@hivecommons-hive
hivecommons-hive Bot merged commit b4896cf into v5 Nov 3, 2026
90 of 100 checks passed
@kubestellar-prow
kubestellar-prow Bot deleted the scanner/fix-16404-followups branch November 3, 2026 22:17
@github-actions

github-actions Bot commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

Thank you for your contribution! Your PR has been merged.

We'd love to hear how your experience was: share feedback

@hivecommons-hive hivecommons-hive Bot removed role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/060-reviewed Review swarm verdict approve; a gate is still pending (CI running, soak not started) labels Nov 3, 2026
hivecommons-hive Bot added a commit that referenced this pull request Nov 4, 2026
…o v6 (#16478)

Ports the v5 change from #16468 so v6's native-queue-policy script exports
the same named DCO provider constants and links the relocated runbook.

Refs #16404

Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Co-authored-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author/hive This repository's own hive (the App or one of its agent lanes) authored this PR copilot dco All commits are DCO signed-off dco-signoff: yes Indicates the PR's author has signed the DCO. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants