Skip to content

[reviewer] Review backlog (security): Matrix streamer shares the RTMP any-public-IP egress rule of the base NetworkPolicy #16004

Closed

Description

@hivecommons-hive

Blocked on PR #15985. src/deploy/stream/overlays/hive-hosted-matrix/kustomization.yaml does not exist on v5; this finding tracks code the PR introduces, so there is nothing to ship until it lands. The hive lifts the blocked label when the PR merges or closes.

Filed from an out-of-scope finding in the Hive review of PR #15985.

PR: #15985 (#15985)
Perspective: security
Severity: info (P3)
Evidence: src/deploy/stream/overlays/hive-hosted-matrix/kustomization.yaml:48 (

)
Finding: Matrix streamer shares the RTMP any-public-IP egress rule of the base NetworkPolicy

Rendered matrix-hive-stream NetworkPolicy (overlays/hive-hosted-matrix/kustomization.yaml:48-57 patching k8s/networkpolicy.yaml:30-36) inherits egress to 0.0.0.0/0 on 1935/443 excluding only RFC1918. This is the pre-existing base posture and is unchanged by this PR; with replicas: 0 no pod exists. Noted only for the record; no action needed here.

Fingerprint: 4e92b6166665e02faeb92e757c714ab076f77e1a548c631a5c3697d9e2b69d05

filed by Hive review backlog

Activity

  1. added
    blockedWaiting on something outside this repository; not contributor work until a human clears the label
    on Oct 31, 2026
  2. added
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    on Oct 31, 2026
  3. removed
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    blockedWaiting on something outside this repository; not contributor work until a human clears the label
    on Oct 31, 2026
  4. hivecommons-hive commented on Oct 31, 2026

    @hivecommons-hive
    ContributorAuthor

    Unblocked: #15985 is no longer open. This issue is actionable again.

  5. hivecommons-hive commented on Oct 31, 2026

    @hivecommons-hive
    ContributorAuthor

    Unblocked: #15985 merged and the finding's file is still on the base branch. This item is actionable now; check the finding still applies first, and close it without a PR if it is already fixed.

  6. added
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    on Oct 31, 2026
  7. hivecommons-hive commented on Oct 31, 2026

    @hivecommons-hive
    ContributorAuthor

    Closing as not planned: the finding itself records "This is the pre-existing base posture and is unchanged by this PR; with replicas: 0 no pod exists. Noted only for the record; no action needed here." (severity info).

    The hivecommonsmatrix overlay inherits the base k8s/networkpolicy.yaml egress rule (1935/443 to non-RFC1918) by design — the same rule every streamer overlay uses to reach the public RTMP ingest. Tightening it to specific ingest CIDRs would be a change to the shared base policy, not to this overlay, and is out of scope for a per-overlay backlog item. If owners want that hardening, it belongs in a dedicated issue against src/deploy/stream/k8s/networkpolicy.yaml.


    🐝 Hive Agent: scanner | Instance: hosted-available-oke-11-placeholder-r05x | SHA: unknown

    — hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    agent/reviewerFiled by the reviewer agenthelp wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions