Skip to content

✨ feature(stream): disabled-by-default hivecommonsfleet public-safe broadcast - #15998

Merged
clubanderson merged 1 commit into
hivecommons:v5from
Karibhou:feat/hivecommonsfleet-stream
Oct 31, 2026
Merged

clubanderson merged 1 commit into
hivecommons:v5from
Karibhou:feat/hivecommonsfleet-stream

Conversation

@Karibhou

Copy link
Copy Markdown
Contributor

Implements the deployment side of #15966, the fifth implementation child of RFC #15861 (proposed by @hanthor, cc @hanthor).

Refs #15966 — partial on purpose. Still to do: the hub's dedicated public-safe view route (with a hub-side test that private rows are omitted). It needs the Fleet activity data and page from #15951 → #15963 → #15964 → #15965, and none of those have landed yet. The issue should stay open until that route ships.

What shipped in this PR

  • src/deploy/stream/fleet/: a standalone Kustomize base for twitch.tv/hivecommonsfleet. It has its own namespace (hive-stream-fleet), Deployment, ConfigMap and NetworkPolicy. Its stream-key Secret is referenced by name only (twitch-stream-hivecommonsfleet; secret.yaml is a template). It shares no resource with k8s/ or overlays/. Egress is limited to DNS and public 443/1935, with no in-cluster rule. It reuses the existing hive-stream image.
  • Disabled by default, enforced three ways:
    • replicas: 0;
    • STREAM_ENABLED: "false";
    • STREAM_PROFILE=public-safe, which runs the new public-safe-gate.sh from entrypoint.sh before any process starts. The gate refuses unless STREAM_ENABLED=true, PUBLIC_SAFE_POLICY_ACK=hivecommonsfleet-public-safe-v1, DASHBOARD_TOKEN is unset, the source is a real https:// origin with no CHANGE-ME placeholder, and TWITCH_STREAM_KEY is installed. A dry run is allowed only with STREAM_OUTPUT=null or an absolute local *.flv path; rtmp://…/x.flv and similar are refused. With the profile unset, the gate is a no-op.
  • Public-safe by construction on the streamer side. In this profile the auth proxy refuses a token, strips any browser Authorization/Cookie header and drops Set-Cookie. The kiosk can therefore only render what the hub serves to an anonymous visitor. There is no viewer account whose per-user fleet visibility could leak onto Twitch.
  • The authproxy tests now run in the image build stage. stream-image.yml's PR build is the only CI lane that sees that package.
  • Docs (streaming-the-activity-monitor.md#the-hivecommonsfleet-broadcast):
    • how the owner enables the stream;
    • the public-safe content policy (versioned, so an old acknowledgement cannot cover new content);
    • an explicit statement that dashboard authentication does not protect Twitch output.
  • changelog.d/added-15966-hivecommonsfleet-stream.md.

Acceptance mapping

Acceptance (#15966) Where
hivecommons streamer config byte-for-byte unchanged TestHivecommonsStreamConfigUnchanged pins sha256 of k8s/*, overlays/hive-hosted/* and docker-compose.yaml, and fails if a file is added there. The diff touches none of them.
New deployment fails closed without credential + explicit enable TestPublicSafeGateFailsClosed (20 cases, including the shipped defaults and the network-sink bypass) and TestFleetDeploymentIsIndependentAndDisabled
Public-safe view omits private rows by construction (test) Streamer side: TestPublicProxyIsAnonymous / TestPublicProxyRefusesToken. Hub-side row filter test: remaining, lands with the public-safe route after #15965.
No credentials in source/config/docs/comments TestFleetManifestsCarryNoCredential; the docs install the key via a silent read -rs
changelog.d/added-*.md included

How tested

Per AGENTS.md, I did not run go test, go build or go vet locally; CI gives the verdict. Local checks: gofmt -l is clean on the changed Go files, shellcheck and bash -n are clean on the scripts, and I ran the gate by hand for every case: no profile → 0, shipped defaults → refused (3), network .flv sink → refused, local dry run → 0. A pr-review-toolkit code-review pass found two issues: the network .flv sink bypass and a missing executable bit. Both are fixed in this PR.

Deployment / activation status

Nothing is activated. This PR does not apply any manifest, install any credential or enable any broadcast. The existing twitch.tv/hivecommons stream is unchanged. The hivecommonsfleet channel is provisioned (owner, #15861), but the stream key and the public-safe hub view are still owner actions, and the latter is also future work. A merge of this PR does not complete #15966.

— hive: backend=claude

🤖 Generated with Claude Code

https://claude.ai/code/session_01HRH6kiPnEbPztw3Fo9fJiM


🐝 Hive Agent: contributor | SHA: cf94d1842

@kubestellar-prow kubestellar-prow Bot added dco-signoff: yes Indicates the PR's author has signed the DCO. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Oct 31, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor

@Karibhou this PR is back in your court (stage/072-returned-to-contributor). The hive will not merge it until the head changes.

Failing checks:

  • test (dashboard 1/4)

Reply here or push a new head to this branch (same sign-off); CI and the review swarm re-run automatically and the PR returns to the normal path.

Queued in your relay fix queue (1 waiting): fixes are handed out before new work as soon as you have capacity.

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docs-currency (read at head cf94d18). Docs match the gate and proxy behaviour; two small operator-facing gaps:

  1. Policy-version bump list is incomplete and unpinned. src/docs/streaming-the-activity-monitor.md:253-255 tells the owner to bump the version "here, in public-safe-gate.sh and in src/internal/streamdeploy", but the literal also lives in src/deploy/stream/README.md:34 and twice more in this doc (:214, :280). The only cross-check is gate ↔ Go const (src/internal/streamdeploy/streamdeploy_test.go:332); the doc/README copies can drift, which defeats the "old acknowledgement cannot cover new content" guarantee the sentence exists for.

    Bump the version everywhere it appears — this file (three places), `src/deploy/stream/README.md`,
    `public-safe-gate.sh` and `src/internal/streamdeploy` — whenever this text changes, so an old
    acknowledgement cannot cover new content.
    

    Optionally extend the test at streamdeploy_test.go:332 to also strings.Contains the version in both markdown files.

  2. Shipped-default symptom is not a gate refusal. :219-220 says shipped defaults "fail every one of these" and :287-289 says a refusal appears in the pod log. With the key not yet installed, fleet/deployment.yaml uses a non-optional secretRef: twitch-stream-hivecommonsfleet, so the container never starts (CreateContainerConfigError) and no gate line is logged; also DASHBOARD_URL already passes the https:// check. Suggest after :289:

    names the missing condition without printing any value. If the pod sits in
    `CreateContainerConfigError`, the `twitch-stream-hivecommonsfleet` Secret is missing (step 2) — the
    gate has not run yet.
    

— hive: agent=ci-maintainer backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive

hivecommons-hive Bot commented Oct 31, 2026 •

Copy link
Copy Markdown
Contributor

Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor.

Review findings from adjudicator-2 (folded here because this head already carries its hive review):

Security perspective (head cf94d18): no in-scope blocker. Gate ordering and fail-closed env handling verified: entrypoint.sh:89 runs the gate as a child under set -euo pipefail (entrypoint.sh:28), so exit 3 stops the container; the gate reads DASHBOARD_TOKEN/DASHBOARD_PATH/STREAM_OUTPUT from the raw env, so an unset DASHBOARD_PATH refuses rather than inheriting the authenticated default at entrypoint.sh:32. newPublicProxy composes onto a non-nil ModifyResponse (authproxy/main.go:98-106), and the fleet netpol/PSS mirror k8s/ exactly.

Advisory (info, non-blocking): the body says the kiosk is anonymous "by construction" via the proxy, but the proxy does not rewrite upstream Location headers or absolute URLs (authproxy/main.go:69-106), and fleet/networkpolicy.yaml:23-30 permits direct 443 egress to the hub's public IP. Any hub redirect or absolute self-URL (login bounce, SSE endpoint) takes Chromium straight to https://hive.hivecommons.dev, bypassing the Cookie/Set-Cookie stripping, and cookies set there persist in the emptyDir profile (entrypoint.sh:92) for the pod's life. Anonymity then rests on "nobody can type into the kiosk", which is still true today, so this is a wording/defence-in-depth note rather than a defect. If you want the proxy to be the actual boundary, consider having newPublicProxy also drop Set-Cookie plus rewrite a Location whose host equals the target origin back to the proxy's own origin.

Review findings from adjudicator-4 (folded here because this head already carries its hive review):

Style/maintainability pass on cf94d18 (read the diff plus entrypoint.sh, authproxy/main.go, k8s/secret.yaml, .github/scripts/affected-go-packages.sh and the v2 coverage gate on v5). No blocker; two advisories.

1. Public-safe proxy inherits a token-oriented log line (low). newPublicProxy (src/deploy/stream/authproxy/main.go:131-135) delegates to the ModifyResponse from newProxy, which on a 3xx → /login logs … DASHBOARD_TOKEN rejected or missing. Under STREAM_PROFILE=public-safe the token is forbidden (gate public-safe-gate.sh:51-52, newPublicProxy line 120), so the one failure an operator will actually hit — the hub route is not anonymous yet — is reported as a credential problem, and the docs tell them to read exactly these logs (streaming-the-activity-monitor.md "Enabling it", step 3). Name the real cause:

	rp.ModifyResponse = func(resp *http.Response) error {
		resp.Header.Del("Set-Cookie")
		if loc := resp.Header.Get("Location"); resp.StatusCode/100 == 3 && strings.Contains(loc, "/login") {
			log.Printf("authproxy: upstream redirected %s to login (%s) — the public-safe source is not served anonymously; fix DASHBOARD_PATH, do not add a token", resp.Request.URL.Path, redactURL(loc))
			return nil
		}
		return modify(resp)
	}

2. Byte-for-byte pin has no regeneration hint (info). TestHivecommonsStreamConfigUnchanged (src/internal/streamdeploy/streamdeploy_test.go:24-33) is intentionally brittle, and ./internal/... is in ALWAYS_PATTERNS, so it runs on every PR. Each future legitimate edit to k8s/ or overlays/hive-hosted/ will fail here; the message prints both hashes but not how to refresh them. A one-liner in the map comment saves the next person a guess, e.g. // Refresh: (cd src/deploy/stream && sha256sum docker-compose.yaml k8s/* overlays/hive-hosted/*).

Consistency otherwise matches the tree: fleet/secret.yaml mirrors k8s/secret.yaml's template annotation, docs use the existing kubectl --context hive-oke form, and the gate is wired before Xvfb as TestPublicSafeWiring asserts.

Review findings from reviewer (folded here because this head already carries its hive review):

Looks correct to me, and the red CI on this head is not this PR's fault.

CI: test (dashboard 1/4) and test (dashboard shuffle 2/3) both fail on TestEventTriggersRejectInvalidAndUnpersistedRules in pkg/dashboard; coverage and test are just downstream of those shards. This PR touches nothing under pkg/dashboard — that flake is the one #15997 fixes. A rerun after #15997 lands should go green.

What I verified in the tree (head cf94d18):

  • authproxy/main.go:126-136 — newPublicProxy wraps rp.Rewrite/rp.ModifyResponse; both are set unconditionally in newProxy (main.go:75, main.go:100), so the wrappers never call a nil func. With token == "" the base Rewrite never sets Authorization (main.go:81), and the public wrapper then deletes Authorization/Cookie on the outbound request and Set-Cookie on the response. Anonymous-by-construction holds.
  • entrypoint.sh:87-89 — the gate runs as a child process before the export … DASHBOARD_TOKEN on line 90, so it sees only the pod env, which is what you want. The default DASHBOARD_PATH on entrypoint.sh:32 is a shell var, not exported, so the gate's [ -n "$path" ] check (public-safe-gate.sh:50) correctly forces an explicit public-safe path in the ConfigMap rather than inheriting the kiosk default.
  • Ran public-safe-gate.sh by hand with everything else valid: '', null, /tmp/x.flv → 0; rtmp://a/x.flv, file:/x.flv, x.flv → refused. Matches the comment on public-safe-gate.sh:52-54 and closes the network-.flv sink that entrypoint.sh:200 would otherwise hand to ffmpeg.
  • fleet/networkpolicy.yaml denies RFC1918 egress and has no in-cluster rule; fleet/deployment.yaml has replicas: 0, automountServiceAccountToken: false, and only the stream-key secretRef. fleet/kustomization.yaml deliberately omits secret.yaml.

One low-severity note (not a blocker): streamdeploy_test.go:26-32 pins sha256 of every file in k8s/ and overlays/hive-hosted/ and fails on any added file. That satisfies the "#15966 byte-for-byte unchanged" acceptance today, but it also means every future legitimate edit to the hivecommons streamer manifests must re-pin hashes in a test that lives in a different package. Worth a one-line comment on the test saying so, or scoping the pin to the files this PR had reason to protect. Maintainer's call.

Body and diff agree: the Refs #15966 partial is stated with what remains (the hub-side public-safe view route after #15965) and why, which is the right form for a deliberately partial PR.

Review findings from reviewer-2 (folded here because this head already carries its hive review):

Code read at cf94d18: the gate and proxy do what they say; this is routed to a human only because it adds a new deploy base + credential template from a fork, which is a maintainer call, not a code defect.

What I verified against the tree (not just the diff):

  • src/deploy/stream/authproxy/main.go:118-137 — newPublicProxy wraps rp.Rewrite/rp.ModifyResponse from newProxy; both are always non-nil there (main.go:74, main.go:100), so the wrappers can't nil-deref. Token refusal, Authorization/Cookie strip and Set-Cookie drop are all exercised by main_test.go.
  • src/deploy/stream/entrypoint.sh:89 runs public-safe-gate.sh under the script's existing set -euo pipefail (entrypoint.sh:29), so exit 3 from the gate stops the container before Xvfb/Chromium/ffmpeg. DASHBOARD_TOKEN is optional in entrypoint (entrypoint.sh:31), so "must be unset" in the profile is satisfiable.
  • public-safe-gate.sh:52-57 — the *://*|*:* arm precedes null|/*.flv, so rtmp://…/x.flv is refused before the dry-run arm, matching entrypoint.sh:200, which hands any *.flv to ffmpeg verbatim.
  • fleet/configmap.yaml ships STREAM_ENABLED: "false", PUBLIC_SAFE_POLICY_ACK: "", DASHBOARD_PATH: CHANGE-ME-…; each independently trips the gate. deployment.yaml has replicas: 0, no token Secret, automountServiceAccountToken: false. secret.yaml is a REPLACE-ME template and is not in kustomization.yaml. No credential in the diff.
  • k8s/, overlays/hive-hosted/, docker-compose.yaml are untouched.

One thing worth a maintainer's eye (not a blocker):

  • src/internal/streamdeploy/streamdeploy_test.go:35 TestHivecommonsStreamConfigUnchanged pins sha256 of every file under k8s/, overlays/hive-hosted/ and docker-compose.yaml, and fails if a file is added. The acceptance item in [scanner] Prepare a disabled-by-default independent hivecommonsfleet broadcast of a public-safe hub activity view #15966 is "unchanged by this PR"; as a permanent test it freezes the existing twitch.tv/hivecommons streamer config, so any later legitimate edit there (image tag, memory limit, overlay tweak) breaks the rest test shard until someone re-pins hashes, and the error message does not say how. Suggest either dropping this test once the PR merges, or replacing the hash pin with the structural assertions the other tests already make. Severity: low (maintainability).

CI: test (dashboard 1/4) / shuffle 2/3 fail on TestEventTriggersRejectInvalidAndUnpersistedRules, the order-dependence flake #15997 fixes; coverage is the cascade. Not caused by this diff — test (rest 1-4), which runs the new internal/streamdeploy package, is green.

Body vs. diff: the acceptance table matches what I read; the body is explicit that the hub-side public-safe route and its row-filter test are deliberately left for after #15965, and Refs #15966 says so on the same line. I have not approved or closed anything.

@github-actions

github-actions Bot commented Oct 31, 2026 •

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

This PR conflicts with v5 itself. Rebase it first: until it merges cleanly into the base, conflicts with other open PRs cannot be told apart from base drift, so only same-file overlaps are listed.

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

No conflicting open PRs or same-file overlaps were found.

@github-actions github-actions Bot added the conflicts-with-open-pr Open PR has a merge conflict with another open PR label Oct 31, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor
cf94d18

⚠️ Sentinel alert — maintainer review required

Hive flagged this PR (author @Karibhou, head cf94d1842e38) because it matches behaviors that can override security controls, escalate privileges or damage the codebase. This is a heuristic, not an accusation — a maintainer should confirm the change is intended before it merges.

  • sensitive_path — changes 12 sensitive path(s) (Touches a sensitive path (OWNERS, workflows, policies, hive config, security docs, …))
    • src/deploy/stream/Dockerfile
    • src/deploy/stream/README.md
    • src/deploy/stream/authproxy/main.go
    • src/deploy/stream/authproxy/main_test.go
    • src/deploy/stream/entrypoint.sh
    • src/deploy/stream/fleet/configmap.yaml
    • src/deploy/stream/fleet/deployment.yaml
    • src/deploy/stream/fleet/kustomization.yaml
    • src/deploy/stream/fleet/namespace.yaml
    • src/deploy/stream/fleet/networkpolicy.yaml
    • src/deploy/stream/fleet/secret.yaml
    • src/deploy/stream/public-safe-gate.sh
  • remote_code_execution — adds a remote-fetch-and-execute, decoded payload, reverse shell or embedded credential (Adds curl|sh, eval of encoded payloads, reverse shells or embedded private keys)
    • src/deploy/stream/Dockerfile

Hive added the sentinel-alert label. While it is present, Hive will not approve this PR, apply LGTM/approval labels, or merge it through any auto-merge lane. Remove the label once reviewed; Hive will not re-apply it unless new commits are pushed. Tune paths and behaviors under sentinel in hive.yaml or the dashboard Security tab.

@hivecommons-hive

Copy link
Copy Markdown
Contributor

@Karibhou the hive has adopted this PR (stage/074-adopted-by-hive): your hive has been offline since the nudge. The hive will rebase this branch on v5 and fix CI here; your commits and sign-off stay. Push a new head yourself at any time and the hive yields it back to you.

@hivecommons-hive
hivecommons-hive Bot force-pushed the feat/hivecommonsfleet-stream branch from cf94d18 to b018d63 Compare October 31, 2026 09:25
@hivecommons-hive

Copy link
Copy Markdown
Contributor

hive/awaiting-ci: rebased onto v5 (picks up #15997, which fixed the TestEventTriggersRejectInvalidAndUnpersistedRules shard failure). Held for human review — green CI will not merge this on its own; it merges after a maintainer reviews it and removes the hold.


🐝 Hive Agent: scanner | Instance: hosted-available-oke-11-placeholder-r05x | SHA: unknown

— hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Decision needed: @hanthor should decide whether this disabled-by-default hivecommonsfleet deployment base (deploy manifest + public-broadcast gate, sentinel-alert) should land now while #15966 stays open for the hub's public-safe view route, and whether the hard-coded https://hive.hivecommons.dev origin and policy id hivecommonsfleet-public-safe-v1 are the ones you want pinned.

Code looks correct to me; routing because it adds a deploy manifest for a public broadcast and a hash-pin on the existing stream config. Nothing here is a defect.

What I verified at b018d63 (diff first, then the base tree, then the body):

  • Existing twitch.tv/hivecommons path is unchanged in behaviour. public-safe-gate.sh:28 is '') exit 0 ;; when STREAM_PROFILE is unset, and entrypoint.sh runs it under set -euo pipefail (line 28) so a non-zero exit really does stop the container before Xvfb/Chromium/ffmpeg. authproxy/main.go only takes the newPublicProxy branch when STREAM_PROFILE == "public-safe"; the default branch calls the original newProxy untouched.
  • newPublicProxy wrapping is safe. newProxy in the base always sets both Rewrite and ModifyResponse (authproxy/main.go:63-96 at v5), so the wrapped rewrite(pr) / modify(resp) calls never hit a nil func.
  • Fail-closed by construction. fleet/configmap.yaml ships STREAM_ENABLED: "false", PUBLIC_SAFE_POLICY_ACK: "", DASHBOARD_PATH: "CHANGE-ME-…", and fleet/deployment.yaml has replicas: 0 and no dashboard-token secretRef. Even with STREAM_ENABLED=true the gate refuses on the placeholder path. entrypoint.sh:31 already defaults DASHBOARD_TOKEN to empty, so the no-credential profile can start once the gate passes.
  • kustomize build src/deploy/stream/fleet renders: Namespace/ConfigMap/Deployment/NetworkPolicy in hive-stream-fleet, egress limited to DNS + public 1935/443, no in-cluster dashboard rule.
  • Hash pins are right. All eight sha256 values in src/internal/streamdeploy/streamdeploy_test.go match the files at this head (checked docker-compose.yaml, k8s/*.yaml, overlays/hive-hosted/kustomization.yaml). TestHivecommonsStreamConfigUnchanged only walks k8s/ and overlays/hive-hosted/, so the open #15985 (new overlays/hive-hosted-matrix/) does not trip it.
  • Stream Image / Build (PR gate, no push) is green, and the Dockerfile now runs go test in the authproxy stage, so TestPublicProxyIsAnonymous / TestPublicProxyRefusesToken actually ran.

Things for the decision-maker, not defects:

  • The byte-for-byte pin is a deliberate ratchet. Any future edit to k8s/*.yaml, docker-compose.yaml or overlays/hive-hosted/kustomization.yaml (an image tag bump, a bitrate change) will fail streamdeploy_test.go until the hash map is updated. The comment at the top of the map says that is the intent per #15861; confirm you want that friction.
  • Refs #15966 — partial on purpose is stated in the body with what remains (the hub's public-safe view route). The scope declaration is explicit, so I am not re-asking it; I am asking only whether the deploy side should land before its consumer exists.
  • Not a duplicate of #15985 (different channel, standalone fleet/ base), but both add a README.md table row and a doc section, so the second to land needs a small rebase.

I have not approved, merged, or closed anything.

— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive

Copy link
Copy Markdown
Contributor

Needs a decision, not a merge:

  • the reviewer swarm returned requires_human @b018d63
  • the review found: the reviewer marked this change high-risk
  • reviewer question: @hanthor should decide whether this disabled-by-default hivecommonsfleet deployment base (deploy manifest + public-broadcast gate, sentinel-alert) should land now while [scanner] Prepare a disabled-by-default independent hivecommonsfleet broadcast of a public-safe hub activity view #15966 stays open for the hub's public-safe view route, and whether the hard-coded https://hive.hivecommons.dev origin and policy id hivecommonsfleet-public-safe-v1 are the ones you want pinned.
  • a sentinel alert is open on this PR
  • the automerge lane will not merge this unattended

Head: verdict requires_human @b018d63, 61/61 checks green, DCO yes, sentinel alert, soak 1m0s of 10m0s.

How to release it:

  • After reading the verdict, a trusted merger can submit a GitHub Approve review for the current head and the lane clears the hold on its next pass; /hive approve replies on a PR are acknowledged but not consumed. An ordinary contributor cannot release their own PR.
  • Resolve the sentinel alert and have a maintainer clear its label.

Clear the cause and the hive re-evaluates on its next pass; the stage moves to stage/090-ready-for-human-merge, stage/095-pre-merge-soak or the merge queue on its own. Approval does not bypass CI, hold labels or other merge gates.

@hivecommons-hive

Copy link
Copy Markdown
Contributor

/lgtm

Posted by @clubanderson from the Hive dashboard; the merge gate decides from here.

@kubestellar-prow

Copy link
Copy Markdown
Contributor

@hivecommons-hive[bot]: changing LGTM is restricted to collaborators

Details

In response to this:

/lgtm

Posted by @clubanderson from the Hive dashboard; the merge gate decides from here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@hivecommons-hive

Copy link
Copy Markdown
Contributor

/approve

Posted by @clubanderson from the Hive dashboard; the merge gate decides from here.

@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: hivecommons-hive[bot]
Once this PR has been reviewed and has the lgtm label, please assign danathar for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

…roadcast

Add an independent streamer deployment for the hub-wide monitor on
twitch.tv/hivecommonsfleet (RFC hivecommons#15861, proposed by @hanthor; child hivecommons#15966).

- src/deploy/stream/fleet/: standalone Kustomize base with its own
  namespace (hive-stream-fleet), Deployment, ConfigMap, NetworkPolicy and
  stream-key Secret name (twitch-stream-hivecommonsfleet, template only).
  Ships disabled: replicas 0, STREAM_ENABLED "false", placeholder source.
- public-safe-gate.sh: with STREAM_PROFILE=public-safe the entrypoint
  refuses to start any process unless the owner enabled the stream,
  acknowledged policy hivecommonsfleet-public-safe-v1, set a real https
  source, left DASHBOARD_TOKEN unset and installed a stream key (only
  'null' or an absolute local *.flv path count as a dry run). Unset
  profile: no-op, so twitch.tv/hivecommons is unaffected.
- authproxy: public-safe mode refuses a token, strips browser
  Authorization/Cookie and drops Set-Cookie, so the kiosk renders the hub
  anonymously; its tests now run in the image build stage.
- src/internal/streamdeploy: CI tests pin the hivecommons stream config
  byte for byte, check the fleet deployment is isolated and disabled with
  no credential, and exercise the gate's fail-closed cases.
- Docs: owner enablement steps, public-safe content policy, and that
  dashboard authentication does not protect Twitch output.

No broadcast is activated by this change.

Hive-Run: hivecommons#15966
Hive-Plan: RFC hivecommons#15861 implementation child 5 (hivecommonsfleet broadcast)
Hive-Spec: hivecommons#15966#acceptance
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01HRH6kiPnEbPztw3Fo9fJiM
Signed-off-by: Karibhou <Karibhou@users.noreply.github.com>
@clubanderson
clubanderson force-pushed the feat/hivecommonsfleet-stream branch from b018d63 to 22a96c2 Compare October 31, 2026 11:20
@hivecommons-hive

Copy link
Copy Markdown
Contributor

@Karibhou this PR has a new head without confirmed hive push evidence, so the hive has handed this PR back to you (stage/074-adopted-by-hive → stage/072-returned-to-contributor). It will nudge again if CI stays red.

@clubanderson
clubanderson merged commit 622f645 into hivecommons:v5 Oct 31, 2026
68 of 69 checks passed
@Karibhou
Karibhou deleted the feat/hivecommonsfleet-stream branch November 15, 2026 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-signoff: yes Indicates the PR's author has signed the DCO. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants