Skip to content

πŸ› activity monitor: some merges show no toast; merge toast lacks countdown bar; bee/odometer skipped for off-board rowsΒ #15828

Closed

Description

@clubanderson

Live evidence (spoke on v5 db43b1a, 12:27 ET), follow-up to #15808 / #15817:

  1. "πŸ› reviewer: carry the operator decision across consecutive base refreshesΒ #15780 merged" toast shown, but no bee and no odometer tick (row not on the board; the detached-row path in πŸ› activity monitor: 'merging now' lingers, silent merges, closed rows vanishΒ #15817 covers this β€” confirm it covers merges that arrive via recently_merged reconcile, not only a merged row payload).
  2. Some merges show no toast at all ("I see items merge and they don't see the merge toast"). Every path that removes a PR from the tracker (webhook eviction, enumerate diff, closed-not-merged, recently_merged reconcile, SSE-driven refetch, poll) must funnel into one celebrateMerge(pr) that is idempotent per (repo, number) and persisted in sessionStorage, so a reload does not re-celebrate but a merge that landed during the reload is still shown once.
  3. The merge toast has no countdown bar: stageTrackerMergeBanner arms a bare setTimeout and never calls toastCountdownBar, so no .toast-bar / --toast-ttl is drawn. Use the shared countdown with the banner's configured lifetime (compatible with ✨ Activity Monitor settings: configurable toast durations and pre-merge soak #15824's toast_info_s).

Tests: node β€” PR present in snapshot N, absent in N+1, in recently_merged β†’ exactly one toast + bee + odometer; reload between payloads still celebrates once; reload after does not repeat; banner draws the countdown bar.

Activity

  1. added
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    on Oct 30, 2026
  2. hivecommons-hive commented on Oct 30, 2026

    @hivecommons-hive
    Contributor

    Scanner note (not starting work): this is sequenced behind #15817, which already rewrites the same surfaces (static/index.html, static-src/js/tracker-merged.js, stage_tracker_recently_closed.go) and whose detached-row path item 1 asks to confirm. Dispatching a parallel fix now would conflict with that human-authored PR, which the hive cannot push to. The hive picks this up once #15817 merges and re-verifies items 1–3 against the merged code.


    🐝 Hive Agent: scanner | Instance: hosted-available-oke-11-placeholder-r05x | SHA: unknown

    β€” hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

  3. hivecommons-hive commented on Oct 30, 2026

    @hivecommons-hive
    Contributor

    🌱 Good first issue β€” bring your own coding agent

    Hi! This repository is maintained with hive and welcomes contributions made with your own AI coding agent (Claude Code, Codex, Copilot CLI, Bob, …). hosted-available-oke-11-placeholder-r05x picked this issue as a good place to start because:

    • has clear steps or acceptance criteria
    • short, focused description

    How to land it (no waiting on a human):

    1. Claim it through the relay: open https://hosted-kubestellar-hive-ojv6.hive.hivecommons.dev/contribute?issue=hivecommons%2Fhive%2315828 and sign in with GitHub. Claiming stamps the issue so hive leaves it to you.
    2. Fork or branch, make the change with your agent, and sign each commit with DCO (git commit -s).
    3. Open a PR whose description says Fixes #15828 β€” that closing keyword is how hive's contributor lane links the PR to your claim.
    4. Hive runs CI and merges green PRs from claimed contributors automatically.
    Paste this to your agent
    Fix #15828 in github.com/hivecommons/hive (https://github.com/hivecommons/hive/issues/15828). First open https://hosted-kubestellar-hive-ojv6.hive.hivecommons.dev/contribute?issue=hivecommons%2Fhive%2315828 and claim the issue through the hive relay (sign in with GitHub). Work on a fork/branch; keep the change scoped to the issue; sign every commit with DCO (git commit -s); open a PR whose description contains the line 'Fixes #15828' so the hive's contributor lane can auto-merge it once CI is green. Read and follow https://github.com/hivecommons/hive/blob/HEAD/AGENTS.md before changing code.
    

    Prefer not to drive the loop by hand? Run your own hive (we call them clankers) β€” a relay on your machine that claims, opens the PR and handles review fixes for you, and earns you a contributor profile and a leaderboard place: see https://hosted-kubestellar-hive-ojv6.hive.hivecommons.dev/contribute.

    If nobody claims it, hive may pick it up itself β€” claiming first prevents that. Docs: contributor relay Β· contributor lane auto-merge Β· trust tiers Β· AGENTS.md.

  4. added
    good first issueDenotes an issue ready for a new contributor, according to the "help wanted" guidelines.
    on Oct 30, 2026
  5. hivecommons-hive commented on Oct 30, 2026

    @hivecommons-hive
    Contributor

    πŸ”’ Claimed by @mendezr (contributor on hive hosted-available-oke-11-placeholder-r05x). The claim lasts 30m0s without activity and renews while the work continues. Reply /unclaim to release, or /claim to take it over if you outrank the holder.

  6. hivecommons-hive commented on Oct 30, 2026

    @hivecommons-hive
    Contributor

    πŸ”“ Claim by @mendezr released (lease revoked).

  7. github-actions commented on Oct 31, 2026

    @github-actions
    Contributor

    @clubanderson this issue was closed by @hivecommons-hive[bot] as completed.

    If this was closed by a merged PR, the fix only takes effect once it ships in a tagged release and your deployment updates to it β€” check your running version against the fix before concluding the fix failed.

    If you are still seeing the problem, comment /reopen and it will be reopened for you β€” you do not need write access. Please add what you are still observing (running version, logs, steps) so it is not closed the same way again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    good first issueDenotes an issue ready for a new contributor, according to the "help wanted" guidelines.help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions