Repository navigation
📖 docs: remove duplicate README run routes - #15648
hivecommons-hive[bot] wants to merge 2 commits into
Conversation
Keep deployment routing in Get started, which already links hosted onboarding, all three self-hosted runtimes, and fleet hub deployment. Hive-Run: #15338 Hive-Plan: README run-route deduplication Hive-Spec: issue-15338#finding Signed-off-by: thatguywob <thatguywob@users.noreply.github.com>
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of No conflicting open PRs or same-file overlaps were found. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Decision needed: @clubanderson should decide whether to close this adoption of #15343 as already landed, since #15341 (same author) removed the identical "Ways to run Hive" section from src/docs/README.md on v5.
This is a no-op against v5: the duplicate section this PR removes is already gone.
What I verified
- The original commit
d15e41ddeletes the five-line## Ways to run Hiveblock atsrc/docs/README.md:53-57. a824f26(#15341, "docs: deduplicate README run-route guidance", merged 2026-10-29T07:45Z, also by @thatguywob) removes exactly the same lines — same heading, same two bullets.- After the
Merge branch 'v5'commit78ffd99on this branch,git diff origin/v5 pr15648is empty and the PR reports+0 −0;grep -n "Ways to run Hive" src/docs/README.mdonv5returns nothing.
Nothing is wrong with the change — it was simply merged twice from the same contributor. Flagging for a maintainer: if you agree, this one (and its fork original #15343) could be closed as superseded by #15341. I have not closed anything.
— hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
Needs a decision, not a merge:
Head: verdict requires_human @78ffd99, 40/44 checks green, 4 pending, DCO yes, soak 0s of 30m0s. What to do: approve this head ( How to release it:
Clear the cause and the hive re-evaluates on its next pass; the stage moves to |
|
Closed as superseded by #15341 by @clubanderson from the Hive dashboard. Already landed on v5 via #15341; closing as superseded. |
…sted PR An issue with several linked PRs draws a sub-row per PR; when one parked PR asks, stageTrackerDecisionTarget resolved the issue row's lead to that PR as well, so the same 'Let hive decide' button appeared on the parent header and on the sub-row (hive#15320 → #15647, hive#15338 → #15648). stageTrackerLeadActionOnRow drops the parent's lead when it acts on a nested PR that is drawn as a sub-row and renders its own; the parent's ⋯ menu keeps 'Decide PR #N…'. Test: a parent + nested-PR pair yields one button. Signed-off-by: Andrew Anderson <andy@clubanderson.com>
…seded (#15664) * 🐛 tracker: a PR waiting on its author never leads with Close as superseded A human-authored PR the review swarm sent back for changes rendered the red inline 'Close as superseded' button: stageTrackerLeadActions flagged every server decide:* option not already in the Decide… submenu as lead, and once delegate/hold were taken the first leftover was the close. - StageTrackerDecisionOption gains Lead (json lead); the server sets it only where a close is the answer (decisionLeadWithCloseSuperseded, the reviewer's RedundantOf). - The SPA never leads a row with a danger option unless o.lead, and the Decide… fallback skips danger entries; the ⋯ menu is unchanged. - The waiting pill for a person's own PR reads 'waiting on @x to push' and the popover question no longer asks 'or close it?'. - Tests updated; focused cases for waiting-on-author (no close lead), the live 085 sent-back shape, and redundant-of (close still leads). Signed-off-by: Andrew Anderson <andy@clubanderson.com> * 🐛 tracker: render Let hive decide once for an issue and its asking nested PR An issue with several linked PRs draws a sub-row per PR; when one parked PR asks, stageTrackerDecisionTarget resolved the issue row's lead to that PR as well, so the same 'Let hive decide' button appeared on the parent header and on the sub-row (hive#15320 → #15647, hive#15338 → #15648). stageTrackerLeadActionOnRow drops the parent's lead when it acts on a nested PR that is drawn as a sub-row and renders its own; the parent's ⋯ menu keeps 'Decide PR #N…'. Test: a parent + nested-PR pair yields one button. Signed-off-by: Andrew Anderson <andy@clubanderson.com> * 📖 changelog: cover the duplicate Let hive decide fix Signed-off-by: Andrew Anderson <andy@clubanderson.com> * 🌱 test: the sent-back 085 row keeps its close inside the Decide… submenu Signed-off-by: Andrew Anderson <andy@clubanderson.com> * 🐛 tracker: a server-marked lead heads the row even when the Decide… submenu lists its verb Signed-off-by: Andrew Anderson <andy@clubanderson.com> --------- Signed-off-by: Andrew Anderson <andy@clubanderson.com>
Supersedes #15343 (adopted after CI went red and the contributor was unavailable; original commits by @thatguywob preserved).
Fixes #15338
This branch is #15343's head
d15e41d8c2c4as pushed by @thatguywob (forkthatguywob/hive), unchanged. Last lane reason on the original:fork-not-editable.Hive fix agent: rebase this branch on
v5, fix the failing checks / review asks, and push to THIS branch. Keep the original author's commits and theirSigned-off-by; add your own sign-off on your commits. Do not open another PR.