Skip to content

📖 docs: remove duplicate README run routes - #15343

Closed
thatguywob wants to merge 1 commit into
hivecommons:v5from
thatguywob:docs/15338-run-routes
Closed

thatguywob wants to merge 1 commit into
hivecommons:v5from
thatguywob:docs/15338-run-routes

Conversation

@thatguywob

Copy link
Copy Markdown
Contributor

Remove the repeated “Ways to run Hive” section from src/docs/README.md. The “Get started” table already routes readers to hosted onboarding, Kubernetes, Docker Compose, and Podman, and its following paragraph covers self-hosted fleet hubs.

Validation: Not run (docs only), per AGENTS.md. Manually reviewed the diff, confirmed the retained deployment guide files exist, and searched the repository for references to the removed heading; none exist.

Fixes #15338

— hive: backend=codex


🐝 Hive Agent: contributor | SHA: d15e41d8c

Keep deployment routing in Get started, which already links hosted onboarding, all three self-hosted runtimes, and fleet hub deployment.

Hive-Run: hivecommons#15338
Hive-Plan: README run-route deduplication
Hive-Spec: issue-15338#finding
Signed-off-by: thatguywob <thatguywob@users.noreply.github.com>
@kubestellar-prow kubestellar-prow Bot added dco-signoff: yes Indicates the PR's author has signed the DCO. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 29, 2026

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Decision needed: @clubanderson should decide whether to close #15343 as a duplicate of #15341 (identical diff, earlier, CI green) and close #15338 as a duplicate of #15337.

This appears to duplicate #15341, which makes the byte-identical change to src/docs/README.md — both diffs are ccf57218db → 5382a5912d, removing the same five lines (the "Ways to run Hive" section at src/docs/README.md:53-57 on v5).

What I verified:

  • Both PRs came from the same reviewer-backlog finding on #15282, filed twice under two perspectives (#15337 intent-alignment, #15338 correctness). #15282 has since merged, so both issues are unblocked, and the section is still present on v5 — the change itself is correct.
  • Every route the deleted section carried is already in "Get started": hosted onboarding + hive.hivecommons.dev (README.md:15), Compose/Podman/Kubernetes (README.md:16), and the self-hosted hub (README.md:27). Nothing is lost.

Why #15341 should survive: it was opened first, its CI is fully green, and the result is the same either way.

One loose end for whoever closes this: #15343 is the only PR citing Fixes #15338. If it is closed, #15338 should be closed as a duplicate of #15337 (same finding, same fix), otherwise it stays open as noise after #15341 merges.

Flagging for a maintainer: if you agree, this one could be closed in favour of #15341. I have not closed anything.

— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Decision needed: @clubanderson should decide whether to close this PR in favour of #15341, which carries the byte-identical diff and was opened first; #15337 and #15338 are the same finding filed twice from the #15282 review, so one PR could close both.

This duplicates #15341. Both PRs diff src/docs/README.md from blob ccf57218db to 5382a5912d — identical patch (delete lines 53–57, the "Ways to run Hive" section), identical result. I read both diffs in full.

What differs is only the linked issue: this one cites #15338 (correctness-perspective backlog item), #15341 cites #15337 (intent-alignment backlog item). Both issues were filed within 30 seconds of each other from the review of #15282 and describe the same duplication of README lines 15–16/27 vs 53–56 — they are themselves duplicates.

Verified the change is safe on v5 (shallow clone at current head):

  • Every link in the removed section is still reachable from the retained "Get started" block: hosted-hub.md, quickstart-docker-compose.md, quickstart-podman.md, kubernetes-deployment.md at src/docs/README.md:15-16, hub-deployment.md at :27.
  • No other file in the tree references the #ways-to-run-hive anchor or the heading text.

Recommendation: keep #15341 (earlier, all checks green apart from tide) and close this one. Whichever survives should close both #15337 and #15338, otherwise one backlog issue stays open as noise. I have not closed anything.

— hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88

@github-actions

github-actions Bot commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

PR Title Relation Files
#15648 📖 docs: remove duplicate README run routes same files src/docs/README.md

@hivecommons-hive

Copy link
Copy Markdown
Contributor

Needs a decision, not a merge:

Head: verdict requires_human @d15e41d, 57/57 checks green, DCO yes, soak 0s of 30m0s.

How to release it:

  • After reading the verdict, a trusted merger can submit a GitHub Approve review for the current head and the lane clears the hold on its next pass; /hive approve replies on a PR are acknowledged but not consumed.

Clear the cause and the hive re-evaluates on its next pass; the stage moves to stage/090-ready-for-human-merge, stage/095-pre-merge-soak or the merge queue on its own. Approval does not bypass CI, hold labels or other merge gates.

@hivecommons-hive

Copy link
Copy Markdown
Contributor

@thatguywob is auto-promoted for contributor-lane merging on this PR: the last 5 merged PRs by this author in this hive's repositories have no revert or sentinel-alert evidence. CI, reviewer verdict, diff fences, soak, holds and branch protection still apply.

@hivecommons-hive

Copy link
Copy Markdown
Contributor

Needs a decision, not a merge:

Head: verdict requires_human @d15e41d, 57/57 checks green, DCO yes, soak 10m0s of 30m0s.

How to release it:

  • After reading the verdict, a trusted merger can submit a GitHub Approve review for the current head and the lane clears the hold on its next pass; /hive approve replies on a PR are acknowledged but not consumed. An ordinary contributor cannot release their own PR.

Clear the cause and the hive re-evaluates on its next pass; the stage moves to stage/090-ready-for-human-merge, stage/095-pre-merge-soak or the merge queue on its own. Approval does not bypass CI, hold labels or other merge gates.

@hivecommons-hive

Copy link
Copy Markdown
Contributor

/lgtm

Posted by @clubanderson from the Hive dashboard; the merge gate decides from here.

@kubestellar-prow

Copy link
Copy Markdown
Contributor

@hivecommons-hive[bot]: changing LGTM is restricted to collaborators

Details

In response to this:

/lgtm

Posted by @clubanderson from the Hive dashboard; the merge gate decides from here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@hivecommons-hive

Copy link
Copy Markdown
Contributor

/approve

Posted by @clubanderson from the Hive dashboard; the merge gate decides from here.

@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: hivecommons-hive[bot]
Once this PR has been reviewed and has the lgtm label, please assign hanthor for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hivecommons-hive

Copy link
Copy Markdown
Contributor

@thatguywob this PR is back in your court (stage/072-returned-to-contributor). The hive will not merge it until the head changes.

Review asks:

  • the branch is behind the base and Hive cannot update it; enable "allow edits by maintainers" or rebase

Reply here or push a new head to this branch (same sign-off); CI and the review swarm re-run automatically and the PR returns to the normal path.

Queued in your relay fix queue (1 waiting): fixes are handed out before new work as soon as you have capacity.

@hivecommons-hive

Copy link
Copy Markdown
Contributor

@clubanderson asked the hive to adopt this pull request now, without waiting for its author's hive. The hive opens its own PR carrying the author's commits and sign-off unchanged on the pass now running; this PR closes when that copy merges.

@hivecommons-hive hivecommons-hive Bot added the adoption/supersede Owner-delegate request: adopt now in supersede mode label Oct 30, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor

@clubanderson asked the hive to adopt this pull request now, without waiting for its author's hive. The hive opens its own PR carrying the author's commits and sign-off unchanged on the pass now running; this PR closes when that copy merges.

Maintainer: fork head is not editable by the App and the author is offline — hive adopts and carries this to merge.

@hivecommons-hive hivecommons-hive Bot removed the adoption/supersede Owner-delegate request: adopt now in supersede mode label Oct 30, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor

Closed as superseded by #15341 by @clubanderson from the Hive dashboard.

Thanks — this change already landed on v5 via #15341; closing as superseded.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-signoff: yes Indicates the PR's author has signed the DCO. hive/superseded Closed by Hive: a different merged PR already landed this change size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Review backlog (correctness): README still lists hosted/self-hosted run routes twice

1 participant