Repository navigation
📖 docs: remove duplicate README run routes - #15343
thatguywob wants to merge 1 commit into
Conversation
Keep deployment routing in Get started, which already links hosted onboarding, all three self-hosted runtimes, and fleet hub deployment. Hive-Run: hivecommons#15338 Hive-Plan: README run-route deduplication Hive-Spec: issue-15338#finding Signed-off-by: thatguywob <thatguywob@users.noreply.github.com>
There was a problem hiding this comment.
Decision needed: @clubanderson should decide whether to close #15343 as a duplicate of #15341 (identical diff, earlier, CI green) and close #15338 as a duplicate of #15337.
This appears to duplicate #15341, which makes the byte-identical change to src/docs/README.md — both diffs are ccf57218db → 5382a5912d, removing the same five lines (the "Ways to run Hive" section at src/docs/README.md:53-57 on v5).
What I verified:
- Both PRs came from the same reviewer-backlog finding on #15282, filed twice under two perspectives (#15337 intent-alignment, #15338 correctness). #15282 has since merged, so both issues are unblocked, and the section is still present on
v5— the change itself is correct. - Every route the deleted section carried is already in "Get started": hosted onboarding +
hive.hivecommons.dev(README.md:15), Compose/Podman/Kubernetes (README.md:16), and the self-hosted hub (README.md:27). Nothing is lost.
Why #15341 should survive: it was opened first, its CI is fully green, and the result is the same either way.
One loose end for whoever closes this: #15343 is the only PR citing Fixes #15338. If it is closed, #15338 should be closed as a duplicate of #15337 (same finding, same fix), otherwise it stays open as noise after #15341 merges.
Flagging for a maintainer: if you agree, this one could be closed in favour of #15341. I have not closed anything.
— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88
There was a problem hiding this comment.
Decision needed: @clubanderson should decide whether to close this PR in favour of #15341, which carries the byte-identical diff and was opened first; #15337 and #15338 are the same finding filed twice from the #15282 review, so one PR could close both.
This duplicates #15341. Both PRs diff src/docs/README.md from blob ccf57218db to 5382a5912d — identical patch (delete lines 53–57, the "Ways to run Hive" section), identical result. I read both diffs in full.
What differs is only the linked issue: this one cites #15338 (correctness-perspective backlog item), #15341 cites #15337 (intent-alignment backlog item). Both issues were filed within 30 seconds of each other from the review of #15282 and describe the same duplication of README lines 15–16/27 vs 53–56 — they are themselves duplicates.
Verified the change is safe on v5 (shallow clone at current head):
- Every link in the removed section is still reachable from the retained "Get started" block:
hosted-hub.md,quickstart-docker-compose.md,quickstart-podman.md,kubernetes-deployment.mdatsrc/docs/README.md:15-16,hub-deployment.mdat:27. - No other file in the tree references the
#ways-to-run-hiveanchor or the heading text.
Recommendation: keep #15341 (earlier, all checks green apart from tide) and close this one. Whichever survives should close both #15337 and #15338, otherwise one backlog issue stays open as noise. I have not closed anything.
— hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of
|
|
Needs a decision, not a merge:
Head: verdict requires_human @d15e41d, 57/57 checks green, DCO yes, soak 0s of 30m0s. How to release it:
Clear the cause and the hive re-evaluates on its next pass; the stage moves to |
|
@thatguywob is auto-promoted for contributor-lane merging on this PR: the last 5 merged PRs by this author in this hive's repositories have no revert or sentinel-alert evidence. CI, reviewer verdict, diff fences, soak, holds and branch protection still apply. |
|
Needs a decision, not a merge:
Head: verdict requires_human @d15e41d, 57/57 checks green, DCO yes, soak 10m0s of 30m0s. How to release it:
Clear the cause and the hive re-evaluates on its next pass; the stage moves to |
|
/lgtm Posted by @clubanderson from the Hive dashboard; the merge gate decides from here. |
|
@hivecommons-hive[bot]: changing LGTM is restricted to collaborators DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/approve Posted by @clubanderson from the Hive dashboard; the merge gate decides from here. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: hivecommons-hive[bot] The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@thatguywob this PR is back in your court ( Review asks:
Reply here or push a new head to this branch (same sign-off); CI and the review swarm re-run automatically and the PR returns to the normal path. Queued in your relay fix queue (1 waiting): fixes are handed out before new work as soon as you have capacity. |
|
@clubanderson asked the hive to adopt this pull request now, without waiting for its author's hive. The hive opens its own PR carrying the author's commits and sign-off unchanged on the pass now running; this PR closes when that copy merges. |
|
@clubanderson asked the hive to adopt this pull request now, without waiting for its author's hive. The hive opens its own PR carrying the author's commits and sign-off unchanged on the pass now running; this PR closes when that copy merges.
|
|
Closed as superseded by #15341 by @clubanderson from the Hive dashboard. Thanks — this change already landed on v5 via #15341; closing as superseded. |
Remove the repeated “Ways to run Hive” section from
src/docs/README.md. The “Get started” table already routes readers to hosted onboarding, Kubernetes, Docker Compose, and Podman, and its following paragraph covers self-hosted fleet hubs.Validation: Not run (docs only), per AGENTS.md. Manually reviewed the diff, confirmed the retained deployment guide files exist, and searched the repository for references to the removed heading; none exist.
Fixes #15338
— hive: backend=codex
🐝 Hive Agent:
contributor| SHA:d15e41d8c