Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
1742526
🌱 refactor: split stage tracker UI tests
Karibhou Oct 29, 2026
7336cd9
📖 docs: correct tracker test references
Karibhou Oct 30, 2026
b3529f3
Merge 7336cd99dd836a0a4b85ba157c14fb6ef40c4350 into 11ec2585892d0b040…
hivecommons-hive[bot] Oct 30, 2026
ac7b555
changelog: fragment for #15633
hivecommons-hive[bot] Oct 30, 2026
0813a05
Merge branch 'v5' into hive/adopt-15566
hivecommons-hive[bot] Oct 30, 2026
c24b44c
Merge branch 'v5' into hive/adopt-15566
hivecommons-hive[bot] Oct 30, 2026
f676b41
Merge branch 'v5' into hive/adopt-15566
hivecommons-hive[bot] Oct 30, 2026
2b74f60
Merge branch 'v5' into hive/adopt-15566
hivecommons-hive[bot] Oct 30, 2026
6e517e9
Merge branch 'v5' into hive/adopt-15566
hivecommons-hive[bot] Oct 30, 2026
b3a16e4
Merge branch 'v5' into hive/adopt-15566
hivecommons-hive[bot] Oct 30, 2026
7e806ad
Merge v5 into hive/adopt-15566; re-apply tracker prelude additions to…
hivecommons-hive[bot] Oct 30, 2026
a4f6348
Merge branch 'v5' into hive/adopt-15566
hivecommons-hive[bot] Oct 30, 2026
da7b959
Merge branch 'v5' into hive/adopt-15566
hivecommons-hive[bot] Oct 30, 2026
26975d7
Merge branch 'v5' into hive/adopt-15566
hivecommons-hive[bot] Oct 30, 2026
84202ae
Merge branch 'v5' into hive/adopt-15566
hivecommons-hive[bot] Oct 30, 2026
0213cd0
Merge branch 'v5' into hive/adopt-15566
hivecommons-hive[bot] Oct 30, 2026
0d0482b
Merge branch 'v5' into hive/adopt-15566
hivecommons-hive[bot] Oct 30, 2026
beb0e25
Merge branch 'v5' into hive/adopt-15566
hivecommons-hive[bot] Oct 30, 2026
8f787a9
Merge branch 'v5' into hive/adopt-15566
hivecommons-hive[bot] Oct 30, 2026
8f3079c
Merge branch 'v5' into hive/adopt-15566
hivecommons-hive[bot] Oct 30, 2026
4d729c0
Merge branch 'v5' into hive/adopt-15566
hivecommons-hive[bot] Oct 30, 2026
a249184
Merge branch 'v5' into hive/adopt-15566
hivecommons-hive[bot] Oct 30, 2026
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.d/changed-15633.md
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
- refactor: split stage tracker UI tests (#15633)
211 changes: 211 additions & 0 deletions src/pkg/dashboard/stage_tracker_ui_prelude_test.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,211 @@
package dashboard

import (
"strings"
"testing"
)

// stageTrackerRowsPreludeJS lifts everything the pure row renderer needs
// out of index.html; stageTrackerRowsFixtureJS is the stage table and the
// row-inspection helpers the row tests share.
func stageTrackerRowsPreludeJS(t *testing.T, html string) string {
t.Helper()
return strings.Join([]string{
"const window = {};",
"function formatDashboardTime(d){return new Date(d).toISOString().slice(11,16)+' UTC';}",
"function formatDashboardDate(d){return new Date(d).toISOString().slice(0,10);}",
"function formatDashboardDateTime(d){return new Date(d).toISOString().slice(0,16);}",
jsConstLine(t, html, "STAGE_TRACKER_PATH"),
jsConstLine(t, html, "STAGE_TRACKER_PR_COLUMN"),
jsConstLine(t, html, "STAGE_TRACKER_MERGE_COLUMN"),
jsConstLine(t, html, "STAGE_TRACKER_NEEDS_DECISION"),
stageTrackerManualMergeJS(t, html),
jsConstLine(t, html, "STAGE_TRACKER_ISSUE_NEEDS_DECISION"),
jsConstLine(t, html, "STAGE_TRACKER_CLOSED_ISSUE_TITLE"),
jsConstLine(t, html, "STAGE_TRACKER_UNTITLED_ISSUE"),
jsConstLine(t, html, "STAGE_TRACKER_SOFT_LINK_VIAS"),
jsConstLine(t, html, "STAGE_TRACKER_SOFT_LINK_TIP"),
jsConstLine(t, html, "STAGE_TRACKER_TRIAGE_NEEDED"),
jsConstLine(t, html, "STAGE_TRACKER_POSSIBLY_EXISTS"),
jsConstLine(t, html, "STAGE_TRACKER_ISSUE_DECISION_COLUMN"),
jsConstLine(t, html, "STAGE_TRACKER_PRE_MERGE_SOAK"),
jsConstLine(t, html, "STAGE_TRACKER_ACTIVE_WORD"),
jsConstLine(t, html, "STAGE_TRACKER_MOD_TEXT"),
jsConstLine(t, html, "STAGE_TRACKER_DRAFT_TIP"),
jsConstLine(t, html, "STAGE_TRACKER_ACTOR"),
jsConstLine(t, html, "STAGE_TRACKER_TERMINAL"),
stageTrackerSentinelJS(t, html),
jsConstLine(t, html, "STAGE_TRACKER_TRAIL_HOPS"),
jsConstLine(t, html, "STAGE_TRACKER_MOD_PRIORITY"),
jsConstBlock(t, html, "STAGE_TRACKER_ICONS"),
jsConstLine(t, html, "STAGE_TRACKER_PAGE_SIZES"),
jsConstLine(t, html, "STAGE_TRACKER_DEFAULT_PAGE_SIZE"),
jsConstLine(t, html, "STAGE_TRACKER_LABEL_CHIP_LIMIT"),
jsConstLine(t, html, "STAGE_TRACKER_AGE_MS"),
jsConstLine(t, html, "STAGE_TRACKER_ATTENTION_STAGES"),
jsConstLine(t, html, "STAGE_TRACKER_LABEL_FAMILIES"),
jsConstLine(t, html, "STAGE_TRACKER_SORTS"),
jsFunc(t, html, "stageTrackerDefaultFilter"),
"var _stageTrackerFilter = stageTrackerDefaultFilter();",
jsFunc(t, html, "stageTrackerWaitSince"),
jsFunc(t, html, "stageTrackerLabelFamily"),
jsConstLine(t, html, "STAGE_TRACKER_NEEDS_HUMAN_STAGES"),
jsConstLine(t, html, "STAGE_TRACKER_NEEDS_HUMAN_AUTHOR_STAGES"),
jsConstLine(t, html, "STAGE_TRACKER_NEEDS_HUMAN_MODS"),
jsFunc(t, html, "stageTrackerItemOnHold"),
jsFunc(t, html, "stageTrackerItemNeedsHuman"),
jsFunc(t, html, "stageTrackerLabelCompare"),
jsFunc(t, html, "stageTrackerLabelDialogData"),
stageTrackerActedJS(t, html),
jsFunc(t, html, "stageTrackerNormalizeFilter"),
jsFunc(t, html, "stageTrackerFilterActive"),
jsFunc(t, html, "stageTrackerMatches"),
jsFunc(t, html, "stageTrackerSort"),
jsFunc(t, html, "stageTrackerPage"),
jsFunc(t, html, "stageTrackerLabelFacets"),
jsFunc(t, html, "stageTrackerCountsText"),
jsFunc(t, html, "stageTrackerRowBreakdown"),
jsFunc(t, html, "stageTrackerIcon"),
jsFunc(t, html, "stageTrackerPRRef"),
jsConstLine(t, html, "STAGE_TRACKER_ACTOR_NONE"),
jsConstLine(t, html, "STAGE_TRACKER_NOBODY_LEAD"),
jsFunc(t, html, "stageTrackerStageActor"),
jsFunc(t, html, "stageTrackerActorKind"),
jsFunc(t, html, "stageTrackerActorTip"),
jsConstLine(t, html, "STAGE_TRACKER_HIVE_PREFIXES"),
jsConstLine(t, html, "STAGE_TRACKER_CLAIMANT_SOURCE"),
jsFunc(t, html, "stageTrackerShortHive"),
jsFunc(t, html, "stageTrackerClaimant"),
jsConstLine(t, html, "STAGE_TRACKER_CLAIMANT_ICON"),
jsFunc(t, html, "stageTrackerClaimantIconKind"),
jsFunc(t, html, "stageTrackerClaimantShort"),
jsFunc(t, html, "stageTrackerClaimantLine"),
jsConstLine(t, html, "STAGE_TRACKER_MOTION_STATIC"),
jsConstLine(t, html, "STAGE_TRACKER_MOTION_ACTIVE"),
jsConstLine(t, html, "STAGE_TRACKER_MOTION_HUMAN"),
jsConstBlock(t, html, "STAGE_TRACKER_MOTION_BY_STAGE"),
jsConstLine(t, html, "STAGE_TRACKER_MOTION_AUTHOR_STAGES"),
jsConstLine(t, html, "STAGE_TRACKER_MOTION_HUMAN_MODS"),
jsFunc(t, html, "stageTrackerMotion"),
jsFunc(t, html, "stageTrackerHeaderHtml"),
jsConstLine(t, html, "STAGE_TRACKER_TRAIN_ICON_PATH"),
jsConstLine(t, html, "STAGE_TRACKER_TRAIN_ICON_TITLE"),
jsFunc(t, html, "stageTrackerTrainIconHtml"),
jsFunc(t, html, "stageTrackerHoldLabels"),
jsFunc(t, html, "stageTrackerSoakLeft"),
jsFunc(t, html, "stageTrackerStripItems"),
jsFunc(t, html, "stageTrackerCurrentStageHtml"),
jsFunc(t, html, "stageTrackerStageWord"),
jsConstLine(t, html, "STAGE_TRACKER_HUMAN_MODS"),
jsConstLine(t, html, "STAGE_TRACKER_HANDLED_TEXT"),
jsConstLine(t, html, "STAGE_TRACKER_HANDLED_NOTE"),
jsFunc(t, html, "stageTrackerRegressionHandled"),
jsFunc(t, html, "stageTrackerRegressionText"),
jsFunc(t, html, "stageTrackerStaleLabelsText"),
jsFunc(t, html, "stageTrackerHopName"),
jsFunc(t, html, "stageTrackerTrailText"),
jsFunc(t, html, "stageTrackerTooltip"),
jsFunc(t, html, "stageTrackerChipsHtml"),
jsFunc(t, html, "stageTrackerHeadColsHtml"),
jsFunc(t, html, "stageTrackerSinceHtml"),
jsFunc(t, html, "stageTrackerSubRowHtml"),
jsFunc(t, html, "stageTrackerPRPillsHtml"),
jsFunc(t, html, "stageTrackerAgoText"),
jsConstBlock(t, html, "STAGE_TRACKER_LINEAGE_REASON_TIP"),
jsFunc(t, html, "stageTrackerLineageText"),
jsFunc(t, html, "stageTrackerSupersededOriginalClause"),
jsFunc(t, html, "stageTrackerLineageTip"),
jsFunc(t, html, "stageTrackerLineageChipHtml"),
jsFunc(t, html, "stageTrackerLinkedPRItem"),
jsFunc(t, html, "stageTrackerLinkedPROpen"),
jsFunc(t, html, "stageTrackerNestedOpenPRs"),
jsConstLine(t, html, "STAGE_TRACKER_LINKED_TIP"),
jsFunc(t, html, "stageTrackerSharedPRs"),
jsFunc(t, html, "stageTrackerLinkedTip"),
jsConstLine(t, html, "STAGE_TRACKER_LINKED_GLYPH"),
jsFunc(t, html, "stageTrackerLinkedDrawnHere"),
jsFunc(t, html, "stageTrackerLinkedSuperseder"),
jsFunc(t, html, "stageTrackerLinkedSupersededGone"),
jsFunc(t, html, "stageTrackerLinkedSupersededTip"),
jsFunc(t, html, "stageTrackerLinkedSorted"),
stageTrackerTierJS(t, html),
jsConstLine(t, html, "STAGE_TRACKER_COVERED_BY_PR"),
jsFunc(t, html, "stageTrackerLeadStage"),
jsFunc(t, html, "stageTrackerLead"),
jsFunc(t, html, "stageTrackerSortKey"),
jsFunc(t, html, "esc"),
jsFunc(t, html, "agentNowAgo"),
jsFunc(t, html, "agentNowClockTime"),
jsFunc(t, html, "stageTrackerHeadline"),
jsFunc(t, html, "stageTrackerAnchor"),
jsFunc(t, html, "stageTrackerSegments"),
jsConstLine(t, html, "STAGE_TRACKER_OPEN_STALE_DAYS"),
jsFunc(t, html, "stageTrackerOpenSince"),
jsFunc(t, html, "stageTrackerBlockedTip"),
jsFunc(t, html, "stageTrackerBlockedOnPR"),
jsConstLine(t, html, "STAGE_TRACKER_BLOCKED_ON_PR_OPEN"),
jsConstLine(t, html, "STAGE_TRACKER_BLOCKED_ON_PR_MERGED"),
jsConstLine(t, html, "STAGE_TRACKER_BLOCKED_ON_PR_CLOSED"),
jsFunc(t, html, "stageTrackerShortAgo"),
jsFunc(t, html, "stageTrackerRefOf"),
jsFunc(t, html, "stageTrackerRowToolsHtml"),
jsFunc(t, html, "stageTrackerRowHtml"),
jsFunc(t, html, "stageTrackerPRIssueSlot"),
jsFunc(t, html, "stageTrackerClosedChipHtml"),
jsFunc(t, html, "stageTrackerItemURL"),
jsFunc(t, html, "stageTrackerItemKey"),
jsFunc(t, html, "stageTrackerMoveAttrs"),
jsFunc(t, html, "stageTrackerNeedsAttention"),
jsFunc(t, html, "stageTrackerVisible"),
jsFunc(t, html, "stageTrackerIsReviewNote"),
jsFunc(t, html, "stageTrackerFoldedReviewNotes"),
jsFunc(t, html, "stageTrackerReviewNotesHtml"),
jsFunc(t, html, "stageTrackerFoldedCount"),
stageTrackerCuesJS(t, html),
}, "\n")
}

const stageTrackerRowsFixtureJS = `
const assert = require('assert');
const now = Date.parse('2026-01-01T12:00:00Z');
const stages = [
{ number: 10, label: 'Actionable', short: 'Actionable', description: 'Ready to be picked up' },
{ number: 15, label: 'Triage needed', short: 'Triage needed', description: 'Actionable but no maintainer has looked at it yet' },
{ number: 20, label: 'Claimed', short: 'Claimed' }, { number: 30, label: 'PR in progress', short: 'PR in progress' },
{ number: 40, label: 'Covered by PR', short: 'Covered by PR' },
{ number: 45, label: 'Needs human decision', short: 'Needs human decision' },
{ number: 50, label: 'Review pending', short: 'CI / Review' }, { number: 60, label: 'Reviewed', short: 'Reviewed' },
{ number: 70, label: 'Fixing', short: 'Fixing', branch_from: 50 }, { number: 71, label: 'Needs author', short: 'Needs author', branch_from: 50 },
{ number: 72, label: 'Returned to contributor', short: 'Returned to contributor', branch_from: 50 },
{ number: 74, label: 'Adopted by hive', short: 'Adopted by hive', branch_from: 50 },
{ number: 80, label: 'Awaiting merge admission', short: 'Merge queue' },
{ number: 85, label: 'Needs human decision', short: 'Needs human decision', branch_from: 80 }, { number: 90, label: 'Ready for human merge', short: 'Ready for human merge', branch_from: 80 },
{ number: 95, label: 'Pre-merge soak', short: 'Soaking', description: 'Lane admitted; the pre-merge soak window is running before the merge is attempted' },
{ number: 100, label: 'Merge queue', short: 'Merge queue' }, { number: 110, label: 'Merged', short: 'Merged' },
];
// The stage table the tooltip's trail names its hops from (fetchStageTracker fills it live).
var _stageTracker = { stages };
// needs-rebase always lands a PR in 070/071/072 (automerge_stage_labels.go), so a
// fixture pairing it with 050/060 would draw a contradictory row.
const rebaseCoherent = (it) => { if ((it.modifiers || []).includes('needs-rebase')) assert.ok(![50, 60].includes(Number(it.stage)), 'fixture #' + it.number + ' pairs needs-rebase with stage ' + it.stage); (it.linked_prs || []).forEach(rebaseCoherent); };
const rawRowHtml = stageTrackerRowHtml;
stageTrackerRowHtml = (item, stages, ctx) => { rebaseCoherent(item); return rawRowHtml(item, stages, ctx); };
// A row is a title line, its strip, then zero or more nested PR sub-rows.
const strips = (row) => row.split('aria-label="Pipeline progress"').slice(1);
const strip = (row) => strips(row)[0].split('<div class="ham-sub"')[0];
const subs = (row) => row.split('<div class="ham-sub"').slice(1);
const segStates = (html) => Array.from(strip(html).matchAll(/<li class="ham-seg ([^"]*)"/g)).map(m => m[1]);
// Visible title occurrences (element text only; title="" attrs excluded).
const titles = (html, t) => (html.match(new RegExp('>' + t.replace(/[.*+?^${}()|[\]\\]/g, '\\$&') + '<', 'g')) || []).length;
const prCol = (html) => Array.from(html.slice(0, html.indexOf('aria-label="Pipeline progress"')).matchAll(/<a class="ham-pr-ref"[^>]*>(.*?)<\/a>/g)).map(m => m[1]);
const B = 'blank';
const text = (h) => h.replace(/<[^>]+>/g, '').replace(/&#39;/g, "'").replace(/\s+/g, ' ').trim();
// The row tooltip rides the issue's #N link on an issue row and the PR link
// (after "PR title · ") on a PR row; the issue slot of a PR row carries none.
const tooltip = (row) => (/<a class="ham-ref"[^>]*title="([^"]*)"/.exec(row) || /<a class="ham-pr-ref"[^>]*title="([^"]*)"/.exec(row))[1];
// Issue slot (lead cell) of a row: its element text.
const lead = (row) => text(/<li class="ham-seg ham-head-lead[^"]*">([\s\S]*?)<\/li>/.exec(row)[1]);
const chips = (row) => (row.match(/class="ham-badge /g) || []).length;
const ctx = { nowMs: now };
const D = 'done', T = 'todo';
`
Loading
Loading