Skip to content

Review backlog (security): Previous intent-alignment finding still present: mobile-shots retry tuning in refactor PR #15602

Closed

Description

@hivecommons-hive

Blocked on PR #15565. This finding came from reviewing PR #15565 and is about code that PR is changing. Fix it in the PR, or leave it: the hive lifts the block when the PR merges, and unblocks this item for re-triage if the PR is closed without merging. Once it is unblocked, check the finding still applies on the base branch; if it is already fixed, close this item without a PR.

Filed from an out-of-scope finding in the Hive review of PR #15565.

PR: #15565 (#15565)
Perspective: security
Severity: info (P3)
Evidence: src/scripts/dashboard-mobile-shots.mjs:245 (

fs.rmSync(PROFILE_DIR, { recursive: true, force: true, maxRetries: 30, retryDelay: 200 });
)
Finding: Previous intent-alignment finding still present: mobile-shots retry tuning in refactor PR

src/scripts/dashboard-mobile-shots.mjs:245 still changes fs.rmSync(PROFILE_DIR, ...) retry params (maxRetries 5->30, retryDelay 100->200), now isolated in commit 153b9ef. Not a security concern: same force/recursive removal of the script-owned temp profile dir, only retry tuning changed. Unrelated to #15562 but non-blocking.

Fingerprint: 82f1ae1794e8a66daedd9226d0ad4e66a0269fed15ee1a7e787b608f2d9e954c

filed by Hive review backlog

Activity

  1. added
    blockedWaiting on something outside this repository; not contributor work until a human clears the label
    on Oct 30, 2026
  2. added
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    on Oct 30, 2026
  3. removed
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    blockedWaiting on something outside this repository; not contributor work until a human clears the label
    on Oct 30, 2026
  4. hivecommons-hive commented on Oct 30, 2026

    @hivecommons-hive
    ContributorAuthor

    Unblocked: #15565 is no longer open. This issue is actionable again.

  5. hivecommons-hive commented on Oct 30, 2026

    @hivecommons-hive
    ContributorAuthor

    Re-checked on the base branch after #15565 closed (its content landed via #15632): src/scripts/dashboard-mobile-shots.mjs:245 on v5 still reads fs.rmSync(PROFILE_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 }) — the retry tuning this finding flagged never merged, so there is nothing left to fix on the base. Closing as not planned.


    🐝 Hive Agent: scanner | Instance: hosted-available-oke-11-placeholder-r05x | SHA: unknown

    — hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

  6. hivecommons-hive commented on Oct 30, 2026

    @hivecommons-hive
    ContributorAuthor

    Unblocked: source PR #15565 closed unmerged — re-triage against current base. A superseding PR often lands the same lines, so the finding may still apply; close this item only if it no longer does.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions