Skip to content

🐛 [reviewer] already-landed empty-diff contributor PRs park at 085 instead of closing as superseded #15732

Closed

Description

@clubanderson

What happened

#15671 taught the hive to close its own already-landed PRs (empty diff against the base tip, reviewer names the PR that carried the change) as superseded instead of asking a person. It only covered hive-authored PRs.

#15544 (by a trusted contributor, for #15543) is +0/−0 against `v5` because the identical change landed via #15545 (merged). The reviewer returned `requires_human` with "@clubanderson should decide whether #15544 can be closed as a no-op now that #15545 (merged) carries this change" and the PR sat at 085 "Needs human decision" for 9h.

Expected

When the evidence is unambiguous — the PR's diff against the current base is empty and a merged landing PR is named by the reviewer / the linked issue was closed by a merged PR / the PR's commits are all contained in the base — the hive should close the PR as superseded for any author kind (contributor and trusted alike), comment "already landed via #N — closing as superseded; thank you @author", mark the tracker row superseded, and never route to 085. A PR whose diff is non-empty keeps the current behaviour.

Log reason: `already-landed:<author_kind>`. Tracker caption: "already landed via #N — closing as superseded".

Refs #15544, #15545, #15671.

Activity

  1. hivecommons-hive commented on Oct 30, 2026

    @hivecommons-hive
    Contributor

    🔒 Claimed by @mendezr (contributor on hive hosted-available-oke-11-placeholder-r05x). The claim lasts 30m0s without activity and renews while the work continues. Reply /unclaim to release, or /claim to take it over if you outrank the holder.

  2. added
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    on Oct 30, 2026
  3. hivecommons-hive commented on Oct 30, 2026

    @hivecommons-hive
    Contributor

    🔓 Claim by @mendezr released (lease revoked).

  4. github-actions commented on Oct 30, 2026

    @github-actions
    Contributor

    @clubanderson this issue was closed by @hivecommons-hive[bot] as completed.

    If this was closed by a merged PR, the fix only takes effect once it ships in a tagged release and your deployment updates to it — check your running version against the fix before concluding the fix failed.

    If you are still seeing the problem, comment /reopen and it will be reopened for you — you do not need write access. Please add what you are still observing (running version, logs, steps) so it is not closed the same way again.

  5. added a commit that references this issue on Oct 30, 2026
    0037265
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions