Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.d/fixed-topbar-hamburger-mobile.md
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
- Dashboard topbar: the ≑ drawer toggle is no longer clipped off the left edge on phones, and on ≀360px-wide screens the πŸ›/βš™ chips collapse into the account menu (which gains a Settings entry) instead of overflowing the row.
2 changes: 1 addition & 1 deletion src/docs/dashboard.md
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ On the v5 line the standalone Platform section is not part of the default dashbo

The light dashboard topbar keeps high-signal operational state only: project name, fleet controls, health, auth, and a compact ACMM autonomy chip such as `L5 Β· Semi-Autonomous`. The chip is display-only and navigates to the ACMM Eval section; changing levels remains in the existing ACMM dialog/sidebar controls.

Build/version details live in the bottom-left sidebar chip. The collapsed chip shows the short SHA, release channel, and an orange `↑` marker only when an upgrade is available. Open the chip for the full commit link, channel/tracking state, compare/release-notes links, last upgrade status when reported, copy-version, and the manual upgrade action. On small screens the sidebar is reachable through the hamburger drawer, so the version menu remains available without returning the long version strip to the topbar.
Build/version details live in the bottom-left sidebar chip. The collapsed chip shows the short SHA, release channel, and an orange `↑` marker only when an upgrade is available. Open the chip for the full commit link, channel/tracking state, compare/release-notes links, last upgrade status when reported, copy-version, and the manual upgrade action. On small screens the sidebar is reachable through the hamburger drawer, so the version menu remains available without returning the long version strip to the topbar. On the narrowest phones (≀360px wide) the topbar also drops the πŸ› feedback and βš™ Settings chips so the row never overflows; both stay reachable from the account (avatar) menu, and feedback from the drawer as well.

## Übersicht widget

Expand Down
11 changes: 11 additions & 0 deletions src/pkg/dashboard/static-src/css/responsive.css
Original file line number Diff line number Diff line change
Expand Up @@ -801,4 +801,15 @@
justify-content: center;
}
}
/* Narrowest phones (iPhone SE/mini class): the right strip's five icon
chips plus the ≑ and ACMM chips no longer fit one row, and the strip
clips overflow rather than wrapping, so the lowest-priority chips go.
Both stay reachable β€” Feedback from the drawer and the account menu,
Settings from the account menu (#15476). */
@media (max-width: 360px) {
#feedback-bug-btn,
#oc-settings-btn {
display: none;
}
}

6 changes: 4 additions & 2 deletions src/pkg/dashboard/static-src/css/topbar.css
Original file line number Diff line number Diff line change
Expand Up @@ -112,10 +112,12 @@
}
/* Drawer toggle. Hidden on desktop; the ≀1024px block flips it to
inline-flex. It lives with the project title so the center run-state
group remains visually anchored. */
group remains visually anchored. No negative margin: .oc-topbar-left
clips overflow, so anything pulled past its left edge is cut off β€”
on phones that showed up as a half-circle hamburger (#15476). */
#oc-drawer-toggle {
display: none;
margin-left: -10px;
flex: 0 0 auto;
}
#oc-drawer-backdrop { display: none; }
.oc-topbar-center { container: navbar-center / inline-size; position: relative; z-index: 1; justify-self: stretch; display: flex; align-items: center; justify-content: center; gap: var(--nav-chip-gap, 8px); min-width: 0; max-width: 100%; overflow: hidden; }
Expand Down
1 change: 1 addition & 0 deletions src/pkg/dashboard/static-src/html/topbar.html
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,7 @@
<a href="#" id="oc-gh-menu-my-hives" class="avatar-menu-item" target="_blank" rel="noopener noreferrer" hidden>My hives β†—</a>
<a href="/api/docs" target="_blank" class="avatar-menu-item">API Docs β†—</a>
<button class="avatar-menu-item" type="button" data-action="openFeedbackModal" data-arg0="submit">Feedback</button>
<button class="avatar-menu-item" type="button" id="oc-gh-menu-settings" data-action="openConfigDialog" data-arg0="governor">Settings</button>
<div class="avatar-menu-divider"></div>
<div id="oc-gh-menu-export-label" class="avatar-menu-label" hidden>Export</div>
<button type="button" id="oc-gh-menu-widget" class="avatar-menu-item" data-action="hiveOpenTextEndpoint" data-arg0="/api/widget" data-arg1="hive-widget.json" data-arg-types="s,s" title="View Übersicht widget JSON">⬇ Widget</button>
Expand Down
18 changes: 16 additions & 2 deletions src/pkg/dashboard/static/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -478,10 +478,12 @@
}
/* Drawer toggle. Hidden on desktop; the ≀1024px block flips it to
inline-flex. It lives with the project title so the center run-state
group remains visually anchored. */
group remains visually anchored. No negative margin: .oc-topbar-left
clips overflow, so anything pulled past its left edge is cut off β€”
on phones that showed up as a half-circle hamburger (#15476). */
#oc-drawer-toggle {
display: none;
margin-left: -10px;
flex: 0 0 auto;
}
#oc-drawer-backdrop { display: none; }
.oc-topbar-center { container: navbar-center / inline-size; position: relative; z-index: 1; justify-self: stretch; display: flex; align-items: center; justify-content: center; gap: var(--nav-chip-gap, 8px); min-width: 0; max-width: 100%; overflow: hidden; }
Expand Down Expand Up @@ -6200,6 +6202,17 @@
justify-content: center;
}
}
/* Narrowest phones (iPhone SE/mini class): the right strip's five icon
chips plus the ≑ and ACMM chips no longer fit one row, and the strip
clips overflow rather than wrapping, so the lowest-priority chips go.
Both stay reachable β€” Feedback from the drawer and the account menu,
Settings from the account menu (#15476). */
@media (max-width: 360px) {
#feedback-bug-btn,
#oc-settings-btn {
display: none;
}
}

/* ══ Input system (Phase 2) ══
One recipe for text inputs/selects/textareas (derived from the old
Expand Down Expand Up @@ -7108,6 +7121,7 @@ <h2 class="config-title">🐝 Getting Started<span id="welcome-progress" class="
<a href="#" id="oc-gh-menu-my-hives" class="avatar-menu-item" target="_blank" rel="noopener noreferrer" hidden>My hives β†—</a>
<a href="/api/docs" target="_blank" class="avatar-menu-item">API Docs β†—</a>
<button class="avatar-menu-item" type="button" data-action="openFeedbackModal" data-arg0="submit">Feedback</button>
<button class="avatar-menu-item" type="button" id="oc-gh-menu-settings" data-action="openConfigDialog" data-arg0="governor">Settings</button>
<div class="avatar-menu-divider"></div>
<div id="oc-gh-menu-export-label" class="avatar-menu-label" hidden>Export</div>
<button type="button" id="oc-gh-menu-widget" class="avatar-menu-item" data-action="hiveOpenTextEndpoint" data-arg0="/api/widget" data-arg1="hive-widget.json" data-arg-types="s,s" title="View Übersicht widget JSON">⬇ Widget</button>
Expand Down
15 changes: 14 additions & 1 deletion src/scripts/dashboard-mobile-shots.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,9 @@
// <viewport>-<theme>-<state>.png one screenshot per shot
// overflow-report.json array of findings:
// { viewport, theme, state, selector, bbox:{x,y,width,height}, kind, detail }
// kind: scroll-overflow | past-viewport | clipped-text | ellipsis-free-space
// kind: scroll-overflow | past-viewport | clipped-text | ellipsis-free-space | clipped-by-strip
// clipped-by-strip: a topbar chip whose box pokes outside an overflow-clipping
// ancestor strip (how the ≑ drawer toggle lost its left edge on phones, #15476).
//
// This is a reporting tool, not a gate: it exits 0 even when findings exist and
// exits 1 only when the harness itself errors. Chrome missing prints SKIP and exits 0.
Expand Down Expand Up @@ -184,6 +186,17 @@ const SCAN_EXPRESSION = `(() => {
if (r.right > vw + 1 || r.left < -1) {
add(el, 'past-viewport', r, 'right ' + round(r.right) + ' / left ' + round(r.left) + ' vs viewport ' + vw);
}
if (el.matches('.oc-topbar .nav-chip')) {
for (let n = el.parentElement; n && !n.classList.contains('oc-topbar'); n = n.parentElement) {
const nox = getComputedStyle(n).overflowX;
if (nox !== 'hidden' && nox !== 'clip') continue;
const nr = n.getBoundingClientRect();
if (r.left < nr.left - 1 || r.right > nr.right + 1) {
add(el, 'clipped-by-strip', r, 'chip spans ' + round(r.left) + '..' + round(r.right) + ' but overflow:' + nox + ' ancestor ' + pathFor(n) + ' spans ' + round(nr.left) + '..' + round(nr.right));
break;
}
}
}
if (hasOwnText(el) && el.scrollWidth > el.clientWidth + 1 && el.clientWidth > 0) {
if (cs.textOverflow === 'ellipsis' && ox === 'hidden') {
const tile = tileFor(el);
Expand Down
Loading