Skip to content

πŸ› tracker: one-line PR sub-row header - #15444

Merged
hivecommons-hive[bot] merged 1 commit into
v5from
fix/pr-subrow-one-line
Oct 29, 2026
Merged

hivecommons-hive[bot] merged 1 commit into
v5from
fix/pr-subrow-one-line

Conversation

@clubanderson

Copy link
Copy Markdown
Member

Fixes #15441

Problem

A PR nested under its issue in the Activity Monitor drew its header on three lines β€” the ↳ connector, then icon #N title, then the base-branch pill β€” before its chevron strip, and a long title wrapped further. Owner: "consolidate from 3 lines of text to 1 to compact the row".

Root cause: the ghost-strip PR cell (.ham-head-cols .ham-seg.ham-head-pr) was flex-direction: column, so each child was its own row, and .ham-pr-title / .ham-title were white-space: normal.

Change

  • tracker.css: the PR cell is a single nowrap flex row (align-items: center, min-width: 0, overflow: hidden). Connector and pills are flex: 0 0 auto; the PR link / title are flex: 0 1 auto with min-width: 0 and ellipsize (full text already on title=); the lineage / adopted-from chip gives way first (flex-shrink: 2, floor 7em) and ellipsizes. .ham-title (issue slot) and .ham-pr-title are nowrap; overflow: hidden; text-overflow: ellipsis, so the issue row and a top-level PR header never wrap either.
  • tracker-row.js: the sub-row puts the lineage / adopted-from chip in the PR cell, after the PR link and before the base pill (it used to sit in the chip cap); the single-PR issue row is reordered the same way (link β†’ lineage β†’ base pill). Ids/classes asserted by tests (ham-linked-ico, ham-pr-ref, ham-pr-num, ham-pr-title, ham-pr-line, ham-badge, ham-lineage, ham-adopted-from, ham-head-pr) are unchanged.
  • stage_tracker_ui_test.go: the node harness asserts the sub-row PR cell holds connector, PR link, lineage chip and base pill as siblings in that order with no block element between them, the PR link hover starts with the full title, the lineage chip is drawn once (not also in the cap), and the single-PR issue row keeps the same order. The prelude now lifts the real lineage-chip helpers.
  • changelog.d/changed-tracker-subrow-one-line.md.

Measured (headless Chromium, 1400 px wide, generated index.html + tokens.css, fixture issue with two covering PRs)

sub-row before after
short title, base pill 67 px (head 45 px β‰ˆ 2.9 lines) 40 px (head 18 px, 1 line)
long title, lineage chip, base pill 124 px (head 102 px) 40 px
whole issue row (2 sub-rows) 275 px 164 px

Before:

before: connector, title and base pill on three lines

After:

after: one line per sub-row, long title ellipsized, lineage chip and pill on the same line

Tests

go test -race ./pkg/dashboard/ -run 'StageTracker|Tracker|IndexHTML' and the full ./pkg/dashboard/ package pass locally.

@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Oct 29, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign nicholasjackson for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 29, 2026
@github-actions

github-actions Bot commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

PR Title Relation Files
#15400 πŸ› fix: keep merge queue position visible during sweeps same files src/pkg/dashboard/static/index.html
#15425 πŸ› fix: identify tracker claims from the local ledger same files src/pkg/dashboard/static-src/js/tracker-row.js
src/pkg/dashboard/static/index.html

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read tracker-row.js and tracker.css at 90bcf72 against the base. Looks correct to me.

Verified

  • The new >-child CSS rules actually match: stageTrackerHeadColsHtml (tracker-row.js:829) emits <li class="ham-seg ham-head-pr">${prRefs.join('')}</li>, and ref is glyph + <a class="ham-pr-ref">/<span class="ham-pr-line"> + lineage chip + base pill concatenated as direct children β€” no wrapper. The repo-chip case wraps only the link in .ham-pr-line, and that class has its own flex: 0 1 auto rule, so it shrinks the same way.
  • .ham-badge (flex: 0 0 auto) vs .ham-lineage (flex: 0 2 auto; min-width: 7em) have equal specificity on a ham-badge ham-lineage chip; the lineage rule is declared later, so it wins and the chip gives way first as the body says.
  • .ham-title going nowrap; ellipsis is safe for hover: both emit sites (tracker-row.js:1231, :1243) already set title="${esc(title)}".
  • Lineage chip removed from the cap cell at :992 and added once to the PR cell at :976; the new test asserts it's drawn exactly once. static/index.html matches static-src for both the CSS and JS hunks.
  • Single-PR issue row (:1201) reordered lineageβ†’base pill consistently with the sub-row.

Not run: go test is disabled in this pod.

β€” hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correctness review (read at head 79ef5c7, after the stated 90bcf72 moved on). Contract #15441 is met for the normal nested PR, the single-PR issue row and the top-level PR header; cascade checks out (tracker.css:116 display:block outranks .ham-lineage inline-flex at :395, so text-overflow applies). Two small things:

  1. Superseded sub-row can still wrap (low). The dimmed "adopted original" line goes through the same ham-head-pr cell (tracker-row.js:985) but its <span class="ham-superseded-note"> gets no sizing rule: it inherits white-space: normal from .ham-head-cols .ham-seg (tracker.css:103) and default min-width:auto, so when the cell is tight the note wraps onto extra lines while the title ellipsizes. Fix in tracker.css after line 118:
        .ham-head-cols .ham-seg.ham-head-pr > .ham-pr-ref, .ham-head-cols .ham-seg.ham-head-pr > .ham-pr-line { flex: 0 1 auto; }
        .ham-head-cols .ham-seg.ham-head-pr > .ham-superseded-note { flex: 0 1 auto; min-width: 0; white-space: nowrap; overflow: hidden; text-overflow: ellipsis; }
    
  2. Comment contradicts behaviour (info). tracker.css:111 says "the title gives way first (then the lineage chip)", but the rules give the chip flex-shrink: 2 (:116) vs the link's 1 (:118), i.e. the chip gives way first β€” which is what #15441 and the PR body ask for. Just fix the comment.

β€” hive: agent=ci-maintainer backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive

Copy link
Copy Markdown
Contributor

stage 080-awaiting-merge-admission β†’ 050-review-pending: required-check-pending:build-and-test

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed β€” no findings from this perspective.

β€” hive: agent=adjudicator-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed β€” no findings from this perspective.

β€” hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive

Copy link
Copy Markdown
Contributor

Hive filed review findings that do not block this PR as backlog items:

Cap: 10 backlog item(s) per PR per day.

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed β€” no findings from this perspective.

β€” hive: agent=ci-maintainer backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed β€” no findings from this perspective.

β€” hive: agent=ci-maintainer backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delta re-review (correctness) β€” head ecf8abb9 vs previously reviewed 79ef5c71.

The delta is only the v5 merge (#15442, auto-merge current-base default); compare/3feba139...ecf8abb9 touches just the PR's five files, so no new code was introduced by the merge. Prior correctness notes are unchanged at this head (low, non-blocking):

  • src/pkg/dashboard/static-src/css/tracker.css:111 β€” comment says the title gives way first, then the lineage chip; the rules do the opposite (.ham-lineage flex: 0 2 auto at :115 vs .ham-pr-title flex: 0 1 auto at :130).
  • src/pkg/dashboard/static-src/css/tracker.css:369 β€” .ham-superseded-note is rendered inside the now-nowrap PR cell (tracker-row.js:985) but has no white-space: nowrap/ellipsis rule, so a long superseded note can still wrap.

β€” hive: agent=adjudicator-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delta re-review (79ef5c7 β†’ ecf8abb) β€” the only new commit is Merge branch 'v5' pulling in #15442 (auto-merge current-base); none of the 9 delta files are PR-authored, so intent alignment against #15441 is unchanged. Still approve from this perspective; two prior low-severity notes remain as-is:

  1. src/pkg/dashboard/static-src/css/tracker.css:110-113 β€” the comment says "the title gives way first (then the lineage chip)", but the rules below (lineage flex: 0 2 auto at :115, .ham-pr-ref/.ham-pr-line flex: 0 1 auto at :117) and #15441 ("the lineage chip … giving way before the title") say the opposite. The code matches the issue; the comment is reversed.
        /* The PR cell is one line: connector, author icon + #N + title, lineage
           chip and base pill sit side by side; the lineage chip gives way first
           (then the title), the pills and the connector never shrink
           (hivecommons/hive "consolidate from 3 lines of text to 1"). */
    
  2. src/pkg/dashboard/static-src/css/tracker.css:369 β€” .ham-superseded-note is rendered as a direct child of the now-nowrap PR cell (tracker-row.js:985) but has no flex/white-space/ellipsis rule, so a long superseded note can still wrap inside the one-line sub-row. Minor (dimmed, superseded rows only).
        .ham-superseded-note { color: var(--muted); font-size: var(--fs-xs); flex: 0 1 auto; min-width: 0; white-space: nowrap; overflow: hidden; text-overflow: ellipsis; }
    

β€” hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks correct to me. Read the diff against the tree at ecf8abb, not just the hunks:

  • stageTrackerHeadColsHtml (tracker-row.js:829) emits <li class="ham-seg ham-head-pr">${prRefs.join('')}</li>, so the connector span, <a class="ham-pr-ref">, lineage chip and base pill really are direct children of the cell β€” the new .ham-head-pr > … selectors in tracker.css:112-116 match the markup, and the ham-pr-line wrapper case is covered by the > .ham-pr-line { flex: 0 1 auto } rule.
  • > .ham-badge { flex: 0 0 auto } and > .ham-lineage { flex: 0 2 auto } have equal specificity; the lineage rule is declared later and wins, so the chip (which has both classes, tracker-row.js:941) does shrink as intended.
  • The superseded branch (tracker-row.js:980-989) never rendered a lineage chip before this change (its chips arg was stageTrackerActedBadgeHtml only), so gating lineage on !superseded preserves behaviour rather than dropping anything.
  • Every .ham-title use (tracker-row.js:1231,1243,1247) sits inside a display:flex .ham-head-main, so nowrap; overflow:hidden; text-overflow:ellipsis actually takes effect.
  • go run ./pkg/dashboard/webstatic/gen … -check exits 0 on this head: static/index.html is in sync with static-src.

Only remaining nit is the one already filed as #15447 β€” the CSS comment at tracker.css:110-111 says the title gives way first, while the flex-shrink: 2 on the lineage chip (and the PR body) says the chip does. Not blocking.

β€” hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style (advisory, no blocker) β€” read at ecf8abb.

Two comments in src/pkg/dashboard/static-src/css/tracker.css now describe the layout this PR removes:

  • tracker.css:107 still says the PR cell "gives way to the chip, which lives in the cap cell" β€” the lineage / adopted-from chip now rides the PR cell (tracker-row.js:975-978); only the acted badge and stageTrackerChipsHtml remain in the cap (tracker-row.js:992).
  • tracker.css:119-122 still explains the cap's align-items: flex-end by "on a two-line title it sits on the second line" β€” titles no longer wrap (.ham-title / .ham-pr-title are nowrap + ellipsis, tracker.css:130,145), so that case cannot occur.
    /* Lead = exactly three of the six equal chevrons (half of the strip
       minus the fixed 4em cap and the six gaps) plus the two gaps between
       them, so the PR cell starts at the PR in progress chevron; the PR cell takes what
       is left; the acted badge and stage chips live in the cap cell. */
    /* The cap's badges sit on the baseline of the one-line title
       (align-items: flex-end inside the stretched cap cell), directly over
       the strip they describe. */

Also, the new comments at tracker.css:113 and tracker-row.js:970 cite the issue by quote (hivecommons/hive "consolidate from 3 lines…") β€” the file's convention is hivecommons/hive#NNNNN (e.g. tracker.css:16,238,317); hivecommons/hive#15441 would make it greppable.

β€” hive: agent=adjudicator backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive

Copy link
Copy Markdown
Contributor

@clubanderson is auto-promoted for contributor-lane merging on this PR: the last 5 merged PRs by this author in this hive's repositories have no revert or sentinel-alert evidence. CI, reviewer verdict, diff fences, soak, holds and branch protection still apply.

@hivecommons-hive

Copy link
Copy Markdown
Contributor

stage 080-awaiting-merge-admission β†’ 050-review-pending: required-check-pending:build-and-test

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read the diff against v5 at 2900a33 plus the surrounding tracker.css / tracker-row.js; this looks correct to me.

What I verified:

  • src/pkg/dashboard/static-src/css/tracker.css:114 β€” the new row rule (.ham-head-cols .ham-seg.ham-head-pr, 3 classes) outranks the align-items: flex-start base at line 103 (2 classes), so align-items: center and flex-direction: row do take effect. .ham-seg (line 282) already carries min-width: 0; overflow: hidden, and .ham-head-main (line 125) has min-width: 0, so the nowrap + text-overflow: ellipsis on .ham-title (line 145) and .ham-pr-title actually ellipsizes instead of overflowing the cell.
  • tracker.css:115-116 β€” > .ham-badge { flex: 0 0 auto } and > .ham-lineage { flex: 0 2 auto } have equal specificity; the lineage rule is later, so the ham-badge ham-lineage chip shrinks first as the body describes.
  • tracker.css:605-614 β€” the ≀1100px grid keeps .ham-head-pr spanning the full row; the new flex-row rule composes with it rather than fighting it.
  • tracker-row.js:977-982 β€” in the repo-chip case ref is wrapped in .ham-pr-line before the lineage chip and base pill are appended, so they stay direct siblings of the cell, which is exactly what the new node assertion at stage_tracker_ui_test.go:725-733 checks. The superseded early-return (tracker-row.js:984) is byte-identical to v5, so the dimmed adopted-original line is unchanged.
  • make's go run ./pkg/dashboard/webstatic/gen … -check passes on this head: the committed static/index.html is in sync with static-src/.
  • The new prelude symbols (jsConstBlock, STAGE_TRACKER_LINEAGE_REASON_TIP, stageTrackerAgoText in tracker-motion.js:38) all exist, so the harness lifts real code.

One low-severity note, not a blocker: .ham-superseded-note (tracker.css:369) has no white-space/flex rule of its own and inherits white-space: normal from .ham-head-cols .ham-seg (line 103), so on a tight row the "Β· superseded by #N" text can still wrap inside its flex item and give that sub-row a second line. If the one-line goal is meant to cover adopted originals too, a white-space: nowrap; flex: 0 0 auto on it would close that gap. I did not measure it in a browser.

β€” hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed β€” no findings from this perspective.

β€” hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed β€” no findings from this perspective.

β€” hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88

@github-actions github-actions Bot added the conflicts-with-open-pr Open PR has a merge conflict with another open PR label Oct 29, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor

stage 060-reviewed β†’ 050-review-pending: required-check-pending:build-and-test

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed β€” no findings from this perspective.

β€” hive: agent=ci-maintainer backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read the diff against v5 plus the callers it touches (stageTrackerSubRowHtml, the single-covering-PR branch in stageTrackerRowHtml, and stageTrackerHeadColsHtml at tracker-row.js:840). Looks correct to me, and the body matches what the code does.

What I verified:

  • The lineage / adopted-from chip now lives in the PR cell instead of the chip cap (tracker-row.js:985 vs the old cap-arg at :1005), and the superseded branch never drew it before, so superseded ? '' keeps that row unchanged.
  • The one-PR issue row (tracker-row.js:1214) only reorders link β†’ lineage β†’ base pill; nothing else in that expression changed.
  • .ham-head-cols .ham-seg.ham-head-pr is flex-direction: row with min-width: 0; overflow: hidden, .ham-head-main gains overflow: hidden, and .ham-title / .ham-pr-title are flex: 0 1 auto; min-width: 0 β€” the ellipsis has a shrinkable ancestor on both the lead and PR cells. The issue-row .ham-title change is in scope per #15441 ("The issue row and the top-level PR header keep to one line the same way").
  • static/index.html mirrors static-src line for line (33/33 changed lines).
  • The new harness block in stage_tracker_ui_test.go asserts sibling order and "drawn once", which fails on the old flex-direction: column + cap-chip layout.

Two notes, neither blocking:

  1. tracker.css:120-123 β€” the comment above .ham-head-cols .ham-seg.cap still says the chip "hugs the bottom of the title block … on a two-line title it sits on the second line". Titles no longer wrap, so that rationale is stale; worth a one-line edit while you're here.
  2. conflicts-with-open-pr is real: #15457 rewrites the same stageTrackerHeadColsHtml([ref], …) line at tracker-row.js:999 (appending the lead button to the cap). git merge-tree reports a conflict on tracker-row.js and static/index.html. Resolution is mechanical β€” drop the lineage-chip term, keep the stageTrackerLeadButtonHtml term β€” whichever lands second.

β€” hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive

Copy link
Copy Markdown
Contributor

stage 080-awaiting-merge-admission β†’ 050-review-pending: required-check-pending:build-and-test

@hivecommons-hive

Copy link
Copy Markdown
Contributor

@clubanderson this PR is held at stage/071-needs-author and the hive will not merge it yet.

Why:

  • the branch conflicts with the base and needs a rebase

Next: the hive does not push to your branch. Push a new head (or reply here); CI and the review swarm re-run automatically and the PR returns to the normal path.

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks correct to me. Read tracker-row.js and tracker.css at 8b68da1 against the v5 tree.

  • The sub-row change is a move, not a duplication: the lineage/adopted-from chip leaves stageTrackerHeadColsHtml's cap argument and joins ref before the base pill (static-src/js/tracker-row.js, sub-row branch), and the single-PR issue row is reordered to match; the new harness assertion that ham-lineage appears exactly once in the head guards against it reappearing in the cap.
  • .ham-title is the top-level issue row's title (tracker-row.js:1244, :1256), so the nowrap/ellipsis rule reaches main rows too β€” the PR body states this is intended ("the issue row and a top-level PR header never wrap either"), and the title= attribute already carries the full text, so nothing is lost on hover.
  • static/index.html carries the same CSS block as static-src/css/tracker.css, so the generated artifact and source agree.

Open question, not verified: whether the ellipsized .ham-title reads well at the Dashboard Mobile Shots viewport β€” the body's measurements are at 1400 px only.

β€” hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed β€” no findings from this perspective.

β€” hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88

A PR nested under its issue drew its header on three lines: the ↳
connector, then the author icon + #N + title, then the base-branch pill,
because the PR cell of the ghost strip was a flex column and the title
wrapped. The cell is now a single nowrap flex row β€” connector, repo
chip, PR link, lineage / adopted-from chip, base pill β€” the title
ellipsizes with its full text on hover, the lineage chip gives way
before the title, and pills never shrink. Issue titles and the
top-level PR header ellipsize the same way. Sub-row height 67 β†’ 40 px
(124 β†’ 40 px with a long title and a lineage chip) at 1400 px wide.

Signed-off-by: Andrew Anderson <andy@clubanderson.com>
@hivecommons-hive
hivecommons-hive Bot force-pushed the fix/pr-subrow-one-line branch from 8b68da1 to 9d9ee59 Compare October 29, 2026 19:00
@hivecommons-hive

Copy link
Copy Markdown
Contributor

hive/awaiting-ci: rebased onto v5 (kept the v5 lead-button cap slot alongside this PR's lineage-chip move; regenerated index.html). CI pending β€” sweep will merge when green.


🐝 Hive Agent: scanner | Instance: hosted-available-oke-11-placeholder-r05x | SHA: 9d9ee5996

β€” hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive

Copy link
Copy Markdown
Contributor

@clubanderson this PR is back in your court (stage/071-needs-author). Its commits are signed off as the hive App rather than as you, so a squash merge would misattribute them and the sign-off attribution check stays red. No hive agent can rewrite a contributor's commits β€” the fix is yours:

  • 1 commit is signed off as the hive App instead of you, so a squash merge would misattribute it β€” set git config user.email to your own address, then run git commit --amend --reset-author -s && git push --force-with-lease

Once the new head lands, CI and the review swarm re-run automatically and the PR returns to the normal path.

@hivecommons-hive
hivecommons-hive Bot merged commit b276166 into v5 Oct 29, 2026
77 of 78 checks passed
@kubestellar-prow
kubestellar-prow Bot deleted the fix/pr-subrow-one-line branch October 29, 2026 19:09
@hivecommons-hive

Copy link
Copy Markdown
Contributor
Evidence bundle `#154448b68da1` sha256:037fee793c77286c1b0468eb54db04538f31a1324e3fca0080c14444e63f7dca β€” download from the dashboard or `hivectl review evidence #15444`.

@hivecommons-hive

Copy link
Copy Markdown
Contributor

merged by Hive trusted-author auto-merge: author @clubanderson holds role owner and GitHub permission admin on repo; CI green at 9d9ee59.

@github-actions

Copy link
Copy Markdown
Contributor

Thank you for your contribution! Your PR has been merged.

We'd love to hear how your experience was: share feedback

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read the diff against the tree at 9d9ee59 (tracker-row.js, tracker.css, the test harness). Looks correct to me.

What I checked:

  • The lineage / adopted-from chip is a direct child of .ham-seg.ham-head-pr on all three render paths, so the new > child selectors at tracker.css:115-118 actually apply: sub-row (tracker-row.js:999-1002, appended after the .ham-pr-line wrapper closes when repo chips are on), single-PR issue row (:1225), and top-level PR row (:1263, no base pill). stageTrackerHeadColsHtml (:842) joins prRefs straight into the <li> with no wrapper.
  • .ham-lineage carries ham-badge too (:954, :977). tracker.css:115 (.ham-badge { flex: 0 0 auto }) and :116 (.ham-lineage { flex: 0 2 auto }) have equal specificity, and :116 is later, so the chip shrinks and the plain base pill does not β€” the ordering is load-bearing but correct as written.
  • Every .ham-title lives inside .ham-head-main (tracker-row.js:1255, :1267, :1271), which now has overflow: hidden; min-width: 0 (tracker.css:125), so nowrap + text-overflow ellipsizes instead of overflowing the fixed-width lead cell; each has title= for hover.
  • Superseded sub-row (:1004-1011) never drew the cap lineage chip before and doesn't now β€” no behaviour change there.

Info only, not blocking: two CSS comments now describe the old layout β€” tracker.css:104-107 ("gives way to the chip, which lives in the cap cell") and :119-122 ("on a two-line title it sits on the second line"). Titles can no longer be two lines and the lineage chip no longer lives in the cap.

β€” hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-signoff: yes Indicates the PR's author has signed the DCO. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tracker PR sub-row spends three lines on connector, title and base pill

1 participant