Repository navigation
π tracker: row actions show progress, surface failures, and advisory Close really closes - #15445
Conversation
β¦Close really closes Close (read) on an advisory row did nothing: runRowAction mapped every decide:* id through stageTrackerDecisionTarget, which only yields a target for a parked PR or a needs-decision issue, so the advisory's empty target list returned silently - no request, no dialog, no toast (tracker row history: [], no audit entry, no pod log line for 15381). - close-read acts on the advisory row itself; an empty decide target list now toasts a warning instead of returning silently - every mutating row action shows the striped busy chevron with the verb caption, then a terminal 'Closed/Merged Β· leaving list' caption until the next tracker payload drops the row - server drops operator-closed items from the tracker for HIVE_OPERATOR_CLOSED_GRACE (default 15m) so a stale GitHub list cannot resurrect the row - close on an operator-paused repo is refused (200 status: refused) with the reason and writes nothing; refused/failed/errored actions restore the chevron, toast the reason and note it on the history badge; the ledger records refused answers as failed - Go handler/tracker tests and Node harness progress/failure tests Signed-off-by: Andrew Anderson <andy@clubanderson.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Changelog: this PR changes code but carries no changelog entry If it is user-visible β a feature, a fix an operator would notice, a This is a reminder, not a gate; it never blocks a merge. |
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of
|
|
@clubanderson is auto-promoted for contributor-lane merging on this PR: the last 5 merged PRs by this author in this hive's repositories have no revert or sentinel-alert evidence. CI, reviewer verdict, diff fences, soak, holds and branch protection still apply. |
|
stage 080-awaiting-merge-admission β 050-review-pending: required-check-pending:Sign-off survives the squash |
There was a problem hiding this comment.
One concrete blocker, otherwise the change reads correctly to me.
Blocker β changelog fragment is in the wrong directory (src/changelog.d/fixed-tracker-advisory-close-progress.md). src/scripts/check-changelog-fragment.sh:51 rejects any fragment under src/changelog.d/ ("fragments live in changelog.d/ at the repo root"), and that is why changelog-fragment-guard is red on d86117a. The body says the fragment is at changelog.d/β¦, so this looks like a mis-placed git add. Fix: git mv src/changelog.d/fixed-tracker-advisory-close-progress.md changelog.d/. (Your sibling PRs #15442 and #15444 have theirs at the root.)
Verified against the tree
runRowAction(tracker-actions.js:1857):rowsis declared at:1821before the newstageTrackerNothingToActOn(id, rows)calls, so no scope issue; thedecide:close-readbranch sits before the genericdecide:*mapping, so advisory rows are no longer sent throughstageTrackerDecisionTarget.stageTrackerDropOperatorClosedkeys onDetail == "closed"; the close branch inapi_repo_item_decision.go:483does answerStatus: "closed"andoperatorActionOutcomerecordsdetail = str("status"), so the ledger match holds for all three ofoperatorClosedActions.stage_tracker.go:2336-2337recomputesOpenIssues/OpenPRsafter the drop;stageTrackerOpenCountswas already the counter at:2331, so the header numbers stay consistent.- Paused-repo refusal is placed before
CreateIssueComment, so nothing is written;writebackGateRef,RepoPausedDetail,RepoPauseForall exist.go build ./pkg/dashboard/passes at this head.
Not run: go test (disabled in this pod); relying on your stated green run.
β hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88
Signed-off-by: Andrew Anderson <andy@clubanderson.com>
|
stage 080-awaiting-merge-admission β 050-review-pending: required-check-pending:build-and-test |
|
Thank you for your contribution! Your PR has been merged. We'd love to hear how your experience was: share feedback |
Fixes #15436
Root cause
runRowAction(tracker-actions.js) maps everydecide:*id throughstageTrackerDecisionTarget(it), which only yields a target for a parked PR or aneeds-decisionissue. An advisory row is stage 0 with no modifiers, so Close (read) on #15381 produced an empty target list and the function returned{toasts: [], pending: []}β no confirm dialog, no request, no toast, no busy state.Evidence (live spoke
e0f8bd901):/api/stage-trackerrow for 15381 β"history": [];/api/audithas no decision/close entry; pod logs (6h) have no15381/close-readline. The server'sclose-readbranch is correct and unit-tested (#15418) β it was never reached.Fix
decide:close-readacts on the advisory row itself; anydecide:*click with an empty target list now toasts a warning instead of returning silently.stageTrackerRunActions, no per-action code.stageTrackerDropOperatorCloseddrops items whose newest ledger action is an appliedclose-*forHIVE_OPERATOR_CLOSED_GRACE(default 15m), and open counts are recomputed, so a stale GitHub list cannot bring the row back.status: refusedwith Close refused: repo paused β β¦ and writes nothing.failedwith the one-line why.Tests
TestRepoItemDecisionCloseReadAdvisoryFixtureAndPausedRefusal(real triage: duplicate and overlapping open issues/PRs to consolidateΒ #15381 labels/title/body fixture: closes via comment + state; paused repo β structured refusal, no writes),TestStageTrackerDropOperatorClosed, newTestOperatorActionOutcomecases.TestStageTrackerAdvisoryCloseReadProgressβ click β busy Closingβ¦ β terminal Closed Β· leaving list β row removed from the next payload; refused and 403 paths restore the label and surface the reason.go test -race ./pkg/dashboard/ -run 'StageTracker|Decision|Advisory|Operator|IndexHTML', full./pkg/dashboard/,./pkg/writeback/all green.Docs:
docs/dashboard-sections.mdrow-actions section; changelogchangelog.d/fixed-tracker-advisory-close-progress.md.