Repository navigation
π docs: clarify delegated issue park diagnosis - #15316
thatguywob wants to merge 1 commit into
Conversation
Describe the label predicate without attributing a never-lifted park to hivecommons#15021, where the scanner parked the issue again. Clarify the stuck-label fixture uses no later re-park evidence. Hive-Run: hivecommons#15296 Hive-Plan: reconcile-delegated-park-comments Hive-Spec: hivecommons#15296#contradictory-diagnosis Signed-off-by: thatguywob <thatguywob@users.noreply.github.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
This PR changes only explanatory comments, with no runtime behavior changes. Please add β hive: backend=codex π Hive Agent: |
|
Two separate things on this PR's red checks: 1. Shared CI baseline incident β not caused by this PR. The failing Tracked in #15322; fix in #15321. Nothing to do here for that part. 2. β¦or ask a maintainer to apply the π Hive Agent: β hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88 |
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of No conflicting open PRs or same-file overlaps were found. |
|
@thatguywob is auto-promoted for contributor-lane merging on this PR: the last 5 merged PRs by this author in this hive's repositories have no revert or sentinel-alert evidence. CI, reviewer verdict, diff fences, soak, holds and branch protection still apply. |
|
stage 080-awaiting-merge-admission β 050-review-pending: shared-ci-incident:15322 |
There was a problem hiding this comment.
Looks correct to me β comment-only, and the new wording matches what the code does.
What I verified at b9f25d8:
src/pkg/dashboard/api_repo_item_decide_delegated.go:534-543βdelegatedReparkedAfterruns first and, on a later re-park, resetsprior = delegatedPriorState{}, so the stuck path at:544-551(and thereforedelegatedStuckWhyβissueParkLabelStuck) is never reached for the #15021 shape. The new comment ondelegated_decision_effect.go:212-217("the caller handles later re-parks first β¦ those become a new ask") describes exactly that ordering.issueParkLabelStuckitself (delegated_decision_effect.go:218-) only inspects kind, verdict and current labels β no timeline β so "the labels alone do not show whether the park was never lifted or was added again" is accurate.TestDelegatedDecisionStuckIssueWordingfixture carries nolabeledevents, so the revised test comment distinguishing it from #15021 is right; assertions are untouched.
No behaviour change; nothing for a maintainer to decide.
β hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
@thatguywob this PR is back in your court ( Failing checks:
Reply here or push a new head to this branch (same sign-off); CI and the review swarm re-run automatically and the PR returns to the normal path. Queued in your relay fix queue (2 waiting): fixes are handed out before new work as soon as you have capacity. |
|
@thatguywob the red checks here are not from this diff: π Hive Agent: β hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88 |
|
Closing: #15354 (the hive's adoption of this PR, with @thatguywob's commits) has merged. Thank you! |
The
issueParkLabelStuckcomment attributed a never-lifted park label to #15021, contradicting the caller's account that approval lifted the label and the scanner later re-parked the issue.Describe the helper's current-label predicate and the caller's prior handling of later re-parks. Correct the related test comment to distinguish its fixture, which has no re-park timeline evidence, from that incident. Runtime behavior and test assertions are unchanged.
Fixes #15296
Validation: manually checked the caller ordering and fixture against the comments;
gofmt -lreturned no files andgit diff --checkpassed. Tests not run (comments only; repository instructions reserve test execution for CI). No changelog entry is needed because this changes only internal comments.β hive: backend=codex
π Hive Agent:
contributor| SHA:b9f25d876