Skip to content

πŸ“– docs: clarify delegated issue park diagnosis - #15354

Merged
hivecommons-hive[bot] merged 3 commits into
v5from
hive/adopt-15316
Oct 29, 2026
Merged

hivecommons-hive[bot] merged 3 commits into
v5from
hive/adopt-15316

Conversation

@hivecommons-hive

Copy link
Copy Markdown
Contributor

Supersedes #15316 (adopted after CI went red and the contributor was unavailable; original commits by @thatguywob preserved).

Fixes #15296

This branch is #15316's head b9f25d876c13 as pushed by @thatguywob (fork thatguywob/hive), unchanged. Last lane reason on the original: required-check-failing:build-and-test.

Hive fix agent: rebase this branch on v5, fix the failing checks / review asks, and push to THIS branch. Keep the original author's commits and their Signed-off-by; add your own sign-off on your commits. Do not open another PR.

thatguywob and others added 2 commits October 29, 2026 05:31
Describe the label predicate without attributing a never-lifted park to #15021, where the scanner parked the issue again. Clarify the stuck-label fixture uses no later re-park evidence.

Hive-Run: #15296
Hive-Plan: reconcile-delegated-park-comments
Hive-Spec: #15296#contradictory-diagnosis
Signed-off-by: thatguywob <thatguywob@users.noreply.github.com>
@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Oct 29, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign nicholasjackson for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@github-actions

Copy link
Copy Markdown
Contributor

Changelog: this PR changes code but carries no changelog entry
(no changelog.d/ fragment and no CHANGELOG.md edit).

If it is user-visible β€” a feature, a fix an operator would notice, a
security change, a migration, a deprecation, or anything breaking β€”
please add a fragment file changelog.d/<category>-<pr-or-slug>.md
containing exactly your entry (see changelog.d/README.md; the
category is one of added/changed/deprecated/fixed/security). Please
do not append to CHANGELOG.md's ## Unreleased directly β€” that
shared section is the merge-conflict generator fragments replaced
(#5675). If it is a refactor, a test-only change, or dependency
churn, no entry is needed and you can ignore this.

This is a reminder, not a gate; it never blocks a merge.

@kubestellar-prow kubestellar-prow Bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 29, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

PR Title Relation Files
#15316 πŸ“– docs: clarify delegated issue park diagnosis same files src/pkg/dashboard/api_repo_item_decide_delegated_test.go
src/pkg/dashboard/delegated_decision_effect.go

Generated by changelog-fragment-guard from the PR title (#5675).
Edit the wording freely, or replace this file with the no-changelog
label if the change is not user-visible.

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Signed-off-by: hivecommons-hive[bot] <280983584+hivecommons-hive[bot]@users.noreply.github.com>
@hivecommons-hive hivecommons-hive Bot added author/hive This repository's own hive (the App or one of its agent lanes) authored this PR dco All commits are DCO signed-off role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/070-fixing Hive-authored PR: CI red, changes requested or needs rebase; a hive agent is fixing it stage/050-review-pending Review swarm requested; awaiting a verdict for the current head and removed stage/070-fixing Hive-authored PR: CI red, changes requested or needs rebase; a hive agent is fixing it labels Oct 29, 2026

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks correct to me. Comment-only change plus the changelog fragment that #15316 was missing.

I verified the new issueParkLabelStuck comment against the caller rather than taking it on faith: src/pkg/dashboard/api_repo_item_decide_delegated.go:539-542 calls delegatedReparkedAfter and resets prior when a park label was re-applied after the recorded decision, and only then (:551) reaches delegatedStuckWhy, whose case issueParkLabelStuck(in, d) at delegated_decision_effect.go:203 fires. So "the caller handles later re-parks first" is an accurate description of the code, and the old attribution of a never-lifted label to #15021 was indeed contradicted by the caller's own comment on the same incident.

Relationship to #15316: the two source hunks are byte-identical to thatguywob/hive@b9f25d8; the only addition here is changelog.d/changed-15354.md, which is what turned changelog-fragment-guard green. Once this lands, #15316 becomes a no-op against v5 and can be closed by a maintainer β€” I have not closed anything.

β€” hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks correct to me. Comment-only change; runtime and test assertions are untouched.

I verified the new wording against the code rather than the PR body:

  • src/pkg/dashboard/delegated_decision_effect.go:212-217 now says the caller handles later re-parks first. It does: src/pkg/dashboard/api_repo_item_decide_delegated.go:539 calls delegatedReparkedAfter and clears prior before delegatedStuckWhy runs at :551, and that caller's own comment (:534-538) records #15021 as approve-lifted-045-then-scanner-re-parked β€” so the old attribution of #15021 to a "never came off" label was indeed wrong.
  • api_repo_item_decide_delegated_test.go:622-628: the fixture (repoItemDecisionMock{issueLabels: ...} + priorComments) supplies no timeline events, so "no re-park timeline evidence" is accurate.

Relation to #15316: this branch carries #15316's head b9f25d8 unchanged plus changelog.d/changed-15354.md, which is the fragment changelog-fragment-guard failed #15316 for. The two cannot both land; this one is the survivor (green guard, hive-pushable branch). Flagging for a maintainer: if you agree, #15316 could be closed in favour of this PR once it merges. I have not closed anything.

β€” hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot added stage/060-reviewed Review swarm verdict approve; a gate is still pending (CI running, soak not started) and removed stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Oct 29, 2026
@hivecommons-hive
hivecommons-hive Bot merged commit 7ee6367 into v5 Oct 29, 2026
82 of 87 checks passed
@kubestellar-prow
kubestellar-prow Bot deleted the hive/adopt-15316 branch October 29, 2026 08:25
@hivecommons-hive

Copy link
Copy Markdown
Contributor Author
Evidence bundle `#15354b0dca54` sha256:0f5978a76b4d75a4559a3773dd761db5858cf79683b6fcae3c9d5b0925b9bfaa β€” download from the dashboard or `hivectl review evidence #15354`.

@github-actions

Copy link
Copy Markdown
Contributor

Thank you for your contribution! Your PR has been merged.

We'd love to hear how your experience was: share feedback

@hivecommons-hive hivecommons-hive Bot removed role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/060-reviewed Review swarm verdict approve; a gate is still pending (CI running, soak not started) labels Oct 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author/hive This repository's own hive (the App or one of its agent lanes) authored this PR copilot dco All commits are DCO signed-off dco-signoff: yes Indicates the PR's author has signed the DCO. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Review backlog (correctness): Contradictory #15021 diagnosis in comments (previous finding, still present)

1 participant