Repository navigation
π docs: clarify delegated issue park diagnosis - #15354
Conversation
Describe the label predicate without attributing a never-lifted park to #15021, where the scanner parked the issue again. Clarify the stuck-label fixture uses no later re-park evidence. Hive-Run: #15296 Hive-Plan: reconcile-delegated-park-comments Hive-Spec: #15296#contradictory-diagnosis Signed-off-by: thatguywob <thatguywob@users.noreply.github.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Changelog: this PR changes code but carries no changelog entry If it is user-visible β a feature, a fix an operator would notice, a This is a reminder, not a gate; it never blocks a merge. |
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of
|
Generated by changelog-fragment-guard from the PR title (#5675). Edit the wording freely, or replace this file with the no-changelog label if the change is not user-visible. Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Signed-off-by: hivecommons-hive[bot] <280983584+hivecommons-hive[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Looks correct to me. Comment-only change plus the changelog fragment that #15316 was missing.
I verified the new issueParkLabelStuck comment against the caller rather than taking it on faith: src/pkg/dashboard/api_repo_item_decide_delegated.go:539-542 calls delegatedReparkedAfter and resets prior when a park label was re-applied after the recorded decision, and only then (:551) reaches delegatedStuckWhy, whose case issueParkLabelStuck(in, d) at delegated_decision_effect.go:203 fires. So "the caller handles later re-parks first" is an accurate description of the code, and the old attribution of a never-lifted label to #15021 was indeed contradicted by the caller's own comment on the same incident.
Relationship to #15316: the two source hunks are byte-identical to thatguywob/hive@b9f25d8; the only addition here is changelog.d/changed-15354.md, which is what turned changelog-fragment-guard green. Once this lands, #15316 becomes a no-op against v5 and can be closed by a maintainer β I have not closed anything.
β hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88
There was a problem hiding this comment.
Looks correct to me. Comment-only change; runtime and test assertions are untouched.
I verified the new wording against the code rather than the PR body:
src/pkg/dashboard/delegated_decision_effect.go:212-217now says the caller handles later re-parks first. It does:src/pkg/dashboard/api_repo_item_decide_delegated.go:539callsdelegatedReparkedAfterand clearspriorbeforedelegatedStuckWhyruns at:551, and that caller's own comment (:534-538) records #15021 as approve-lifted-045-then-scanner-re-parked β so the old attribution of #15021 to a "never came off" label was indeed wrong.api_repo_item_decide_delegated_test.go:622-628: the fixture (repoItemDecisionMock{issueLabels: ...}+priorComments) supplies no timeline events, so "no re-park timeline evidence" is accurate.
Relation to #15316: this branch carries #15316's head b9f25d8 unchanged plus changelog.d/changed-15354.md, which is the fragment changelog-fragment-guard failed #15316 for. The two cannot both land; this one is the survivor (green guard, hive-pushable branch). Flagging for a maintainer: if you agree, #15316 could be closed in favour of this PR once it merges. I have not closed anything.
β hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
Thank you for your contribution! Your PR has been merged. We'd love to hear how your experience was: share feedback |
Supersedes #15316 (adopted after CI went red and the contributor was unavailable; original commits by @thatguywob preserved).
Fixes #15296
This branch is #15316's head
b9f25d876c13as pushed by @thatguywob (forkthatguywob/hive), unchanged. Last lane reason on the original:required-check-failing:build-and-test.Hive fix agent: rebase this branch on
v5, fix the failing checks / review asks, and push to THIS branch. Keep the original author's commits and theirSigned-off-by; add your own sign-off on your commits. Do not open another PR.