Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/pkg/dashboard/api_repo_item_decide_delegated_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -619,9 +619,10 @@ func TestReparkFromEvents(t *testing.T) {
}
}

// TestDelegatedDecisionStuckIssueWording reproduces hivecommons/hive#15021:
// the hive approved an ISSUE (`default-approve`), approved-direction landed
// but stage/045-needs-decision never came off. Past the effect timeout the
// TestDelegatedDecisionStuckIssueWording covers an approved issue with both
// approved-direction and stage/045-needs-decision, with no later re-park
// recorded. Unlike hivecommons/hive#15021, this fixture has no timeline
// evidence that the park lifted and was added again. Past the effect timeout the
// toast must not say "approved for merge" (nothing merges on an issue),
// must name the stuck label, and must offer the lift first.
func TestDelegatedDecisionStuckIssueWording(t *testing.T) {
Expand Down
10 changes: 6 additions & 4 deletions src/pkg/dashboard/delegated_decision_effect.go
Original file line number Diff line number Diff line change
Expand Up @@ -209,10 +209,12 @@ func (s *Server) delegatedStuckWhy(in delegatedecision.Input, d delegatedecision
}
}

// issueParkLabelStuck reports the case seen on hivecommons/hive#15021: the
// hive approved an issue and `approved-direction` landed, but the
// stage/045-needs-decision park label never came off, so the scanner keeps
// skipping the issue. The toast names the label and offers the lift.
// issueParkLabelStuck reports an approved issue that still carries both
// approved-direction and stage/045-needs-decision. The labels alone do not
// show whether the park was never lifted or was added again. The caller
// handles later re-parks first (hivecommons/hive#15021: approve lifted 045,
// then the scanner re-parked), so those become a new ask rather than a
// stuck-label diagnosis. The toast names the label and offers the lift.
func issueParkLabelStuck(in delegatedecision.Input, d delegatedecision.Decision) bool {
if in.Kind != delegatedecision.KindIssue || d.Verdict != delegatedecision.VerdictApprove {
return false
Expand Down
Loading