Repository navigation
✨ Soak countdown on every soak pill, with the live timer on hover - #15223
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of
|
828bdf4 to
eeef25c
Compare
Generated by changelog-fragment-guard from the PR title (#5675). Edit the wording freely, or replace this file with the no-changelog label if the change is not user-visible. Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Signed-off-by: clubanderson <407614+clubanderson@users.noreply.github.com>
|
@clubanderson is auto-promoted for contributor-lane merging on this PR: the last 5 merged PRs by this author in this hive's repositories have no revert or sentinel-alert evidence. CI, reviewer verdict, diff fences, soak, holds and branch protection still apply. |
|
@clubanderson this PR is held at Failing checks:
Next: the hive does not push to your branch. Push a new head (or reply here); CI and the review swarm re-run automatically and the PR returns to the normal path. |
The pass records the soak it holds a head for on the stage record
(NoteSoak) whether the lane admitted it (095) or trust still blocks it
(060/080, RouteHuman's soak evidence), the tracker payload carries it as
soak {started_at, until, window_s, head_sha}, and the SPA counts one
clock down on every soak pill, flips to ready past the window, notices a
replaced head and writes the live time left into the chevron hover.
Signed-off-by: Andrew Anderson <andy@clubanderson.com>
4fa2c81 to
c66f4dc
Compare
|
Thank you for your contribution! Your PR has been merged. We'd love to hear how your experience was: share feedback |
Fixes #15218
What
Record.SoakHead / SoakStartedAt / SoakWindowSecondswithStore.NoteSoak / ClearSoakandRecord.Soak().automerge_stage_soak.go): every pass writes the soak it holds the head for — from the lane'ssoaking(remaining=…)reason after admission (095), or from RouteHuman's soak evidence on a green trust-blocked head (060/080, including a head first seen green this pass and one past the window) — and clears it otherwise.soak: {started_at, until, window_s, head_sha}; the issue's nested linked PR mirrors it. Legacy 095 records withoutNoteSoakfall back to the reason's remaining, aged from the sweep, with the configured window.stageTrackerSoakClock / SoakWords / SoakTick— one clock on every soak pill: "Soaking · 12m left" counting down in place; "ready — next sweep in 3m" past the window (060/080 keep their word with "soak 25m left" / "soaked — next sweep in 42s"); "Soak restarted · new head" when the row's head is not the soaked one. "merge sweep running" no longer hides the clock. The tick rewrites the live hover sentence ("Head abc1234 must sit 30 minutes without new commits before the hive merges it · 12m 30s left · soak ends 8:42 PM") into the chevron's and glyph'stitle/aria-labelwithout a re-render. Static glyph — no spinner (🐛 fix: stop the status symbols rotating on tracker chevrons #15189 stays).Tests
TestStoreNoteSoak(stagelabels),TestSoakWindowFor/TestNoteSoakWritesAndClears(automerge).TestStageTrackerSoakPayload/TestStageTrackerSoakInPayload/TestStageTrackerSoakNode(dashboard; node fixture covers countdown, ready, restarted, 060 variant, issue mirror, tick + hover refresh, no spin).TestStageTrackerMergeGateNodeupdated for the clock attributes.