Repository navigation
π Prefer covering PR progress in Activity Monitor messages - #15236
Conversation
Signed-off-by: Andy Anderson <andy@clubanderson.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of No conflicting open PRs or same-file overlaps were found. |
|
@clubanderson is auto-promoted for contributor-lane merging on this PR: the last 5 merged PRs by this author in this hive's repositories have no revert or sentinel-alert evidence. CI, reviewer verdict, diff fences, soak, holds and branch protection still apply. |
Signed-off-by: Andy Anderson <andy@clubanderson.com>
There was a problem hiding this comment.
Read against v5 with the callers (stage_tracker.go:2042-2043 ordering, stageTrackerResolveLinkedPRs, stageTrackerPruneSoftLinks, stageTrackerResolveActors). The core of the change is sound: "its PR" is the actor value the stage-040 captions already use (stage_tracker.go:1508,1523,1525), so the stageTrackerResolveActors extension at stage_tracker_actor.go:343 is consistent, and the hold/blocked/issue-decision guards are tested.
One finding I think is worth fixing before this lands:
Medium β a reverse soft link rewrites the issue's narration as "Covered by". stageTrackerPruneSoftLinks keeps Refs/mention links whose target is a listed open issue (stage_tracker.go:2697 only drops soft links to PRs or to unlisted mentions; stageTrackerLinkSoft at :2564 is anything not PRLinkViaFixes). The PR-side pass at :2745 then appends that PR to issue.LinkedPRs regardless of Via. The new stageTrackerLinkedPRProgress (:2835) fires on any sub-040 issue with a non-empty LinkedPRs, and chooses its prefix from stageengine.ReasonIsPartialCover(it.Reason) (:2853). For a reverse-only link the issue's Reason was derived without that PR β that is the exact case the resolver exists for ("even when the issue's own claim evidence has not caught up", :2714) β so Reason is not a partial-cover reason and the caption becomes "Covered by PR #M β β¦" for a PR that merely wrote Refs #N or mentioned the issue. Before this change such a link only nested the strip and left the issue's own caption (e.g. Claimed / Actionable) intact. Consequence: an operator reads an actionable or claimed issue as handled when the PR deliberately does not close it. Suggested fix: when deciding the prefix, also consult the linked PR's LinkedIssues entry for this issue (stageTrackerLinkSoft(li) β "Partially covered by"), or skip the rewrite when every link to the issue is soft. The existing boundary test only exercises the partial case via Reason, so it would not catch this.
Info, no action needed: the stageTrackerIsNew change (stage_tracker_new.go:65) checks len(it.LinkedPRs) > 0, but at the issue-intake call site applyStageTrackerNew runs at stage_tracker.go:1937, before it.LinkedPRs is filled at :1941-1945, so that clause is dead there; only the LinkedPR > 0 half and the later it.New = nil in the new function do the work. Moving the append above applyStageTrackerNew would make the predicate self-sufficient.
β hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
@clubanderson this PR is held at Why:
Next: the hive does not push to your branch. Push a new head (or reply here); CI and the review swarm re-run automatically and the PR returns to the normal path. |
Signed-off-by: Andy Anderson <andy@clubanderson.com>
|
CI iteration: the new payload and row/event regression tests passed, including initial New + existing PR, PR-side reverse linkage, refresh, multi/shared rows, and no-PR behavior. CI also exposed an existing endpoint assertion that explicitly expected the stale scanner actor on an issue already covered by PR #103; updated that assertion to require the PR actor and current caption. Re-running CI with that expectation corrected. No queue records or runtime deployment changed. |
|
@clubanderson this PR is held at Why:
Next: the hive does not push to your branch. Push a new head (or reply here); CI and the review swarm re-run automatically and the PR returns to the normal path. |
|
Validation on latest head 56331a1: all four dashboard coverage shards and all three randomized/race dashboard lanes PASS; package coverage-floor gate PASS; golangci-lint PASS; changelog-fragment guard and DCO PASS. This includes the new linked-PR payload, boundaries, and rendered-row/Hive-event regressions plus the corrected endpoint assertion. General image/build workflow checks may still be queued. PR remains open; no merge or deployment performed. |
|
merged by Hive trusted-author auto-merge: author @clubanderson holds role owner and GitHub permission admin on repo; CI green at 56331a1. |
|
Thank you for your contribution! Your PR has been merged. We'd love to hear how your experience was: share feedback |
β¦15301) * π Let hive decide: close already-fixed PRs instead of adopting them Delegated decisions on contributor PRs now walk a ladder before the contributor-offline adopt-supersede rule: already-fixed (issue closed by a merged PR, or a merged PR declares supersession) β close as superseded with a note naming the merging PR; mergeable-as-is β merge gate; rebase-then-merge (recorded, lands with #15104); return-to-contributor when the author's clanker or hive is connected or picked the rework up; adopt-supersede only last, never for owner/human PRs. Each rung logs why the previous ones did not apply; the toast says why; the decide API exposes decision.ladder {decision, reason, ruled_out}. Wording names the author's clanker vs hive truthfully. Fixes #15289 Signed-off-by: Andrew Anderson <andy@clubanderson.com> * π± dashboard: stage_tracker_linked_progress_test compiles against the open-vouch signature v5 landed #15236 and #15253 side by side; the former's test still called stageTrackerResolveLinkedPRs with one argument. Signed-off-by: Andrew Anderson <andy@clubanderson.com> --------- Signed-off-by: Andrew Anderson <andy@clubanderson.com>
β¦out per repo) (#15442) The current-base gate (auto_merge.require_current_base, #13634) only ran for listed repos, so the hive that merges hivecommons/hive merged #15236 green-but-stale and broke v5 for every open PR for 20 minutes (#15335). - Gate is now on for every repo by default (auto_merge.require_current_base_default, nil = true). - auto_merge.skip_current_base: [owner/repo] opts a repo out. - An explicit require_current_base entry stays strict; a repo gated only by the default merges a behind head the App cannot update (fork without maintainer edits, branch protection / 403) as tested, with one WARN per PR, so the default does not park every fork PR fleet-wide. Refs #15335 Signed-off-by: Andrew Anderson <andy@clubanderson.com> Co-authored-by: hivecommons-hive[bot] <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Root cause
Issue intake narration (
new, caption, next actor) was finalized before issue-side PR links were copied and before reverse PR closing references were resolved. The visual PR strip already used PR progress, but the issue payload and Hive event diff retained the old New/scanner caption.Change
Related: #15218. Its soak countdown request already has PR #15223; this PR addresses the separate stale tracker message and does not claim to resolve the countdown issue.
Validation
gofmt -lon all changed Go files: clean.git diff --check: clean.