Skip to content

πŸ› Prefer covering PR progress in Activity Monitor messages - #15236

Merged
hivecommons-hive[bot] merged 3 commits into
v5from
fix/tracker-linked-pr-hive-message
Oct 29, 2026
Merged

hivecommons-hive[bot] merged 3 commits into
v5from
fix/tracker-linked-pr-hive-message

Conversation

@clubanderson

Copy link
Copy Markdown
Member

Root cause

Issue intake narration (new, caption, next actor) was finalized before issue-side PR links were copied and before reverse PR closing references were resolved. The visual PR strip already used PR progress, but the issue payload and Hive event diff retained the old New/scanner caption.

Change

  • Reconcile issue narration after final PR linkage, preferring current covering-PR captions and actors, without changing stage/store/queue records.
  • Stop treating known PR coverage as New; preserve no-PR intake, independent holds/blockers/issue decisions, partial coverage, and metadata-free links.
  • Cover initial payload, refresh to another PR caption, issue-side and reverse links, single/multiple/shared row rendering, tooltip, and Hive event markup with regression fixtures.

Related: #15218. Its soak countdown request already has PR #15223; this PR addresses the separate stale tracker message and does not claim to resolve the countdown issue.

Validation

  • gofmt -l on all changed Go files: clean.
  • git diff --check: clean.
  • Repository AGENTS.md requires Go tests and dashboard package coverage floors to run in CI only; monitoring those results. No local builds/tests, rollout, queue edits, or merge.

Signed-off-by: Andy Anderson <andy@clubanderson.com>
@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Oct 29, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign clubanderson for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 29, 2026
@github-actions

github-actions Bot commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

No conflicting open PRs or same-file overlaps were found.

@hivecommons-hive

Copy link
Copy Markdown
Contributor

@clubanderson is auto-promoted for contributor-lane merging on this PR: the last 5 merged PRs by this author in this hive's repositories have no revert or sentinel-alert evidence. CI, reviewer verdict, diff fences, soak, holds and branch protection still apply.

@hivecommons-hive hivecommons-hive Bot added author/human A person pushed this PR themselves dco All commits are DCO signed-off role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Oct 29, 2026
Signed-off-by: Andy Anderson <andy@clubanderson.com>

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read against v5 with the callers (stage_tracker.go:2042-2043 ordering, stageTrackerResolveLinkedPRs, stageTrackerPruneSoftLinks, stageTrackerResolveActors). The core of the change is sound: "its PR" is the actor value the stage-040 captions already use (stage_tracker.go:1508,1523,1525), so the stageTrackerResolveActors extension at stage_tracker_actor.go:343 is consistent, and the hold/blocked/issue-decision guards are tested.

One finding I think is worth fixing before this lands:

Medium β€” a reverse soft link rewrites the issue's narration as "Covered by". stageTrackerPruneSoftLinks keeps Refs/mention links whose target is a listed open issue (stage_tracker.go:2697 only drops soft links to PRs or to unlisted mentions; stageTrackerLinkSoft at :2564 is anything not PRLinkViaFixes). The PR-side pass at :2745 then appends that PR to issue.LinkedPRs regardless of Via. The new stageTrackerLinkedPRProgress (:2835) fires on any sub-040 issue with a non-empty LinkedPRs, and chooses its prefix from stageengine.ReasonIsPartialCover(it.Reason) (:2853). For a reverse-only link the issue's Reason was derived without that PR β€” that is the exact case the resolver exists for ("even when the issue's own claim evidence has not caught up", :2714) β€” so Reason is not a partial-cover reason and the caption becomes "Covered by PR #M β€” …" for a PR that merely wrote Refs #N or mentioned the issue. Before this change such a link only nested the strip and left the issue's own caption (e.g. Claimed / Actionable) intact. Consequence: an operator reads an actionable or claimed issue as handled when the PR deliberately does not close it. Suggested fix: when deciding the prefix, also consult the linked PR's LinkedIssues entry for this issue (stageTrackerLinkSoft(li) β†’ "Partially covered by"), or skip the rewrite when every link to the issue is soft. The existing boundary test only exercises the partial case via Reason, so it would not catch this.

Info, no action needed: the stageTrackerIsNew change (stage_tracker_new.go:65) checks len(it.LinkedPRs) > 0, but at the issue-intake call site applyStageTrackerNew runs at stage_tracker.go:1937, before it.LinkedPRs is filled at :1941-1945, so that clause is dead there; only the LinkedPR > 0 half and the later it.New = nil in the new function do the work. Moving the append above applyStageTrackerNew would make the predicate self-sufficient.

β€” hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot added stage/071-needs-author Human-authored PR: CI red, changes requested or conflicting; diagnosis posted, the author must act and removed stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Oct 29, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor

@clubanderson this PR is held at stage/071-needs-author and the hive will not merge it yet.

Why:

  • the review swarm requested changes

Next: the hive does not push to your branch. Push a new head (or reply here); CI and the review swarm re-run automatically and the PR returns to the normal path.

Signed-off-by: Andy Anderson <andy@clubanderson.com>
@clubanderson

Copy link
Copy Markdown
Member Author

CI iteration: the new payload and row/event regression tests passed, including initial New + existing PR, PR-side reverse linkage, refresh, multi/shared rows, and no-PR behavior. CI also exposed an existing endpoint assertion that explicitly expected the stale scanner actor on an issue already covered by PR #103; updated that assertion to require the PR actor and current caption. Re-running CI with that expectation corrected. No queue records or runtime deployment changed.

@hivecommons-hive hivecommons-hive Bot added stage/050-review-pending Review swarm requested; awaiting a verdict for the current head stage/071-needs-author Human-authored PR: CI red, changes requested or conflicting; diagnosis posted, the author must act and removed stage/071-needs-author Human-authored PR: CI red, changes requested or conflicting; diagnosis posted, the author must act stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Oct 29, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor

@clubanderson this PR is held at stage/071-needs-author and the hive will not merge it yet.

Why:

  • the review swarm requested changes

Next: the hive does not push to your branch. Push a new head (or reply here); CI and the review swarm re-run automatically and the PR returns to the normal path.

@clubanderson

Copy link
Copy Markdown
Member Author

Validation on latest head 56331a1: all four dashboard coverage shards and all three randomized/race dashboard lanes PASS; package coverage-floor gate PASS; golangci-lint PASS; changelog-fragment guard and DCO PASS. This includes the new linked-PR payload, boundaries, and rendered-row/Hive-event regressions plus the corrected endpoint assertion. General image/build workflow checks may still be queued. PR remains open; no merge or deployment performed.

@hivecommons-hive

Copy link
Copy Markdown
Contributor
Evidence bundle `#1523656331a1` sha256:d326449b1c5cba49163e882df268ea5b77f4ad01d1015c83f1a057545d3cb7dc β€” download from the dashboard or `hivectl review evidence #15236`.

@hivecommons-hive

Copy link
Copy Markdown
Contributor

merged by Hive trusted-author auto-merge: author @clubanderson holds role owner and GitHub permission admin on repo; CI green at 56331a1.

@github-actions

Copy link
Copy Markdown
Contributor

Thank you for your contribution! Your PR has been merged.

We'd love to hear how your experience was: share feedback

clubanderson added a commit that referenced this pull request Oct 29, 2026
…open-vouch signature

v5 landed #15236 and #15253 side by side; the former's test still called
stageTrackerResolveLinkedPRs with one argument.

Signed-off-by: Andrew Anderson <andy@clubanderson.com>
clubanderson added a commit that referenced this pull request Oct 29, 2026
…15301)

* πŸ› Let hive decide: close already-fixed PRs instead of adopting them

Delegated decisions on contributor PRs now walk a ladder before the
contributor-offline adopt-supersede rule: already-fixed (issue closed by a
merged PR, or a merged PR declares supersession) β†’ close as superseded
with a note naming the merging PR; mergeable-as-is β†’ merge gate;
rebase-then-merge (recorded, lands with #15104); return-to-contributor
when the author's clanker or hive is connected or picked the rework up;
adopt-supersede only last, never for owner/human PRs. Each rung logs why
the previous ones did not apply; the toast says why; the decide API
exposes decision.ladder {decision, reason, ruled_out}. Wording names the
author's clanker vs hive truthfully.

Fixes #15289

Signed-off-by: Andrew Anderson <andy@clubanderson.com>

* 🌱 dashboard: stage_tracker_linked_progress_test compiles against the open-vouch signature

v5 landed #15236 and #15253 side by side; the former's test still called
stageTrackerResolveLinkedPRs with one argument.

Signed-off-by: Andrew Anderson <andy@clubanderson.com>

---------

Signed-off-by: Andrew Anderson <andy@clubanderson.com>
hivecommons-hive Bot added a commit that referenced this pull request Oct 29, 2026
…out per repo) (#15442)

The current-base gate (auto_merge.require_current_base, #13634) only ran
for listed repos, so the hive that merges hivecommons/hive merged #15236
green-but-stale and broke v5 for every open PR for 20 minutes (#15335).

- Gate is now on for every repo by default
  (auto_merge.require_current_base_default, nil = true).
- auto_merge.skip_current_base: [owner/repo] opts a repo out.
- An explicit require_current_base entry stays strict; a repo gated only
  by the default merges a behind head the App cannot update (fork without
  maintainer edits, branch protection / 403) as tested, with one WARN per
  PR, so the default does not park every fork PR fleet-wide.

Refs #15335

Signed-off-by: Andrew Anderson <andy@clubanderson.com>
Co-authored-by: hivecommons-hive[bot] <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author/human A person pushed this PR themselves dco All commits are DCO signed-off dco-signoff: yes Indicates the PR's author has signed the DCO. role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) size/L Denotes a PR that changes 100-499 lines, ignoring generated files. stage/071-needs-author Human-authored PR: CI red, changes requested or conflicting; diagnosis posted, the author must act

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant