Repository navigation
✨ Activity Monitor: Accept triage on the label-less reporter-trust hold, leading the row menu - #15221
Conversation
…ld, leading the row menu A 000-new issue the reporter-trust gate holds for a maintainer (no stage label yet, next_mover: maintainer) offered no Accept triage: the menu predicate only fired on 015 / needs-triage. Offer it there too, lead every triage row's menu with it, hint what the click writes and as whom with the hive's next pass, carry the governor's next scanner pass in the result toast, and narrate the accepted 000-new row (server and optimistic alike) as waiting on the hive with the triage gate done. Fixes #15215 Signed-off-by: Andrew Anderson <andy@clubanderson.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@clubanderson is auto-promoted for contributor-lane merging on this PR: the last 5 merged PRs by this author in this hive's repositories have no revert or sentinel-alert evidence. CI, reviewer verdict, diff fences, soak, holds and branch protection still apply. |
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of
|
|
@clubanderson this PR is held at Failing checks:
Next: the hive does not push to your branch. Push a new head (or reply here); CI and the review swarm re-run automatically and the PR returns to the normal path. |
Signed-off-by: Andrew Anderson <andy@clubanderson.com>
|
Thank you for your contribution! Your PR has been merged. We'd love to hear how your experience was: share feedback |
Fixes #15215 — "no option to accept triage" (live: #15198).
Problem
A label-less issue from an un-admitted reporter reads as a 000-new row ("New · waiting for a maintainer's triage (add
triage/accepted); the hive's next pass in 13m") but its "⋯" menu had no Accept triage:stageTrackerTriageNeededonly fired on stage 015 or theneeds-triagemodifier. The handler (POST …/items/{n}/accept-triage, #13805) was already there.Change
Client (
static/index.html)stageTrackerTriageNeededalso fires on a 000-new issue withnew.next_mover: "maintainer".needs-triage/ 000-new hold), separated from the generic items; hint: "addstriage/acceptedas @you; the hive takes it on its next pass (≈N min)" (label from the row's narration when configured otherwise; ETA fromnew.next_pass_atelse the governor'snextKickAt). Wraps per 🐛 fix: wrap the row menu's consequence hints under their label #15176's hinted-menu style.stageTrackerActionCtxcarriesloginand the governor for the hint.Server
stage_tracker_new.go: when the accept label is already on the issue, the 000-new narration reads the hive as next mover with the triage gate done ("triage accepted (label)") — so the reconcile confirms the optimistic row even while the bucket still saysreporter_triage.api_repo_item_accept_triage.go: result's next line is "Hive picks it up on its next scanner pass (≈13m); …" from the governor's published next kick.Write path, attribution and gating are unchanged:
repo_item_accept_triageaudit entry as the signed-in user; same guard as Hold (repo write or verified owner; 401/403 otherwise).Decline triage… not added: no "triage declined" label concept exists in
pkg/stagelabels/pkg/config— Hold with a reason remains the inverse.Tests
TestStageTrackerNewState(accept label on → hive mover, gate done),TestRepoItemAcceptTriageNextPassETA, result line asserted inTestRepoItemAcceptTriageAuthorizationAndLabels(403/401/audit already covered).TestStageTrackerAcceptTriageMenuVisibility): leads the menu, hint text with/without login & ETA, shows on the 000-new maintainer hold, not on an admitted new issue / PR / plain Open row, optimistic 000-new patch.go test ./pkg/dashboard/...(incl. webstatic style ratchet) green.