Skip to content

✨ Activity Monitor: Accept triage on the label-less reporter-trust hold, leading the row menu - #15221

Merged
clubanderson merged 2 commits into
v5from
feat/accept-triage-action
Oct 29, 2026
Merged

clubanderson merged 2 commits into
v5from
feat/accept-triage-action

Conversation

@clubanderson

Copy link
Copy Markdown
Member

Fixes #15215 — "no option to accept triage" (live: #15198).

Problem

A label-less issue from an un-admitted reporter reads as a 000-new row ("New · waiting for a maintainer's triage (add triage/accepted); the hive's next pass in 13m") but its "⋯" menu had no Accept triage: stageTrackerTriageNeeded only fired on stage 015 or the needs-triage modifier. The handler (POST …/items/{n}/accept-triage, #13805) was already there.

Change

Client (static/index.html)

  • stageTrackerTriageNeeded also fires on a 000-new issue with new.next_mover: "maintainer".
  • Accept triage leads the menu on every triage row (015 / needs-triage / 000-new hold), separated from the generic items; hint: "adds triage/accepted as @you; the hive takes it on its next pass (≈N min)" (label from the row's narration when configured otherwise; ETA from new.next_pass_at else the governor's nextKickAt). Wraps per 🐛 fix: wrap the row menu's consequence hints under their label #15176's hinted-menu style.
  • Optimistic row: 015 → 010 Actionable (unchanged); a 000-new row flips to the hive-mover narration (triage ✓ → actionable (next) → claimed), 👤 gone.
  • stageTrackerActionCtx carries login and the governor for the hint.

Server

  • stage_tracker_new.go: when the accept label is already on the issue, the 000-new narration reads the hive as next mover with the triage gate done ("triage accepted (label)") — so the reconcile confirms the optimistic row even while the bucket still says reporter_triage.
  • api_repo_item_accept_triage.go: result's next line is "Hive picks it up on its next scanner pass (≈13m); …" from the governor's published next kick.

Write path, attribution and gating are unchanged: repo_item_accept_triage audit entry as the signed-in user; same guard as Hold (repo write or verified owner; 401/403 otherwise).

Decline triage… not added: no "triage declined" label concept exists in pkg/stagelabels / pkg/config — Hold with a reason remains the inverse.

Tests

  • Go: TestStageTrackerNewState (accept label on → hive mover, gate done), TestRepoItemAcceptTriageNextPassETA, result line asserted in TestRepoItemAcceptTriageAuthorizationAndLabels (403/401/audit already covered).
  • Node fixture (TestStageTrackerAcceptTriageMenuVisibility): leads the menu, hint text with/without login & ETA, shows on the 000-new maintainer hold, not on an admitted new issue / PR / plain Open row, optimistic 000-new patch.
  • go test ./pkg/dashboard/... (incl. webstatic style ratchet) green.

…ld, leading the row menu

A 000-new issue the reporter-trust gate holds for a maintainer (no stage
label yet, next_mover: maintainer) offered no Accept triage: the menu
predicate only fired on 015 / needs-triage. Offer it there too, lead every
triage row's menu with it, hint what the click writes and as whom with the
hive's next pass, carry the governor's next scanner pass in the result
toast, and narrate the accepted 000-new row (server and optimistic alike)
as waiting on the hive with the triage gate done.

Fixes #15215

Signed-off-by: Andrew Anderson <andy@clubanderson.com>
@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Oct 29, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign clubanderson for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 29, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor

@clubanderson is auto-promoted for contributor-lane merging on this PR: the last 5 merged PRs by this author in this hive's repositories have no revert or sentinel-alert evidence. CI, reviewer verdict, diff fences, soak, holds and branch protection still apply.

@github-actions

github-actions Bot commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

PR Title Relation Files
#15134 🐛 Delegated decision on a capability gap: model the blocker, stop the un-park/re-park loop, name the missing App permission same files src/pkg/dashboard/stage_tracker_row_actions_test.go
src/pkg/dashboard/static/index.html
#15228 ✨ tracker: waiting-on chip shows human or bot icon instead of text qualifier same files src/pkg/dashboard/static/index.html
#15186 🐛 Activity Monitor: one coherent post-decision state for Let hive decide rows; 060 reviewed in CI / Review same files src/pkg/dashboard/stage_tracker_row_actions_test.go
src/pkg/dashboard/static/index.html
#15085 ✨ Activity Monitor: Adopt now and Reroute to another clanker for PRs waiting on a contributor's clanker same files src/pkg/dashboard/stage_tracker_row_actions_test.go
src/pkg/dashboard/static/index.html
#15206 🐛 Activity Monitor: delegated adopt-supersede reports executing → adopted/could-not-adopt, routes workflow-path to the workflows blocker, re-adoption survives the mutation journal same files src/pkg/dashboard/static/index.html
#15219 🐛 fix: preserve human and owner PRs during delegated decisions same files src/pkg/dashboard/static/index.html
#15200 🐛 fix: tracker history column wears a history mark, not a ✓ same files src/pkg/dashboard/static/index.html
#15122 🐛 Write-back containment: per-kind gate for every unsolicited GitHub write, with backfill guard same files src/pkg/dashboard/static/index.html
#15104 🐛 Activity Monitor: Rebase, then merge as maintainer; fixer owns parked conflicting PRs; dismiss self-inflicted changes_requested same files src/pkg/dashboard/stage_tracker_row_actions_test.go
src/pkg/dashboard/static/index.html
#14807 ✨ dashboard: stream Job pod logs in the terminal pane for sandbox.runtime: job agents same files src/pkg/dashboard/static/index.html
#15223 ✨ Soak countdown on every soak pill, with the live timer on hover same files src/pkg/dashboard/static/index.html

@hivecommons-hive hivecommons-hive Bot added author/human A person pushed this PR themselves dco All commits are DCO signed-off role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Oct 29, 2026
@hivecommons-hive hivecommons-hive Bot added stage/071-needs-author Human-authored PR: CI red, changes requested or conflicting; diagnosis posted, the author must act and removed stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Oct 29, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor

@clubanderson this PR is held at stage/071-needs-author and the hive will not merge it yet.

Failing checks:

  • build-and-test

Next: the hive does not push to your branch. Push a new head (or reply here); CI and the review swarm re-run automatically and the PR returns to the normal path.

Signed-off-by: Andrew Anderson <andy@clubanderson.com>
@hivecommons-hive hivecommons-hive Bot removed the stage/071-needs-author Human-authored PR: CI red, changes requested or conflicting; diagnosis posted, the author must act label Oct 29, 2026
@hivecommons-hive hivecommons-hive Bot added the stage/050-review-pending Review swarm requested; awaiting a verdict for the current head label Oct 29, 2026
@clubanderson
clubanderson merged commit 0744bf1 into v5 Oct 29, 2026
74 of 77 checks passed
@kubestellar-prow
kubestellar-prow Bot deleted the feat/accept-triage-action branch October 29, 2026 01:49
@github-actions

Copy link
Copy Markdown
Contributor

Thank you for your contribution! Your PR has been merged.

We'd love to hear how your experience was: share feedback

@hivecommons-hive hivecommons-hive Bot removed role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Oct 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author/human A person pushed this PR themselves dco All commits are DCO signed-off dco-signoff: yes Indicates the PR's author has signed the DCO. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

✨ Activity Monitor: no option to accept triage on a label-less issue the reporter-trust gate holds

1 participant