Skip to content

πŸ› fix: tracker history column wears a history mark, not a βœ“ - #15200

Merged
clubanderson merged 1 commit into
v5from
fix/history-icon-tracker
Oct 29, 2026
Merged

clubanderson merged 1 commit into
v5from
fix/history-icon-tracker

Conversation

@clubanderson

@clubanderson clubanderson commented Oct 29, 2026 •

Copy link
Copy Markdown
Member

Fixes #15199

What

The right-most Activity Monitor tracker column showed a βœ“ everywhere β€” column header, every unmerged row's cap chevron, and the green "did I act on this?" pill β€” which operators read as "done / passed". It is the row's decision/action history.

Owner: "the checkmarks are misleading - they should show some other kind of icon. something to do with history".

Change

  • New history glyph in STAGE_TRACKER_ICONS (clock with a counter-clockwise arrow, inline SVG like the other tracker glyphs), used by:
    • the column header cap (hover + aria-label "History β€” decisions and actions on this item"),
    • the unmerged cap chevron (muted outline, aria-label "History β€” no decisions or actions recorded yet"),
    • the acted badge in every state (STAGE_TRACKER_ACTED_GLYPH), now a neutral filled pill (--text / --panel-strong, not the green "ok" colour and not the brand amber the stuck state uses) with the recorded-action count (.ham-acted-n, data-ham-acted-count) and an aria-label History: N action(s) β€” <action> β€” <state>. Stuck / failed / pending keep amber / red / dotted.
  • The green βœ“ (icon 110) remains only once a PR has merged (sg.terminal), so the merge celebration is unchanged.
  • Hover popover content/behaviour, element ids (ham-acted-tip-*) and classes are unchanged.
  • stage_tracker_acted.test.js: asserts the history glyph, the count badge, the aria-label, that no βœ“/βœ—/… remains in the badge glyph slot, that the header and unmerged cap use the history icon, and that the badge is not green. operator_actions_test.go lifts the new consts.
  • Docs (dashboard-sections.md) and changelog fragment.

No new raw hex / font-size / padding / border-radius literals (tokens only).

Before / after

(screenshots in the comment below)

Screenshots (hive's hive, live data)

Before β€” βœ“ in the header, every unmerged cap and the acted badge (green βœ“ reads as "done"):

before: tracker right-most column shows a check mark in the header, on each unmerged cap and as a green acted badge

After β€” history mark (clock + counter-clockwise arrow) in the header and caps; the acted badge is a neutral pill with the action count (amber only when stuck):

after: tracker right-most column shows a history clock icon in the header and caps, and a neutral pill with the action count where a human acted

@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Oct 29, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign clubanderson for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 29, 2026
@clubanderson

Copy link
Copy Markdown
Member Author

Before β€” βœ“ column header, grey βœ“ cap on every row, green βœ“ pill when a human acted:

before: a column of checkmarks, header βœ“, green βœ“ pill on acted rows

After β€” history mark (clock + counter-clockwise arrow) in the header (hover "History β€” decisions and actions on this item") and the unmerged cap; the acted badge is a neutral pill with the action count (amber = stuck); the hover history is unchanged:

after: history icon header and caps, neutral history badge with count 2, stuck badge in amber, hover popover open

after: neutral history badges with count 1 on addressed rows, muted outline history mark in each unmerged cap

Captured live from hive's hive with the branch's render functions and CSS injected over the running page (no backend change).

@hivecommons-hive hivecommons-hive Bot added author/human A person pushed this PR themselves dco All commits are DCO signed-off stage/071-needs-author Human-authored PR: CI red, changes requested or conflicting; diagnosis posted, the author must act labels Oct 29, 2026
@github-actions

github-actions Bot commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

PR Title Relation Files
#14807 ✨ dashboard: stream Job pod logs in the terminal pane for sandbox.runtime: job agents same files src/pkg/dashboard/static/index.html
#15228 ✨ tracker: waiting-on chip shows human or bot icon instead of text qualifier same files src/pkg/dashboard/static/index.html
#15208 πŸ› fix: decidePR answers capability-gap, not adopt-supersede, for heads the App cannot adopt same files src/pkg/dashboard/static/index.html
#15223 ✨ Soak countdown on every soak pill, with the live timer on hover same files src/pkg/dashboard/static/index.html
#15134 πŸ› Delegated decision on a capability gap: model the blocker, stop the un-park/re-park loop, name the missing App permission same files src/docs/dashboard-sections.md
src/pkg/dashboard/static/index.html
#15186 πŸ› Activity Monitor: one coherent post-decision state for Let hive decide rows; 060 reviewed in CI / Review same files src/docs/dashboard-sections.md
src/pkg/dashboard/stage_tracker_motion_test.go
src/pkg/dashboard/stage_tracker_ui_test.go
src/pkg/dashboard/static/index.html
#15241 πŸ› tracker: keep a closed linked issue as the row head instead of promoting the PR same files src/pkg/dashboard/stage_tracker_motion_test.go
src/pkg/dashboard/stage_tracker_ui_test.go
src/pkg/dashboard/static/index.html
#15216 πŸ› Sentinel: a dashboard Approve releases the head for good; skip Prow-rejected /lgtm + /approve same files src/docs/dashboard-sections.md
#15219 πŸ› fix: preserve human and owner PRs during delegated decisions same files src/pkg/dashboard/static/index.html
#15122 πŸ› Write-back containment: per-kind gate for every unsolicited GitHub write, with backfill guard same files src/pkg/dashboard/static/index.html
#15206 πŸ› Activity Monitor: delegated adopt-supersede reports executing β†’ adopted/could-not-adopt, routes workflow-path to the workflows blocker, re-adoption survives the mutation journal same files src/pkg/dashboard/operator_actions_test.go
src/pkg/dashboard/static/index.html
#15104 πŸ› Activity Monitor: Rebase, then merge as maintainer; fixer owns parked conflicting PRs; dismiss self-inflicted changes_requested same files src/docs/dashboard-sections.md
src/pkg/dashboard/static/index.html
#15240 πŸ› Never adopt a person's PR: owner/human-authored PRs return to their author instead of the contributor-offline lane same files src/pkg/dashboard/static/index.html

@hivecommons-hive

Copy link
Copy Markdown
Contributor

@clubanderson is auto-promoted for contributor-lane merging on this PR: the last 5 merged PRs by this author in this hive's repositories have no revert or sentinel-alert evidence. CI, reviewer verdict, diff fences, soak, holds and branch protection still apply.

@hivecommons-hive hivecommons-hive Bot added role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/050-review-pending Review swarm requested; awaiting a verdict for the current head and removed stage/071-needs-author Human-authored PR: CI red, changes requested or conflicting; diagnosis posted, the author must act labels Oct 29, 2026

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read the diff against the tree at 7c5883c and ran node --test src/pkg/dashboard/stage_tracker_acted.test.js (13/13 pass). Looks correct to me.

What I verified, so a maintainer does not have to:

  • stageTrackerIcon(key, cls, label) already accepts the third label argument the new header/cap calls pass (index.html:14722) and emits role="img" aria-label when it is set, so the aria text on the history cap is real, not dropped.
  • The n the badge now prints comes from src.count, which stageTrackerActedSource already populates from operator_action_count (index.html:15152, server side operator_actions.go:645) β€” including the issue-row-over-single-PR borrow path. No new payload field needed.
  • The cap segment is built with terminal: anchor >= STAGE_TRACKER_TERMINAL and state: terminal ? 'active' : 'todo' (index.html:14682), so sg.terminal ? βœ“ : history at 14912 and the .ham-seg.cap.todo .ham-history-ico rule target exactly the merged / unmerged split the body describes.
  • jsConstBlock stops at the first ;\n; every entry in STAGE_TRACKER_ICONS is a single-line quoted string, so the Go lift of the block in operator_actions_test.go ends at }; as intended.

Body and diff agree; no unrelated scope. Changelog fragment is correctly prefixed fixed-.

β€” hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot added stage/071-needs-author Human-authored PR: CI red, changes requested or conflicting; diagnosis posted, the author must act and removed stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Oct 29, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor

@clubanderson this PR is held at stage/071-needs-author and the hive will not merge it yet.

Failing checks:

  • test (dashboard 1/4)
  • test (dashboard 2/4)
  • test (dashboard 3/4)
  • test (dashboard 4/4)
  • test (dashboard shuffle 1/3)
  • test (dashboard shuffle 2/3)
  • test (dashboard shuffle 3/3)

Next: the hive does not push to your branch. Push a new head (or reply here); CI and the review swarm re-run automatically and the PR returns to the normal path.

The right-most Activity Monitor column (header, unmerged cap chevron and
the "did I act on this?" badge) showed a βœ“, which operators read as done
or passed; it is the row's decision/action history. Replace the glyph with
a clock-and-counter-clockwise-arrow history icon from the shared tracker
icon map, make the badge a neutral pill (not the green ok colour, not the
stuck amber) with the recorded-action count and an aria-label, and keep the
hover history, element ids and classes. The green βœ“ remains only once a PR
has merged. Header hover: History β€” decisions and actions on this item.

Signed-off-by: Andrew Anderson <andy@clubanderson.com>
@hivecommons-hive hivecommons-hive Bot added stage/050-review-pending Review swarm requested; awaiting a verdict for the current head and removed stage/071-needs-author Human-authored PR: CI red, changes requested or conflicting; diagnosis posted, the author must act labels Oct 29, 2026

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed β€” no findings from this perspective.

β€” hive: agent=adjudicator-4 backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed β€” no findings from this perspective.

β€” hive: agent=adjudicator-3 backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks correct to me. Read the three call sites against v5 index.html:

  • stageTrackerIcon(key, cls, label) already accepts the third label arg and switches aria-hidden β†’ role="img" aria-label when given (index.html:14833-14836), so the header cap and unmerged cap chevron get real labels without a signature change.
  • src.count on the acted badge is populated by stageTrackerActedSource from operator_action_count on both the direct and linked-PR paths (index.html:15257,15260; Go field at operator_actions.go:645), so the .ham-acted-n count badge is never undefined β€” and Math.max(1, …) covers the legacy no-count payload.
  • sg.terminal is set on the cap segment (index.html:14798), so the βœ“ (icon 110) correctly survives only on merged rows.

The only tests that reference ham-acted/STAGE_TRACKER_ACTED_GLYPH are operator_actions_test.go and stage_tracker_acted.test.js, both updated here; nothing else in src/pkg/dashboard still asserts the green βœ“ badge. The stage_tracker_ui_test.go regex ham-ico( ham-history-ico)? matches the new <svg class="ham-ico ham-history-ico" …> output. Nothing blocking from my side; CI is still running on this head.

β€” hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88

@clubanderson
clubanderson force-pushed the fix/history-icon-tracker branch from 880e322 to 1bf71c7 Compare October 29, 2026 01:44

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read the change against the tree at 880e322, not just the diff. Looks correct to me.

The two things I checked because they would silently regress if wrong:

  • if (sg.cap) inner = sg.terminal ? βœ“ : history β€” terminal is set on the cap segment where it's built (index.html:14682, segs.push({ number: STAGE_TRACKER_TERMINAL, …, terminal, cap: true })), and is false on every non-cap segment (:14680), so a merged PR keeps its βœ“ and nothing else can match the cap branch.
  • The new count on the badge reads src.count, which the badge source already carried before this PR (index.html:15152/:15155 from operator_action_count, operator_actions.go:645) and the tooltip already used (:15267), so the number and the "N earlier actions" line can't disagree.

STAGE_TRACKER_HISTORY_ICON is built from STAGE_TRACKER_ICONS.history declared earlier in the same script (:14693 vs :15142), so no TDZ issue; the motion test now pulls the real STAGE_TRACKER_ICONS block via the existing jsConstBlock helper instead of an empty stub. Docs (dashboard-sections.md legend, cue tokens, badge paragraph) and the Decisions filter title are updated in the same PR.

β€” hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed β€” no findings from this perspective.

β€” hive: agent=adjudicator-3 backend=copilot model=claude-fable-5.1 copilot=1.0.88

@github-actions

Copy link
Copy Markdown
Contributor

Thank you for your contribution! Your PR has been merged.

We'd love to hear how your experience was: share feedback

@github-actions github-actions Bot removed the conflicts-with-open-pr Open PR has a merge conflict with another open PR label Oct 29, 2026
@hivecommons-hive hivecommons-hive Bot removed role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Oct 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author/human A person pushed this PR themselves dco All commits are DCO signed-off dco-signoff: yes Indicates the PR's author has signed the DCO. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Activity Monitor: the tracker right-most βœ“ column reads as "done" but is the row history

1 participant