Repository navigation
π fix: tracker history column wears a history mark, not a β - #15200
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Before β β column header, grey β cap on every row, green β pill when a human acted: After β history mark (clock + counter-clockwise arrow) in the header (hover "History β decisions and actions on this item") and the unmerged cap; the acted badge is a neutral pill with the action count (amber = stuck); the hover history is unchanged: Captured live from hive's hive with the branch's render functions and CSS injected over the running page (no backend change). |
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of
|
b17bb9b to
7c5883c
Compare
|
@clubanderson is auto-promoted for contributor-lane merging on this PR: the last 5 merged PRs by this author in this hive's repositories have no revert or sentinel-alert evidence. CI, reviewer verdict, diff fences, soak, holds and branch protection still apply. |
There was a problem hiding this comment.
Read the diff against the tree at 7c5883c and ran node --test src/pkg/dashboard/stage_tracker_acted.test.js (13/13 pass). Looks correct to me.
What I verified, so a maintainer does not have to:
stageTrackerIcon(key, cls, label)already accepts the thirdlabelargument the new header/cap calls pass (index.html:14722) and emitsrole="img" aria-labelwhen it is set, so the aria text on the history cap is real, not dropped.- The
nthe badge now prints comes fromsrc.count, whichstageTrackerActedSourcealready populates fromoperator_action_count(index.html:15152, server sideoperator_actions.go:645) β including the issue-row-over-single-PR borrow path. No new payload field needed. - The cap segment is built with
terminal: anchor >= STAGE_TRACKER_TERMINALandstate: terminal ? 'active' : 'todo'(index.html:14682), sosg.terminal ? β : historyat14912and the.ham-seg.cap.todo .ham-history-icorule target exactly the merged / unmerged split the body describes. jsConstBlockstops at the first;\n; every entry inSTAGE_TRACKER_ICONSis a single-line quoted string, so the Go lift of the block inoperator_actions_test.goends at};as intended.
Body and diff agree; no unrelated scope. Changelog fragment is correctly prefixed fixed-.
β hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
@clubanderson this PR is held at Failing checks:
Next: the hive does not push to your branch. Push a new head (or reply here); CI and the review swarm re-run automatically and the PR returns to the normal path. |
7c5883c to
880e322
Compare
The right-most Activity Monitor column (header, unmerged cap chevron and the "did I act on this?" badge) showed a β, which operators read as done or passed; it is the row's decision/action history. Replace the glyph with a clock-and-counter-clockwise-arrow history icon from the shared tracker icon map, make the badge a neutral pill (not the green ok colour, not the stuck amber) with the recorded-action count and an aria-label, and keep the hover history, element ids and classes. The green β remains only once a PR has merged. Header hover: History β decisions and actions on this item. Signed-off-by: Andrew Anderson <andy@clubanderson.com>
There was a problem hiding this comment.
Looks correct to me. Read the three call sites against v5 index.html:
stageTrackerIcon(key, cls, label)already accepts the thirdlabelarg and switchesaria-hiddenβrole="img" aria-labelwhen given (index.html:14833-14836), so the header cap and unmerged cap chevron get real labels without a signature change.src.counton the acted badge is populated bystageTrackerActedSourcefromoperator_action_counton both the direct and linked-PR paths (index.html:15257,15260; Go field atoperator_actions.go:645), so the.ham-acted-ncount badge is never undefined β andMath.max(1, β¦)covers the legacy no-count payload.sg.terminalis set on the cap segment (index.html:14798), so the β (icon 110) correctly survives only on merged rows.
The only tests that reference ham-acted/STAGE_TRACKER_ACTED_GLYPH are operator_actions_test.go and stage_tracker_acted.test.js, both updated here; nothing else in src/pkg/dashboard still asserts the green β badge. The stage_tracker_ui_test.go regex ham-ico( ham-history-ico)? matches the new <svg class="ham-ico ham-history-ico" β¦> output. Nothing blocking from my side; CI is still running on this head.
β hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88
880e322 to
1bf71c7
Compare
There was a problem hiding this comment.
Read the change against the tree at 880e322, not just the diff. Looks correct to me.
The two things I checked because they would silently regress if wrong:
if (sg.cap) inner = sg.terminal ? β : historyβterminalis set on the cap segment where it's built (index.html:14682,segs.push({ number: STAGE_TRACKER_TERMINAL, β¦, terminal, cap: true })), and isfalseon every non-cap segment (:14680), so a merged PR keeps its β and nothing else can match the cap branch.- The new count on the badge reads
src.count, which the badge source already carried before this PR (index.html:15152/:15155fromoperator_action_count,operator_actions.go:645) and the tooltip already used (:15267), so the number and the "N earlier actions" line can't disagree.
STAGE_TRACKER_HISTORY_ICON is built from STAGE_TRACKER_ICONS.history declared earlier in the same script (:14693 vs :15142), so no TDZ issue; the motion test now pulls the real STAGE_TRACKER_ICONS block via the existing jsConstBlock helper instead of an empty stub. Docs (dashboard-sections.md legend, cue tokens, badge paragraph) and the Decisions filter title are updated in the same PR.
β hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1
|
Thank you for your contribution! Your PR has been merged. We'd love to hear how your experience was: share feedback |



Fixes #15199
What
The right-most Activity Monitor tracker column showed a β everywhere β column header, every unmerged row's cap chevron, and the green "did I act on this?" pill β which operators read as "done / passed". It is the row's decision/action history.
Owner: "the checkmarks are misleading - they should show some other kind of icon. something to do with history".
Change
historyglyph inSTAGE_TRACKER_ICONS(clock with a counter-clockwise arrow, inline SVG like the other tracker glyphs), used by:STAGE_TRACKER_ACTED_GLYPH), now a neutral filled pill (--text/--panel-strong, not the green "ok" colour and not the brand amber the stuck state uses) with the recorded-action count (.ham-acted-n,data-ham-acted-count) and an aria-labelHistory: N action(s) β <action> β <state>. Stuck / failed / pending keep amber / red / dotted.sg.terminal), so the merge celebration is unchanged.ham-acted-tip-*) and classes are unchanged.stage_tracker_acted.test.js: asserts the history glyph, the count badge, the aria-label, that no β/β/β¦ remains in the badge glyph slot, that the header and unmerged cap use the history icon, and that the badge is not green.operator_actions_test.golifts the new consts.dashboard-sections.md) and changelog fragment.No new raw hex / font-size / padding / border-radius literals (tokens only).
Before / after
(screenshots in the comment below)
Screenshots (hive's hive, live data)
Before β β in the header, every unmerged cap and the acted badge (green β reads as "done"):
After β history mark (clock + counter-clockwise arrow) in the header and caps; the acted badge is a neutral pill with the action count (amber only when stuck):