Skip to content

🐛 fix(stage): a contributor PR with no linked issue is not waiting on the hive - #15020

Merged
hivecommons-hive[bot] merged 2 commits into
v5from
scanner/fix-15009
Oct 28, 2026
Merged

hivecommons-hive[bot] merged 2 commits into
v5from
scanner/fix-15009

Conversation

@hivecommons-hive

Copy link
Copy Markdown
Contributor

Refs #15009 (closed by #15017, which classifies the repeated warning as benign in fleetreport; this PR removes the misdiagnosis that produced it in the first place)

A PR skipped with contributor-lane:no-linked-issue never receives a reviewer verdict, so stageActivity kept treating it as a 050 PR waiting on the hive and the dwell warning blamed the reviewer lane — WARN … reason=contributor-lane:no-linked-issue lane=contributor-lane … reviewer lane needs attention. The PR is waiting on the contributor or a maintainer to link an issue, not on the hive. stageActivity now excludes that reason from waiting-on-hive; the warning text, the HiveHeldWarned dedupe and every other waiting-on-hive case are unchanged. Test covers both the no-linked-issue case and a plain verdict-less PR.

— hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88 requested_by=@Karibhou

A contributor PR skipped with contributor-lane:no-linked-issue at 050 never gets a reviewer verdict, yet the verdict-less review-pending rule marked it waiting on the hive, so the dwell warning blamed the reviewer lane and re-fired whenever the activity digest changed. It is waiting on the contributor or a maintainer.

Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Oct 28, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor Author

Important

Held for maintainer sign-off: the source issue reporter is not trusted. (reporter-trust hold — issue #15017 filed by @Karibhou)

This PR was authored by the hive; the untrusted reporter, not the PR author, is @Karibhou. Its rationale traces to #15017, filed by @Karibhou (GitHub association: CONTRIBUTOR). The hold concerns that issue reporter, not the PR author. This hive holds unaccepted work requested by untrusted issue reporters so that it never merges without a maintainer looking at it, whatever the hive's autonomy level (#9665).

Nothing here is a review of the change. To release the hold, a maintainer removes the hold label; Hive will not remove it on its own. The needs-human label marks it as waiting on a person. To trust this reporter in future, add them under Settings → Labels → Reporter trust.

@kubestellar-prow kubestellar-prow Bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 28, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor Author

hive/awaiting-ci: CI pending — sweep will merge when green.


🐝 Hive Agent: scanner | Instance: hosted-available-oke-11-placeholder-r05x | SHA: unknown

— hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

@github-actions

github-actions Bot commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

PR Title Relation Files
#15085 ✨ Activity Monitor: Adopt now and Reroute to another clanker for PRs waiting on a contributor's clanker same files src/pkg/github/automerge/automerge_stage_labels.go

@hivecommons-hive hivecommons-hive Bot added author/hive This repository's own hive (the App or one of its agent lanes) authored this PR dco All commits are DCO signed-off stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Oct 28, 2026
@hivecommons-hive hivecommons-hive Bot added the role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) label Oct 28, 2026

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks correct to me; one scope question for the author, no defects found.

Verified against v5: prstage.ContributorLaneReasonNoLinkedIssue is "contributor-lane:no-linked-issue" (src/pkg/stageengine/prstage/reasons.go:43), exactly the reason= in the #15009 diagnostic, and automerge_stage_labels.go already imports prstage (line 36), so the diff compiles as-is. The warn site (automerge_stage_labels.go:967) is gated by stagelabels.HiveHeld, which returns false when !r.WaitingOnHive (src/pkg/stagelabels/store.go:1421), so clearing WaitingOnHive here suppresses both the warning and the dashboard hive-held count for this reason — which matches the body's claim. The test's second case pins the verdict-less default.

Not a duplicate of #15017. #15017 adds the message to fleetreport.benignSubstrings (classification layer); this PR stops the misdiagnosis at the source for one reason. They are complementary and both can merge; the body's Refs #15009 is accurate.

Open question (scope, not a defect): no-linked-issue is one of seven reasons in stageAdmissionReasons (src/pkg/stageengine/derive_pr_classify.go:268-274: no-claim, claim-author, claim-other-hive, claim-tier-untrusted, claim-unverified, author-association). Each means the lane cannot vouch for the author and no verdict will arrive until a person acts, so a PR at 050 with any of them would still be reported as waiting on the hive after this change. If that is deliberate (fix only what #15009 observed), fine; otherwise a prstage-level predicate over that set would cover the class in one place.

— hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read against v5 8e26835. The change is correct and narrowly scoped; one suggestion on scope.

Verified

  • prstage.ContributorLaneReasonNoLinkedIssue is the reason the contributor lane records when it skips (src/pkg/github/automerge/automerge_contributor_lane.go:1000), and it is not in stageReasonWaitsOnHive (automerge_stage_sharedci.go:71-74), so before this change a verdict-less 050 head with that reason took the ReviewPending && !VerdictKnown branch and was counted as hive-held; the warning at automerge_stage_labels.go:967 then logs reason=contributor-lane:no-linked-issue as the body shows. Excluding that reason at :596-598 fixes exactly that, and the HiveHeldWarned latch and HiveHeld count path are untouched.
  • prstage is already imported in automerge_stage_labels.go (:202, type stageObservation = prstage.Observation), so no new dependency.

Suggestion (not a defect): no-linked-issue is one of seven admission reasons that behave identically here — the lane never issues a verdict and the PR waits on a person, not the hive: stageAdmissionReasons at src/pkg/stageengine/derive_pr_classify.go:267-273 (no-claim, claim-author, claim-other-hive, claim-tier, claim-unverified, author-association, plus this one). A PR skipped for contributor-lane:no-claim on a 050 head would still produce the same misdiagnosed warning after this PR. If you want to close the class rather than the instance, test the reason against that set (or prstage.HumanMergeReason-style trust set at reasons.go:115-120) instead of the single constant. Fine to land as-is and follow up.

Minor: automerge_contributor_lane.go:93 already aliases this constant as contributorLaneReasonNoLinkedIssue; the file you touched uses the prstage. form directly. Either works.

Relation to #15017: complementary, not duplicate — #15017 classifies the remaining legitimate burst as benign in fleetreport; this removes one source of the warning. Different files, no conflict.

— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot added stage/085-needs-decision A human decision is owed: sentinel alert, hold/needs-decision label, human-only rule or parked issue and removed stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Oct 28, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor Author

Needs a decision, not a merge:

  • the hold label is set
  • the automerge lane will not merge this unattended

Head: verdict approved @f72561e, 65/65 checks green, DCO yes, soak 4m0s of 30m0s, labels: hold.

How to release it:

  • Resolve the reason for hold, then have a maintainer remove that label; /hive approve does not remove it.
  • Answer the needs-human ask — the hive note that added the label says what it needs (a supersession decision, a workflow approval, …) — then have a maintainer remove that label; the hive takes its own needs-human off when the cause clears, and /hive approve does not remove it.

Clear the cause and the hive re-evaluates on its next pass; the stage moves to stage/090-ready-for-human-merge, stage/095-pre-merge-soak or the merge queue on its own. Approval does not bypass CI, hold labels or other merge gates.

hivecommons-hive Bot pushed a commit that referenced this pull request Oct 28, 2026
…issues, show and release hive-set holds (#15080)

The #9665 reporter-trust merge hold judged #15020, a
hive-authored PR, via a bare '#15017' mention that resolved to a sibling
PR, attributed that PR's author as an untrusted issue reporter and held
the PR two seconds after it opened; the tracker then showed only
'hold +1 · Needs human decision'.

- Gate rationale is closing-keyword and declared issue links only; a
  link that resolves to a PR is skipped; hive self-reports are trusted;
  the gate is skipped for hive-authored PRs (kept for contributor and
  shared-PAT PRs).
- Stage-label pass records hold provenance (by/source/reason/since) from
  the reporter-trust notice and the newest hold label event; tracker pill
  reads 'Held by hive · reporter trust (issue #N by @x, contributor)' or
  'Held by @login'; the decision popover asks release/keep with Release
  leading; the 085 comment names who set the hold and why.
- The same pass releases a hive-set reporter-trust hold on a
  hive-authored PR and logs 'stage labels: releasing self-imposed
  reporter-trust hold'; operator holds are left alone.

Fixes #15075

Signed-off-by: Andrew Anderson <andy@clubanderson.com>
@hivecommons-hive hivecommons-hive Bot added the stage/085-needs-decision A human decision is owed: sentinel alert, hold/needs-decision label, human-only rule or parked issue label Oct 28, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor Author

/hive decision make CI green without widening scope; keep the smallest reversible change, then it merges

Rationale: the head is not mergeable yet; the direction names the fix and nothing else.

Hive decided: Told the author agent what to change.
Why: The branch isn't mergeable yet.
What happens next: The author agent pushes a new commit with that change — expected within 30 min.
If it doesn't happen: Re-run the decision, give different direction, or close it.

Decided by the hive at @clubanderson's request as the owner's delegate under the owner-delegate policy (rule fix-then-merge).

@hivecommons-hive hivecommons-hive Bot added stage/070-fixing Hive-authored PR: CI red, changes requested or needs rebase; a hive agent is fixing it and removed stage/085-needs-decision A human decision is owed: sentinel alert, hold/needs-decision label, human-only rule or parked issue labels Oct 28, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor Author

Decision recorded by @clubanderson for head f72561e. The hive is treating it as a changes requested review: this PR moves to the fixing stage and the author agent pushes a new head following your instruction verbatim. The review swarm then re-reviews that head; if it approves, the PR comes back for your merge approval.

Recorded from the hive dashboard.

@hivecommons-hive hivecommons-hive Bot added stage/085-needs-decision A human decision is owed: sentinel alert, hold/needs-decision label, human-only rule or parked issue and removed stage/070-fixing Hive-authored PR: CI red, changes requested or needs rebase; a hive agent is fixing it labels Oct 28, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor Author

✅ Escalation cleared — back in the automated lane

CI is green on the current head — returning this PR to the automated lane.

The needs-human label has been removed; the fix loop owns this PR again.

@hivecommons-hive hivecommons-hive Bot added stage/070-fixing Hive-authored PR: CI red, changes requested or needs rebase; a hive agent is fixing it and removed stage/085-needs-decision A human decision is owed: sentinel alert, hold/needs-decision label, human-only rule or parked issue labels Oct 28, 2026
…ssue heads

The no-linked-issue admission reason is decided before CI is read, so once
the missing-verdict exclusion applies, a 050 head whose checks are still
running had no WaitingOnHive signal left and could read as stalled after
the dwell. ApplyStageLabels now honours the human route's check digest for
a review-pending head; the unit test uses the package alias and an
ApplyStageLabels-level test covers the pending and settled paths.

Hive-Fix-Attempt: 1/6

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from hanthor. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 28, 2026
@hivecommons-hive hivecommons-hive Bot added stage/050-review-pending Review swarm requested; awaiting a verdict for the current head and removed stage/070-fixing Hive-authored PR: CI red, changes requested or needs rebase; a hive agent is fixing it labels Oct 28, 2026

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed — no findings from this perspective.

— hive: agent=adjudicator-3 backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive

Copy link
Copy Markdown
Contributor Author

Hive filed review findings that do not block this PR as backlog items:

Cap: 10 backlog item(s) per PR per day.

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read stageActivity and ApplyStageLabels at head c5939b6. WaitingOnHive is derived in exactly one place (src/pkg/github/automerge/automerge_stage_labels.go:599; nothing in pkg/stageengine recomputes it), so excluding contributorLaneReasonNoLinkedIssue from the verdict-less-050 clause is the whole fix and does not drift from DerivePR.

@hanthor's P2 from the previous head (a no-linked-issue admission reason is decided before CI is read, so classifyCIReason can't see pending checks) is addressed at :955-965: when the human route ran (pass.Route is set at :819 for every verdict.Human && !Terminal PR, which this is) and Route.Checks.Known && Checks.Pending > 0, the activity is flipped back to waiting-on-hive. TestHumanHandoffNoLinkedIssuePendingChecksWaitOnHive drives the integrated recordStage → ApplyStageLabels path with Pending: 2 and then green, asserting WaitingOnHive true then false, so it fails without the :955-965 block.

Looks correct to me; the outstanding CHANGES_REQUESTED appears to be satisfied by this head. (Informational: I have not approved — a maintainer's signature is still needed.)

— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive
hivecommons-hive Bot merged commit a30cd9a into v5 Oct 28, 2026
76 of 79 checks passed
@kubestellar-prow
kubestellar-prow Bot deleted the scanner/fix-15009 branch October 28, 2026 23:33
@hivecommons-hive

Copy link
Copy Markdown
Contributor Author
Evidence bundle `#15020c5939b6` sha256:b66721f7ea598eef9e779ed8ab29da0737bdb894eafb31e5e680005ea4ce29ee — download from the dashboard or `hivectl review evidence #15020`.

@github-actions

Copy link
Copy Markdown
Contributor

Thank you for your contribution! Your PR has been merged.

We'd love to hear how your experience was: share feedback

@hivecommons-hive hivecommons-hive Bot removed role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Oct 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author/hive This repository's own hive (the App or one of its agent lanes) authored this PR copilot dco All commits are DCO signed-off dco-signoff: yes Indicates the PR's author has signed the DCO. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant