Skip to content

Reporter-trust gate held hive-authored PR 15020 via sibling PR 15017; hold unattributed on tracker #15075

Closed

Description

@clubanderson

What happened

#15020 (author app/hivecommons-hive, labels author/hive + role/trusted, base v5, 65/65 checks green, verdict approved) was put on hold + needs-human by the hive itself at 17:14:18Z, two seconds after it opened, by the #9665 reporter-trust hold:

<!-- hive:reporter-trust-hold:9665 --> <!-- hive:reporter-trust-metadata {"OwnsNeedsHuman":true,"Held":true,"Issue":15017,"Repo":"hivecommons/hive","Reporter":"Karibhou","Association":"CONTRIBUTOR", ...

At 17:40Z the stage-label pass moved it to stage/085-needs-decision ("the hold label is set - the automerge lane will not merge this unattended"). It sat 49+ minutes as "Needs human decision" with a bare "hold +1" pill, and the operator could not tell who held it or why.

Root cause

  1. Wrong linked artifact. 15020's body reads Refs #15009 (closed by #15017, …). The gate fed the body to the bare-mention parser (ParseReferencedIssues), which yielded #15017 — a sibling hive-authored PR for the same issue, not an issue. Issues.Get(15017) returns a PR as an issue object; the gate never checked IsPullRequest(), and attributed the PR's reporter field (Karibhou, CONTRIBUTOR) as the issue reporter.
  2. Hive-authored PRs were judged. The gate ran on the hive's own PR; the reporter's trust says nothing about whether the hive's own fix may merge.
  3. No provenance. The tracker and 085 comment had no way to say the hold was hive-set, or why; the decision popover had no release/keep question.
  4. No recovery. Nothing ever releases a hive-set reporter-trust hold on a hive-authored PR.

Fix

  • Gate rationale = closing-keyword links + declared issues only; a link that resolves to a PR is skipped; hive self-reports ([selfreport], app/AI author) resolve as trusted; gate skipped for hive-authored PRs (kept for contributor / shared-PAT PRs).
  • Stage-label pass reads the hive:reporter-trust-metadata notice + newest hold label event, records hold {by, source, reason, since, issue, reporter, association} on the stage store / tracker payload; pill reads "Held by hive · reporter trust (issue #N by @x, contributor)" / "Held by @login"; decision popover asks release/keep with Release leading; 085 comment names who set the hold and why.
  • Same pass releases a hive-set reporter-trust hold on a hive-authored PR (stage labels: releasing self-imposed reporter-trust hold), leaving operator holds alone.

Acceptance

After roll, the next stage-label pass releases 15020's hold + needs-human with a release comment and the log line above, and the automerge lane merges it.

Activity

  1. added
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    on Oct 28, 2026
  2. github-actions commented on Oct 28, 2026

    @github-actions
    Contributor

    @clubanderson this issue was closed by @hivecommons-hive[bot] as completed.

    If this was closed by a merged PR, the fix only takes effect once it ships in a tagged release and your deployment updates to it — check your running version against the fix before concluding the fix failed.

    If you are still seeing the problem, comment /reopen and it will be reopened for you — you do not need write access. Please add what you are still observing (running version, logs, steps) so it is not closed the same way again.

  3. added a commit that references this issue on Oct 28, 2026
    caf9449
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    has-open-prhelp wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.kind/bugCategorizes issue or PR as related to a bug.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions