Skip to content

πŸ› fix(review): stop treating not-hive-authored dispatch skips as repeated errors - #14880

Merged
hivecommons-hive[bot] merged 1 commit into
v5from
scanner/fix-14870
Oct 28, 2026
Merged

hivecommons-hive[bot] merged 1 commit into
v5from
scanner/fix-14870

Conversation

@hivecommons-hive

Copy link
Copy Markdown
Contributor

The hive deliberately never pushes fixes to PRs it did not author; the resulting 'review fix dispatch excluded' line was logged at WARN every cycle, tripping the selfreport slog feed into filing unclassified_error_repeated. Policy skips (not-hive-authored) now log at INFO and never reach the feed; other exclusion reasons stay WARN. Targets v5 (running build); v5β†’v6 forward-merge carries it.

Closes #14870

β€” hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

…ed errors

Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Oct 28, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign kellyaa for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 28, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

PR Title Relation Files
#14862 πŸ› fix: preserve supersession decisions across stage reconciliation same files src/cmd/hive/main.go
#14821 πŸ› fix: preserve supersession decisions across stage reconciliation same files src/cmd/hive/main.go
#14524 ✨ feat(hub,agent): Hub-coordinated live CLI session pool for multi-tenant runner capacity same files src/cmd/hive/main.go

@hivecommons-hive

Copy link
Copy Markdown
Contributor Author

hive/awaiting-ci: CI pending β€” sweep will merge when green.


🐝 Hive Agent: scanner | Instance: hosted-available-oke-11-placeholder-r05x | SHA: unknown

β€” hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot added author/hive This repository's own hive (the App or one of its agent lanes) authored this PR dco All commits are DCO signed-off role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Oct 28, 2026

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed β€” no findings from this perspective.

β€” hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed β€” no findings from this perspective.

β€” hive: agent=ci-maintainer backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed β€” no findings from this perspective.

β€” hive: agent=adjudicator-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed β€” no findings from this perspective.

β€” hive: agent=adjudicator backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive

Copy link
Copy Markdown
Contributor Author

Hive filed review findings that do not block this PR as backlog items:

Cap: 10 backlog item(s) per PR per day.

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed (docs-currency) β€” no blocking findings; one advisory.

  • src/cmd/hive/main.go:11149-11151 β€” the loop's lead comment still reads "One WARN per changes_requested head … must be loud (#14665)", but the loop now emits INFO for not-hive-authored / not-hive-authored-squash-signoff. Suggest amending the comment to note the policy-skip exception so the #14665 intent and the #14870 carve-out are both visible to the next reader.
  • Out of scope (pre-existing): the function doc at main.go:11141-11147 says "The planner reports each head once, so this does not repeat on every eval cycle", yet src/pkg/review/dispatch.go:1400-1407 records a not-hive-authored exclusion again for every already-withheld head on each cycle β€” which is the repetition #14870's "6 in 10m0s" shows. This PR silences the symptom (level) without changing that; the doc sentence is inaccurate for FixExclusions.

Changelog fragment name/format matches changelog.d/README.md; no src/docs/ page references this log line.

β€” hive: agent=ci-maintainer backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive
hivecommons-hive Bot merged commit 7a30276 into v5 Oct 28, 2026
79 of 83 checks passed
@kubestellar-prow
kubestellar-prow Bot deleted the scanner/fix-14870 branch October 28, 2026 08:08
@hivecommons-hive

Copy link
Copy Markdown
Contributor Author
Evidence bundle `#1488097ab75c` sha256:ad80ba2c63faf671d2170f81d94e26a62ea0d29c641eb25ed8dfbb9bf5c9740e β€” download from the dashboard or `hivectl review evidence #14880`.

@github-actions

Copy link
Copy Markdown
Contributor

Thank you for your contribution! Your PR has been merged.

We'd love to hear how your experience was: share feedback

@hivecommons-hive hivecommons-hive Bot removed role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Oct 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author/hive This repository's own hive (the App or one of its agent lanes) authored this PR copilot dco All commits are DCO signed-off dco-signoff: yes Indicates the PR's author has signed the DCO. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[selfreport] unclassified_error_repeated: review fix dispatch excluded

0 participants