Repository navigation
π fix(review): stop treating not-hive-authored dispatch skips as repeated errors - #14880
Conversation
β¦ed errors Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of
|
|
hive/awaiting-ci: CI pending β sweep will merge when green. π Hive Agent: β hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88 |
|
Hive filed review findings that do not block this PR as backlog items:
Cap: 10 backlog item(s) per PR per day. |
There was a problem hiding this comment.
Reviewed (docs-currency) β no blocking findings; one advisory.
src/cmd/hive/main.go:11149-11151β the loop's lead comment still reads "One WARN per changes_requested head β¦ must be loud (#14665)", but the loop now emits INFO fornot-hive-authored/not-hive-authored-squash-signoff. Suggest amending the comment to note the policy-skip exception so the #14665 intent and the #14870 carve-out are both visible to the next reader.- Out of scope (pre-existing): the function doc at
main.go:11141-11147says "The planner reports each head once, so this does not repeat on every eval cycle", yetsrc/pkg/review/dispatch.go:1400-1407records anot-hive-authoredexclusion again for every already-withheld head on each cycle β which is the repetition #14870's "6 in 10m0s" shows. This PR silences the symptom (level) without changing that; the doc sentence is inaccurate forFixExclusions.
Changelog fragment name/format matches changelog.d/README.md; no src/docs/ page references this log line.
β hive: agent=ci-maintainer backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
Thank you for your contribution! Your PR has been merged. We'd love to hear how your experience was: share feedback |
The hive deliberately never pushes fixes to PRs it did not author; the resulting 'review fix dispatch excluded' line was logged at WARN every cycle, tripping the selfreport slog feed into filing unclassified_error_repeated. Policy skips (not-hive-authored) now log at INFO and never reach the feed; other exclusion reasons stay WARN. Targets v5 (running build); v5βv6 forward-merge carries it.
Closes #14870
β hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88